GitLab

Implements perftests that measure throughput of running and posting tasks.

Results on Windows P920:
[ RUN      ] TaskSchedulerPerfTest.PostThenRunNoOpTasks
*RESULT Posting tasks throughput: Post-then-run no-op tasks= 1.86 us/task
*RESULT Running tasks throughput: Post-then-run no-op tasks= 3.5304 us/task
*RESULT Num tasks posted: Post-then-run no-op tasks= 10000 tasks
[       OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasks (57 ms)
[ RUN      ] TaskSchedulerPerfTest.PostThenRunNoOpTasksManyThreads
*RESULT Posting tasks throughput: Post-then-run no-op tasks many threads= 2.693075 us/task
*RESULT Running tasks throughput: Post-then-run no-op tasks many threads= 2.58605 us/task
*RESULT Num tasks posted: Post-then-run no-op tasks many threads= 40000 tasks
[       OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasksManyThreads (136 ms)
[ RUN      ] TaskSchedulerPerfTest.PostThenRunNoOpTasksMorePostingThanRunningThreads
*RESULT Posting tasks throughput: Post-then-run no-op tasks more posting than running threads= 3.253125 us/task
*RESULT Running tasks throughput: Post-then-run no-op tasks more posting than running threads= 2.419125 us/task
*RESULT Num tasks posted: Post-then-run no-op tasks more posting than running threads= 40000 tasks
[       OK ] TaskSchedulerPerfTest.PostThenRunNoOpTasksMorePostingThanRunningThreads (135 ms)
[ RUN      ] TaskSchedulerPerfTest.PostRunNoOpTasks
*RESULT Posting tasks throughput: Post/run no-op tasks= 2.9757 us/task
*RESULT Running tasks throughput: Post/run no-op tasks= 3.2136 us/task
*RESULT Num tasks posted: Post/run no-op tasks= 10000 tasks
[       OK ] TaskSchedulerPerfTest.PostRunNoOpTasks (35 ms)
[ RUN      ] TaskSchedulerPerfTest.PostRunNoOpTasksManyThreads
*RESULT Posting tasks throughput: Post/run no-op tasks many threads= 8.7977 us/task
*RESULT Running tasks throughput: Post/run no-op tasks many threads= 2.26535 us/task
*RESULT Num tasks posted: Post/run no-op tasks many threads= 40000 tasks
[       OK ] TaskSchedulerPerfTest.PostRunNoOpTasksManyThreads (94 ms)
[ RUN      ] TaskSchedulerPerfTest.PostRunBusyTasksManyThreads
*RESULT Posting tasks throughput: Post/run busy tasks many threads= 4.046625 us/task
*RESULT Running tasks throughput: Post/run busy tasks many threads= 50.63795 us/task
*RESULT Num tasks posted: Post/run busy tasks many threads= 40000 tasks
[       OK ] TaskSchedulerPerfTest.PostRunBusyTasksManyThreads (2028 ms)
[ RUN      ] TaskSchedulerPerfTest.PostWithConstantWorkload
*RESULT Posting tasks throughput: Post tasks with constant workload= .0135 us/task
*RESULT Running tasks throughput: Post tasks with constant workload= 2.5396 us/task
*RESULT Num tasks posted: Post tasks with constant workload= 10000 tasks
[       OK ] TaskSchedulerPerfTest.PostWithConstantWorkload (29 ms)
[----------] 7 tests from TaskSchedulerPerfTest (2523 ms total)

Change-Id: I1e47eaf2db792d96e3e3ba290769e95673bd0b62
Reviewed-on: https://chromium-review.googlesource.com/c/1296624
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607835}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5549f98ca7e4..9e9db70e8858


Created with:
  gclient setdep -r src-internal@9e9db70e8858

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2f70d4b14827f7e47c0b36286d4cdc36fa2aed74
Reviewed-on: https://chromium-review.googlesource.com/c/1334569Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607834}

Currently the NGConstraintSpace's direction for inline children of a
block containeris is LTR even if the block container has RTL direction.

BUG=904951

Change-Id: I271f2e2f4b30df6513d84ea149dc73b9532a4ce0
Reviewed-on: https://chromium-review.googlesource.com/c/1334508Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607833}

R=benmason@chromium.org

Change-Id: If133d6f0be2e39f2da535692790f549269b6be5d
Reviewed-on: https://chromium-review.googlesource.com/c/1334836Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607832}

This reverts commit 20b9700c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607824 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIwYjk3MDBjODQ1MGFmNGY4ZmQ5NzE3MDRkMDhhZThhZjdhZmQxMDEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109897

Sample Failed Step: compile

Original change's description:
> Add Fast Transition as enterprise policy
> 
> Add support for an enterprise policy that lets the admin
> turn Fast Transition on or off.
> 
> BUG=791202
> CQ-DEPEND=1291930
> TEST=(1) unit-tests (2) Added network policy to YAPS
> server, enabled Fast Transition and checked that the
> values propagate to client
> 
> Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d
> Reviewed-on: https://chromium-review.googlesource.com/c/1297644
> Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607824}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=791202

Change-Id: I250820660b1aaccc0cf30b14e8d9e105d264ccab
Reviewed-on: https://chromium-review.googlesource.com/c/1334837
Cr-Commit-Position: refs/heads/master@{#607831}

To make a fake of LargeIconService, its methods need to be defined as virtual.
This change make it an abstract class and moves implementation to an Impl file.

Change-Id: I4a9f92d3b3e14f94a2f8eec72c2924a4ff45da7f
Reviewed-on: https://chromium-review.googlesource.com/c/1311538
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607830}

In order to address an surface invariants race condition, BrowserPluginGuest
began sending a child allocated LocalSurfaceId. BrowserPlugin would forcibly
begin using this ID.

This was initially a workaround for a <webview> bug. However <webview> no longer
uses BrowserPlugin, so this is no longer necessary. PDFs still do, but do not
suffer from this invariants violation.

Bug: 655231
Change-Id: I02299fee7990b2a6747be16d32c42e5a0b4743ae
Reviewed-on: https://chromium-review.googlesource.com/c/1330218Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607829}

1. replace indexing by DialogOption with switch (easier to maintain)
2. improve comments
3. add one assert to confirm code correctness

Change-Id: I6c4aee88e945ebcedfdc2b7864b68feec95e1f4a
Reviewed-on: https://chromium-review.googlesource.com/c/1262644Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#607828}

account for every time status changes its value

Change location of host status collection during MultiDevice Setup.
The metric was logged only on start-up.  This change intends for
HostStatus to log on start up and every time status changes its value.

Bug: 902868
Change-Id: I30de454dee61ff8bf8f5cd8b6ab071fc820abd35
Reviewed-on: https://chromium-review.googlesource.com/c/1327415Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607827}

RatserDecoder uses Skia to do rendering, and skia can restore vertex
attribs. So we don't need maintain and restore it in RasterDecoder.

Bug: 902904
Change-Id: I3e85d3960e0b782e41ae6d45c07ddf3494e63ca9
Reviewed-on: https://chromium-review.googlesource.com/c/1334201
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607826}

If a request fails with a net::Error code that we don't have an explicit
NEL standard `type` value for, we still want to generate a NEL report.
The standard provides an `unknown` type for these errors.

Change-Id: If4c0ab3bf4052cec9224dfd7053e1ca500b1b5dc
Reviewed-on: https://chromium-review.googlesource.com/c/1329351Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607825}

Add support for an enterprise policy that lets the admin
turn Fast Transition on or off.

BUG=791202
CQ-DEPEND=1291930
TEST=(1) unit-tests (2) Added network policy to YAPS
server, enabled Fast Transition and checked that the
values propagate to client

Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d
Reviewed-on: https://chromium-review.googlesource.com/c/1297644
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607824}

The following structs were redundant with structs that Mojo
auto-generates:
- WebIDBCursorDirection
- WebIDBDataLoss
- WebIDBOperationType
- WebIDBPutMode
- WebIDBTaskType
- WebIDBTransactionMode

This CL updates those references to refer to the equivalent
blink::mojom:: type, instead.

References to kWebIDB* values are updated to point to the
equivalent value in the associated Mojo enum type.

Bug: 717812
Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df
Reviewed-on: https://chromium-review.googlesource.com/c/1303634
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607823}

Bug: 539572
Change-Id: Ia3516e8dfbca2521d5c1b7af043ed79072e194a5
Reviewed-on: https://chromium-review.googlesource.com/c/1333895
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607822}

https://android.googlesource.com/platform/external/perfetto.git/+log/02761361bf6a..96026fbcbeee


git log 02761361bf6a..96026fbcbeee --date=short --no-merges --format='%ad %ae %s'
2018-11-13 fmayer@google.com Merge "profiling: Use cmdline instead of binary name."
2018-11-13 treehugger-gerrit@google.com Merge "profiling: Fix cleanup of profiling state."
2018-11-13 skyostil@google.com Merge "Disable debug log spam when embedded in a third party project"


Created with:
  gclient setdep -r src/third_party/perfetto@96026fbcbeee

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I13d85586513067ad5695d9cee7b2438a2125f268
Reviewed-on: https://chromium-review.googlesource.com/c/1334567Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607821}

net/ doesn't use any of theses interfaces, or Mojo itself, so this
code shouldn't be in net/.

TBR=miu@chromium.org

Change-Id: I62f65d181d0d1ff7ca43d83ca17656124752e898
Reviewed-on: https://chromium-review.googlesource.com/c/1323791
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607820}

These were assigned to large meta bugs. I'm filing individual bugs for
each failure so we can track them in our conformance effort.

Bug: 483282, 662644, 905001, 905003, 905004
Bug: 905006, 905007, 905011
TBR: kbr@chromium.org
Change-Id: I8f7a19d6cf80e1e448ce159622705b1da1445b28
Reviewed-on: https://chromium-review.googlesource.com/c/1334296Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607819}

This CL enables the Declarative Net Request API on the beta channel.

BUG=886497, 696822

Change-Id: I86b404504fede646ee5c85fb3a5724dd9e523aaa
Reviewed-on: https://chromium-review.googlesource.com/c/1330914Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607818}

This reverts commit ffa5c05c.

Reason for revert: broke webkit_tests on Mojo Linux bot. Likely something to do with gn config that lacks proprietary codecs.

Original change's description:
> media: Add H264 profile extraction support
> 
> Without the ffmpeg decoder configured, libavformat is unable to get the
> codec profile and chromium ffmpeg wrapper code choose some defaults.
> This will mess up the decode scenarios where non-ffmpeg decoders like vaapi
> are in use. Fortunately, we can still get hold of the ffmpeg's
> AVStream extradata param which should contain the
> H264 AVCDecoderConfigurationRecord (ISO/IEC 14496-15).
> So we use internal parser for extracting profile information
> from this AVCDecoderConfigurationRecord.
> 
> BUG=784610
> TEST=media_unittests:FFmpegCommonTest.VerifyH264Profile
> 
> Change-Id: Id67c7026eefb5bb73e6c5fbbab7a362cb4553ab1
> Reviewed-on: https://chromium-review.googlesource.com/c/1292605
> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607769}

TBR=dalecurtis@chromium.org,chcunningham@chromium.org,sreerenj.balachandran@intel.com

Change-Id: I1cc9a3236d7187115566dff882c586b00dca713b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 784610
Reviewed-on: https://chromium-review.googlesource.com/c/1334664Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607817}

Design document:
https://docs.google.com/document/d/1cPF5PruriWNP2Z5gSkq4MBTm0wSZqLyIJkUO9ekibeo

BUG=890413

Change-Id: Ib372a573b1a0f68467f785ce74ef7821c9d48614
Reviewed-on: https://chromium-review.googlesource.com/c/1322350Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607816}

Bug: 674649
Change-Id: I61d467612683c1d9b4fc3e1b1685d278aac5b508
Reviewed-on: https://chromium-review.googlesource.com/c/1334549Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607815}

The previous attempt of fixing this test (crrev.com/c/896683) did not
end up fixing it because GURL::GetContent() doesn't include the
fragment deliminater. This was not discovered until slimnav is enabled
again on FYI bot.

This CL fixes the issue by looking for a partial match in omnibox URL.

Bug: 807428
Change-Id: Ieea5dc0205edf14b1f7f9c89363a492d0b2c811e
Reviewed-on: https://chromium-review.googlesource.com/c/1334204
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607814}

This is a part of my effort to cleanup our system-wide metric
measurement code.

TBR=wfh@chromium.org,bartfab@chromium.org,jochen@chromium.org,rsesek@chromium.org,kinuko@chromium.org

Bug: 891864
Change-Id: I896b8936d91789ba0e0423f0937cd54c973bfcda
Reviewed-on: https://chromium-review.googlesource.com/c/1327441
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607813}

This is done proactively, in case we want to add features to Browser.* that we
don't want to be exposed over extensions API, etc.

Change-Id: Ice2dc0ffbec783b429daae8e950a5861228a95cf
TBR: updated API call site
Reviewed-on: https://chromium-review.googlesource.com/c/1334003Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607812}

This CL adds unit tests for CafBaseMediaRouteProvider. Some methods are
exposed for easier testing.

Also, the CL includes several minor fixes to CafBaseMRP.

Bug: 711860
Change-Id: I1675e122406a787ccdb25a32c337c50f60d71872
Reviewed-on: https://chromium-review.googlesource.com/c/1333117
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607811}

Bug: 899113
Change-Id: Idc90d221cdfbdb11e042b88985ef9394fad20409
Reviewed-on: https://chromium-review.googlesource.com/c/1330335
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607810}

The default keyword is reserved and is also not a valid <custom-ident>.[1]
We should deprecate and remove support for default in custom-ident.
Add a UseCounter for default in custom-ident.

[1]: https://drafts.csswg.org/css-values-4/#custom-idents

Bug: 882285
Change-Id: I1c102200a641c6a2a1266a95a682e367f28b6d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1325599Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607809}

Bug: 854673
Change-Id: I139764a243ebf1d6c4209e124e6a8cf328985053
Reviewed-on: https://chromium-review.googlesource.com/c/1299835Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607808}

This CL renames s/gpu_decoder/gpu.decoder/ trace category, since
it appears next to gpu.{debug,device,service} (with dot) [1].

"gpu_decoder" doesn't seem to be used automatically in autotests
or google3.

[1] https://i.imgur.com/zwpJeoA.png (https://i.imgur.com/zwpJeoA.png)

Change-Id: I43b9923e3ca356b7f2e63f083fb93f9e5eaf3d3c
Reviewed-on: https://chromium-review.googlesource.com/c/1334229Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607807}

R=hansberry@chromium.org

Bug: 903991
Test: none
Change-Id: I20d5d297c7fdaff8360935818740c483a720ee1a
Reviewed-on: https://chromium-review.googlesource.com/c/1334187
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607806}

For NG, we need to get the DisplayItemClient ID from the
paint fragment, not the InlineTextBox.

R=kojii@chromium.org

Change-Id: I0363ad1fdeb09e3f2422abb33516b3ffc713338e
Reviewed-on: https://chromium-review.googlesource.com/c/1334418Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607805}

MultiDevice.BetterTogetherSuite.MultiDeviceFeatureState
AndroidSms.MultiDeviceFeatureState
SmartLock.MultiDeviceFeatureState
InstantTethering.MultiDeviceFeatureState

Multiple enumerated histograms with the same 9 buckets:
1) “Prohibited by policy”,
2) “Disabled by user”,
3) “Enabled by user”,
4) “Not supported by Chromebook”,
5) “Not supported by phone”,
6) “Unavailable, no verified host”,
7) “Unavailable, insufficient security”,
8) “Unavailable, suite disabled”, and
9) “Further setup required”.

Bug: 870138
Change-Id: Ic96b673a10b4ecd52b9f44b0f29abc52d29858b3
Reviewed-on: https://chromium-review.googlesource.com/c/1315938Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607804}

This reverts commit ec9be0fd.

Reason for revert: Relanding after increasing trace download timeout to 120s

Original change's description:
> Disable failing perf tests on Nexus_5.
> 
> TBR=nednguyen@google.com
> NOTRY=true
> 
> Bug: 902064
> Change-Id: Ic9f91ba4b263fb4ed435ac7a9dc1a096aa452516
> Reviewed-on: https://chromium-review.googlesource.com/c/1318586
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#605491}

TBR=nednguyen@google.com,crouleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 902064
Change-Id: I03804b1a557226498df63eb8a7c0dea31e3f227f
Reviewed-on: https://chromium-review.googlesource.com/c/1334335Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607803}

Bug: 836238
Change-Id: I10a60aea6e70c0a0f4a0ed40a7c9172ae383d170
Reviewed-on: https://chromium-review.googlesource.com/c/1334294Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607802}

Change-Id: I2582be57bcd094e17703dcdae109dde3e5875315
Reviewed-on: https://chromium-review.googlesource.com/c/1332720Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607801}

This is a reland of 8bd3e513

The only difference between this and the original is swapping the
run loop wait and the WaitForLoadStop in the browser tests, and adding
--ignore-previews-blacklist

Original change's description:
> Integrate Lite Page Server Previews with the Previews Stack
>
> Adds Lite Page Server Previews to DetermineAllowedPreviews and
> DetermineCommitted. For now, the preview is always allowed if the
> feature is enabled and is committed if the URL matches.
>
> This intentionally leaves an open question about whether more logic
> in the NavigationThrottle can/should be moved into the DeciderImpl.
>
> The biggest part of this change is moving the URL checking logic to
> the previews component and adding additional helper functions there.
>
> Bug: 898557
> Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9
> Reviewed-on: https://chromium-review.googlesource.com/c/1323800
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Doug Arnett <dougarnett@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607427}

Bug: 898557
Change-Id: I463a45331b7281cde6c83b61ee82b3bbdd8f5cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1333896
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607800}

Bug: 892852
Change-Id: Icc76061860b92e349bf1f3a936fef78a2c4a6e00
Reviewed-on: https://chromium-review.googlesource.com/c/1318838Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607799}

This is a reland of be707070
The build failure was fixed in perfetto:
https://android-review.googlesource.com/c/platform/external/perfetto/+/822041

Original change's description:
> Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits)
>
> https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0
>
> $ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
> 2018-10-31 jerryturcios08 Correct grammatical error in README.md
> 2018-10-30 absl-team Googletest export
> 2018-10-30 misterg Googletest export
> 2018-10-29 absl-team Googletest export
> 2018-10-29 akonradi Add Optional() to the cheat sheet doc.
> 2018-10-29 misterg Googletest export
> 2018-10-29 misterg Googletest export
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
> 2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
> 2018-10-26 absl-team Googletest export
> 2018-10-24 absl-team Googletest export
> 2018-10-24 misterg Googletest export
> 2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
> 2018-10-23 durandal Googletest export
> 2018-10-24 peter_jiachen Disable extensions and force standard
> 2018-10-24 peter_jiachen Revert previous changes
> 2018-10-24 peter_jiachen Fix -std=c++11 flag
> 2018-10-23 joelanderson333 add documentation of manual c++11 specification
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 gennadiycivil Update advanced.md
> 2018-10-23 svg153 ACTION table format
> 2018-10-22 absl-team Googletest export
> 2018-10-19 gennadiycivil Update .travis.yml
> 2018-10-18 gennadiycivil Update .travis.yml
> 2018-10-18 misterg Googletest export
> 2018-10-16 absl-team Googletest export
> 2018-10-17 kakkoko Fix incorrect XML file name in help message
> 2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
> 2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
> 2018-10-16 jonathan.wendeborn Don't fully qualify enum member
> 2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
> 2018-10-12 robert Change types to remove cast warnings.
> 2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
> 2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
> 2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
> 2018-10-09 absl-team Project import generated by Copybara.
> 2018-10-09 misterg Internal Change
> 2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
> 2018-10-06 ryee88 fix typo
> 2018-10-10 spartucus Update .gitignore
> 2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
> 2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
> 2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
> 2018-10-09 absl-team Apply [[noreturn]] to Abort()
> 2018-10-09 gennadiycivil Update Makefile.am
> 2018-10-09 gennadiycivil Update BUILD.bazel
> 2018-10-09 gennadiycivil Update README.md
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-09 gennadiycivil Delete CHANGES
> 2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
> 2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
> 2018-10-08 misterg always define define GTEST_LANG_CXX11 1
> 2018-10-08 misterg Remove non-variadic pre C++11 AllOf
> 2018-10-05 gennadiycivil Update primer.md
> 2018-10-05 misterg Remove pre-C++11 code from gtest-printers
> 2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
> 2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
> 2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
> 2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
> 2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
> 2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
> 2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
> 2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
> 2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
> 2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
> 2018-10-01 misterg Googletest export
> 2018-09-27 durandal Googletest export
> 2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
> 2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
> 2018-09-26 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
> 2018-09-25 gennadiycivil Keep one MinGW build, remove the others
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Update appveyor.yml
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
> 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update Makefile.am
> 2018-09-25 gennadiycivil Update .travis.yml
> 2018-09-25 misterg automake
> 2018-09-25 misterg test automake c++11
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 gennadiycivil Update configure.ac
> 2018-09-25 misterg typo
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg autotools c++11
> 2018-09-25 misterg test
> 2018-09-25 misterg include c++11 for autotools
> 2018-09-25 absl-team Googletest export
> 2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
> 2018-09-25 misterg Googletest export
> 2018-09-24 misterg Googletest export
> 2018-09-20 absl-team Googletest export
> 2018-09-25 misterg enable MingW on PR
> 2018-09-25 misterg C++11 autotools build
> 2018-09-25 misterg adding c++11 to appveyor mingW
> 2018-09-25 misterg typo
> (...)
>
> Created with:
>   roll-dep src/third_party/googletest/src
>
> TBR=thakis@chromium.org
>
> Bug: 893369
> Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1310634
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604801}

TBR=thakis@chromium.org

Bug: 893369
Change-Id: I227ca83bcd60662367c39f2869606928c922194d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chromium.try:win_x64_archive
Reviewed-on: https://chromium-review.googlesource.com/c/1320471
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607798}

Change-Id: Ib1a4632cead932fba7cf181ac95348b6468abb18
Reviewed-on: https://chromium-review.googlesource.com/c/1330905
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607797}

This patch changes |StartOfWord()| to utilize |TextSegments|
class to make it work with LayoutNG.

This patch also fixes existing incorrect behavior on
fast/text/international/cjk-segmentation.html

Bug: 778507
Change-Id: Iedee4632206154c8e813f3e43136c1a000e39435
Reviewed-on: https://chromium-review.googlesource.com/c/1309227
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607796}