GitLab

The current BrokerClient is not signal-safe because of its use of base::Pickle
which uses new and delete, and also its use of std::vector, which is not
technically signal safe either. These are used in messaging IPCs with the
BrokerHost when a syscall is trapped, thus BrokerClient must be made signal
safe. This is discussed in https://crbug.com/255063.

This CL creates a new BrokerSimpleMessage class to handle simple IPC messaging
with strings and ints only. It uses fixed sized messages to simplify logic and
allow it to allocate all its memory on the stack. It creates send, receive, and
a synchronous send-and-receive method. It also adds a basic set of unit tests
to sanity check behavior.

Bug: 255063
Change-Id: I8077a515921b62969a1b8b173d903f2a118ed186
Reviewed-on: https://chromium-review.googlesource.com/553400
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558415}

Gtk increases the reference count of the cairo_pattern_t before returning it to
clients, so this CL adds the appropriate call to cairo_pattern_destroy().

R=thestig

Change-Id: I540c635e15d086aa515c0b1bc3953c1008df5607
Reviewed-on: https://chromium-review.googlesource.com/1058031Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558414}

The method being tested requires a non-unique origin, so make sure the
dummy html is actually loaded with a valid security origin.

Bug: 104300
Change-Id: I9b8728d1c16f788bee08fb1c0dff5637a17dc942
Reviewed-on: https://chromium-review.googlesource.com/1057830Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558413}

Change-Id: Ic62a16887fb7e1028d961f3ba752ce9ad2fbe37e
Reviewed-on: https://chromium-review.googlesource.com/1054696
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558412}

Based on the discussion at:
https://chromium-review.googlesource.com/c/chromium/src/+/1050935/5/content/browser/network_service_client.cc
This CL changes the |is_main_frame| variable name to |is_request_for_main_frame|
to make it more clear. The variable indicates if the request (associated
with a frame) is the request for the frame itself or a subresource.

Bug: 783990
Change-Id: I0369efc027c27cac3c19a1ce48a0fba7a67809a0
Reviewed-on: https://chromium-review.googlesource.com/1056292Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558411}

Updates the styling of the NTP fakebox for GM2. Modifies
GetConfigData to allow the NTP to show/hide these updates
depending on the kNtpUIMd flag.

Bug: 837784
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I40a76820fc4a5f976166b64b74e5c7d73668cce4
Reviewed-on: https://chromium-review.googlesource.com/1042281
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558410}

Previously this code compared the current (possibly new) value of
css-animation-playstate to the value of blink::Animation::Paused()
to determine if it should toggle the paused state. This is incorrect;
if blink::Animation::pause() is called directly from JS these values
diverge by spec[0]. We only need to toggle the pause state from
CalculateAnimationUpdate if css-animation-playstate itself has changed.

Note that this incorrect behavior did not actually manifest in release
builds because of a no-DCHECK-only optimization; if is_animation_style_change
is set, we skip the entire state-update step and just calculate interpolations.

[0]: https://drafts.csswg.org/css-animations-2/#animation-play-state

Bug: 838594
Change-Id: I23a9eb0d338171c5a125b54ec4e29b916aceb3b0
Reviewed-on: https://chromium-review.googlesource.com/1053759Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558409}

This CL includes several minor changes to components/crash/ in
preparation for enabling Crashpad on Android.

- Use std::string instead of char* in GetProductNameAndVersion.
- Set LD_LIBRARY_PATH when building handler args for component builds.
- Update Android handler executable to libcrashpad_handler.so.
- Don't set a url parameter on Android to avoid Crashpad attempting to
  upload reports, which it doesn't yet support.
- Initialize CrashHandlerHost on the first call to GetDeathSignalSocket
  because CrashHandlerHost may be created before it can post tasks to
  the IO thread.

Bug: crashpad:30
Change-Id: I80efa0cf87cb4081773eaa516b1d6eb90fb6f5e8
Reviewed-on: https://chromium-review.googlesource.com/1056320
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558408}

CC=perezju@chromium.org
BUG=842731
NOTRY=true
TBR=eyaich@chromium.org

Change-Id: Idbc0a87a843c3647e1ad15d13a5429dda6e9d0cf
Reviewed-on: https://chromium-review.googlesource.com/1058068Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558407}

chrome::FindBrowserWithWebContents returns nullptr when the webcontents
opened in a views::WebView

Change-Id: I6465bbd83efe7cef23568ab8026c5eb96990e769
Reviewed-on: https://chromium-review.googlesource.com/1056547Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558406}

Part of ongoing effort to enable ChromeVox in
chromecast.  This CL brings in the chrome.i18n api
from chrome.

PS 1 is base for copied files.  PS 2+ modifications
on top of copied files.  Duplicate code will be
removed later (b/837773).

Bug: b/73383411
Test: None
Change-Id: I571edb830ed09d4c3866bb14649b472c550acd04
Reviewed-on: https://chromium-review.googlesource.com/1057354Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558405}

Bug: 817377
Change-Id: I4d290113a6cb00dda74f0906294665862d40ddb1
Reviewed-on: https://chromium-review.googlesource.com/1057696Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558404}

Any time the WebContents is removed from the TabStripModel and then destroyed,
JavaScriptDialogTabHelper would fail to deregister itself as an observer of the
TabStripModel. This would cause use after free.

Change-Id: I162f5f7c65b0b2848a922130cefc31348eeecc6e
Bug: 842545
Reviewed-on: https://chromium-review.googlesource.com/1057873
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558403}

This reverts commit de77cb76.

Reason for revert: https://crbug.com/842408 should now be fixed.

Original change's description:
> Revert "Reland "win: Link with lld instead of link.exe by default""
> 
> This reverts commit a25e3672.
> 
> Reason for revert: broke Windows tests using ANGLE's GL back-end.
> Breaks the CQ for graphics-related tests, and ANGLE's CQ.
> 
> example builds:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1063
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20dEQP%20Release%20%28NVIDIA%29/3528
> 
> Original change's description:
> > Reland "win: Link with lld instead of link.exe by default"
> > 
> > The nacl browser_test failures on Win7 that caused the last revert are fixed.
> > There's a known bug about this regressing binary size (crbug.com/838449),
> > but with in-progress patches binary size will soon be 200 kB smaller and
> > these should all be rolled in by branch point, so let's reland this to find
> > more unknown unknowns.
> > 
> > Original change's description:
> > > win: Link with lld instead of MSVC's link.exe by default
> > >
> > > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > > link.exe, but it's significantly faster and it can also handle LLVM's
> > > internal representation, which will enable us to do link-time
> > > optimization and control-flow integraty checks with Clang.
> > >
> > > While lld is much faster at linking, it doesn't support incremental
> > > links, meaning builds that only touch a few files and re-link a large
> > > executable may become slower.
> > >
> > > This is the first attempt at switching everything over, with the
> > > purpose of gathering data and finding unknown unknowns. It's likely
> > > temporary until something breaks.
> > >
> > > is_win_fastlink is implicitly ignored when using lld, as lld without
> > > fastlink is faster than link.exe with it.
> > >
> > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > > link.exe to make sure that configuration keeps working.
> > >
> > > Bug: 792131
> > 
> > Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db
> > Reviewed-on: https://chromium-review.googlesource.com/1054521
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557987}
> 
> TBR=thakis@chromium.org,rnk@chromium.org
> 
> Change-Id: Ida516adc6708c59407b817c8425c14bd3153d5b8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1056327
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558055}

TBR=thakis@chromium.org,rnk@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ided62bd7fb25d17d7a318539f41c308fb738797e
Reviewed-on: https://chromium-review.googlesource.com/1057767Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558402}

Methods marked as constexpr could b evaluated at compile time, but this need not be true at all call sites.
This implies that all their arguments could also be constexpr, either explicitly or implicitly.
One of the restrictions is that they should contain at most one return statement.

In AXNode, the methods I marked constexpr could never have been evaluated at compile time.
In this particular case, I was under the mistaken belief that constexpr would force the methods to be inline. But even though constexpr implies inline, it also has the added implications described above.

Thanks to Robert Sesek for the advice on when to use constexpr.

TBR=dmazzoni@chromium.org, rsesek@chromium.org

Change-Id: I58a6abb816bb7ae89f346ddb5ffea4d7d46395e4
Reviewed-on: https://chromium-review.googlesource.com/1055734Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558401}

Bug: 842729
Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb

TBR=eyaich@

Change-Id: I66e634c272f445ea2eb482722251a68fca0579bb
Reviewed-on: https://chromium-review.googlesource.com/1057832
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558400}

Also adds validation against incoming server data, preventing
enabled features which are not in the supported feature set.

Bug: 824568, 752273
Change-Id: I70de90f5b104a2559e1c4e6350abcc7c002934bb
Reviewed-on: https://chromium-review.googlesource.com/1053373
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558399}

This NullPointerException should be really rare. There is a fix on
the way, for now we just catch the exception to prevent crash.

Bug: 842059
Change-Id: Ie130d887d303e7f08504b8c783ae43b87ed31ccf
Reviewed-on: https://chromium-review.googlesource.com/1057427Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558398}

The tests check that service workers don't see mimeHandler requests. This still is true with the
network service. However the network service path doesn't copy the subresource_overrides_ field for
ServiceWorkerSubresourceLoaderFactory.

As such, adjust the test to account for 2 by just checking that service workers don't see the mime
handler requests.

Bug: 715640
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I25c473ddd50b7641eb4b3da8883cb9998ad8de4a
Reviewed-on: https://chromium-review.googlesource.com/1056607Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558397}

1) Add animation for showing preview wallpaper/wallpaper thumbnails.

2) Set min height/width for the picker window.

3) Add "Preset category" for the new picker.

Bug: 837485, 837329, 836848, 835352, 835196
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifddc5e2af900b7c9b9f8e0001b605f70d2f9b079
Reviewed-on: https://chromium-review.googlesource.com/1054141
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558396}

Adds caching of hosts found within NetworkScanner and a method
ResolveHost for name resolution

Bug: 757625
Change-Id: I96a76e5c62ffc9f99bc34ad1f145f07e3f5dccf3
Reviewed-on: https://chromium-review.googlesource.com/1050803Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558395}

This is the markdown version of https://goo.gl/Tmau3m

R=eyaich@chromium.org

Bug: 842232
Change-Id: I762808bc05646d11c0ddafb7786912505bb6f81e
Reviewed-on: https://chromium-review.googlesource.com/1057953Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558394}

This is the markdown version of https://goo.gl/KfgF2h

R=eyaich@chromium.org

Bug: 842232
Change-Id: Id59e233071b1a7d1fe424ace4ea1f23aae47d7c8
Reviewed-on: https://chromium-review.googlesource.com/1057840Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558393}

This won't have any effect until the CL that makes SKCMS_LEGACY_POWF
relevant lands: https://skia-review.googlesource.com/c/skcms/+/128041

Change-Id: If890bc620e726288422184876fb50275a7e0082d
Reviewed-on: https://chromium-review.googlesource.com/1057871Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558392}

Update OWNERS files to remove folks who've moved on from
storage-related work, and ensure we have coverage and correct
components as well.

Change-Id: I8013b9b493f03f3a887523ca931d0d18f6118968
Reviewed-on: https://chromium-review.googlesource.com/1050396Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558391}

The D3DVsync feature doesn't work with OOP-D, so don't try to use it at
the same time. GpuVSyncProviderWin can be simplified with OOP-D as it's
just an ExternalBeginFrameSource essentially without the process
boundary.

Bug: 787814
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I814671841df65fcd3141bcfa2ca9db8ea745ea0b
Reviewed-on: https://chromium-review.googlesource.com/1057846Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558390}

BUG=842768

Change-Id: Ic59dcbb02d413d9830e11fd7117307c31ee60621
Reviewed-on: https://chromium-review.googlesource.com/1057948Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558389}

This reverts commit 27c99670.

Reason for revert: https://crbug.com/841565

Original change's description:
> Mojo EDK: Improve internal process handle ownership
> 
> Mojo passes around base::ProcessHandle values for various reasons. On
> most systems this is fine, but at least on Windows, a ProcessHandle
> refers to an owned reference to a system process object, and if not
> careful it's possible for a base::ProcessHandle value to inadvertently
> change meaning over time.
> 
> This CL introduces the concept of a move-only ScopedProcessHandle
> within Mojo, which on most platforms is just a base::PlatformHandle.
> On Windows, this represents an owned base::ProcessHandle which closes
> on destruction and clones correctly using DuplicateHandle rather than
> merely copying the raw handle value.
> 
> ScopedProcessHandle is used in a few places where process handle
> ownership semantics were previously weaker than necessary, or were
> correct but implemented ad hoc.
> 
> This also updates ScopedPlatformHandle (and supporting code like
> Channel::RewriteHandles) such that the |owning_process| field (if not
> the current process) is always an owned process handle. This ensures
> that when such handles are closed in unsent messages, they can be
> safely closed in the target process (from within the source process)
> without any risk of raciness against target process termination.
> 
> Bug: 837612
> Change-Id: I943bb5f70ede56351d52b2ecea7d76fcfdee46ce
> Reviewed-on: https://chromium-review.googlesource.com/1036459
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555117}

TBR=jcivelli@chromium.org,rockot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837612
Change-Id: Ief6e1d6d6f2f96dc7420e06d8438cc06cbf17490
Reviewed-on: https://chromium-review.googlesource.com/1057699Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558388}

Bug: 829965
Change-Id: I0edaa674fc4820dc6229270abd53ba92ae72d18a
Reviewed-on: https://chromium-review.googlesource.com/1057845Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558387}

Also clean up some other migrated builders.

BUG=793905,793907,793908,793914,793944,793913

Change-Id: I0a047112e0cf319bb00ad45f2c8441d96060ca67
Reviewed-on: https://chromium-review.googlesource.com/1056467Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558386}

Add a comment explaining why it's ok to silently fail to schedule an
overlay plane in GbmPixmap::ScheduleOverlayPlane when fb is 0.

Bug: 779356
Test: It's a comment
Change-Id: Id68fe9464b1b18023d16176005c8fb5af62e8c6f
Reviewed-on: https://chromium-review.googlesource.com/1057867Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558385}

We have a suitable UKM replacement now.

Bug: None
Change-Id: Ic628dbc19b69f56d0ee5a4184f8bcb786348c594
Reviewed-on: https://chromium-review.googlesource.com/1056330Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558384}

This CL converts ManagedPreferenceDelegate into an interface and
replaces most of its anonymous subclasses with lambdas.

Bug: None
Change-Id: Icb207a94dcc268c326836eb3204a74b212e40d71
Reviewed-on: https://chromium-review.googlesource.com/1047870Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558383}

The base class for this factory ensures that only one operation instance
is active at any time.

Bug: 824568, 752273
Change-Id: Ia0b4220aef2f021802b7f43ead7b2915a7cf983a
Reviewed-on: https://chromium-review.googlesource.com/1054097
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558382}

Getting too many file open error reports relatively frequently.
Try raising the fd limit to see if things improve.

Changed base implementation to only increase the fd limit. In case
this is used in webview and app has already set the limit above
what we need.

Bug: 842271
Change-Id: I418ea96b4a51fd15e8166d111a191d00153a565c
Reviewed-on: https://chromium-review.googlesource.com/1056070Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558381}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1de725e0b53..babd098f3684

$ git log d1de725e0..babd098f3 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 ehmaldonado gclient: Simplify GetScmName and CreateSCM.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:839925


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I63a00f02cbf4ee0a5c3c83fe758b807edf801abe
Reviewed-on: https://chromium-review.googlesource.com/1057894
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558380}

While running layout tests on MacOS, one of the tests failed within
CopyTextureCHROMIUM() because of an unsupported type. The origin of
the failure was wihtin canvas_color_params.cc, where GL_HALF_FLOAT
was used instead of GL_HALF_FLOAT_OES. The validators for this type
is initialized within gpu/command_buffer/service/feature_info.cc
and contains GL_HALF_FLOAT_OES, but not GL_HALF_FLOAT, which isn't
supported on GLES2 and unfortunately has a different value.

Bug: chromium:757974
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If7a28c53db4a4f6acef035ee432153cec4f0acbb
Reviewed-on: https://chromium-review.googlesource.com/1057360Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558379}

This CL is the start of a refactor to pull update methods for
page action icons out of the LocationBar interface and into
a PageActionIconContainer interface so that page action icons
can live outside of the location bar.

Design doc: https://docs.google.com/document/d/18HJywSmw6JiYMxFTbP496ivilPblOT8A63V12ip3ymE/

Bug: 788051
Change-Id: I2ae0e289d1e777e7bde5d0d73094dbbc60b2109a
Reviewed-on: https://chromium-review.googlesource.com/1049126Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558378}

This reverts commit 78aa0578.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 558371 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc4YWEwNTc4ZTA2Y2MyODgzNDNkMzk1Mzk3MzZhYzdjMzJhMTJlNTUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/64263

Sample Failed Step: compile

Original change's description:
> Add a tool to render new QUIC trace format using gnuplot
> 
> Merge internal change: 195841296
> Merge internal change: 195910638
> 
> R=rch@chromium.org
> 
> Change-Id: Id9681a3360ced19d329b68e161ff897e17ef43e7
> Reviewed-on: https://chromium-review.googlesource.com/1055756
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558371}

Change-Id: I533684421c474ebb17bfcc1cd7aabbc5aa7d4bd0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1057528
Cr-Commit-Position: refs/heads/master@{#558377}

Now the config files refers to the open fonts from
third_party/test_fonts instead of ms-ttf-corefonts that were used
previously.

Also fixed android_fallback_fonts.xml to refer to
NotoSansCJKjp-Regular.otf instead of NotoSansCJKkr-Regular.otf to
match the fonts we have in //third_party/test_fonts

Bug: 787020
Change-Id: Ie50f76c0a183e9904a3dae2d6fef091a6c2abe83
Reviewed-on: https://chromium-review.googlesource.com/1048872Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558376}