- 31 Oct, 2018 40 commits
-
-
Luciano Pacheco authored
This reverts commit 2903236d. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > Change NavigationListModel to support MyFiles as Volume. > > Add MYFILES_VOLUME_ENABLED in private strings to be able to have the > feature flag in the JS/UI code. > > Change VolumeManager to use MyFiles folder for Downloads volume, the > method |GetMyFilesFolderForProfile| takes care of returning the right > value based on the feature flag MyFilesVolume. > > Change NavigationListModel to support MyFiles as Volume when > MyFilesVolume feature flag is enabled: > 1. MyFiles volume is the Downloads volume (after the feature flag is > removed we can rename it accordingly). Setup Downloads volume as > VolumeEntry, > 2. Create a NavigationModelFakeItem with "My files" label, based on the > VolumeEntry (step #1). > 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact > Downloads volume. > 4. Continue to add Linux and Play files to Myfiles. > > Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' > Bug: 873539 > Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 > Reviewed-on: https://chromium-review.googlesource.com/c/1308235 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604143} TBR=joelhockey@chromium.org,lucmult@chromium.org,ioanap@chromium.org Change-Id: I0c5b1fd5f23b2ec2b56ab13ab93a2d3a1ffd277a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873539 Reviewed-on: https://chromium-review.googlesource.com/c/1309569Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604193}
-
Hiroki Nakagawa authored
This is a preparation CL for implementing off-the-main-thread worker top-level classic script loading. <Context of this change> Currently, a top-level worker classic script is loaded on the main thread with a parent document's context. In this case, MIME-type of the script is loosely checked for historical reasons. For example, 'text/html' can be executed as a script. On the other hand, once off-the-main-thread script loading is implemented, a top-level worker classic script is loaded on a worker thread with a worker's context and MIME-type of the script is strictly checked. This breaks bunch of web-platform-tests. To keep the backward compatibility, this CL allows WorkerClassicScriptLoader to specify whether to impose strict MIME-type checks regardless of the execution context type. A subsequent CL will disable it when off-the-main-thread top-level worker classic script loading: https://chromium-review.googlesource.com/c/chromium/src/+/1293432 <Possible cleanup in the future> The flag to disable the strict MIME-type check should actually be determined based on the 'fetch client' of script loading, so a subsequent cleanup CL may move the flag from WorkerClassicScriptLoader to FetchClientSettingsObject. Bug: 794548, 835717 Change-Id: I5cc8828966dd7619b30879f3d287505ad4b22fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1293097 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#604192}
-
yoshiki iguchi authored
This is a follow up of crrev.com/c/1303322. This CL adds a test for it. Bug: 897653 Test: passed the added test Change-Id: I546979f9e88c548201c733b446aa6c2f4ab2a7c9 Reviewed-on: https://chromium-review.googlesource.com/c/1308252 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#604191}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b00b28ee5067..f577ab3d38f9 git log b00b28ee5067..f577ab3d38f9 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7e85c092..9996ac89 (604065:604166) Created with: gclient setdep -r src/third_party/webrtc@f577ab3d38f9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61583a2d3b39cb47a2caa88fe713d371e22e1f75 Reviewed-on: https://chromium-review.googlesource.com/c/1309536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604190}
-
Mario Sanchez Prada authored
Bug: 886600 Change-Id: Idd339ae91bffeeceaeee929accde53fedc9f804d Reviewed-on: https://chromium-review.googlesource.com/c/1299162Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#604189}
-
Hajime Hoshi authored
This CL makes binding initialization a little delayed so that |frame_| always exists when the local frame's binding is created. After this CL, more tasks via WebLocalFrameImpl are executed on a per- frame task runner. Bug: 786332 Change-Id: I2f632814acefa7cf1bb2411563405306c469b6fc Reviewed-on: https://chromium-review.googlesource.com/c/1298532Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604188}
-
Rune Lillesveen authored
We only checked if we needed to update v0 shadow distribution before skipping style recalc for getComputedStyle and friends. Slot re- assignment for shadow dom v1 also needs to be done as it may affect inheritance ancestors for the element in question. This may be the reason for issue 900138, but we have no repro, so hard to say. Bug: 900138 Change-Id: Ie2ceae97141aabed0e26de3070b1f170e9eedeed Reviewed-on: https://chromium-review.googlesource.com/c/1307396Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604187}
-
Rijubrata Bhaumik authored
This is a JavaScript based test which is skipped if focusDistance is not supported. This test is run both on real cameras on some bots and also against the FakeVideoCaptureDevice. BUG=732807 Change-Id: I87be1cbf96aa79adcd539732f421bcfe69f92981 Reviewed-on: https://chromium-review.googlesource.com/c/1306498 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604186}
-
Luum Habtemariam authored
Re-adds the MissingKeyValueDelimiter unittest, accidentally removed in commit 9268d9a1. Bug: chromium:894274 Test: Tests still pass. Change-Id: I37228e812eaf71b1d51fb9982aedea70570311d2 Reviewed-on: https://chromium-review.googlesource.com/c/1306657 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Converts all HeapHashMap allocations from new to MakeGarbageCollected. Allocations using new will be banned from now on. Bug: 757708 Change-Id: Ib37cbfab74fd8209bf7355a36009165d0a7fdc09 Reviewed-on: https://chromium-review.googlesource.com/c/1307535 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9602f22485b..99e9e292a1a3 Created with: gclient setdep -r src-internal@99e9e292a1a3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1622827d0ab303370d6a876dcf588d94c069a183 Reviewed-on: https://chromium-review.googlesource.com/c/1309535Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604183}
-
Mathias Carlen authored
This change introduces an on/off switch which is off by default and is inspired by SavePasswordsPreferences. It is tied to a shared preference, lives entirely in Java and gates instantiation of the UiController. R=gogerald@chromium.org Bug: 806868 Change-Id: I849b6c5568a0cf7bb787dea2e4e73dc8abbf2c75 Reviewed-on: https://chromium-review.googlesource.com/c/1301443 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#604182}
-
Dominic Farolino authored
R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 882344 Change-Id: I42e264f9fc1591129091aa9f18b258a4e2313181 Reviewed-on: https://chromium-review.googlesource.com/c/1249400 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#604181}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69a72945dcdd..4d8f48db9ef5 git log 69a72945dcdd..4d8f48db9ef5 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@4d8f48db9ef5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I63b3695a8e702e3c5f5d6ee9cacf50e03d4cd974 Reviewed-on: https://chromium-review.googlesource.com/c/1309533Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76eeb8565846..fa909263570e git log 76eeb8565846..fa909263570e --date=short --no-merges --format='%ad %ae %s' 2018-10-31 primiano@google.com Merge "probes + trace_processor: Polling of /proc/[pid]/status mem counters" Created with: gclient setdep -r src/third_party/perfetto@fa909263570e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I08dbf894960cd98ecf91f8a3fb681dfc4328fc42 Reviewed-on: https://chromium-review.googlesource.com/c/1309534Reviewed-by:
-
Adam Rice authored
Copying MessageChannel and other functions to the binding object caused a memory regression. As a temporary workaround, only copy them to the binding object when the TransferableStreams feature is enabled. BUG=897046,900141,899637 Change-Id: If312f2e0967a19e9db427f60125d96c48d45fdc7 Reviewed-on: https://chromium-review.googlesource.com/c/1307534Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Rijubrata Bhaumik authored
if |exposure_time| >= 0.0f, then we assume that |exposure_mode| is manual. FakeVideoCaptureDevice is an internal class, so such assumptions are reasonable. Suggested by Miguel at https://chromium-review.googlesource.com/c/chromium/src/+/1243288/6/media/capture/video/fake_video_capture_device.h#107 BUG=823316 Change-Id: I8e112be76854da0f2c4343a8d62a5619e3aa79e4 Reviewed-on: https://chromium-review.googlesource.com/c/1307397 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Bug: 888072 Change-Id: I398053dad885c14483be4a07021f0b601a785b97 Reviewed-on: https://chromium-review.googlesource.com/c/1306946 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Leon Han authored
After https://crrev.com/c/1238079, blink::SWContainerClient becomes a supplement of Document and its only user is blink::SWContainer. This indirection looks redundant, so this CL refactors SWContainer to be also a supplement of Document and makes it take over all code logic of SWContainerClient, then removes SWContainerClient completely. BUG=789857 Change-Id: If2ecede8530c5d3a922f2388853b46b860fbbb2f Reviewed-on: https://chromium-review.googlesource.com/c/1286434 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604175}
-
Jazz Xu authored
This CL modifies the MediaControlSliderElement's segment positioning algorithm to take into account how slider elements handle the thumb element's position (The slider width is slightly larger than the thumb's center's moving range). This fixes an issue where the progress bar wasn't always aligned with the timeline thumb. Bug:839673 Change-Id: I6dd07c27174571945e585ac5654da991d610f89c Reviewed-on: https://chromium-review.googlesource.com/c/1294843 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604174}
-
Tatsuhisa Yamaguchi authored
Bug: 888072 Change-Id: Ifaa3ccecf4d21ae23054523290b2b87b033688f5 Reviewed-on: https://chromium-review.googlesource.com/c/1306969Reviewed-by:
-
Roberto Carrillo authored
...into linux-code-coverage, using the machine allocated to linux-code-coverage-builder previously. This is so that the code coverage report can be generated without needing to transmit the instrumented binaries from the builder to the tester, in addition to uploading it to isolate. R=stgao,liaoyuke Change-Id: I5af90704c78eee81f4bc2c28c9237334966045e1 Reviewed-on: https://chromium-review.googlesource.com/c/1306786Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#604172}
-
Hirokazu Honda authored
This enables VideoFrameValidator in evey TestSimpleDecode test case, that is, the test case except TestDecodeTimeMedia (performance test) and NoCrash. Because an input stream is decoded repeatedly, the index in display order of video frame on PictureReady() needs to be passed to VideoFrameValidator. It seems there is no good way to get the frame index from Picture. So I just count up the index on PictureReady() and reset it to 0 on NotifyResetDone(). This seems a hacky way and only works with the current VDA unittest, which always rewind to the beginning of the stream and does not jump to the middle of the stream. BUG=chromium:856562 TEST=VDA unittest on eve with frame validator $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 --ozone-platform=gbm --test_import --frame_validator Change-Id: I8fbbf165254f4e26c69f8da27b41ff3b9f395224 Reviewed-on: https://chromium-review.googlesource.com/c/1304286 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d54a42bd9174..e9602f22485b Created with: gclient setdep -r src-internal@e9602f22485b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6d2442d98f682a1fbf90922e2cc20f39d3dc4bae Reviewed-on: https://chromium-review.googlesource.com/c/1309332Reviewed-by:
-
Yutaka Hirano authored
Bug: 873959 Change-Id: I00d1350390d8e9083cf6dcb6fb0d5d8556d49c0e Reviewed-on: https://chromium-review.googlesource.com/c/1309395Reviewed-by:
-
Joshua Bell authored
The request for "Allow Indexed DB?" passed along the origin and the name of the database being accessed (or description of the operation). The former is used for the actual permission check. The latter was unused. Remove the parameter throughout the plumbing, including legacy IPC and Mojo pathways. Change-Id: I6e81670c34c748492545cd4954b2e913f9e1aef4 Reviewed-on: https://chromium-review.googlesource.com/c/1306914Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: If445645ad9a714a1d8498d08829300457a0ea845 Reviewed-on: https://chromium-review.googlesource.com/c/1308954Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604167}
-
Hiroki Nakagawa authored
This is a mechanical cleanup CL for making it easier to add new use counter tests. Bug: 900444 Change-Id: Ib8d3c708c0f6ed1fd00b00bbcc9e873097cccd64 Reviewed-on: https://chromium-review.googlesource.com/c/1308240 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/761322d458ea..6386fdec9f49 git log 761322d458ea..6386fdec9f49 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 briannorris@chromium.org cros flash: don't depend on 'cgpt' 2018-10-30 ahassani@chromium.org chromeos_config: Run paygen for <board>-payloads-tryjobs Created with: gclient setdep -r src/third_party/chromite@6386fdec9f49 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ida8e4c0060b135e71b929b0f15119bed7a2250da Reviewed-on: https://chromium-review.googlesource.com/c/1309330Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3f887b82310..b00b28ee5067 git log b3f887b82310..b00b28ee5067 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cb3899c..7e85c092 (603959:604065) Created with: gclient setdep -r src/third_party/webrtc@b00b28ee5067 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia83c94db30d2462bf20fe14d4e1435f241223ce0 Reviewed-on: https://chromium-review.googlesource.com/c/1309327Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bf8120cabd6..69a72945dcdd git log 9bf8120cabd6..69a72945dcdd --date=short --no-merges --format='%ad %ae %s' 2018-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7cba6be85a14..193a284d34d2 (7 commits) 2018-10-31 caryclark@skia.org added MakeFromYUVATextures to docs Created with: gclient setdep -r src/third_party/skia@69a72945dcdd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I3bcfad73a8b32647eafb0f861c49a9a291c42d6a Reviewed-on: https://chromium-review.googlesource.com/c/1309329Reviewed-by:
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I2a6bc371f5c28c1afa906fd54ea66dd98aacea7f Reviewed-on: https://chromium-review.googlesource.com/c/1307359Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#604162}
-
Donn Denman authored
This reverts commit 0036bbd0. Reason for revert: Ran out of time to try the development pipeline DETAILS: Just whitespace changes from the original. Original change's description: > [TTS] Write snippet to UKM for offline development > > Writes a snippet-hash and doc-id to UKM iff a command-line flag is > set that allows this development-only data to be logged. Disabled > on Beta and Stable channels. > > See go/ukm-cs-5, go/ukm-dev-data, go/cs-sanitized for details. > > Unfortunately our ContextualSearchDelegate cannot decode a JSON 64bit value > so we now expect to receive these new data in string format. > > Also fix a bug in the existing Ranker code: the native logger cannot log > 64-bit values, so we rename some misleading methods. Also, we need to break > these new data up into high/low 32-bit values when we log to Ranker. > > BUG=894568, 872902 > > Change-Id: Id0dd3ac218bafeb23396f010c340e5e5531799f0 > Reviewed-on: https://chromium-review.googlesource.com/c/1264591 > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599258} TBR=rkaplow@chromium.org,donnd@chromium.org,twellington@chromium.org,amoylan@chromium.org,rhalavati@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894568, 872902 Change-Id: I99cc44bf1f89cace8548957e75acbcdd2cfe9afa Reviewed-on: https://chromium-review.googlesource.com/c/1308102 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#604161}
-
Esmael El-Moslimany authored
Bug: 899187 Change-Id: Ib640ceeec2abeb1f6ad1411cc10633018f85e303 Reviewed-on: https://chromium-review.googlesource.com/c/1308076 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604160}
-
Koji Ishii authored
Following bot results are included. 11229 11240 11250 11260 11265 41 lines were removed and 9 lines were deflaked by consecutive results since 11202. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I259e27620abb6d07377e1a98bfcef68145d1bad2 Reviewed-on: https://chromium-review.googlesource.com/c/1307913 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604159}
-
Yutaka Hirano authored
Wait until the response body arrives at the client side before cancelling the loader in order not to rely on a certain scheduling policy. Bug: 896159 Change-Id: Ifdacae1bd257ca12f57e64aed2fbffb5b5d1ab72 Reviewed-on: https://chromium-review.googlesource.com/c/1304173Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#604158}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a847559555af..d54a42bd9174 Created with: gclient setdep -r src-internal@d54a42bd9174 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic1270e3697cd18a1ee13e4afd7d71fb742f251cd Reviewed-on: https://chromium-review.googlesource.com/c/1309328Reviewed-by:
-
Dominick Ng authored
RecordMetrics() is called after browser startup and then no more than once per hour of browser use. It must fetch all site engagement content settings and calculate statistics over them, and on some Android devices it blocks the UI thread for 2500ms. This is bad since Android will kill the browser if the UI thread is busy for more than 5 seconds. This CL refactors the method to make it less expensive. In particular: - a duplicate call to SiteEngagementService::GetAllDetails is eliminated - SiteEngagementService::GetAllDetails (the fetch method) is refactored so that it may be run as a background task to free the UI thread. This involved eliminating all calls to HostContentSettingsMapFactory::GetForProfile as this method DCHECKs that it is on the UI thread. After this CL, SiteEngagementService::GetAllDetails() is called once in SiteEngagementService::RecordMetrics(), and that one call happens on a background thread. Other callers to the method continue to call it on the UI thread; future work may convert the method to be callback-driven so that it is never called on the UI thread. BUG=900022 Change-Id: Ie661b915891ddf981ac4a3049e8e96b73b23684d Reviewed-on: https://chromium-review.googlesource.com/c/1307018 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#604156}
-
Koji Ishii authored
This patch re-uses line box fragments where possible. Overall approach is: 1. Line box NGPaintFragment is marked as dirty when modified. This was done in separate patches by yosin@, and is being improved further. 2. On the beginning of layout, if NGPaintFragment exists for the inline formatting context and re-using is possible, copy them to NGFragmentBuilder. 3. Setup the internal states and break token so that NGBlockLayoutAlgorithm can continue from the copied fragments. This is very initial patch. Not much improvements are seen in blink_perf.layout yet, but at this stage, the reuse is only for very limited conditions, and I'm finding cases where we mark dirty too much (fixing in parallel.) Also some cases we're slowing down, due to the overhead to check the reusability but ended up with no reuse. The code to check is also target to be profiled for more optimizations. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib0f24ece25bf666f67042a915ed75e0b5d2b4356 Reviewed-on: https://chromium-review.googlesource.com/c/1196724 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604155}
-
Hajime Hoshi authored
As |notification_task_runner_| can execute V8, this must not be the default task runner. Use a per-frame task runner instead. Bug: 870606 Change-Id: I6537fa2fae5f9b5e831476be815220cc3e783711 Reviewed-on: https://chromium-review.googlesource.com/c/1307360Reviewed-by:
-
