GitLab

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/607313002

Cr-Commit-Position: refs/heads/master@{#297124}

We converted this target to GN already, so app_list can depend on it as
is. This should address the TODO(GYP) in the BUILD.gn file.

BUG=None
TEST=None
R=brettw@chromium.org
TBR=xiyuan@chromium.org,mark@chromium.org

Review URL: https://codereview.chromium.org/590863002

Cr-Commit-Position: refs/heads/master@{#297123}

Reworks DepsIterator so it is compatible with STL iterators enough to work with range-based for loops. The iterator is now created by a target rather than taking a target as an argument, which makes the loops more natural.

I also changed some loops around code I was touching to use range-based.

Review URL: https://codereview.chromium.org/610043002

Cr-Commit-Position: refs/heads/master@{#297122}

Say you have class A and subclass B.

Previously it was required to PassAs() a scoped_ptr<B> into a
scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
created scoped_ptrs, you can just use make_scoped_ptr always now.

And when you want to return or assign an empty scoped_ptr(), you can
now use nullptr directly.

Also adds PRESUBMIT checks for:
- return scoped<T>(foo). This should be return make_scoped_ptr(foo).
- bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
- return scoped<T>(). This should be return nullptr.
- bar = scoped<T>(). This should be return bar = nullptr.

This also replaces p.reset() with p = nullptr; But it does not add a
PRESUBMIT check for that because there are things other than scoped_ptr
with a reset() function.

R=enne@chromium.org

Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08
Cr-Commit-Position: refs/heads/master@{#297096}

Review URL: https://codereview.chromium.org/609663003

Cr-Commit-Position: refs/heads/master@{#297121}

Review URL: https://codereview.chromium.org/609103002

Cr-Commit-Position: refs/heads/master@{#297120}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/611733002

Cr-Commit-Position: refs/heads/master@{#297119}

Review URL: https://codereview.chromium.org/612643002

Cr-Commit-Position: refs/heads/master@{#297118}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/613553002

Cr-Commit-Position: refs/heads/master@{#297117}

This adds support to use nullptr to construct, assign, or return a
scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
of a move-only constructor.

The changes are:

- Add a constructor that takes decltype(nullptr) as a parameter. This
allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
function with return type scoped_ptr<T> to "return nullptr;" instead
of "return scoped_ptr<T>();".

- Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
empty and deletes anything it held.

- Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
constructing a scoped_ptr from another using move-only semantics. This
piece is critical for allowing the function returning nullptr to be
assigned to some other scoped_ptr at the callsite. In particular, take
the following code:
  scoped_ptr<T> Function() { return nullptr; }
  scoped_ptr<T> var = Function();
In this case the constructor which takes a nullptr allows Function() to
be written, but not to be used. The move-only constructor allows the
assignment from Function() to var. See "C++11 feature proposal:
Move-only constructors" on chromium-dev for more explanation why.

The scoped_ptr<T> class already had a constructor which took
scoped_ptr<U,E> as an argument, so this was changed to be
scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
constructor, so a scoped_ptr&& constructor was added. These match
the constructors found on the unique_ptr class.

- Remove the RValue type and the contructor that constructs a
scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
instead of a scoped_ptr::RValue, to avoid the type conversion and
remove some complexity. This is done with a new emulation macro that
still provides Pass() and makes the type go down the MoveOnlyType
path in base::Callback code.

This adds base_unittests to demonstrate and use these changes.

The use of Pass() remains unchanged until std::move() is written
or allowed. At that time std::move() could be used instead of Pass.

R=brettw@chromium.org, jamesr@chromium.org

Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
Cr-Commit-Position: refs/heads/master@{#297072}

Review URL: https://codereview.chromium.org/599313003

Cr-Commit-Position: refs/heads/master@{#297116}

R=cmumford@chromium.org, jsbell@chromium.org, michaeln@chromium.org
BUG=418297

Review URL: https://codereview.chromium.org/594403005

Cr-Commit-Position: refs/heads/master@{#297115}

Derived from worksheet attached to https://code.google.com/p/chromium/issues/detail?id=369206#c17

BUG=369206
TEST=Manual, see bug.

Review URL: https://codereview.chromium.org/611693002

Cr-Commit-Position: refs/heads/master@{#297114}

Since Cast disables all user interaction, gesture requirement/infobar are
not useful.

The other flags are for protected content playback.

R=xhwang@chromium.org,byungchul@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/597813002

Cr-Commit-Position: refs/heads/master@{#297113}

It seems that it's possible that GDK events happen while we're going
to unregister the GDK event handler, and the code must be thread-safe.
(A gpointer |data| in the old code seems pointing to the deleted object.)

This CL removes use of |data| pointer and makes the code thread-safe
without adding any mutex.

BUG=417210

Review URL: https://codereview.chromium.org/610523002

Cr-Commit-Position: refs/heads/master@{#297112}

BUG=414483

Review URL: https://codereview.chromium.org/587153002

Cr-Commit-Position: refs/heads/master@{#297111}

This will make easy to tell when the main thread is
in a high latency mode without having to infer based
on the surrounding context.

BUG=none

Review URL: https://codereview.chromium.org/561043002

Cr-Commit-Position: refs/heads/master@{#297110}

Revert of Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (patchset #1 id:1 of https://codereview.chromium.org/606143003/)

Reason for revert:
scoped_ptr nullptr support was reverted.

Original issue's description:
> Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder.
>
> R=jamesr@chromium.org
>
> Committed: https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71
> Cr-Commit-Position: refs/heads/master@{#297093}

TBR=jamesr@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/593313006

Cr-Commit-Position: refs/heads/master@{#297109}

Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #2 id:20001 of https://codereview.chromium.org/610083002/)

Reason for revert:
scoped_ptr nullptr support was reverted.

Original issue's description:
> Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}.
>
> R=jamesr@chromium.org
>
> Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052
> Cr-Commit-Position: refs/heads/master@{#297095}

TBR=jamesr@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/609033002

Cr-Commit-Position: refs/heads/master@{#297108}

Revert of Add nullptr support to scoped_ptr. (patchset #7 id:180001 of https://codereview.chromium.org/599313003/)

Reason for revert:
This CL broke several scoped_ptr tests.

Original issue's description:
> Add nullptr support to scoped_ptr.
>
> This adds support to use nullptr to construct, assign, or return a
> scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> of a move-only constructor.
>
> The changes are:
>
> - Add a constructor that takes decltype(nullptr) as a parameter. This
> allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> function with return type scoped_ptr<T> to "return nullptr;" instead
> of "return scoped_ptr<T>();".
>
> - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> empty and deletes anything it held.
>
> - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> constructing a scoped_ptr from another using move-only semantics. This
> piece is critical for allowing the function returning nullptr to be
> assigned to some other scoped_ptr at the callsite. In particular, take
> the following code:
>   scoped_ptr<T> Function() { return nullptr; }
>   scoped_ptr<T> var = Function();
> In this case the constructor which takes a nullptr allows Function() to
> be written, but not to be used. The move-only constructor allows the
> assignment from Function() to var. See "C++11 feature proposal:
> Move-only constructors" on chromium-dev for more explanation why.
>
> The scoped_ptr<T> class already had a constructor which took
> scoped_ptr<U,E> as an argument, so this was changed to be
> scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> constructor, so a scoped_ptr&& constructor was added. These match
> the constructors found on the unique_ptr class.
>
> - Remove the RValue type and the contructor that constructs a
> scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> instead of a scoped_ptr::RValue, to avoid the type conversion and
> remove some complexity. This is done with a new emulation macro that
> still provides Pass() and makes the type go down the MoveOnlyType
> path in base::Callback code.
>
> This adds base_unittests to demonstrate and use these changes.
>
> The use of Pass() remains unchanged until std::move() is written
> or allowed. At that time std::move() could be used instead of Pass.
>
> R=brettw@chromium.org, jamesr@chromium.org
>
> Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> Cr-Commit-Position: refs/heads/master@{#297072}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/603353005

Cr-Commit-Position: refs/heads/master@{#297107}

Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (patchset #6 id:120001 of https://codereview.chromium.org/609663003/)

Reason for revert:
scoped_ptr nullptr support needs to be reverted

Original issue's description:
> cc: Remove use of PassAs() and constructor-casting with scoped_ptr.
>
> Say you have class A and subclass B.
>
> Previously it was required to PassAs() a scoped_ptr<B> into a
> scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
> created scoped_ptrs, you can just use make_scoped_ptr always now.
>
> And when you want to return or assign an empty scoped_ptr(), you can
> now use nullptr directly.
>
> Also adds PRESUBMIT checks for:
> - return scoped<T>(foo). This should be return make_scoped_ptr(foo).
> - bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
> - return scoped<T>(). This should be return nullptr.
> - bar = scoped<T>(). This should be return bar = nullptr.
>
> This also replaces p.reset() with p = nullptr; But it does not add a
> PRESUBMIT check for that because there are things other than scoped_ptr
> with a reset() function.
>
> R=enne@chromium.org
>
> Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08
> Cr-Commit-Position: refs/heads/master@{#297096}

TBR=enne@chromium.org,jamesr@chromium.org,vmpstr@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/608503005

Cr-Commit-Position: refs/heads/master@{#297106}

For offTheSideButton, animation was always enabled regardless of nodeMoved/
nodeRemoved. Enable animation only when it is called from -nodeRemoved:,
decided by 'animate' parameter.

BUG=60628
R=asvitkine@chromium.org

TEST=
1. Launch chrome and add more bookmarks and folders so that chevron is seen.
2. Drag and adjust items so that there is atleast one folder and one or more bookmarks under chevron.
3. Drag a bookmark(within chevron) and drop it under the folder(within chevron) and observe.
4. There should be no poof animation/sound presented to see/hear.

Review URL: https://codereview.chromium.org/599793002

Cr-Commit-Position: refs/heads/master@{#297105}

We're currently not passing the request context or frame type correctly
when performing redirects, which breaks our mixed content checking
functionality for those requests. This is the Chromium side of a fix.
Blink side to follow.

BUG=417841

Review URL: https://codereview.chromium.org/605103003

Cr-Commit-Position: refs/heads/master@{#297104}

Also remove logic for 401 errors. I don't think this is the correct thing to do, and covers up the real failure.

BUG=418225
TEST=None.
R=tonyg

Review URL: https://codereview.chromium.org/608933002

Cr-Commit-Position: refs/heads/master@{#297103}

Memory for WriteInto() should be greater than the url length,
As in the WriteInto() it reserve the memory of size 'length_with_null'
and then resize it to "length_with_null-1'
Chnage done to give memory 1 greater than the url length size.

BUG=417732

Review URL: https://codereview.chromium.org/599373003

Cr-Commit-Position: refs/heads/master@{#297102}

R=dpapad@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/575333002

Cr-Commit-Position: refs/heads/master@{#297101}

BUG=418190

Review URL: https://codereview.chromium.org/607013003

Cr-Commit-Position: refs/heads/master@{#297100}

This wasn't enough and was causing compilation error in clean build.

This reverts commit 2a244c81.

BUG=414340
TBR=yoz@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/610093002

Cr-Commit-Position: refs/heads/master@{#297099}

Cr-Commit-Position: refs/heads/master@{#297098}

BUG=416612
TBR=nyquist@chromium.org, pkasting@chromium.org, courage@chromium.org

Tommy: TBR for signin_manager_android.cc
Michael: TBR for gaia_web_auth_flow.cc
Peter: TBR for auto_login_infobar_delegate.cc

Review URL: https://codereview.chromium.org/601643002

Cr-Commit-Position: refs/heads/master@{#297097}

Say you have class A and subclass B.

Previously it was required to PassAs() a scoped_ptr<B> into a
scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly
created scoped_ptrs, you can just use make_scoped_ptr always now.

And when you want to return or assign an empty scoped_ptr(), you can
now use nullptr directly.

Also adds PRESUBMIT checks for:
- return scoped<T>(foo). This should be return make_scoped_ptr(foo).
- bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo).
- return scoped<T>(). This should be return nullptr.
- bar = scoped<T>(). This should be return bar = nullptr.

This also replaces p.reset() with p = nullptr; But it does not add a
PRESUBMIT check for that because there are things other than scoped_ptr
with a reset() function.

R=enne@chromium.org

Review URL: https://codereview.chromium.org/609663003

Cr-Commit-Position: refs/heads/master@{#297096}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/610083002

Cr-Commit-Position: refs/heads/master@{#297095}

BUG=418214

Review URL: https://codereview.chromium.org/609983002

Cr-Commit-Position: refs/heads/master@{#297094}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/606143003

Cr-Commit-Position: refs/heads/master@{#297093}

Since extension errors are designed to take up the full amount of space, there
was no room left for the borders to indicate tab highlighting, and they were
slightly cut off. Fix this by adding a tiny bit of room above and below each
error, and to the end of the view details link.

Screenshots (after and before): http://imgur.com/acdRaXH,XDDIdZ8
BUG=380637

Review URL: https://codereview.chromium.org/599103004

Cr-Commit-Position: refs/heads/master@{#297092}

It's not being used anymore

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/606503005

Cr-Commit-Position: refs/heads/master@{#297091}

We'll be adding a new type of interstitial for captive portals. This
patch is to accomodate that change.

BUG=384667

Review URL: https://codereview.chromium.org/600153004

Cr-Commit-Position: refs/heads/master@{#297090}

The script currently just verifies that all changes are "git cl format" clean.

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/611673002

Cr-Commit-Position: refs/heads/master@{#297089}

Currently, the host list is fetched from the main activity's onStart()
handler. If onStart() is triggered again during the process of
authentication, this could cause an infinite loop of pending requests.

Review URL: https://codereview.chromium.org/607453004

Cr-Commit-Position: refs/heads/master@{#297088}

The theory is that some of the tests that check
mean_pixels_approximated could become worse after my change
because PLI's drawn as solid color were not adding its drawn
pixels into the calculation.  I can't replicate the test,
possibly due to lack of throttling on my phone, so the plan is
to commit this change and see if the tests go back to normal.

Even if it doesn't improve the test, the change is correct and
should be committed regardless.

BUG=416446

Review URL: https://codereview.chromium.org/607063003

Cr-Commit-Position: refs/heads/master@{#297087}

GetUILanguageList didn't check for locale aliases when resolving input
method languages. This patch fixes it.

BUG=418220
TEST=manual

Review URL: https://codereview.chromium.org/608903003

Cr-Commit-Position: refs/heads/master@{#297086}

Nobody knows yet what the right fix should be.

So this is just a band-aid, until we figure it out.

It isn't bad as it may look like, but certainly far
from the ideal as nothing from ui/ should be
depending on things declared in chrome/.

BUG=374490
TEST=git cl try -c -r HEAD passes on Android.
R=sky@chromium.org,primiano@chromium.org

Review URL: https://codereview.chromium.org/609963003

Cr-Commit-Position: refs/heads/master@{#297085}