- 03 Sep, 2020 40 commits
-
-
Luke Zielinski authored
This test is already flaky and now also times out. Importer tries to add the timeout as a separate line instead of combining it with the existing line, which causes a lint error. TBR=smcgruer Change-Id: I0046597b917746e5ec8e7110025f1507adf74582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391205Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804360}
-
David Bertoni authored
These tests were disabled for flakiness. They passed 3000 iterations on the bots without flaking. One test fails consistently on the LaCrOS bot and is disabled for that build configuration. Bug: 69215, 108493 Change-Id: Ie93c5949520c39c7b1ec8439f442722795535fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376463 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804359}
-
Elly Fong-Jones authored
We've decided to abandon system modality on non-ChromeOS platforms, so always use window modality for this dialog instead. Some minor cleanups of DownloadInProgressDialogView are included in this change. Bug: 1121132 Change-Id: Ia1e5efaa63a38a0f97608253ee688b08b8a86a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377989Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804358}
-
edchin authored
Bug: 1123704 Change-Id: Ifb025407075376c7046c79e361bdc4c690db905d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386843Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804357}
-
Ken Rockot authored
We try to unregister NetworkCallback in cases where one was never registered due to an earlier failure. This fixes that. Fixed: 1121933 Change-Id: If0a3a9db5d64197e8bad11df8bc53d8433692d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392742 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804356}
-
Xiang Ji authored
Validation: Test passed locally Bug: 1102144 Change-Id: Iee4dcf7dc58d103b3ef26e7c86950293645ccad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392406Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#804355}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Ie496c68ea5fbcc05eb803da4a74fcd3f2eaadd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392764Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#804354}
-
dpapad authored
Fixed: 1123803 Change-Id: Ibf8a56c667ca469d0e4679c7be9e88f682446848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389343 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804353}
-
danakj authored
There's a weird split of responsibility between RenderWidgetHostImpl and RenderWidgetHostViewBase, both of which are used for all platforms. This merges some responsibility up to RenderWidgetHostImpl for the OnRenderFrameMetadataChangedAfterActivation() event. R=avi@chromium.org Change-Id: I2349391493b1bb1e71393c5a7bb34e931d650527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392620 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804352}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 85.0.4183.81 TBR=estaab@chromium.org Bug: 1041619 Change-Id: I5a9d7b39a0ac540fe0389cb788d6b81ed860c768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392981Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#804351}
-
Daniel Classon authored
Adds deep links to the Printing Page and the CUPS Printers subpage. Adds a new test for the Printing Page. Bug: 1084154 Change-Id: I2695fb9817a29ec7bcbd9c42b141cff0bad7dd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391603Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#804350}
-
danakj authored
This method is just for tests, and they can find the value by using a RenderFrameSubmissionObserver. R=avi@chromium.org Change-Id: Id73446e782953f8c4e94dad0c91cd37acd16b434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390855 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
John Lee authored
https://imgur.com/a/8EY34XX Bug: 1123227 Change-Id: Idf4d10b8b4a9652df8fb8876ad7b0d497e289347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390996 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#804348}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that properties like 'text-align' that don't apply to ::marker, should not be able to affect the ::marker via inheritance when set to an ancestor. Therefore, this patch sets 'text-align: start !important' in UA origin. The specific value is not much important, since inside markers are inline boxes unaffected by 'text-align', and outside markers are usually sized with shrink-to-fit. It only matters in case of outside markers whose text contains newline characters, or in quirks mode when the marker is forced to occupy the whole line. Additionally, since 'text-align' has been implemented as a longhand rather than a shorthand of 'text-align-all' and 'text-align-last', this patch also sets 'text-align-last: start !important'. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-text-align.html TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js Change-Id: Ibe8d72d4675c5d1e3b0ceedf3acc615e1514fe7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391242Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#804347}
-
Renjie Tang authored
Bug: b/167434069 Change-Id: I57d5caef848498563e7932114cd880204b73c975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391736Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804346}
-
David Bertoni authored
Bug: 1093066 Change-Id: I2cfb8124ee962c57c253771e10538e993337f85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354829Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804345}
-
Hui Yingst authored
This CL adds an array of |Attachment| in MetadataMessageData so that the back end can send the pp::VarArray of attachment information with the rest of the metadata to the front end, and then stores it. Bug: 177188 Change-Id: I676c8ecf86321eb0cbd2d95f328d76ed5eec0e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335032 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804344}
-
Robert Ogden authored
Uses the decision logic documented in the bug to decide which type of probe to do, if it is needed. The HTTP probe functionality is left intact, with an experiment flag to force its use instead of a TLS probe. Bug: 1115731 Change-Id: Ia93436cf3e0ef94d7ca9b2e5131a24c965f0b2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376566Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#804343}
-
Gavin Williams authored
This feature will show the printer status icons on the Print Preview destination dialog page. go/printer-availability-destination-dialog-design-doc Bug: 1123754 Change-Id: Iae8c761193397ec18d4e7c3b177fd39a6b31013d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388268 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#804342}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea8f739bce40..c94650d88fd7 2020-09-03 mbonadei@webrtc.org Remove AudioProcessing::SetExtraOptions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e28defc353717c8b800a2ce757064dcd85ff8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804341}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009030800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zwRP_oB_FFojw9A51kcgFuTt7F2XMAF7nY9G1H61DPsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia1f3b48e556f1a6059b8586cd48620236661d96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392674Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804340}
-
Ken Rockot authored
This moves the query for 3D API blocking policy back to the IO thread with the document URL provided by the renderer again. The IO thread is used to reduce sync IPC hangs in renderers using WebGL, and the origin is trusted from the renderer (a) to avoid racy coordination between IO and UI thread and (b) because this is not a security-sensitive decision. Fixed: 1119941 Change-Id: Ica47eb137c1e28a7e754b753f2356266e8b9d659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380345 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804339}
-
Sinan Sahin authored
Change-Id: I84c31c97a340011c42642810425c3e9676e27eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995877Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#804338}
-
Alex Newcomer authored
This reverts commit 1af1bc07. Reason for revert: Blocking the Chrome on Chromeos uprev. https://bugs.chromium.org/p/chromium/issues/detail?id=1123901#c6 Original change's description: > arcvm: Start arcvm-adbd on starting ARCVM > > This CL depends on the following CLs: > https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431 > https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806 > https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221 > > BUG=b:166314117 > TEST=arc.Boot.vm still passes, arcvm-adbd runs > > Change-Id: I385a807d84a98b4a97dcc66daf6bef5881eef2bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380733 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803035} TBR=yusukes@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:166314117 Change-Id: I30644f24fbe139330a54e88aefc1b73c0340340e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392625Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804337}
-
Anders Hartvoll Ruud authored
The basename suffix '_test_helpers' (with an 's' at the end) gets special treatment by audit_non_blink_usage.py: like other test code, it's exempt from the audit. This came up when trying to use the css_test_helpers namespace in a new animation_test_helper.h/cc util, which was frowned upon by audit_non_blink_usage.py. This CL also wraps the functions in a animation_test_helpers namespace. This is just something I recommend, and not strictly required. (It makes it less risky and more acceptable to add new helpers with "common" names, like CreateAnimation). Change-Id: I627fa6987c5dfad9b7c1d1452de10b07ee9b8ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391221Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#804336}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284 2020-09-03 fmayer@google.com Merge "Check if target process has exited first." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie1bbf442efcee24948b266e82ae38a88fc0757a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392719Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/600d59e343a0..fa82803f46aa 2020-09-03 madigens@gmail.com * ChangeLog: Add entry for last commit. 2020-09-03 dalboris@gmail.com Export version info (#58935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I11ce70217ed73add9f3600415a200da959f13f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392352Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#804334}
-
W. James MacLean authored
When the touch-selection context menu is re-shown after moving one of the selection handles, it goes through RenderWidgetHostViewAndroid which always sends the request to the mainframe renderer, which is incorrect when the selection is inside an OOPIF. This CL fixes it by having TouchSelectionControllerClientManagerAndroid route the request to the manager's currently active client. If the selection is in an OOPIF, then TouchSelectionControllerClientChildFrame will handle it. We still need to develop tests for touch handle movements & context menus, both for OOPIFs and main frames. Bug: 977215 Change-Id: I3649af49839778fea4462b35b1b11349e00edcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382227 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804333}
-
Henrique Nakashima authored
Fixed version with integration test to guard against the bug that required the revert. Original message: Use IncognitoTabModelObserver to break IncognitoTabModel->.incognito Two new classes IncognitoNotificationPresenceController and IncognitoProfileDestroyer now bind the TabModelSelector to the .incognito package, controlling respectively the incognito notification and the incognito Profile destruction. Since TabModelSelectorBase creates the TabModels only after native load, it acts as a relay for the events. It is changed to recognize that there are two TabModels, one normal and one incognito, so it can observe the incognito one. Splitting IncognitoTabModel into interface and impl keeps tests from having to depend on IncognitoTabModelImpl. Bug: 1109013 Change-Id: I04421e2f58e7ab498fbab31657175ee5e2c310b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378733Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#804332}
-
Rob Buis authored
If the <munder>, <mover> or <munderover> elements have a computed math-style property equal to compact and their base is an embellished operator with the movablelimits property, then their layout algorithms are respectively the same as the ones described for <msub>, <msup> and <msubsup>. In this CL we delegate to the scripts algorithm which is changed to be able to handle script types over, under and underover. This CL does not handle embellished operators as defined [2] but just the first case, i.e. <mo> elements but not the two other cases, to simplify this CL. To handle dynamic changes to the movablelimits attribute on <mo> UpdateFromElement is implemented on LayoutNGMathMLBlockFlow. To handle dynamic changes to attributes (like displaystyle) on math elements UpdateFromElement is implemented on LayoutNGMathMLBlock. [1] https://mathml-refresh.github.io/mathml-core/#children-of-munder-mover-munderover [2] https://mathml-refresh.github.io/mathml-core/#embellished-operators Bug: 6606 Change-Id: Ib4af58ed88b7d41944f4d4676bba812c3b7a3a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383023Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#804331}
-
Shrek Shao authored
Rerecord the tests on Mac OS. Upload the rendering_desktop_e0cf9b9bd8.wprgo to chrome-partner-telemetry. Unzip the wprgo file to make sure the expected URL "http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2\u0026use_attributes=1\u0026use_multi_draw=1\u0026num_geometries=120000" appears. This should fix the request failure issue on current perf bots. Bug: 890539 Change-Id: I4f409d4304cc910c81f4275780d3578c195349ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391595Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#804330}
-
John Lee authored
https://imgur.com/a/OxpFoac Change-Id: I07d79f0b682cf8da7ca1416a7882d34b560ee767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390963Reviewed-by:
-
Henrique Nakashima authored
print_class_dependencies.py is used to audit deps, and normally we look at outbound deps and inbound deps at different points and in different situations. Change-Id: Ie331b7502ff09827a3ddf08a6c2cc3b8d7183b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391593 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804328}
-
Lukasz Anforowicz authored
This CL adds extra logging to NavigateToURLInSameBrowsingInstance that was blamed for the first failed test assertion in the log stored in https://crbug.com/859487#c3. This CL doesn't contain any actual fix for the flakiness, but reenables the test anyway, because 1) the test passed 50 times when run locally 2) hopefully the extra logging will help diagnose the flakiness if the test starts flaking again on the bots Fixed: 859487 Change-Id: I90caf66b0ffbbd341a5c8cd00a5605d509aa31d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390998 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This is a reland of 0ad6a0b8 This CL fixes the _partial_java rule, which was failing due to android resource issues in the original CL. Original change's description: > Replace AndroidX Preference[Dialog]FragmentCompat with the version from master > > This CL replaces the PreferenceFragmentCompat and > PreferenceDialogFragmentCompat classes in the AndroidX preference > library with the version from master, which has a change needed for > WebLayer. The preference library maintainers say they won't create a new > release just for this fix, so to get it we'll have to pull it in > ourselves. > > Bug: 1092986 > Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802334} Bug: 1092986 Change-Id: I3330d3d5f9f9c1732cc853a8a3ab5fb59595a4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382617 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804326}
-
Nate Chapin authored
Currently, we lazily initialize document the first time it is requested *and* all of the data is loaded (https://crbug.com/1107442 fixed a case where we would incorrectly initialize the document by creating it before all of the data had been received). It's much clearer to just initialize the document when all of the data is received, and have GetDocument() be a simple getter. Change-Id: I830dca5cc953ca8467fd936f5c783db21cfce051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316415 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#804325}
-
Anupam Snigdha authored
This patch has the initial implementation of the VirtualKeyboard APIs on Android. It uses the new virtualKeyboardPolicy that will let web authors control the virtual keyboard behavior through JS by calling virtual keyboard's show/hide APIs. In the next patch I'll implement the geometrychange event that will let web authors control whether to scroll the editable element into view by default or not and also send the size of the virtual keyboard rectangle. It is currently behind a runtime flag - VirtualKeyboard. Explainers and Design Doc: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardPolicy/explainer.md https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Bug: 856269 Change-Id: I2424e016cad34e52f9c59503f1918f5c51e4bcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386461 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Additionally, update all existing clients to use the kBluetoothLowEnergy client. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2391739. The CL originally got reverted because it used cached CQ results to submit, but some other changes had landed since the CQ results were cached which broke the build. Original CL is patchset 1, and fix is in patchset 2. Bug: 1106937 Change-Id: I72c6d0eec7e5afcfdde09a8439a10f856883732b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392916 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804323}
-
Elly Fong-Jones authored
This change is the first step in rectifying the confusion around WidgetDelegate's ownership of its contents view, which is documented at length in WidgetDelegate's class definition. Specifically, this change makes it clear when it is *intended* that ownership of the contents view is taken from the WidgetDelegate. This is step 1 of this plan: 1) Introduce WidgetDelegate::TransferOwnershipOfContentsView() and migrate to it in places that are trying to take ownership 2) Introduce WidgetDelegate::SetContentsView(), which will either: a. Store the provided view in a unique_ptr, if it is not owned by client, or b. Store the provided view in a raw pointer, if it is owned by client 3) Replace all existing overrides of GetContentsView() with uses of SetContentsView() 4) Require that !owned_by_client() in SetContentsView(), which will likely require intense surgery of client classes 5) Have SetContentsView() take and TransferOwnershipOfContentsView() return a unique_ptr<View> rather than a View* This multi-step plan avoids ever storing a view with owned_by_client in a unique_ptr, which is an extremely simple route to an accidental double-free. Bug: 1075649 Change-Id: I3ee55423ba5e4e7b48a50a9f4e04299f0721d410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376449 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804322}
-
Marijn Kruisselbrink authored
Different storage partitions should not be able to resolve blob URLs created in other partitions. To ensure this, give each partition their own blob url registry. There is one exception though, a <webview> inside a chrome app should be able to resolve blob URLs that were created by the chrome app. To enable this, we add the concept of a "fallback url registry" to BlobUrlRegistry, and pass the BlobUrlRegistry of the app in as fallback when creating the storage partition for a <webview>. Bug: 1106890 Change-Id: I809f24a2c0b4d8d21e53d46bb6d3e2027b21281b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324110Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
