GitLab

GLSurface::Destroy() could be called from outside the GLSurface
implementation. Since it is also called in NativeViewGLSurfaceGLX's
destructor, calling Destroy() twice will cause a BadWindow error.

BUG=470004

Review URL: https://codereview.chromium.org/1034173004

Cr-Commit-Position: refs/heads/master@{#322494}

BUG=466091

Review URL: https://codereview.chromium.org/1019543002

Cr-Commit-Position: refs/heads/master@{#322493}

https://chromium.googlesource.com/angle/angle/+log/3cd438d1..1ea584c56

BUG=470695,461274
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/1032323005

Cr-Commit-Position: refs/heads/master@{#322492}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e0b19d4..fd3a91e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1034253002

Cr-Commit-Position: refs/heads/master@{#322491}

Disable expiration date popups, CVC text input field, and storage
checkbox once a permanent error message is shown.

BUG=448572

Review URL: https://codereview.chromium.org/1038043003

Cr-Commit-Position: refs/heads/master@{#322490}

Refactor a little to share some ui->skia converters.

BUG=468509
TEST=set HKLM\Software[\Wow6432Node]\Microsoft\Avalon.Graphics\DISPLAY1\PixelStructure to 1 or 2, zoom in and confirm RGB or BGR fringes respectively.

Review URL: https://codereview.chromium.org/1021643002

Cr-Commit-Position: refs/heads/master@{#322489}

Build VP9 postproc/mfqe for WebRTC
https://codereview.chromium.org/1033873004

R=marpan@google.com, tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1009963004

Cr-Commit-Position: refs/heads/master@{#322488}

OnPaint() is not part of the recursion, it won't have access to the
necessary pieces to do recursion.

If you need to do painting while inside the recursion, this should
happen in PaintChildren(). So move the contents of OnPaint() to
PaintChildren().

R=estade@chromium.org
BUG=466426

Review URL: https://codereview.chromium.org/1029263011

Cr-Commit-Position: refs/heads/master@{#322487}

This can only fail if a CDM declares support for a container that Chrome does not, which would be a bug in CDM registration.

BUG=374751

Review URL: https://codereview.chromium.org/1035923004

Cr-Commit-Position: refs/heads/master@{#322486}

This only affects PlzNavigate. When a same-site navigation should reuse the current WebUI, in RFHM::GetFrameHostForNavigation the (shadowing) method-local |should_reuse_web_ui_| would be set to true and the speculative WebUI would (correctly) not be created. But later on as the instance-level |should_reuse_web_ui_| defaults to false, RFHM::CommitPending would try to get the |speculative_web_ui_| which would not be set and *could* cause a crash. As of now the crash doesn't happen because CommitPending is not called when the current RFH is kept for the navigation.

BUG=376094

Review URL: https://codereview.chromium.org/1012863004

Cr-Commit-Position: refs/heads/master@{#322485}

This was used as part of an upstream transition and is no longer used.

BUG=428882

Review URL: https://codereview.chromium.org/1026333005

Cr-Commit-Position: refs/heads/master@{#322484}

BUG=chromium:470719
TEST=build successfully
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/1036953002

Cr-Commit-Position: refs/heads/master@{#322483}

BUG=

Review URL: https://codereview.chromium.org/1010803014

Cr-Commit-Position: refs/heads/master@{#322482}

BUG=470660

Review URL: https://codereview.chromium.org/1036853004

Cr-Commit-Position: refs/heads/master@{#322481}

Tweaks to the Data Saver promo currently shown on Chrome
Android to improve the messaging and the call-to-action.
Adds a clickable link to the settings page and makes the
enable button, renamed to "Turn on data saver," directly
enable the proxy.

BUG=455267

Review URL: https://codereview.chromium.org/1011363006

Cr-Commit-Position: refs/heads/master@{#322480}

The return line being outside the synchronized block allowed the cached
state to be reset to null before it was calculated.

BUG=470966

Review URL: https://codereview.chromium.org/1031413005

Cr-Commit-Position: refs/heads/master@{#322479}

$ gn gen out-gn
$ gn check out-gn //components/nacl/renderer/plugin/*

BUG=367595,376000
TEST=see above
R=bradnelson@google.com,brettw@chromium.org
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1034193003

Cr-Commit-Position: refs/heads/master@{#322478}

Expose <webview>.contextMenus.onShow
chrome EventTarget like object so one can "addListener" that can
preventDefault() to cancel bringing up <webview> context menu.

BUG=465733
Test=Open a chrome app with <webview>. E.g.
Load a <webview> in a chrome app, e.g.
the browser sample app:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser

Right click on the <webview>, context menu is expected to be shown.

Now open the app's inspector: from chrome://inspect, switch to "Apps" then select to inspect "Browser sample".

Register a listener to disable context menu:

document.querySelector('webview').contextMenus.onShow.addListener(function(e) {
  e.preventDefault();
});

Right click on the <webview> again, context menu should not show up.

Review URL: https://codereview.chromium.org/1026383003

Cr-Commit-Position: refs/heads/master@{#322477}

This CL added read_mtu into the signature of
BluetoothAudioSink::Observer::BluetoothAudioSinkDataAvailable and
modified corresponding tests.

BUG=441581
TEST=device_unittests --gtest_filter=*AudioSink*

Review URL: https://codereview.chromium.org/1034893002

Cr-Commit-Position: refs/heads/master@{#322476}

BUG=470231

Review URL: https://codereview.chromium.org/1031413004

Cr-Commit-Position: refs/heads/master@{#322475}

This adds histogram values for extension permission messages that
are missing.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1037053003

Cr-Commit-Position: refs/heads/master@{#322474}

The latter is just a backwards-compatibility redirect to the former,
and I'm hoping to get rid of it.

Review URL: https://codereview.chromium.org/1036653004

Cr-Commit-Position: refs/heads/master@{#322473}

BUG=449116

Review URL: https://codereview.chromium.org/1034933002

Cr-Commit-Position: refs/heads/master@{#322472}

Also update from github in the process. Leaves externs currently pending
review as parts of Chrome already rely on them.

R=tbreisacher@chromium.org,hirono@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1034873002

Cr-Commit-Position: refs/heads/master@{#322471}

With this CL, we ignore font files with .fon/.pfm/.pfb extensions while building our custom font collection.
MSDN Ref: http://goo.gl/TfCOA

BUG=439571
R=cpu@chromium.org,scottmg@chromium.org

Review URL: https://codereview.chromium.org/1034813003

Cr-Commit-Position: refs/heads/master@{#322470}

TimedWait(TimeDelta::Max()) should do the same as Wait() (although should not
be used, given that there is a dedicated method to do that).

More generally, TimedWait should accept random, unreasonable large timeouts.

BUG=465948
TESTS=base_unittests

Review URL: https://codereview.chromium.org/999753005

Cr-Commit-Position: refs/heads/master@{#322469}

This was found by looking at the output of gyp_flag_compare step in
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/25653/steps/gyp_flag_compare/logs/stdio

BUG=461019
TEST=gn gen out-gn
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/1032273005

Cr-Commit-Position: refs/heads/master@{#322468}

Remove HpackHuffmanAggregator header, implementation, test, and build rules.
Obsolete Net.SpdyHpackEncoddeCharacterFrequency histogram.  As the HTTP/2
standard is finalized, there is no longer a need to gather character
distribution statistics.

BUG=414758

Review URL: https://codereview.chromium.org/1017853004

Cr-Commit-Position: refs/heads/master@{#322467}

BUG=468902
TEST=trybots
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1032543003

Cr-Commit-Position: refs/heads/master@{#322466}

BUG=470661

Review URL: https://codereview.chromium.org/1033003004

Cr-Commit-Position: refs/heads/master@{#322465}

BUG=463472

Review URL: https://codereview.chromium.org/972203002

Cr-Commit-Position: refs/heads/master@{#322464}

BUG=466848

Review URL: https://codereview.chromium.org/1036723003

Cr-Commit-Position: refs/heads/master@{#322463}

Previously, we collected PPS UMAs across all users. We created a throttler and used it in a 'simulated' mode.

Now that real PPS users exist, collect UMAs only on actual PPS users. This is accomplished by only creating a throttler when PPS is enabled.

BUG=470731

Review URL: https://codereview.chromium.org/1024493004

Cr-Commit-Position: refs/heads/master@{#322462}

MediaController.java is used by the android cast code which upstreamed from the private Chrome for Android repository.
It derives from open source Android source code,
specifically from one of the Android supportv4 samples, and has been
in the downstream repository for some time.

See the README.chromium file for more details.

BUG=315088

Review URL: https://codereview.chromium.org/1008603003

Cr-Commit-Position: refs/heads/master@{#322461}

R=cpu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1033483003

Cr-Commit-Position: refs/heads/master@{#322460}

Mostly a mechanical change, though it involves extending the estimation
abilities of our TimeSource clients to provide estimates for times
outside of the current media time range.

BUG=110814, 439548
TEST=media_unittests still pass.

Review URL: https://codereview.chromium.org/1027553002

Cr-Commit-Position: refs/heads/master@{#322459}

BUG=NONE

Review URL: https://codereview.chromium.org/1018793003

Cr-Commit-Position: refs/heads/master@{#322458}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b880d7f..e0b19d4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1031303003

Cr-Commit-Position: refs/heads/master@{#322457}

[Icons NTP] Use GetVariationParamValue instead of experiment prefix to determine when large icons are enabled.

This is the standard pattern for adding a forcing flags in about://flags.

This also matches a google3 change that just landed which declares that parameter.

BUG=467712

Review URL: https://codereview.chromium.org/1032073003

Cr-Commit-Position: refs/heads/master@{#322456}

A non-broken but recently broken QUIC alternative service does not race for 0RTT
(because it is recently broken) but is still used (because it is not broken).
Upon successful connection, the service should be confirmed (marked as not
recently broken so that it can be used next time for 0RTT).

This CL adds this functionality and a test for it.  I locally verified that the
test fails without the rest of the change.

BUG=392575

Review URL: https://codereview.chromium.org/1035713003

Cr-Commit-Position: refs/heads/master@{#322455}