- 21 Nov, 2018 40 commits
-
-
Stephane Zermatten authored
With this patch, scripts can use a 'prompt' action to ask questions instead of ending the script. The UI of 'prompt' looks just like the UI that appears between scripts, so the choice between a prompt and multiple scripts should be a scripter implementation decision. The prompt action, can: - allow a subset of the page to be touchable, as controlled by the focus action, like what happens between scripts - propose suggestions to be displayed in chips, to simulate script execution - react to element existence, to simulate preconditions Limitation: Prompt does not allow navigation outside of the current page, nor page reloads. Bug: 1340309 Change-Id: I033399621e5afa0d02021cac6cab6765c913970c Reviewed-on: https://chromium-review.googlesource.com/c/1343266 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#610114}
-
Alex Newcomer authored
During long press, we request menu options twice. Avoid making this expensive call twice. Before, we returned early on the callback. Keep that incase race conditions, but also return early before the request if a menu already exists. Bug: 907556 Change-Id: Ie7798e25faea5128651f4a06415d978a5a6cbe35 Reviewed-on: https://chromium-review.googlesource.com/c/1347090Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610113}
-
Nico Weber authored
luci-milo.cfg linter: Lint bot category, and check that each toplevel category on the main waterfall has a subwaterfall. Also tweak a few categories to make main and subwaterfalls match. Bug: none Change-Id: I15ac12e6854be01af39da8869b87102ec17f305a Reviewed-on: https://chromium-review.googlesource.com/c/1346731Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610112}
-
Gayane Petrosyan authored
This reverts commit c03fc8e7. Reason for revert: <INSERT REASONING HERE> Original change's description: > Roll clang 346388-1:346388-4. > > Ran `tools/clang/scripts/upload_revision.py 346388 4`. > > Bug: 870331 > Change-Id: Ie2ebb3aa52bc757f4a0680cdbf8f060a030ce9a6 > Reviewed-on: https://chromium-review.googlesource.com/c/1344209 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610096} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,mmoroz@chromium.org Change-Id: Ica508f221abd3f53dee66eb3f1937773c8947d27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870331 Reviewed-on: https://chromium-review.googlesource.com/c/1347104Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#610111}
-
Mike Reed authored
Bug: skia:2664 Change-Id: Icf69c8361ae1ff939d95ba3ac74d080ea9027525 Reviewed-on: https://chromium-review.googlesource.com/c/1343658Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#610110}
-
Egor Pasko authored
TBR=yusufo@chromium.org NOTRY=true NOTREECHECKS=true Bug: 907548 Change-Id: Iff9b41e03778f21a0a81584b70d55fdfdeb9fdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1346952Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610109}
-
Guido Urdaneta authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Ie49e3d2f9b8afe1abc552172d78dd86088b6ce41 Reviewed-on: https://chromium-review.googlesource.com/c/1310714 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610108}
-
Leszek Swirski authored
This reverts commit 1ed3b3c2. Reason for revert: Re-enabling the trial now that 874080 is being field tested. Original change's description: > [config] Disable scheduled script streaming field trial > > Measure the impact of the current trial by seeing what regressed, and > disable while waiting for Bug:874080 to be resolved, since there are > currently some loading regressions. > > Bug: 715309 > Bug: 885053 > Bug: 886668 > Change-Id: I4497e11373ffa92d3e5f5844fa9fbe73fef6bf4b > Reviewed-on: https://chromium-review.googlesource.com/c/1255946 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596175} TBR=rmcilroy@chromium.org,holte@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 715309, 885053, 886668 Change-Id: I59f9e0d1f5b97a75d7d81e98471cd21a3a68888b Reviewed-on: https://chromium-review.googlesource.com/c/1296502Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#610107}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76499cd866b6..2da0d123402a git log 76499cd866b6..2da0d123402a --date=short --no-merges --format='%ad %ae %s' 2018-11-21 hjd@google.com Merge "perfetto-ui: Use table name in cpu track" Created with: gclient setdep -r src/third_party/perfetto@2da0d123402a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6b2eb0dc703d116d661ebf022b545cedf4e20046 Reviewed-on: https://chromium-review.googlesource.com/c/1346789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610106}
-
Antoine Labour authored
We need to make sure we consistently pick the texture target, because native GMBs may not be available for all usages. Bug: 905569 Change-Id: Ibc325a23494597fefab3e62da71656bae30a42df Reviewed-on: https://chromium-review.googlesource.com/c/1345074Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610105}
-
Tim Volodine authored
Enable the Speech recognition part of the Web Speech API in Android WebView. Speech synthesis API remains disabled for now, see crbug.com/487255. BUG=487255 TEST=https://www.google.com/intl/en/chrome/demos/speech.html Change-Id: Id2c2654c34f63a5ba2ac883614a24b18ab419015 Reviewed-on: https://chromium-review.googlesource.com/c/1340318 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#610104}
-
Anthony Vallee-Dubois authored
This is simply a follow-up on https://chromium-review.googlesource.com/c/1315949 that handles links being opened in a different tab. Bug: 900586,872777 Change-Id: I212e1d787db30da988dddaff0fc9e29978d7222e Reviewed-on: https://chromium-review.googlesource.com/c/1331667Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610103}
-
Moe Ahmadi authored
Bug: 892376 Change-Id: I6f3a802cb11eb18f6470b35d70f683a7b0c9abaa Reviewed-on: https://chromium-review.googlesource.com/c/1335879Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610102}
-
Abhishek Arya authored
R=glider@chromium.org Change-Id: Ia8a300ba5f993862502017d4e164388bd6e0206d Reviewed-on: https://chromium-review.googlesource.com/c/1346466Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610101}
-
Robert Kaplow authored
This changed the datatype checks from GetPreferredDataTypes to GetActiveDataTypes and adds IsSyncFeatureActive() check instead of connection_status. Tested end-to-end verified against the butter experiment. Bug: 906609 Change-Id: I23c0f80cf707a1e8cca5b3f2aa99a3aebc6eec94 Reviewed-on: https://chromium-review.googlesource.com/c/1343369 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610100}
-
Martijn Croonen authored
This updates from revision 6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03) to revision 5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08) Bug: 904963 Change-Id: I7a7caf8e98b35791ccb95e6f0d5ce48647d237cc Reviewed-on: https://chromium-review.googlesource.com/c/1343098Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610099}
-
Kevin McNee authored
cross-process-guests sets the value for the GuestViewCrossProcessFrames feature. The feature itself has been enabled by default since M63 (see issue 655753), however we've been keeping it around for testing purposes. It's no longer useful to have this exposed via about:flags, so we'll remove it there, but keep the feature so we can still test with --disable-features=GuestViewCrossProcessFrames Bug: 533069, 665722 Change-Id: I1dcb84e0facf288059bc1cad555108f543847ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1340916Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610098}
-
Alexei Svitkine authored
- Makes the "retry shortly" logic on first failed request takes precedence over HTTP fallback. This way, when this happens users won't immediately try HTTP if the first request fails (which can be frequent per comment). - Makes it so if there's a restrict parameter, the HTTP fallback is disabled. This should prevent users with a restrict parameter toggling their state (since that can have surprising and undesirable effects such as UI features toggling on and off.) Bug: 902489 Change-Id: I2cd7d24258acb7363287086a63fb94a93de8cd89 Reviewed-on: https://chromium-review.googlesource.com/c/1340823 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610097}
-
Max Moroz authored
Ran `tools/clang/scripts/upload_revision.py 346388 4`. Bug: 870331 Change-Id: Ie2ebb3aa52bc757f4a0680cdbf8f060a030ce9a6 Reviewed-on: https://chromium-review.googlesource.com/c/1344209Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610096}
-
Mikel Astiz authored
ModelTypeWorker::GetContribution() should also be blocked if some updates are pending a decryption key, otherwise a DCHECK is hit: [32730:356:1120/142053.301971:FATAL:model_type_worker.cc(471)] Check failed: entries_pending_decryption_.empty(). Since this codepath was the only remaining user of BlockForEncryption() that didn't verify entries_pending_decryption_ being empty, we change BlockForEncryption() itself to also require that condition. Bug: 873902,873494 Change-Id: Ic9f841380da5f81dd440d39698902a6fe2966be4 Reviewed-on: https://chromium-review.googlesource.com/c/1346392 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610095}
-
Hannes Payer authored
Privacy review doc: https://goo.gl/X5eYHh Change-Id: Ic99b316b1ab2fe665670f0131f8255b9ac4b0395 Reviewed-on: https://chromium-review.googlesource.com/c/1345434Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610094}
-
Friedrich Horschig authored
With this CL, the password_accessory_controller_impl will initialize the needed ManualFillingController lazily. This fixes an infinite recursion when the ManualFillingControllerImpl creates a PasswordAccessoryControllerImpl which then tries to create the first one again. Bug: 907419 Change-Id: I6e19d04c93c3ad41f60e6720eb9eedf12e3831d7 Reviewed-on: https://chromium-review.googlesource.com/c/1346301 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610093}
-
Stephen McGruer authored
This is a follow-up from a comment on https://chromium-review.googlesource.com/c/chromium/src/+/1297172 Bug: None Change-Id: Ic6d68ea85b5735d523d0a398a09b708dbcf3931a Reviewed-on: https://chromium-review.googlesource.com/c/1340961Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610092}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c4d5642e1363..0e4dfcbcf4fd git log c4d5642e1363..0e4dfcbcf4fd --date=short --no-merges --format='%ad %ae %s' 2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 16e6b253..92f8c5b2 (609893:609994) 2018-11-21 qiangchen@chromium.org Set Framerate in RTCVideoEncoderH264 2018-11-21 aleloi@webrtc.org Disabling ScreenDrawerTest.TwoScreenDrawerLocks Created with: gclient setdep -r src/third_party/webrtc@0e4dfcbcf4fd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibb14d96fa379e3c965d435a3c76b79a1197a9262 Reviewed-on: https://chromium-review.googlesource.com/c/1346351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610091}
-
Jason Chase authored
Added crbug.com/906163 to follow up when the expiry date approaches. Bug: 906163 Change-Id: Iae7d335eb0be5617066f8f94940061f8b22bc2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1340571Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#610090}
-
Anand K. Mistry authored
BUG=None Change-Id: I646e0ddc9abd1b82848a32dd998f4364cbd3809a Reviewed-on: https://chromium-review.googlesource.com/c/1343462Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610089}
-
Anders Ruud authored
This reverts commit 44c61e5b. Reason for revert: Broke compile on ios-webview: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929233980627121728/+/steps/compile/0/stdout Original change's description: > Block resources in FormStructureBrowserTest. > > The files used for FormStructureBrowserTest are snapshots of real web > sites. They can have link to online resources but should not need them > for the test to pass. > But if the network is really bad, the page can wait for the resource > loading to finish and timeout. > Preventing the resource loading will make the test faster and more > robust. > > Bug: 896173 > Change-Id: I78f180aca959c50996b1af932cc31c1690795038 > Reviewed-on: https://chromium-review.googlesource.com/c/1343089 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610079} TBR=eugenebut@chromium.org,olivierrobin@chromium.org,mahmadi@chromium.org Change-Id: Ia64b9afb000f40aa17a7b2fb66c0b213666c1fd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896173 Reviewed-on: https://chromium-review.googlesource.com/c/1346832Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610088}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/836674c28b1e..6aab06e0e5d4 git log 836674c28b1e..6aab06e0e5d4 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 geofflang@chromium.org Don't allow unary operators on void types. Created with: gclient setdep -r src/third_party/angle@6aab06e0e5d4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900058 TBR=geofflang@chromium.org Change-Id: I2dab64c3f6dac725795455bcc04ee8fffd1f9750 Reviewed-on: https://chromium-review.googlesource.com/c/1346689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610087}
-
Jan Krcal authored
This CL adds a missing integration test that typed url sync properly stores remote typed URLs and their visits so that they expire along with local typed URLs. Bug: 881285 Change-Id: I17f97c80bb4f281cc0ecd2576c81ef94a5dc0235 Reviewed-on: https://chromium-review.googlesource.com/c/1346459Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610086}
-
Yi Su authored
highlighting search results in a better way. This CL introduces the Replacement class into find_in_page.js to support better DOM operations for highlighting search results. This will fix the bug that whitespaces are reduced when users search for a single whitespace and cancel the search. This CL is also a necessary preliminary work for supporting searching across multiple HTML nodes. Bug: 228585, 895839 Change-Id: I960a012daef93824039ff22b824f70dcc6d1e3b7 Reviewed-on: https://chromium-review.googlesource.com/c/1341918Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610085}
-
Rayan Kanso authored
Add CacheStorageCacheEntryHandler which handles how blobs are written to the disk cache and how they are read back. This CL causes no behavioral changes, it is just a refactor. CacheStorageCacheEntryHandler can now be specialized for Background Fetch caches to store request body blobs instead of side blobs. Bug: 774054 Change-Id: I4bea29ea53ea898e2b3e517fc3b0a74777280d16 Reviewed-on: https://chromium-review.googlesource.com/c/1338188 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#610084}
-
Peter Boström authored
Removes the round-rect end caps in favor of a rectangular throbber. The throbber size and timings are also updated. See chromium:907435. Bug: chromium:907422, chromium:907435 Change-Id: I7d7a18a4d19b18361db84de829a93475a57efa44 Reviewed-on: https://chromium-review.googlesource.com/c/1346091Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610083}
-
Hannes Payer authored
Change-Id: I9689f53e9874bf05a9a5756462e5724f89a53e33 Reviewed-on: https://chromium-review.googlesource.com/c/1345511Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610082}
-
Olya Kalitova authored
First CL to the changes connected with PluginVm managed policies. It contains policies initial definitions & descriptions. There are two new device policies introduced: PluginVmAllowed - allows PluginVm to run on a specific device. PluginVmImage - contains URL and hash of the VM image that should be downloaded later in order to use PluginVm. Bug: 904843 Change-Id: I20c69a2d7ed7a128f0096b5c9e23b0a7424c4f65 Reviewed-on: https://chromium-review.googlesource.com/c/1341539Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#610081}
-
chaopeng authored
The root cause of this issue is we use device pixel to check if the event is non client event but NonClientFrameView is using DIP coordinate. The mouse press event in resizing should be non client event otherwise FindTargetForEvent think some window is capturing the events then route the following events to wrong window until next mouse press. Bug: 881975 Change-Id: I66492c05e14add875775ae9dae32b456ab23f23d Reviewed-on: https://chromium-review.googlesource.com/c/1333992Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610080}
-
Olivier Robin authored
The files used for FormStructureBrowserTest are snapshots of real web sites. They can have link to online resources but should not need them for the test to pass. But if the network is really bad, the page can wait for the resource loading to finish and timeout. Preventing the resource loading will make the test faster and more robust. Bug: 896173 Change-Id: I78f180aca959c50996b1af932cc31c1690795038 Reviewed-on: https://chromium-review.googlesource.com/c/1343089 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610079}
-
Anders Hartvoll Ruud authored
TBR=hbos@chromium.org Bug: 907481 Change-Id: Ia9ba831079b39c374664dd4e9d847c6a69073268 Reviewed-on: https://chromium-review.googlesource.com/c/1346395 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610078}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Bug: 850504 Change-Id: I617a48c931a6acf3bb7ca560d59b1136eea59d44 Reviewed-on: https://chromium-review.googlesource.com/c/1346457Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ace67b95f5c..ae57ced21615 git log 9ace67b95f5c..ae57ced21615 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 dhanyaganesh@chromium.org cidb: Delete unused functions Created with: gclient setdep -r src/third_party/chromite@ae57ced21615 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ice52c26b23ffa653aa5799f4571d5710b44542d7 Reviewed-on: https://chromium-review.googlesource.com/c/1346349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610076}
-
sangseok.jang authored
If drop_down_menu is shown at least twice(e.g repeating right-click), Inkdrop's state is still although hover drop_down_menu is closed. Bug: https://www.crbug.com/907358 Change-Id: Ie6ff9f4cfd09711a9b9af95cc0645e3c24778bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1345694Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610075}
-