- 28 Feb, 2019 40 commits
-
-
Mason Freed authored
Previous to this CL, the default safe_opaque_background_color_ was transparent. And in BGPT mode, we were not setting this setting at all. This lead to checkerboarded tiles being rendered fully-transparent, which means prior content was left visible. With this CL, the safe background color is being set. And additionally, a DCHECK makes sure that the color is actually opaque, to catch other cases where it isn't being set. Also, the OOMTileBorderColor was being used as the checkerboard color, when there was already a checkerboard color defined. It is now being used. Bug: 923202 Change-Id: Ie4f24edb8ccd7c625a4128decb0a5256bbae077c Reviewed-on: https://chromium-review.googlesource.com/c/1474973Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636512}
-
Joe DeBlasio authored
This CL adds translation console screenshots for the new lookalike interstitial. Bug: 927924 Change-Id: Ib570fa6da059368637829b074346da04e94c5efc Reviewed-on: https://chromium-review.googlesource.com/c/1495449 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636511}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7b2da871e95..b2565b18d03e git log b7b2da871e95..b2565b18d03e --date=short --no-merges --format='%ad %ae %s' 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4b314eefc839..5de69e91bd93 (1 commits) 2019-02-28 fmalita@chromium.org solink with --start-group/--end-group 2019-02-28 scroggo@google.com Enable Skia for Windows 2019-02-28 halcanary@google.com SkQP Documentation 2019-02-28 kjlubick@google.com [canvaskit] Support image assets for Skottie Created with: gclient setdep -r src/third_party/skia@b2565b18d03e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/117921091,chromium:b/123085931 TBR=scroggo@chromium.org Change-Id: Id9e7ddb21dfbcd21024a59a5ab85dd8082444f32 Reviewed-on: https://chromium-review.googlesource.com/c/1494827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636510}
-
Majid Valipour authored
Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1418076 Some of the test are flaky with threaded compositing. Enabling the virtual suite but marking these as flaky for now because it is better to have coverage on threaded compositing code path for other tests and any new ones that we migrate to wpt. external/wpt/animation-worklet/animation-worklet-inside-iframe.https.html [ Pass Failure ] external/wpt/animation-worklet/animator-animate.https.html [ Pass Failure ] external/wpt/animation-worklet/animator-with-options.https.html [ Pass Failure ] external/wpt/animation-worklet/playback-rate.https.html [ Pass Failure ] external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html [ Pass Failure ] external/wpt/animation-worklet/worklet-animation-pause-resume.https.html [ Pass Failure ] external/wpt/animation-worklet/worklet-animation-with-fill-mode.https.html [ Pass Failure ] Bug: 915352 Change-Id: I31423fd0d1d55bbeb995be52db546c624a4b3744 Reviewed-on: https://chromium-review.googlesource.com/c/1492436Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636509}
-
Avery Musbach authored
When identifying snapped windows to carry over to split view on entering tablet mode, ignore the app list, non user positionable windows (such as extension popups), windows being dragged, and windows hidden from overview. Test: ash_unittests TabletModeControllerTest.* Bug: 931859 Change-Id: Ib498fb6c5ebad5ac907d05f1e4448e9ba4c254b7 Reviewed-on: https://chromium-review.googlesource.com/c/1471456 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636508}
-
Steven Bennetts authored
This removes SystemClockClient from DBusThreadManager and uses explicit client initialization in Chrome and Ash. The intention is to remove all clients accessed in src/ash from DBusThreadManager and remove that confusing dependency from ash entirely. This CL also: * Moves system clock clients to a subdir in chromeos/dbus. * Adds a TestInterface to SystemClockClient so that tests do not require specific knowledge of the fake implementation. * Modifies ash::ClockModel to handle uninitialized SystemClockClient so that it is not required for every ash unit test using Shell. For minor change to c/b/chromeos/login browser test: TBR=xiyuan@chromium.org Bug: 647367 Change-Id: If6575cf2df9dc9677dcd31032be0c49ae0c286a5 Reviewed-on: https://chromium-review.googlesource.com/c/1492480Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636507}
-
Jacob Dufault authored
This means that all JS calls are deferrable by default. Bug: 930888 Change-Id: Id651e281746a0a99b6285bb82039bb8e5f0cf047 Reviewed-on: https://chromium-review.googlesource.com/c/1487809Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#636506}
-
Xida Chen authored
At this point, we do not purge any entry in the PaintWorkletImageCache, and this CL implements one caching strategy. The idea is: for each new impl frame, if a cache entry is getting accessed/updated, then reset the |num_of_frames_not_accessed| to 1, otherwise increase that by 1. At each new impl frame, we go through the cache, and purge any entry whose |num_of_frames_not_accessed| is larger than a certain threshold, which means that the entry is never used/updated in the last N frames. Unit tests are added. BUG: 907897 Change-Id: I7013325c71e498472e129addd7d171549a852c35 Reviewed-on: https://chromium-review.googlesource.com/c/1479658 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636505}
-
Mike Wittman authored
Changes Module to a class and encapsulates the its state. This is a prerequisite to changing Module to an interface that can be implemented independently for Windows and Mac. Bug: 931418 Change-Id: I5b52234d8f325a08f3b1b8147e60743baed31965 Reviewed-on: https://chromium-review.googlesource.com/c/1478084 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/160b5823ac4f..65cf8a9b9775 git log 160b5823ac4f..65cf8a9b9775 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 fmayer@google.com Merge "Add test that Read / Write work if the other end closes." Created with: gclient setdep -r src/third_party/perfetto@65cf8a9b9775 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3b093cd0c2b67758b95642367277e167f74135a6 Reviewed-on: https://chromium-review.googlesource.com/c/1495369Reviewed-by:
-
Sam Goto authored
Bug: 878979 Change-Id: Ie96867d4f6bc1415d8ffb5f1f43e93d0364043e2 Reviewed-on: https://chromium-review.googlesource.com/c/1492430 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#636502}
-
Kush Sinha authored
Summary of changes: - Consolidate the logic of checking Chrome OS Account Manager's availability into 1 utility function. - Make this utility function return |false| for the availability of Chrome OS Account Manager in Public Sessions. Bug: 926157 Change-Id: Ife2e5fffe95ca8c08c42376e80a5950785d4669f Reviewed-on: https://chromium-review.googlesource.com/c/1486333 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#636501}
-
Austin Eng authored
This adds HandleReturnData to DecoderClient to allow the WebGPUDecoder to send binary blobs of return commands back to the WebGPUImplementation. Its implementation in the InProcessCommandBuffer and the ProxyCommandBufferImpl forward the data to the GpuControlClient interface. The WebGPUImplementation will receive the return command stream via GpuControlClient::GpuControlOnReturnData. Bug: 877147 Change-Id: Ic7983b9d7b6dd15680427162762bc3bc39bd52fd Reviewed-on: https://chromium-review.googlesource.com/c/1481615 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636500}
-
Navid Zolghadr authored
Bug: 907601 Change-Id: I88d5682df5488f2030a1f5ef18118d3b3ba18008 Reviewed-on: https://chromium-review.googlesource.com/c/1486154Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636499}
-
Lan Wei authored
user-activation-delegation API allows to transfer user activation state to any target window in the frame tree through postMessages with "transferUserActivation" set to be true. Bug: 931885 Change-Id: I224f5fb04b2e08f751c33f5cba867562664fbe0b Reviewed-on: https://chromium-review.googlesource.com/c/1477911 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#636498}
-
David Bokan authored
In focusless spatial navigation, when the interested element is removed from the document, but remains alive, the search algorithm begins from it. This results in the algorithm not moving to a new element because it doesn't find a parent container (the document) for the Element. This CL fixes the issue by checking if the interested_node is disconnected when we decide on a starting node for the search. If it is, we use the default document node like we would when there is no interested element. Bug: 929526 Change-Id: Ic5ebe85e563e6c240d301f4fd0c92be8087dd43b Reviewed-on: https://chromium-review.googlesource.com/c/1493397Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636497}
-
Lei Zhang authored
- Add / simplify constructors/destructors. - Add a buffer size DCHECK() to avoid going out of bounds. - Replace new keyword usage with the appropriate "make" function. - Fix bad indentation from r636359. Change-Id: Iab5cb939b36abb4ccebcced2b44aa432c55b4f39 Reviewed-on: https://chromium-review.googlesource.com/c/1495366Reviewed-by:
-
Andrew Grieve authored
This reverts commit 53410c06. Reason for revert: merger script was updated. > Original change's description: > > android: Launch Crashpad with /system/bin/linker on Q > > > > This adds a small executable, libcrashpad_handler_trampoline.so, to > > Monochrome, Trichrome, and SystemWebView. The trampoline loads the > > remaining Crashpad handler code from the main native library, which > > must export `CrashpadHandlerMain()`. > > > > All three packages will continue to use /system/bin/app_process to > > launch Crashpad on P-. > > > > Note on static_initializers.gni: > > > > There aren't any real, new static initializers. The increased count is > > due to the addition of the new object. Static initializers are counted > > by measuring the size of each object's .init_array and dividing by the > > object's pointer size. libcrashpad_handler_trampoline.so has two > > invalid slots which are ignored by the loader: > > > > readelf -x .init_array libcrashpad_handler_trampoline.so > > > > Hex dump of section '.init_array': > > 0x00001008 ffffffff 00000000 TBR=pasko@chromium.org,torne@chromium.org,agrieve@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: Ifdeb10d70977208eb01761b4588d8bfbaecfa20d Bug: 928422, 935973 Reviewed-on: https://chromium-review.googlesource.com/c/1488574Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#636495}
-
Danyao Wang authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6rZ7kBLwmhg/lqEpsHLiDgAJ Bug: 915907 Change-Id: I08825b981d93016b1d8d3647ee76cb4ccea4173a Reviewed-on: https://chromium-review.googlesource.com/c/1492488 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636494}
-
Alec Douglas authored
This commit modifies the MediaControls to show the controls and update the current time indicators (current time text + timeline thumb) immediately during seek requests so the element behavior during rapid seek requests (e.g. user is holding down the FF button on their BT keyboard) look similar to when a user is scrubbing the timeline with their mouse. Bug: 748749 TEST=MediaControlsImplTest, manual testing out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest* Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d Reviewed-on: https://chromium-review.googlesource.com/c/1274945 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636493}
-
chrome://browser-switchNicolas Ouellet-payeur authored
Also fixes an issue where the Chromium string and the Google Chrome string didn't match. Change-Id: I92726d0e4bfbaf4872ea5d0a4389b0225ae7dba9 Reviewed-on: https://chromium-review.googlesource.com/c/1484078 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636492}
-
Jun Mukai authored
This reverts commit 186521f9. Reason for revert: causing multiple issues (crbug.com/936640 and crbug.com/936686) Original change's description: > Emit window bounds when the window is transformed. > > The transform can be applied on overview mode and can affect > the bounds in screen. > > Bug: 931161 > Test: services_unittests > Change-Id: I5ef15745d73f7ffcd74e5844ffeef18b0d544d66 > Reviewed-on: https://chromium-review.googlesource.com/c/1480206 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634009} TBR=mukai@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931161 Change-Id: I091bb8af891b75f3cc1153c026990bbf6b12c7d6 Reviewed-on: https://chromium-review.googlesource.com/c/1495202Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636491}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad9e9432731b..a0a1dcc95853 git log ad9e9432731b..a0a1dcc95853 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 dgarrett@google.com workspace_stages: Use temp git-cache for branched gclient. 2019-02-28 dgarrett@google.com workspace_stages: SyncChrome using branched gclient. Created with: gclient setdep -r src/third_party/chromite@a0a1dcc95853 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I9b26c820fce6cd185ff2d5083ea5477755b54fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1495362Reviewed-by:
-
Jinho Bang authored
The event handler is triggered when the user changes payer information such as payer name, payer email, or payer phone in the user interface. Unlike other PaymentRequestUpdateEvent(e.g. shippingaddresschange), this event can fire only after the website calls retry() with validation errors in the payer contact information. This feature is still behind runtime flag(PaymentRetry). FYI, we've already had a desktop implementation in crrev.com/c/1206750. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI Related spec change: https://github.com/w3c/payment-request/pull/724 Test: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRetryTest.java payment-request/payment-response/onpayerdetailchange-attribute.https.html payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html Bug: 861704 Change-Id: If9d01e4696b0ed8e415a76313c70da4d6ec230f6 Reviewed-on: https://chromium-review.googlesource.com/c/1477610 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chrome would not show the merchant's shipping address validation error message if the merchant also provided some shipping options. This patch shows the error message if the merchant sets it or if the merchant clears the shipping options in an update. After this patch, Chrome shows the merchant's shipping address validation error message even if the merchant provided some shipping options. As before, if the merchant clears shipping options in an update without providing an error message, Chrome displays a default error message. This behavior has not changed. Bug: 934902 Change-Id: Idfeef5963fd1c9e12d7cdfe1ec9afedd51563a8d Reviewed-on: https://chromium-review.googlesource.com/c/1482720 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636488}
-
Xiaocheng Hu authored
https://codereview.chromium.org/2250133004 introduced a regression that editing boundary adjustment may move the result position out of the editing host. This patch fixes it. Bug: 936613 Change-Id: If07d33df991635291672370fe8a89fc3a35520da Reviewed-on: https://chromium-review.googlesource.com/c/1493391Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636487}
-
Joe DeBlasio authored
This CL changes "Did you mean to go to example.com" to "Did you mean example.com". Bug: 927924 Change-Id: I3f75715475315be052a193e9bf7001a7b0b78e77 Reviewed-on: https://chromium-review.googlesource.com/c/1494976 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Ella Ge authored
This reverts commit b37e23cb. Reason for revert: Suspect this causes failure on WebKit Linux Trusty Leak: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/30727 Original change's description: > [Reland] Synthetic input waits on compositor display > > Reland Note: > { > Previously landed: > https://crrev.com/258ed8d55e4f8b4d99fcde72c3569b9450198092 > Reverted: > https://crrev.com/716496fe0909bc918c410a56f6566390b12adedc > > Revert was due to failing Leak Detector bot. Issue was that the > browser still held a reference to the V8 function for the gesture > completion callback which was never resolved. This CL resolves > callback when the BlinkTestRunner is reset. Original CL uploaded in > PS1. > } > > This CL makes synthetic input - the kind used in web tests and > telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame > has been submitted by the renderer and displayed by the display > compositor before resolving the completion callback. This means client > code that wants to wait until any observable side-effects of this input > is visible to further input need only wait on the gesture's completion > callback. > > To give a motivating example: suppose we wish to write a test that > scrolls an out-of-process iframe into view and clicks on a button in the > frame. The code might look something like this: > > gpuBenchmarking.smoothScroll(1000, () => { > gpuBenchmarking.tap(0, 0); > }); > > This code contains a race today. The callback for smoothScroll is > invoked as soon as the ScrollEnd is received in the renderer. However, > until a new compositor frame is submitted from the renderer, the tap > may occur against stale hit testing geometry. This is a major source of > flakiness in our tests. > > This CL fixes the problem by forcing the renderer to perform a full > redraw at the end of each gesture. The redraw produces a compositor > frame and we invoke the callback once the compositor frame is displayed. > We do this by reusing the RequestPresentation mechanism in RenderWidget. > RequestPresentation required two modifications to work in web tests > which use a single thread proxy with no scheduler: > > - LayerTreeHost::Composite needs to check the forced redraw flag to > determine whether we need to raster, otherwise it won't produce a > frame > - RequestPresentation must request a main frame since there's no > scheduler to perform the commit, which is what SetNeedsForcedRedraw > requests. > > The timing change exposed an issue in the > overlay-play-button-tap-to-hide.html test so this CL also cleans that > test up to listen to the animation changes in media controls properly. > > Finally, it's possible we may get input in a RenderWidget that's not > currently displayed. e.g. A click event sent via ChromeDriver causes a > TouchStart followed by a TouchEnd. The TouchStart causes a window.open > which opens and focuses a new tab. The TouchEnd then happens on the > background tab. In this case, we should resolve the callback rather than > waiting on a CompositorFrame that'll never come. See ChromeDriver test > testNetworkConnectionTypeIsAppliedToAllTabs for an example of this. > > > TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org > > Bug: 902446 > Change-Id: Ia2f0a5a6ae51216582bf4cc1d03cb5ba724ddffd > Reviewed-on: https://chromium-review.googlesource.com/c/1490757 > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636440} TBR=peter@chromium.org,bokan@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org Change-Id: I9200ea622887575de2d582f1d6e9030dd425aac9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902446 Reviewed-on: https://chromium-review.googlesource.com/c/1495442Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636485}
-
Sigurdur Asgeirsson authored
Bug: 936828 Change-Id: I9ed609c5ca0bf8d9c7e38d25393af8ebbbbc2060 Reviewed-on: https://chromium-review.googlesource.com/c/1494895 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636484}
-
Tommy Steimel authored
This CL re-adds logic to log MediaLauncherActivity in the WebappCustomTabTimeSpentLogger. This was accidentally removed in a rebase. Bug: 935777 Change-Id: Ifa553184ab3e598cd3c0787eead8845a3b4c0695 Reviewed-on: https://chromium-review.googlesource.com/c/1493441Reviewed-by:
-
Michael Lippautz authored
As a drive-by return a tuple of string and flag for an object's name to easily figure out wheter the object should be considered internal or not. Bug: 936797 Change-Id: Icd6efc709b46b48ac6944d3b814ffa72906b55e0 Reviewed-on: https://chromium-review.googlesource.com/c/1493911 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636482}
-
Koji Ishii authored
This patch copies the logic to check ShouldPaintDescendantOutlines from BlockPainter::PaintBlockFlowContents(). Before this change, PaintPhase::kOutline and kDescendantOutlinesOnly painted all descendants. With this change, they paint LayoutInline descendants only, matching to the legacy behavior. The difference was observed in fast/block/float/float-in-float-painting.html. Bug: 936024 Change-Id: I8f0d985b7ced9f8e1295bdb4e4a0f3763551b2c6 Reviewed-on: https://chromium-review.googlesource.com/c/1495134Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#636481}
-
Becky Zhou authored
Bug: 936275 Change-Id: Icb58cda11379b0bc5f149aafbd84bacbc8a015c2 Reviewed-on: https://chromium-review.googlesource.com/c/1493071Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636480}
-
Roger Tawa authored
Bug: 936587 Change-Id: I9cdf7d8eca4862aeaa6aebb6266b51aa0dfc6777 Reviewed-on: https://chromium-review.googlesource.com/c/1492045Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#636479}
-
Luum Habtemariam authored
ipp_converter::ConvertIppToMojo does not take ownership of the passed in ipp_t*; this change reflects that. Bug: None Test: unitests still pass Change-Id: I19cbdb084175a57ab533cd63099d54acae624c2b Reviewed-on: https://chromium-review.googlesource.com/c/1493206Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#636478}
-
Luum Habtemariam authored
Now correctly failing on unrecognized tag_types. Keeping ipp_t objs wrapped in printing::ScopedIppPtr objs throughout fuzzing. Bug: chromium:936435 Test: Reproducible test case no longer fails. Change-Id: I13fd72834fb971e5fc9fc28541c28b7a293a41d0 Reviewed-on: https://chromium-review.googlesource.com/c/1492572 Auto-Submit: Luum Habtemariam <luum@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This reverts commit e7db3d02. Reason for revert: caused several regressions. Bug:936798,936652,936763 Original change's description: > Re-land: [BGPT] Support kDstIn blend-mode for non-render surface quads > > This reverts commit 0d564c1d. > > It is a re-land of the original patch, with a fix to support the > AA quad rendering path in GLRenderer. > > Bug: 936087 > > Change-Id: I1e7d19051d891a20f902704bebf78ca45145751f > Reviewed-on: https://chromium-review.googlesource.com/c/1489899 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636148} TBR=chrishtr@chromium.org,enne@chromium.org Change-Id: I8d85d23362a7c2f69e03c8b7a031aa436b33b40d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936087 Reviewed-on: https://chromium-review.googlesource.com/c/1495039Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636476}
-
Yi Gu authored
The README is outdated. Changes in this patch: 1. Updating some "Animation" to "KeyframeModel" for correctness 2. Adding newly implemented classes to README Bug: 930130 Change-Id: Ie209090ed375a0547de2dddd376063090b7a37bf Reviewed-on: https://chromium-review.googlesource.com/c/1460861 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636475}
-
Gabriel Charette authored
This reverts commit d8a530f9. Reason for reland: initial CL had a bug when a native nested loop goes idle multiple times in a row. It needs to be able to reuse the existing native timer instead of assuming there isn't one (there won't be one the first time the native loop goes idle but there'll be one one all other idle phases unless we're out of delayed tasks). Original change's description: > Revert "[base] Migrate the Win MessagePump to DoSomeWork" > > This reverts commit 8c5fb8cb. > > Reason for revert: DCHECK(!installed_native_timer_); in dev builds > when moving and resizing windows. Seems interactive_ui_tests might > not cover those cases..? > > Original change's description: > > [base] Migrate the Win MessagePump to DoSomeWork > > > > This CL migrates both MessagePumpForUI and ForIO as they use the same > > base class and it's easier to do both at once. > > > > Tweaks to MessagePumpBase and/or both pumps: > > * Use DoSomeWork() instead of DoWork()/DoDelatedWork() > > * Replace |delayed_work_time_| by a timeout value computed on the stack > > from the result of DoSomeWork(). Conversely making > > ScheduleDelayedWork() a no-op as desired. > > * Refactor GetCurrentDelay() into GetSleepTimeoutMs() and use modern > > safe_conversions.h to perform the math. > > > > MessagePumpForUI specific tweaks: > > * Fixed crbug.com/929263: ::SetTimer() used 0 as an nIDEvent but > > ::KillTimer() used |this| so they weren't even interacting... > > * Fixed bug: even with the previous bug fixed. HandleTimerMessage() > > could be invoked while in a non-native DoRunLoop() (e.g. since > > KillTimer doesn't remove WM_TIMER messages already enqueued) and as > > such result in redundant sources of scheduling since it would then > > continue to RescheduleTimer() and confusing state for DoRunLoop()). > > * Ignore WM_TIMER messages which weren't scheduled by our ::SetTimer(). > > * Simplified usage of native ::SetTimer(). We now *only* rely on it > > when in a native nested loop and kill it immediately after to avoid > > double-scheduling. > > > > Note: MessageLoopTest.PostDelayedTask_SharedTimer_SubPump tests the > > necessity for a native timer when entering a native nested loop and > > confirms that the new behavior is WAI. > > > > Also adding regression tests for a tricky use case (and finding that > > it's already broken on ToT..!). Filed crbug.com/930940 to follow-up. (regression tests relanded separately in crrev.com/631918) > > > > Bug: 885371, 929263, 930940 > > Change-Id: I7f2d18a1a5a494c6a4f31fcc0fad9b4de25d70a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/1455266 > > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Auto-Submit: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#631231} > > TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 885371, 929263, 930940 > Change-Id: Ic179d0493d01d4f44330927d9ccdb0f1454d2e78 > Reviewed-on: https://chromium-review.googlesource.com/c/1471254 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631885} R=fdoray@chromium.org,alexclarke@chromium.org Bug: 885371, 929263, 931871 Change-Id: I10277d92cb780ba17dc5b9a359dc26b381e85ef4 Reviewed-on: https://chromium-review.googlesource.com/c/1471257 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Ioana Pandele authored
Add expectation for flaky external/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html This test seems to be flaky on multiple bots. TBR=foolip@chromium.org Bug: 936827 Change-Id: Id91065f4df77d03721eed2e6f1ca17d2a5f17ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1494875Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
