GitLab

Tried to improve readability. Also re-arranged the for-loop a bit.

This CL is part of splitting up [1].

[1] https://codereview.chromium.org/639433002

R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/652703002

git-svn-id: svn://svn.chromium.org/blink/trunk@183633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unify the pixel snapping logic for selection rects by moving the logic
into selectionRectForText and having selectionRectForSimpleText and
selectionRectForComplexText respectively return precise values.

R=fmalita@chromium.org

Review URL: https://codereview.chromium.org/648633003

git-svn-id: svn://svn.chromium.org/blink/trunk@183632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=410411
TEST=no visible change

Review URL: https://codereview.chromium.org/655613002

git-svn-id: svn://svn.chromium.org/blink/trunk@183631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417463

Review URL: https://codereview.chromium.org/648223003

git-svn-id: svn://svn.chromium.org/blink/trunk@183630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This new event is of type MediaEncryptedEvent, which has initDataType instead of contentType (but this CL just renames one to the other, without translation), and changes the type of initData from Uint8Array to ArrayBuffer as per the WD EME spec.

Also in this CL:
  - Start renaming keyNeeded() to encrypted() by renaming the it on HTMLMediaElementEncryptedMedia.
  - Remove unused contentType argument from createWebkitNeedKeyEvent() (good thing it's unused or the contentType to initDataType change would be a lot harder).
  - Fix prefixed/encrypted-media-events.html test to test the prefixed needkey event instead of the unprefixed one.

TBR=jochen@chromium.org,ddorwin@chromium.org
BUG=224786
(cherry picked from commit ad09c3ed1914691ee4a089cfe95988892ed42407)

Review URL: https://codereview.chromium.org/655603003

git-svn-id: svn://svn.chromium.org/blink/trunk@183628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the API for WebContentDecryptionModule and
WebContentDecryptionModuleSession in order to implement
the latest EME API spec.

BUG=224786
TEST=Adding to API, no code using it. All existing EME tests pass.

Review URL: https://codereview.chromium.org/642583003

git-svn-id: svn://svn.chromium.org/blink/trunk@183627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch switches to "Causes" for explaining timeline records. The
major change is "Stacks" have been renamed "Causes". This is prepwork
for two upcoming projects: invalidation tracking which will fill out many
more causes, and javascript samples which are easily confused with
the "stack" term. If the causes checkbox is not checked, no initiator
or stack information will be shown.

Some minor rewording of the causes has also been done. For example,
the stack for a layout now reads "First layout invalidation" instead of
"Layout invalidated".

A screenshot is available at http://pr.gg/justcause3.png

BUG=410701

Review URL: https://codereview.chromium.org/631573002

git-svn-id: svn://svn.chromium.org/blink/trunk@183626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'parent' argument is not used, remove it.

This implicitly fixes an incorrect invocation of the constructor from
ScrollAnimatorNoneTest::SavePerAxisData, which following r183583 was
passing in an uninitialized pointer value as argument.

R=mkwst
BUG=

Review URL: https://codereview.chromium.org/648273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=183172 .

BUG=81439
TEST=none
TBR=jamesr

Review URL: https://codereview.chromium.org/641643004

git-svn-id: svn://svn.chromium.org/blink/trunk@183624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In pinch viewport mode, the size of the FrameView is always the content
width of the document (not the true viewport size), so this patch plumbs
the viewport size to fullscreen elements separately.  Secondly, in this
mode there is an "inner viewport" that scrolls separately and whose
scrollability additionally needs to be disabled.  Do so by using
setUserScrollable() (which is a mechanism that only works in this mode).

BUG=411072

Review URL: https://codereview.chromium.org/636363003

git-svn-id: svn://svn.chromium.org/blink/trunk@183623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is blink side CL to expose input type radio button with menu as parent with
correct IA2 role similar to aria role menuitemradio.

BUG=422879

Review URL: https://codereview.chromium.org/651893002

git-svn-id: svn://svn.chromium.org/blink/trunk@183622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL encapsulates the simple/complex logic in a low level glyphBuffer builder function, and removes all paint-related codepath-specific methods. Everything above buildGlyphBuffer() now operates on a codepath-agnostic data structure (glyphBuffer).

To pull this off, the CL unifies GlyphBuffer & GlyphBufferWithOffsets by adding offset support to the former. The approach has no downside beyond a slightly increased stack frame size for the simple path, and is aligned with plans to eventually store offsets for simple text also (and possibly drop advances altogether).

Also, most text blob caching logic is relocated down into Font drawText() - which allows us to trivially add support for complex text blobs (currently still off due to the lack of offsets support in buildTextBlob). The advance return value (which doesn't play well with blob caching) is dropped, and the only existing client for it is converted to use a new dedicated, blob-cache-bypassing drawUncachedText() method.

R=jbroman@chromium.org,eae@chromium.org,dominik.rottsches@intel.com,leviw@chromium.org

Review URL: https://codereview.chromium.org/645363003

git-svn-id: svn://svn.chromium.org/blink/trunk@183620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fetch the actual fill from the various paint-server RenderSVGResources
into a new "data blob" SVGPaintServer. This makes said resources
independent of the GC, and means that GC-state can be managed more
directly by the caller.
Since this makes postApplyResource useless, it's removed, and
applyResource is renamed to preparePaintServer.
Some functions residing on RenderSVGResource is moved to SVGPaintServer.
Paint-server fetch+application is moved to updateGraphicsContext, which
is also changed to return a bool indicating if a paint-server is
available. Handling of clip-path-as-mask is also moved here.

BUG=420022

Review URL: https://codereview.chromium.org/638933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All uses appear to have been removed from the codebase.

BUG=417463
TBR=adamk@chromium.org

Review URL: https://codereview.chromium.org/650933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417275

Review URL: https://codereview.chromium.org/602783002

git-svn-id: svn://svn.chromium.org/blink/trunk@183616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/652693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we use 2 marking threads regardless of the number of processors available.
Given that the marking phase takes a substantial amount of time,
this CL changes the number of marking threads to min(the number of processors, 4).

This CL also decreases the block size of each CallStack from 200 to 128
because load balancing is not good in some benchmarks such as LargeDistributionWithoutLayout. This CL improves LargeDistributionWithoutLayout by 10% for example.

BUG=420515

Review URL: https://codereview.chromium.org/648633002

git-svn-id: svn://svn.chromium.org/blink/trunk@183613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The problem arises due to the fact that treeElement value is not updated
at the moment of keyDown/keyPress events. The "input" event should be
handled for the proper text value.

BUG=422928
R=apavlov

Review URL: https://codereview.chromium.org/650123002

git-svn-id: svn://svn.chromium.org/blink/trunk@183612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Catch uncaught promise rejections from V8 and log to console. (patchset #13 id:520001 of https://codereview.chromium.org/625943002/)

Reason for revert:
This is likely the cause of breakage for these browser_tests:
ManageProfileUITest.Create_NameUpdateOnAvatarSelected
ManageProfileUITest.Create_NoNameUpdateOnAvatarSelectedAfterRevert
ManageProfileUITest.Create_NoNameUpdateOnAvatarSelectedAfterEdit


https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/56670

Original issue's description:
> Catch uncaught promise rejections from V8 and log to console.
> 
> Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn.
> 
> BUG=393913
> R=pfeldman, yurys
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183598

TBR=pfeldman@chromium.org,yurys@chromium.org,jl@opera.com,aandrey@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393913

Review URL: https://codereview.chromium.org/650203003

git-svn-id: svn://svn.chromium.org/blink/trunk@183611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Different fonts selected for width calculation and actual painting (patchset #6 id:180001 of https://codereview.chromium.org/593673003/)

Reason for revert:
This broke fast/css/font-face-opentype.html and fast/text/line-break-after-question-mark.html on WinXP

https://sheriff-o-matic.appspot.com/blink/failure/webkit_tests%3A%3Afast%2Fcss%2Ffont-face-opentype.html%3A%3Awebkit_tests%3A%3Afast%2Ftext%2Fline-break-after-question-mark.html

Original issue's description:
> In some cases different fonts are selected to get width of string and
> to draw text.
> In Font.cpp calls, font get changed due to fallback font architecture.
> When making calls we need to check if Unicode is present in primary font or not.
>  In case of Ellipsis, we need to check if Ellipsis Unicode is present in primary font or not,
> if not then use "Dot" Unicode, this is also suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/)
> 
> BUG=416425
> TEST=fast/text/ellipsis-platform-font-change.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183597

TBR=eae@chromium.org,behdad@chromium.org,tkent@chromium.org,h.joshi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=416425

Review URL: https://codereview.chromium.org/648233002

git-svn-id: svn://svn.chromium.org/blink/trunk@183609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tracing state management happens on the browser side. So the local state does nothing.
Also if DevTools window was closed when tracing was active the next DevTools session had
this flag enabled. So it was not possible to correctly process tracing data because they
had no TracingStartedInPage event. The state used to be necessary when we had console.timeline/timelineEnd implementation.

This test case has been covered by timeline-trivial.html

BUG=420008
R= yurys@chromium.org, caseq@chromium.org, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/638673002

git-svn-id: svn://svn.chromium.org/blink/trunk@183608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eae

Review URL: https://codereview.chromium.org/648223002

git-svn-id: svn://svn.chromium.org/blink/trunk@183607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Promptly let go of a memory cache entry's Resource when evicting it,
and do not wait until the next GC to strike. This provides the same
behavior & lifetime for the resource as non-Oilpan.

R=mkwst
BUG=420068

Review URL: https://codereview.chromium.org/649213002

git-svn-id: svn://svn.chromium.org/blink/trunk@183606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183597

BUG=416425
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/654563002

git-svn-id: svn://svn.chromium.org/blink/trunk@183605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch console message contains incorrect line number of code in InjectedScriptSource._evaluateOn function.
With this patch this message contains correct script id, line number and column number.

Review URL: https://codereview.chromium.org/566883002

git-svn-id: svn://svn.chromium.org/blink/trunk@183603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/648193002

git-svn-id: svn://svn.chromium.org/blink/trunk@183602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://crrev.com/6bffde4d87f7a05e5a871cd48366d56b8b83e950 introduces
dispatching of messages on InspectorFrontendAPI post the
IFH.loadCompleted() call only, hence the IFAPI.loadCompleted() call
is no longer required.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/644493003

git-svn-id: svn://svn.chromium.org/blink/trunk@183601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using a LengthPoint for this property makes it possible to use
a converter rather than custom code, and it makes animation
building cleaner too.

The setPerspectiveOrigin[X,Y] are kept because of the corresponding
prefixed properties, but they can be removed eventually.

Review URL: https://codereview.chromium.org/643893002

git-svn-id: svn://svn.chromium.org/blink/trunk@183600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was broken by the async module loading.

R=pfeldman@chromium.org,dgozman

Review URL: https://codereview.chromium.org/648153002

git-svn-id: svn://svn.chromium.org/blink/trunk@183599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn.

BUG=393913
R=pfeldman, yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464

Review URL: https://codereview.chromium.org/625943002

git-svn-id: svn://svn.chromium.org/blink/trunk@183598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

to draw text.
In Font.cpp calls, font get changed due to fallback font architecture.
When making calls we need to check if Unicode is present in primary font or not.
 In case of Ellipsis, we need to check if Ellipsis Unicode is present in primary font or not,
if not then use "Dot" Unicode, this is also suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/)

BUG=416425
TEST=fast/text/ellipsis-platform-font-change.html

Review URL: https://codereview.chromium.org/593673003

git-svn-id: svn://svn.chromium.org/blink/trunk@183597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't need custom behavior for this property.

Review URL: https://codereview.chromium.org/645043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There doesn't appear to be a reason for this property to have
custom behavior. It's better to use a converter and call that
from the generated function.

Review URL: https://codereview.chromium.org/642303002

git-svn-id: svn://svn.chromium.org/blink/trunk@183595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As of f885f9b1178fa278beafd201fb92a93af2117d64, this variable is now
pointless, because the existence of a CachedUAStyle is only possible
when 'hasAppearance' is 'true'.

Review URL: https://codereview.chromium.org/639963005

git-svn-id: svn://svn.chromium.org/blink/trunk@183594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce WebRuntimeFeatures::setCSSViewportEnabled() so that it can be called from content::SetRuntimeFeaturesDefaultsAndUpdateFromArgs()
if the "--enable-viewport" command line option is present.

BUG=420535

Review URL: https://codereview.chromium.org/630903002

git-svn-id: svn://svn.chromium.org/blink/trunk@183593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420008
TBR=yurys@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/654483003

git-svn-id: svn://svn.chromium.org/blink/trunk@183592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removing redundant names introduced for input type checkbox with menu as parent and aria role menuitemcheckbox

In this CL https://codereview.chromium.org/589383004/, a redundant name was introduced
for input type checkbox with menu as parent. Rather the role defined for aria
role menuitemcheckbox can be used for input type checkbox with menu as parent.

Review URL: https://codereview.chromium.org/649073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=422432

Review URL: https://codereview.chromium.org/649563003

git-svn-id: svn://svn.chromium.org/blink/trunk@183589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently -webkit-transform-origin is a shorthand while transform-origin
is not. This patch makes the vendor-prefixed property behave the same as
non-prefixed property. This has minor changes to serialization, which
the test changes document.

In doing so we fix a crash in parsing some invalid values.

BUG=405323

Review URL: https://codereview.chromium.org/649153002

git-svn-id: svn://svn.chromium.org/blink/trunk@183588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183585

BUG=407079
TBR=apavlov@chromium.org

Review URL: https://codereview.chromium.org/650813002

git-svn-id: svn://svn.chromium.org/blink/trunk@183587 bbb929c8-8fbe-4397-9dbb-9b2b20218538