- 16 Oct, 2018 40 commits
-
-
Oystein Eftevaag authored
If we're emitting an _END trace event, we know that the string table entries for the name and the categories have already been emitted and so we don't need to check the string table in this case. R=primiano@chromium.org,skyostil@chromium.org Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f Reviewed-on: https://chromium-review.googlesource.com/c/1258043 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#600183}
-
Will Harris authored
../../ppapi/tests/test_url_loader.cc:877:11: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32] total_bytes_to_be_received); ^~~~~~~~~~~~~~~~~~~~~~~~~~ BUG=879657 Change-Id: I152f456368131fe7a2891ff0c97bf83f26ef0906 Reviewed-on: https://chromium-review.googlesource.com/c/1220173 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600182}
-
Xiaoqian Dai authored
If one of the resized windows is hidden (visibility changes to hidden), the multi-window resizer should also be hidden. Bug: 894853 Change-Id: I77c8c5e831a85a6e66edb35381778d92e97cc856 Reviewed-on: https://chromium-review.googlesource.com/c/1282027 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#600181}
-
Tom Anderson authored
BUG=853841 R=pkasting Change-Id: Ifb680152768ea9214861b63b9f55181c2ad1ed6b Reviewed-on: https://chromium-review.googlesource.com/c/1278144Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600180}
-
Xiaohan Wang authored
I am getting the following gn gen errors when I have the following gn args in a clank repo. This CL fixes those unused gn variables to suppress those errors. Almost all of the changes are suggested by torne@chromium.org. gn args: target_os = "android" target_cpu = "arm64" dcheck_always_on = true is_debug = true is_java_debug = true enable_proguard_obfuscation = false is_component_build = false symbol_level = 1 use_jumbo_build = false build_apk_secondary_abi = false gn error: ERROR at //chrome/android/BUILD.gn:1553:29: Assignment had no effect. native_lib_version_rule = "//build/util:chrome_version_json" ^--------------------------------- You set the variable "native_lib_version_rule" here and it was unused before it went out of scope. See //chrome/android/BUILD.gn:1530:1: whence it was called. android_apk("trichrome_library_apk") { ^------------------------------------- See //BUILD.gn:339:9: which caused the file to be included. "//chrome/android:chrome_junit_tests", ^------------------------------------ Bug: 887078 Change-Id: I6c2a7aaef437fde9e6c52311d086e11b1f86574c Reviewed-on: https://chromium-review.googlesource.com/c/1284091Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#600179}
-
Ella Ge authored
This CL adds a vector predicted_events_ to WebCoalescedInputEvent, to support pointer event getPredictedEvent API. This CL also changes the InputEventPrediction class used for resampling to also generate 3 predicted event even when resampling is disabled. The 3 predicted event will be generated by Kalman filter predictor for now, but in the following CL (add accuracy metrics), we change it to be controll by another flag, so we can gather accuracy data for different prediction algorithms on finch without turning on resampling. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/CgFyxYikn6A Bug: 885299 Change-Id: I89b50ceea2847ea501b04ceb0da58f03741c379d Reviewed-on: https://chromium-review.googlesource.com/c/1232884Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#600178}
-
Hans Wennborg authored
New Clang versions started taking enumerators into account for the -Wshadow warning: ../../ui/compositor/layer_animation_element.h:41:5: warning: declaration shadows a variable in namespace 'ui' [-Wshadow] UNKNOWN = 0, ^ ../../ui/latency/latency_info.h:97:3: note: previous declaration is here UNKNOWN, ^ By making ui::SourceEventType an enum class, we avoid putting the enumerators in such a large namespace as ui. TBR=jochen Bug: 895475 Change-Id: I99347d754cb21dacb5d7c4bae975d3310dcb19fd Reviewed-on: https://chromium-review.googlesource.com/c/1284951 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600177}
-
Giovanni Ortuño Urquidi authored
Bug: 870192 Change-Id: I66cbf722d8e5443e6c606b05a32a8ace3d45f63c Reviewed-on: https://chromium-review.googlesource.com/c/1282765Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#600176}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7eaeb14ee78..f0988af921fb git log f7eaeb14ee78..f0988af921fb --date=short --no-merges --format='%ad %ae %s' 2018-10-16 treehugger-gerrit@google.com Merge "Fix GCC build" Created with: gclient setdep -r src/third_party/perfetto@f0988af921fb The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie3fb3b986f1f58c93052170417eb8f1c88255fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1283954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600175}
-
Artur Khachatryan authored
Disabling following tests on Android. Test ChromeDriverTest.testGenerateTestReport not yet supported for Chrome M69 and M70, so we disable for Android Stable and Beta as they are currently running Chrome M69 and M70 respectively Test ChromeDriverTest.testTakeElementScreenshotInIframe fails due to the known ChromeDriver bug 2579 Change-Id: I3d20483faea56a0f035739506b253215da5e3ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1285075Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600174}
-
Yuchen Liu authored
ClearKey is a software based key system, we should not ask backend to handle decryption with this key system. The patch delays the creation of StreamDecryptor until we know which key system to use. BUG=internal b/117273176 TEST=cast https://simpl.info/eme/clearkey/ Change-Id: I5de56f84c52b42f5440928406a36ae364e61c1fc Reviewed-on: https://chromium-review.googlesource.com/c/1284950Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600173}
-
Daniel Bratell authored
In some jumbo build experiments (not official) there was an identical constant in two explore_sites files. In jumbo builds many cc files are merged into one translation unit for much faster compilation. This moves the constant to a header where it can be reused. Change-Id: Id460645a39d69999bf2227c25651d1149f1a6d6c Reviewed-on: https://chromium-review.googlesource.com/c/1275895 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600172}
-
Lei Zhang authored
base: :LazyInstance is deprecated. Change-Id: I25a4ee2fbc47ca4d5ce775738316e129b3538327 Reviewed-on: https://chromium-review.googlesource.com/c/1284531Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#600171}
-
James Cook authored
ShelfAppBrowserTest.LaunchAppFromDisplayWithoutFocus0 and ShelfAppBrowserTest.LaunchAppFromDisplayWithoutFocus1 cannot assume a browser window's root window is the display's root window. Check display IDs instead. Bug: 855767 Change-Id: I5a5486b82502bf8d4d0d9f9ff19231a4a3d93b61 Reviewed-on: https://chromium-review.googlesource.com/c/1285081Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600170}
-
Ethan Kuefner authored
No longer needed. Change-Id: I48e7073aba7861d7265337996c3ce6146d972f50 Reviewed-on: https://chromium-review.googlesource.com/c/1282220 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#600169}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74b702466046..1e488131ffcd git log 74b702466046..1e488131ffcd --date=short --no-merges --format='%ad %ae %s' 2018-10-16 tandrii@chromium.org Revert "git cl: delete no longer used Rietveld methods." Created with: gclient setdep -r src/third_party/depot_tools@1e488131ffcd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: Ib3aabc30311a4f0e4dc70da08f5d7029be183e89 Reviewed-on: https://chromium-review.googlesource.com/c/1284758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600168}
-
Xing Liu authored
Currently removing an ongoing download may hit assertion in StorageSummaryProvider, this is due to a bug in onItemUpdated that we increase the total storage based on old item instead of the new item. Bug: 892328 Change-Id: I64cda81662290df049f74aa3f1893c7a0984c043 Reviewed-on: https://chromium-review.googlesource.com/c/1284705Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600167}
-
Becky Zhou authored
+ Add test on Feed NTP to simulate click on a test card Bug: 860055 Change-Id: Ibf8f4b1ab46ed34dc77346dd19680df876c2d6aa Reviewed-on: https://chromium-review.googlesource.com/c/1260485 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600166}
-
danakj authored
Previously the WebWidgets would each ask RenderWidget to initialize the compositor at different points in its initialization. WebPagePopup would do so after the widget was initialized, where as local root frames would do so before it was initialized (but importantly, after for_oopif_ was set - so really in the middle of initialization). WebView would do so before any initialization of RenderWidget. This made for 3 different ordering interactions of compositor initialization and RenderWidget initialization. Notably, compositor initialization goes through RenderWidget, and depends on that class. So using it before it's initialized is.. troublesome. This removes the WebWidgetClient::InitializeLayerTreeView() method, and has RenderWidget always initialize a compositor (since we always composite them now, thanks Always Forced Compositing Mode!). That allows RenderWidget to control the order of its initialization internally, so it is not used before it is initialized (or, at least not in this case.. there may be more to untangle). We add WebWidget::SetLayerTreeView() instead, which goes out to the WebWidget when the RenderWidget is being initialized, since the WebWidget is initialized first and passed to RenderWidget. This helps detangle the SimCompositor and FrameTestHelpers a bit, we no longer need 2 LayerTreeViews in SimTest - one in SimCompositor and one in TestWebViewClient. Instead we use the singular one in TestWebViewClient, and pass through the SimCompositor as the LayerTreeViewDelegate to it, so that it can implement callbacks from the compositor. Now the FrameTestHelpers must set the LayerTreeView on the various WebWidgets that it creates, either WebViewImpl or WebFrameWidgetImpls. R=ajwong@chromium.org, dcheng@chromium.org, jochen@chromium.org, piman@chromium.org Bug: 889759 Change-Id: I0e1b3ebf4132874d1151a6a770a02a1a40b650b1 Reviewed-on: https://chromium-review.googlesource.com/c/1271793Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600165}
-
Lei Zhang authored
Change-Id: Id53aa30f876c5be1f770f22cfca375bbb74fea2b Reviewed-on: https://chromium-review.googlesource.com/c/1284209Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#600164}
-
gogerald authored
Bug: 806868 Change-Id: I4e3f2340929a68423bbc3c8153c9576d243cc032 Reviewed-on: https://chromium-review.googlesource.com/c/1284649 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600163}
-
Dominick Ng authored
The intent helper is versioned differently to Chrome. Explicitly check its version separately if the incoming WebAPK launch intent specifies the intent helper as its default browser. Fail out and launch as a tab always if the provided default browser isn't supported. BUG=893927 Change-Id: I2eb551042003eb6ca59062b86992428282ecad91 Reviewed-on: https://chromium-review.googlesource.com/c/1282143Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#600162}
-
Tom Anderson authored
After [1], dynamic refresh is the default MD mode on ChromeOS so the UI switches between touchable and non-touchable UI depending on the tablet mode state. Since the frame caption buttons are hidden when in tablet mode, there's no longer a need to change the tablet mode spacing depending on the tablet mode state: we just always use 0 spacing. This fixes an issue where a browser window gets created when in touchable UI mode (but the frame caption buttons are not shown) and then when the UI changes to non-touchable mode, the spacing between buttons is not updated to 0, but the buttons are shown. [1] https://chromium.googlesource.com/chromium/src/+/63bf489f5d0038b1208c2439a1140910d263e9dc BUG=881371 Change-Id: Ifa76428abe266aaddc2ba9c946a213060a630713 Reviewed-on: https://chromium-review.googlesource.com/c/1283942Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600161}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py / headless/lib/browser/devtools_api/client_api_generator.py. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I1d053de59f0e6c07cfe42b29a3e09aaab91ac330 Reviewed-on: https://chromium-review.googlesource.com/c/1281166Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600160}
-
John Z Wu authored
Risk data is needed during credit card verification in order to communicate with payments API, and it can only be obtained by a 1st party app. Bug: 895694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I79ee7cddf9618ee32e4050f0b3b4b61447e7ea1f Reviewed-on: https://chromium-review.googlesource.com/c/1282388 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#600159}
-
Khushal authored
Add an UMA metric which reports the accumulated time for a raster task including the time from raster worker thread and the GPU main thread. The GPU side timer takes care of only measuring time slices when the decoder is processing commands. TBR=holte@chromium.org, piman@chromium.org, sunnyps@chromium.org BUG: 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ed515daba4b5bdc701a20e5ff33dc770d170b2b Reviewed-on: https://chromium-review.googlesource.com/c/1283487 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#600158}
-
Xiaohui Chen authored
Bug: b/117793448 Test: histogram unit tests and manual test on device Change-Id: I3233920570752391a295da90de1f9b48d1f02924 Reviewed-on: https://chromium-review.googlesource.com/c/1285049Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#600157}
-
Chris Harrelson authored
Before this patch, ComputeVisualOverflow() was virtual, and so was AddVisualOverflowFromChildren(), which was called by ComputeVisualOverflow(). This pattern existed to share a bit more code with LayoutBlock other than the code to collect rects from children. This CL instead inlines the duplicated code in a few places and de-virtualizes AddVisualOverflowFromChildren. Bug: 894244 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic9e36c0271ac6d88ee660e9113e1a2b7db8e0148 Reviewed-on: https://chromium-review.googlesource.com/c/1281234Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600156}
-
Jia authored
Major changes in this cl are - We now use curves represented by MonotoneCubicSpline. - Other changes to trainer and modeller impl to pave the way for the next cl that will introduce an actual model for brightness. Bug: 881215 Change-Id: Ic180d7e764772b41f8f2a11a6eaaf3f0e4e72e28 Reviewed-on: https://chromium-review.googlesource.com/c/1278458 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600155}
-
Stephen Lanham authored
This #define has been error-prone in the past and now no longer matches the Widevine convention after which it was modeled. Convert to use the much-safer BUILDFLAG() macro. Update use_playready to enable_playready to match the Chromium GN conventions. BUG= Test: Cast CQ Change-Id: I5ac8a238051a6208d2960ee7ce957099b396e45a Reviewed-on: https://chromium-review.googlesource.com/c/1284065Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600154}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4edb5e25..b141a319 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: I7c0d0daa74c4813731c5ebcf8d73bd89f5b2cf52 Reviewed-on: https://chromium-review.googlesource.com/c/1283259Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600153}
-
Johannes Henkel authored
To be consistent with the other creation methods. See also: https://chromium-review.googlesource.com/c/chromium/src/+/1281166/4/headless/lib/browser/protocol/protocol_string.h Bug: chromium:891377 Change-Id: I4cf9a3ccd1dc91b428aa10e28ddbb49c56195622 Reviewed-on: https://chromium-review.googlesource.com/c/1284910Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600152}
-
Kevin Strohbehn authored
Bug: 883032 Change-Id: Ib65bc5fb61f0526d9ccc688769f1f68284f3bfeb Reviewed-on: https://chromium-review.googlesource.com/c/1269860 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600151}
-
Min Qin authored
Since feature list are not loaded before native library, this CL introduces a helper class to write the feature values to SharedPreferences, and loads them when needed. It allows download and other features to launch finch trials to start ServiceManager on startup. BUG=842245 Change-Id: I8dcc8a97ae16152e1bf33bbe7f7d7349cdffa0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1271587Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600150}
-
Alexander Alekseev authored
This Cl prepares for bug 596743 and has fixes to clear for https://chromium-review.googlesource.com/c/chromium/src/+/1269235 landing. Bug: 892757 Change-Id: I9858ec633158310c805430f1f070b5cff730f94f Reviewed-on: https://chromium-review.googlesource.com/c/1282462 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#600149}
-
Brandon Wylie authored
Bug: 888712 Change-Id: I6f89d30906700b7b5f4fe283a749a09c5a6e59ce Reviewed-on: https://chromium-review.googlesource.com/c/1250061 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600148}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88afab4ff0f0..b273e0cd217d git log 88afab4ff0f0..b273e0cd217d --date=short --no-merges --format='%ad %ae %s' 2018-10-16 lwsong@google.com Add aggregate graphs to visualization tool. 2018-10-16 perezju@chromium.org [telemetry] Fix typo in WebSocketException 2018-10-16 perezju@chromium.org [soundwave] Remove old comment Created with: gclient setdep -r src/third_party/catapult@b273e0cd217d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876681 TBR=sullivan@chromium.org Change-Id: I5fdc43203e194660ce62571123e9f8003626dfc1 Reviewed-on: https://chromium-review.googlesource.com/c/1284569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600147}
-
rbpotter authored
crbug.com/804047 has been fixed, and the DCHECK referenced in the Print Preview JS no longer occurs. Remove the async(..., 1) workaround. Bug: None Change-Id: I0a8f38a697965e912265092d33ef7a2d0e58f85f Reviewed-on: https://chromium-review.googlesource.com/c/1281912Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600146}
-
Nate Fischer authored
No change to default behavior, because this logic is behind a flag. This blocks billing threats in WebView, and adds some tests for this functionality. This involves: * Add necessary resources to WebView's whitelist * Test Loud and Quiet interstitials * Test we use the correct threat type integer in onSafeBrowsingHit * Test that the Feature is disabled on trunk * Add hardcoded WebUI URL for billing interstitial (also for Chrome) R=changwan@chromium.org, vakh@chromium.org Feature enabled via commandline flag. This is necessary to stay consistent with Chrome. Bug: 887186 Test: run_webview_instrumentation_test_apk --gtest_filter=SafeBrowsingTest#*Billing* Test: Manual - load chrome://safe-browsing/match?type=billing with Binary-Size: Increase is due to added WebView strings for the new interstitials. Change-Id: I695c39ffdd79ef5e771027953bfffc327fc6864b Reviewed-on: https://chromium-review.googlesource.com/c/1270476Reviewed-by:Carlos IL <carlosil@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600145}
-
Vlad Tsyrklevich authored
Bug: 894423 Change-Id: I10e809b1b745f2c9d0fdcbf6bd1f958d1aec0103 Reviewed-on: https://chromium-review.googlesource.com/c/1283934Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600144}
-