GitLab

Bug: 1089501
Change-Id: I5eb857fe8acb8008b05c3f52db066b832c2dbddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254700Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780510}

This adds additional EG test coverage for Safe Browsing, for
scenarios identified by the test team when they were
manually testing this feature.

Change-Id: Id27ff75a0e92ba7501aeb250ab0112d8eb9a278b
Bug: 1093510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246995
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780509}

Bug: 1092936
Change-Id: If11473a8fb9893b528cf1a6a19c23ecfe96da815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253018Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780508}

Display problems are reported with Huawei and Honor devices with Mali
GPU. The GPU driver version of them are < 19.0.0. The same problem can
not be reproduced with other devices with Mali GPU with driver 19.0.0.
So disable vulkan finch for Mali driver < 19.0.0.

Bug: 1096222
Change-Id: Ib15fc865c4a173fc4413c4a4bbb3521bb4cc07cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251177
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780507}

Adds the kExpanded / kCollapsed accessibility header node data to
section headers.

Also fires off the kExpandedChanged event when this changes.

Bug: 1078183, 1052522
Change-Id: Ie037ebede9003ebf486ec3e3ba0124e3b1b0057b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247139
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780506}

Bug: 1097260
Change-Id: I28a9eed52f254364c8782f6b6fe95f1e637cbbcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255559
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780505}

In the newly introduced VideoDecoder, we create a native buffer for
video decoding on demand in the PlatformVideoFramePool. This buffer
eventually makes it to the MailboxVideoFrameConverter in order to
produce a SharedImage for the client.

This CL ensures that the NativePixmap created in the
PlatformVideoFramePool can be re-used in the MailboxVideoFrameConverter.
Before this CL, we would call CreateNativePixmapFromHandle()
unnecessarily when creating the SharedImage for a buffer. That's because
we didn't propagate the GpuMemoryBufferId correctly from the
PlatformVideoFramePool to the MailboxVideoFrameConverter and the check
in [1] would fail. As a result, we would end up creating an additional
DRM framebuffer which is unnecessary because the allocation in the
PlatformVideoFramePool would have already created one. Thus, the
video.MemCheck.h264_hw test would fail because of having created too
many objects.

To propagate the GpuMemoryBufferId correctly, we create a
GpuMemoryBuffer VideoFrame in the PlatformVideoFramePool (instead of a
dma-buf VideoFrame). That way, when MailboxVideoFrameConverter calls
CreateGpuMemoryBufferHandle(), it gets a GpuMemoryBufferHandle with the
same ID that PlatformVideoFramePool gets. Additionally, we make
MailboxVideoFrameConverter use kPlatformVideoFramePoolClientId since
that identifies the namespace of the GpuMemoryBufferIds in question.

Note that for SCANOUT_VDA_WRITE buffers (which we use for video
decoding), we end up creating a ClientNativePixmapOpaque when creating a
GpuMemoryBufferImplNativePixmap. This is problematic because a
ClientNativePixmapOpaque doesn't let us query the stride and we need to
know it in order to create a GpuMemoryBuffer VideoFrame. Therefore,
GpuMemoryBufferImplNativePixmap::stride() is changed so that it's not
necessary to have a gfx::ClientNativePixmap to query the stride.
Instead, we query the underlying NativePixmapHandle directly.

For that same reason, we must introduce a workaround in the
VideoFrameValidator: when we get a GMB VideoFrame, we cannot map it
directly because ClientNativePixmapOpaque doesn't allow us to.
Therefore, we extract the dma-buf FDs and use the regular dma-buf
mapping path.

[1] https://cs.chromium.org/chromium/src/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc?l=152&rcl=d96e9f16ae852ec9dbd15bf17df3d440402413bb

Bug: 1091450, 1093644
Test: video.MemCheck.h264_hw_switch, video.DecodeAccelVD.h264 on eve
Change-Id: I3d60efa362b66bd2f01139296d4ed756c8777ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233534
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780504}

In this CL, we add histogram:
"Startup.Android.FeedContentFirstLoadedTime.Instant(.NoInstant)".
It records the time duration from a cold start till the Feeds articles
are first loaded on the StartSurface. The histograms are recorded as
deferred tasks after startup only if StartSurface is shown when Chrome
is launched from a cold start.

A new interface method ContentChangedListener#onAddFinished() is added.
It notifies FeedSurfaceMediator when the Feeds content is added to the
RecyclerView.

Bug: 1092931
Change-Id: Ice5fb669505f87e17af30daeecc6a2567205d504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240131
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780503}

If enabled, forward crashes to the system's crash handler, rather than
processing them internally via Breakpad/Crashpad.

This introduces a new GN argument, use_system_crash_handler, which
enables forwarding to the system crash handler.  By default it instead
uses the builtin crash handling from Breakpad/Crashpad.

Only supports the external_mojo processes.

Also enable crash forwarding by default for the crash_uploader, since it
doesn't include internal crash handling.

Merge-With: eureka-internal/413496

Bug: internal b/156659049
Bug: internal b/157693574
Test: build
Change-Id: Iced0d8ce02f7367ac8c9f2ef46d232f2d4b27732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222971Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Joshua LeVasseur <jlevasseur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780502}

This allows screenshots to be shared by looping back to the share sheet.
A new JNI call to make a Uri from an arbitrary bitmap is also included.

Bug: 1093372
Change-Id: I444634f5a19ac5a9b3b30c961127de7fe5cda72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243496
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780501}

This delay may lead to a crash if WebContents in destroyed in between.

Bug: 1097111
Change-Id: If77cc3ffc7866cf8ff0c0a8043549595724583fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253981Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780500}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/50e7bb530903..e74db562ce8c

2020-06-19 brcui@microsoft.com Update Settings telemetry panel keys to fix Locations tab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1096745
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib260ab9a5936a5ca5da9d107f876a8446a1c5c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255167Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780499}

Before completing the VideoCaptureDeviceMFWin::Init() function we
should wait on MF_CAPTURE_ENGINE_INITIALIZED.  The Capture Source is
not fully constructed until the MF_CAPTURE_ENGINE_INITIALIZED event
fires and calling methods before this time can cause unstable behavior.

Bug: 1076730
Change-Id: I239077a4d9a599643b9e2c4ed0e26219a2dbb58f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238879Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Christian Larson <chrila@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#780498}

Optimization: If clipping is on, clip the overlay quad first. Then the
occluding damage rect will intersect with the clipped overlay quad.

Bug:1096097

Change-Id: I741cbd45f5ed11118185a69b03753fe6108563ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249597Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780497}

https://chromium.googlesource.com/openscreen.git/+log/64150e03b378..f8393bee83f1

2020-06-19 jrw@google.com Made certificate_proto fuzzable.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Ieb60628a3d1071e1c11696d6eec15f984560b2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255164Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780496}

The main change in this CL is using the same cursor fallback selection
machinery for both Aura/X11 and Ozone/X11. In addition to that:

Cursor loading now uses cursor names, instead of a mix of cursor names
and shapes (as introduced in [0]), given that all shapes can be loaded
by Xcursor using their corresponding name.

The CSS name is preferred over other options, relying on
cursor themes usually linking known cursor names to cursors defined in
the theme, or alternatively, picking alternative cursors as defined in a
fallback table.

It fixes the w-resize fallback changing it to left_side and replaces
v-scroll and h-scroll (introduced in [1]) with all-scroll, as they are
only available on Windows.

[0]: https://crrev.com/c/1998353
[1]: https://crrev.com/c/1638924

Bug: 1029142
Change-Id: If50698d5305135be43cda4eeb48532d23816754f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245704
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780495}

Change-Id: Ib9f3c32779cc410b010c6f3940fa75f2b16bb65f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252696Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780494}

Bug: 819294
Change-Id: Ibf5b13cdccaa371b7f5972bf511aeb20ed1bf9c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252000
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780493}

R=robertma@chromium.org
CC=chanli@chromium.org,iannucci@chromium.org,nodir@chromium.org

Bug: 1084459
Change-Id: I5927eae3308757027aab956dcc5086e7dc596983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253140
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780492}

Change-Id: Ib74ee08c23c077c729923397cae17c72811d83f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255022
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780491}

When reading procfs files we shouldn't use the base file operations as
they are annotated as MAY_BLOCK. This CL introduces an equivalent to
base::ReadFileToString which doesn't have any blocking annotations.

Bug: 1090623
Change-Id: I159f239caf1fe0613de9fdb92cd5fca687cb955b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229153
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780490}

baseaudiocontext-audioworklet.https.html is flaky due to dependency on
FuchsiaMediaResourceProvider, which is currently not implemented in
content_shell

TBR=chonggu@google.com

Bug: 1061226, 1096611
Change-Id: I79d642bc0353117dde81cfa566881ac2075c5156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255518Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780489}

Bug: 1097346
Change-Id: I09239e7647e182e1094ffed28aecd12c89f31fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255218
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780488}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1909f444..a9ea1674

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1b2ccd305c8f23771f56f18205b369db1e41c708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254881Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780487}

Algorithm helpers that distribute widths to columns.

Bug: 958381
Change-Id: I2a876e81c8caa6ef4743f3c4ae5fd4f45f6fec15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242129Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780486}

(Test-only change.)

The following change[1] updates |GetAssertionTask| to only assert the
matching credential after a silent probe batch. However, some of the
golden-data tests then fail because they were returning a different
credential ID, and that mismatch isn't caught until higher up in the
stack.

Fixing that causes other test failures and so on. This change is the
transitive closure of updating all the mismatched test data.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2250893

Change-Id: Ida7a92f7e8b2bbaa74352caf6963c6ce0c00e246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252640
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#780485}

Change-Id: Ife0bbd6baa9deedac77a777ddc672d723dd276c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255121Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780484}

Priority will be needed to identify which queue a sequencing id
belongs to.

Also - minor cleanup of unused using statements.

Bug: chromium:1078512
Change-Id: Ic851eb5dfc0aba8460218241cf30ff7a86380c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252948
Auto-Submit: Zach Trudo <zatrudo@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#780483}

https://quiche.googlesource.com/quiche.git/+log/46d05bc682ff..37b2e1806f4a

$ git log 46d05bc68..37b2e1806 --date=short --no-merges --format='%ad %ae %s'
2020-06-18 renjietang Fix incorrect determination of stream type in QUIC T050.
2020-06-18 fayang In quic, bundle server initial crypto data with initial ack. protected by gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack.
2020-06-18 fayang In quic, include undecryptable packets information in error details when client closes connection with quic_handshake_timeout for debugging purpose. client only, not protected.
2020-06-18 dschinazi Properly ignore HTTP Infomational 1XX status codes in QUIC
2020-06-18 renjietang Turn on end_to_end tests on TLS 0-RTT reject.
2020-06-18 renjietang In QUIC client with TLS versions, delay retransmission of 0-RTT packets until 1-RTT keys are available.
2020-06-18 fayang In quic with tls, remove the head of line blocking caused by an unprocessable packet. protected by gfe2_reloadable_flag_quic_fix_undecryptable_packets.
2020-06-17 nharper Support 0-RTT TLS in QuicSpdySession

Created with:
  roll-dep src/net/third_party/quiche/src

R=dschinazi@chromium.org

Change-Id: I2018fb64314c84bdb297bbe5551e8c3fee3796fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254467Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780482}

The original CL that added it was:
https://codereview.chromium.org/1413363003

which has to do with the ways in which the pre-BGPT system explained
scrolling and fixed-position elements to the compositor. Since then
BGPT shipped, which no longer requires communicating this via the
graphics layer tree.

Bug: 1096732,950418

Change-Id: I9d6fe98298d69244ad4ca298e934d5c5765cf2da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253282Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780481}

Fix the inline biometric enrollment dialog button not getting focus by
default.

Fixed: 1097311
Change-Id: I58cf4492287b68cc7ce5bb3f6980e65d3caebd80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255101
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#780480}

ui::ThroughputTracker should not be reused. It DCHECKs when data
tracking overlaps and drop reports when it happens. This CL
changes to create a new ui::ThroughputTracker instance when the
hover card bubble animation starts.

This also fixes one crash that a browser window on external display
gets moved to internal display when disconnecting external
displays, where the Compositor becomes invalid.

Bug: 1060816, 1096840
Change-Id: I63b50279492fe2e464ed45efd7139e4cb8a43148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254698Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780479}

Add metrics for recording:
1. the state of the default brwoser when promo is displayed
2. the result of the promo
3. the reason of dismissing the dialog

Bug: 1090103
Change-Id: I38c04bb12272a3128afcb6f0762c8ee16ea4b121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248453
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780478}

Use a scoped trace event for the duration of RunServiceManager ends
up covering the main RunLoop::Run() and adding an event over idle
phases of the main thread (undesired) : https://snipboard.io/S2puE6.jpg

Changed to emit an instant event that highlights when
RunServiceManager starts without tracking it through the entire
browser lifetime.

R=oksamyt@chromium.org, rockot@google.com

Bug: Event over idle phases in startup traces.
Change-Id: I0bb36e9446a052059973af3445727128113eb168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254097
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780477}

Also changes some text in this test as well.

Bug: 1097225
Change-Id: I3dc128dee8d5f35d30509af38291183297ffc535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254824
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780476}

During hotseat drag, if the gesture keeps moving up after the hotseat
has been fully extended, the hotseat will stop moving. Do not record the
presentation time metric, as there may not be any changes for compositor
to handle. In that  case, all pending presentation durations would be
recorded when the gesture ends, with inflated presentation time values.

BUG=1093068

Change-Id: I449e9af5658b8d2de706cbdf843e0ddd96e940ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252947Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780475}

Bug: 1095654
Change-Id: I55cd6e7c1871fc681480927b9fb90a8466d4791b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255099
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780474}

This change moves some header inclusions around to properly respect
our philosophy of IWYU.

Bug: chromium:888189
Test: simple-chrome with board=coral
Change-Id: If48d9ea596578adf2c26ade54e0c28478b4c37ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248452Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780473}

Image doodles have a background color they are designed for (white for
light mode doodles). If the NTP's background doesn't match this color
the image doodle is shown in a box of its design background color.

We sent the doodle design background color via mojo in preparation of
dark mode doodles that will have a different color.

Bug: 688960
Change-Id: I70bb8be129228a8e35cdbfd16fee9a3b2f2d79ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253210
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780472}

Fixed a reversed condition caused safe API permissions trigger
full warning on the login screen of the managed-guest session.


Bug: 1096838
Change-Id: I535d823c26de93a6934e82e61c2b12b27fc73680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253758Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#780471}