- 04 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e36d03001695..d85686f7c379 git log e36d03001695..d85686f7c379 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 brianosman@google.com Update comment on isNumericalTransferFn to clarify that fn is always set 2019-11-04 michaelludwig@google.com Skip unnecessary moveTo in degenerate quad calculations 2019-11-04 borenet@google.com Reland "[recipes] Assert that Git is obtained from CIPD" 2019-11-04 penghuang@chromium.org Make GrVkResource::Trace thread safe. 2019-11-04 borenet@google.com [infra] Make SkottieWASM and LottieWeb use git from CIPD Created with: gclient setdep -r src/third_party/skia@d85686f7c379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:960620,chromium:None Change-Id: Ia0d686c7ce933ec430883d3e0b4f78a24a310c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712258}
-
Joshua Pawlicki authored
TBR=tommycli@chromium.org Bug: 1021219 Change-Id: Id4f4666dd124017c707cdb10e7e401b8b1fefce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896514Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712257}
-
Dan Beam authored
Fixed: 1019589 Change-Id: I11fad6d0088df2040a895457b62358aaa7ca53c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892096 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#712256}
-
Dale Curtis authored
BUG=1019669 TBR=lazyboy Change-Id: Id2e2811db659e1151efc1bc198d5507b9d6454cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898333Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712255}
-
Yulun Wu authored
This will enable shelf dimming in guest mode. Bug: 996006 Change-Id: I148cd97538c02a07d61994e05c4e25ad4ae62b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894626Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712254}
-
Jasper Chapman-Black authored
This is the last minor feature needed to bring Caspian to parity with the JS-backed Tiger Viewer. One more major feature to go, diff mode. Bug: 1011921 Change-Id: Iefbc340f372fa8debad77460a5d3cefda5f54129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894178 Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712253}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=mcasas@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: If0528b001a87cb4f3f43b3b5dfe6bff987eab67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893538 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#712252}
-
dpapad authored
- Move GenericHandler from content/ to chrome/ - Rename to NavigationHandler - Stop registering it blindly for all WebUI pages within WebContentsImpl. - Register it explicitly in HistoryUI, the only currently known usage of it. - Change util.js so that a call to listenForPrivilegedLinkClicks() is required to trigger that functionality. Previously listeners were added as soon as util.js was evaluated. Note there are probably a few more places that use NavigationHandler to be registered. The goal of this CL is to narrow down who needs this functionality and explicitly add it there. So some temporary regressions are expected. Bug: 1020360 Change-Id: I2e2f5a0fe06cb8268a38380f29547afa94e7450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894911 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712251}
-
Nate Fischer authored
No change to logic. Use the EXPECT_* macros over the ASSERT_* macros. This is helpful when there are multiple failed assertions in one unittest, because both failed assertions can be seen. At the moment, this is only visible when running in verbose mode (-v). But this is still marginally better for the devs who are aware of this option, with no downside for everyone else. Fixed: 1020778 Test: Manually modify test so 2 consecutive expectations will fail, then Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* -v Test: Observe both failed expectations are in the log Change-Id: I6d0267340fafb9c514c7d1b013c10c954316e645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898171Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712250}
-
Bruce Dawson authored
While writing crrev.com/c/1881988 it was pointed out that CreateForCurrentThread was simpler than SetClipboardForCurrentThread, when applicable. This switches three uses to the simpler form. Updating ClipboardRecentContentGenericTest required changing the return type of CreateForCurrentThread from a base class to derived class pointer. Change-Id: Ie45fee94ea8c7581047f03b2b637bb87cf2dbbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891333 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712249}
-
Henrique Ferreiro authored
//third_party/blink/renderer/modules/gamepad is the only user of blink::WebGamepadListener. Move its definition there as blink::GamepadListener. Also remove blink::WebPlatformEventListener, which was only used by blink::WebGamepadListener as an empty parent class. Bug: 919392 Change-Id: If7831dccc0ff405264320c2bd08c586a872f0422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886891Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Balazs Kelemen <b.kelemen@samsung.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#712248}
-
Avery Musbach authored
If a window is destroyed while being dragged from the top, then the drop target shall be removed. If a snap preview is showing, then you will encounter this separate issue: https://crbug.com/1020343 OverviewSessionTest.DropTargetRemovedIfWindowDraggedFromTopIsDestroyed/? Test: ash_unittests Bug: 1021127 Change-Id: I8b7ad1ea34fafc36fc5edeee791c7003a3779297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898326Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#712247}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/7789823ec9..167e7ad444 TBR=mjackson@microsoft.com Change-Id: I597f53e747dacb9695523a51dfec8d4aeeace580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898067Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712246}
-
Regan Hsu authored
* Add ripple effect to the 'center' and 'center cropped' buttons. * Remove border when either button is selected. * Center the centering buttons correctly. sceenshots & video of ripple: https://drive.google.com/drive/folders/1mwxne0ZwSRH1OUDaS2c7thJ7iQ8ExkHm?usp=sharing Bug: 916671 Change-Id: I5c67ffd2718973a56af80426604dc7e3e9f8c01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892294Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712245}
-
Natalie Chouinard authored
The Usage and Crash report settings screen was replaced with a switch. Cleaning up no longer used files and resources. Bug: 868826 Change-Id: Id833a49fba6503d356978bacf6b246e11ae6bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896123Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712244}
-
Ian Kilpatrick authored
We only hit this section of code when LayoutNGBlockFragmentation is enabled. Currently the NGBoxFragmentPainter doesn't support painting column rules correctly. This will have to be added before LayoutNGBlockFragmentation is enabled. Bug: 988015 Change-Id: I40f2f873814f861e370428972fb52b12f3e4907b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869445Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712243}
-
Dana Fried authored
Change-Id: I40a49793b9db01ae8b6497c38b09ab420cd56a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895754 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#712242}
-
Elly Fong-Jones authored
This document describes how the Mac team does bug triage, primarily for our own reference but maybe also as a useful resource for other teams. Bug: None Change-Id: I21e04ef300337b25531a288643eead0bfa647412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841773Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712241}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df482aad3e7e..486508d8c322 git log df482aad3e7e..486508d8c322 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 cjmcdonald@chromium.org cros_extract_deps: Fix syntax to unpack additional return value Created with: gclient setdep -r src/third_party/chromite@486508d8c322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6d303dbf49f4b7084a55daa869140ee53a7b5305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896512Reviewed-by:
-
Eric Stevenson authored
This will cause compile errors for proguard_enabled builds if generated proxy native classes aren't fully inlined and removed. An example where this would happen is caching the result of WrapperClassNameJni.get() in a member variable. Example errors: Item void org.chromium.base.MemoryPressureListenerJni.<init>() was not discarded. Some JNI wrapper classes were not fully optimized. org.chromium.base.MemoryPressureListenerJni should not appear in a release .dex file. Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. ... Item void org.chromium.base.library_loader.LibraryPrefetcherJni.<init>() was not discarded. Some JNI wrapper classes were not fully optimized. org.chromium.base.library_loader.LibraryPrefetcherJni should not appear in a release .dex file. Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. ... Bug: 993421 Change-Id: I488640859a939d41eed2e44bb01904062942257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894151 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
Dana Fried authored
This affects behavior behind a flag so it's not a regression, but absolutely needs fixed while I figure out what to do with the rest of the code here. Change-Id: Iecaad932aa1d8dab44a5cf3f59077100f52a67eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896303 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
-
Joel Hockey authored
Often times out in debug Bug: 1020318 Change-Id: Iab3efaddbfc0f4418c6b948948c8f460f73d5c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895267 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#712237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5dba5c7ba486..0460f06e10cf git log 5dba5c7ba486..0460f06e10cf --date=short --no-merges --format='%ad %ae %s' 2019-11-04 zakerinasab@google.com Merge "Docs: Add running UI and docs server to running.md" 2019-11-04 lalitm@google.com trace_processor: add RowMap iterator and use in Table iterator Created with: gclient setdep -r src/third_party/perfetto@0460f06e10cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I1ed2d3543f132c77b210b5d9b2a9d83ccc8c47f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897854Reviewed-by:
-
Greg Thompson authored
Also ensure that the temp dir can be deleted in TearDown. BUG=546640 R=sky@chromium.org Change-Id: I8e939324616a3e278c0508f639d0caaec2042f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894007 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2cba7759c45..23c213f71633 Created with: gclient setdep -r src-internal@23c213f71633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None Change-Id: Ia1bba79e8ea4669f969f531fb20fd9c5c803814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896510Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712234}
-
Matt Menke authored
This reverts commit f6ec475d. Reason for revert: We're seeing these failures on the tree again. Original change's description: > Revert "Remove SpawnedTestServer timeouts." > > This reverts commit 8e4bd238. > > Reason for revert: want to verify that workarounds to https://crbug.com/869227 inside vpython itself are actually useful > plus to read more logs. > > The original can re-landed any time if new occurrences of https://crbug.com/869227 manifest themselves. > > Original change's description: > > Remove SpawnedTestServer timeouts. > > > > These timeouts are ancient. The test infrastructure has its own > > timeouts, which should make these obsolete. Also, this may help with > > https://crbug.com/869227, where starting the Python test server > > times out. > > > > Bug: 869227 > > Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: David Benjamin <davidben@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#707894} > > TBR=davidben@chromium.org,mmenke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 869227 > Change-Id: Ic11c2e9a78568738a7712a1141876840f8a63740 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893789 > Auto-Submit: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711706} TBR=davidben@chromium.org,iannucci@chromium.org,tandrii@google.com,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869227 Change-Id: I31794b424e1d3aec994fea74f63645f85cb1b80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897976Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712233}
-
Joshua Pawlicki authored
This reverts commit 83ced150. Reason for revert: Causes timeouts for SpanTest.OutOfBoundsDeath in Windows debug builds. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=SpanTest.OutOfBoundsDeath Original change's description: > [base] Introduce base::CheckedContiguousRange > > This change introduces base::CheckedContiguousRange, which similarly to > base::span is a light-weight wrapper around a contiguous container > performing bound CHECKs. > > However, in contrast to base::span this class keeps a pointer to the > underlying container, and thus is able to respond to changes to data() > and size(), which base::span can't do. > > Furthermore, this change provides a constexpr overload of base::data() > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > Bug: 990059 > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712120} TBR=palmer@chromium.org,dcheng@chromium.org,jdoerrie@chromium.org Change-Id: I813ab3ab80d75cb96189584b504488e3ab5a6c43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894162Reviewed-by:
-
Dale Curtis authored
Flakes on all platforms now, so should be marked everywhere. BUG=1010472,1019079 TBR=waffles Change-Id: Ibea535220eb3093e3a99f985a1077af5eb0cb258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898202Reviewed-by:
-
Peter Wen authored
Specifically for the file apk_merger.py Bug: None Change-Id: I0e889d95d7749dbce3d812fc971e2b690ab20789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896506 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712230}
-
chrome://flagsmanuk authored
Bug: 950512 Change-Id: Ia670e8f931e886e4298ba07f9cd7f8cdd328e8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897484Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#712229}
-
Xianzhu Wang authored
This reverts commit 9f934997. The original patch broke deferred main frame update during page navigation because the new WebViewImpl::SetRootLayer() missed DeferMainFrameUpdate which was in the removed WebViewImpl::SetRootGraphicsLayer(). Fix that by adding back the logic. Original change's description: > Revert "Don't create GraphicsLayers for VisualViewport" > > This reverts commit 8657999c. > > Reason for revert: Caused crash crbug.com/1020181. > > Original change's description: > > Don't create GraphicsLayers for VisualViewport > > > > Now VisualViewport creates cc::Layers instead of GraphicsLayers, and > > creates foreign layers directly during painting instead of by collecting > > GraphicsLayers. This makes VisualViewport use the same code for CAP and > > pre-CAP. > > > > PaintLayerScrollableArea still uses GraphicsLayers which are created by > > PaintLayerCompositor/CompositedLayerMapping. > > > > GraphicsLayers created by PaintLayerCompositor/CompositedLayerMapping > > no longer need to attach to VisualViewport which no longer creates > > GraphicsLayers. > > > > Bug: 1012594 > > Change-Id: I5ce76a3b5728d3810d85d536357cb437eea5fc4f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869126 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710881} > > TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1012594, 1020181 > Change-Id: I3e0f5fa0b3698d8af7cd9f6d6f81e34f40c8b30d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894110 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711503} Bug: 1012594, 1020181 Change-Id: Ib1440e0c0ac5d5490697d85027fb30e24e51f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895081Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712228}
-
Hector Carmona authored
Also update users of FocusRowBehavior to set the index in order to take advantage of the new attributes. Bug: 1020305 Change-Id: Ife51f853060b5d8e67984f34f7333ec9f7c0345a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894324 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This will pass on the Trusted Type enforcement requirement set by the CSP header, but will not actually instantiate a TrustedTypePolicyFactory. That plugs the current hole; but might not be an acceptable long-term solution. Bug: 951536 Change-Id: I56d541d57184396ce1dacdac9236d9259189f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886826 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Dale Curtis authored
Pass/Timeout was already excluded, but Crash was left off. BUG=1014812 TBR=waffles Change-Id: Ib2da88c9dedbb46f5a00893d9b37a7e721619d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897856Reviewed-by:
-
Toni Barzic authored
Original attempt CL:1888652 got reverted because a new usage popped up. HomeLauncherGestureHandler currently has three observers: 1. AppListControllerImpl, which is also a HomeScreenDelegate implementation (on which HomeScreenGestureHandler already depends, so additional observer interface just obscures/complicates this dependency) 2. HomeLauncherStateWaiter which is used by interactive UI/perf tests to wait for launcher animations to complete 3. BackdropController which pauses backdrop updates while home launcher drag is in progress (this landed in parallel with first attempt of landing this) For case 1., moving the observer methods to HomeScreenDelegate interface will work fine. For case 2., the test waiter can register a callback with AppListControllerImpl to be run when the home launcher animations are complete - the same way it's done by LauncherStateWaiter, an equivalent test waiter used in clamshell mode (or for waiting for non-visibility app list state transitions) For case 3. the dependency is switched - instead of BackdropController observering HomeLauncherGestureHandler for drag events, HomeLauncherGestureHandler requests pause in backdrop updates while home launcher state transitions are in progress. Given that HomeLauncherGestureHandler already depends in BackdropController (to animate backdrop window), this removes newly added circular dependency. BUG=1005366 Change-Id: I73e249eaf41d8ccf1e349dfa6ba023eccb97159a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894464Reviewed-by:Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712224}
-
Yue Li authored
Extend the expiry milestone of assistant app support feature flag which is still in use. Bug: None Test: Locally build and test Change-Id: I18e8e08579e80343f2beecaecfaec7394fc1b5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895741Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#712223}
-
Vladimir Levin authored
This removes a TODO I was planning on doing, but I think it's fine to keep the override right in the getter, to ensure that we get correct behavior anytime we use the getter. R=chrishtr@chromium.org Bug: 10163281 Change-Id: Ie55b2d69bad47e20b7c2c9123a131e6c738f6e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897853Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712222}
-
Antonio Gomes authored
Blink uses its own WTF::ThreadSafeRefCounted instead. BUG=787254 R=guidou@chromium.org Change-Id: I468ec63f649381e0d2bc3e9b76472992d87605ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887370 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712221}
-
Ben Kelly authored
These tests were previously switched to exercise the case when the features were disabled since the fieldtrial_testing_config.json was setup to enable the feature. It turns out, however, that fieldtrial_testing_config.json does not affect web platform tests. Therefore re-enable the feature in these virtual test suites. Bug: 960012,1010624 Change-Id: I661ccaa0a76b9380f98d69abc8df4c01c28fe9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898168Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#712220}
-
Dale Curtis authored
PushMessagingBrowserTest.PushEventEnforcesUserVisibleNotification is flaking and OWNERS are not responding on bug. Disable. BUG=458160 TBR=peter Change-Id: I9f44abaee56ac06126c1ca88067832965bda8460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898087Reviewed-by:
-
