GitLab

When a receiving a new interval from a syncbase it
is meant to take precedence, we now clear the old
interval so it gets updated with the new time. This
solves some sorting bugs related to syncbases.

A new test has been added "onhover_syncbases.html" which
tests repeted "mouseover" and "mouseout" events.

Bug: 740541
Change-Id: I7a8e3691593a537c4dbc1da3bdbbe09eaf30e500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718704Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#682841}

Currently, we only support thread instruction delta values on
PHASE_COMPLETE events. Since we'll soon replace complete events
(at least on TrackEvent proto level) with begin/end event pairs, this
patch adds support for emitting absolute thread instruction count
values on begin/end events.

Also ensures that we write sensible timestamps for all metadata events
in TraceLog.

Bug: 925589
Change-Id: Ie01339aefb3d148457f51057e0722c4506dda82f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729262
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682840}

VizCompositorThread should have a TYPE_DEFAULT message loop on all
platforms except for Fuchsia where it needs to be TYPE_IO. Plumbing in
GpuPreferences::message_pump_type does the right thing for Fuchsia but
potentially the wrong thing elsewhere. Add platform specific #ifdef to
properly handle this case and remove plumbing.

Bug: 958387
Change-Id: Idfa0e1b21a37642d297f2601c9a9f52ca8770fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728313
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682839}

The existing code assumed that if the defer commits restarted due
to the time being beyond the timeout, it must mean that commits were
deliberately deferred. But if the frame in question does not ever
defer main frame updates, it never explicitly starts or stops deferring
commits, so the timeout trivially kicks in on the first frame
update.

Manually tested, seeing most first commits are because deferral was
not allowed at all. This is more in line with expectations, but also
makes the metric less useful for determining who has the feature
enabled.

Change-Id: Id44cc74a1afdd78e3ba7ef96d8ca133a7c948af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716330Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682838}

android_dlopen_ext() and dl_iterate_phdr() don't need to be accessed via
dlsym(). Access the symbols directly instead.

Bug: 979638
Change-Id: I4b6b4d097cd1e107f7a1d0e7f5e540d4cc472552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729072
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682837}

This CL makes the data saver checks more resilient.

Moving the checks to the very beginning at the navigation start also
prevents recording of some of the Previews histograms for
non-DRP users.

Change-Id: I26c96d654180a2202eef5f0899c89c37bf4c6da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716121Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682836}

Disables the SendTabToSelf feature in
WebXrVrTransitionTest#testNonImmersiveStopsDuringImmersive, as it's
suspected that the feature is the cause of recent flakiness.

TBR=bialpio@chromium.org

Bug: 986580
Change-Id: Ic1b22a9ba48d5c96729c4e57439c590dcdd1ca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729537Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682835}

This reverts commit cca6943d.

Reason for revert: This appears to have made CacheStorageManagerTest.TestErrorInitializingCache flaky - see https://crbug.com/989313

Original change's description:
> CacheStorage: Allow reads to be executed in parallel.
> 
> This CL adds the CacheStorageParallelOps feature with the associated
> "max_shared_ops" parameter.  Enabling the feature and setting the
> parameter to greater than one will allow read-only cache_storage
> operations to run in parallel.  By default parallel operation is
> disabled.
> 
> The overall design is to treat each CacheStorageScheduler as if it
> has its own read-write-lock.  When an operation is scheduled it must
> be flagged as either "shared" or "exclusive".  Some number of shared
> operations (determined by the feature param) may run in parallel.
> Exclusive operations always run by themselves without parallelism.
> 
> This CL also includes the ServiceWorkerCache.PeakParallelSharedOps
> histogram which will measure how much parallelism we actually see in
> practice.  The peak is measured across a small time period defined by
> when an idle scheduler begins running its first shared op to until it
> stops running all shared ops.
> 
> Bug: 985379
> Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680986}

TBR=dmurph@chromium.org,jwd@chromium.org,jam@chromium.org,rayankans@chromium.org,wanderview@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 985379, 989313
Change-Id: Iad71c64d0446d3e9bc09392ffa0ce38914d6c85f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728071Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682834}

Expansion includes parsing OWNERS files, creating DOM Elements for the
owners found in the files, and replacing the files' respective DOM
Elements with newly-created owners elements.

Bug: 924136
Change-Id: Ice1bffeddf490a28bb3983858a75c1844a23c712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715407
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682833}

Remove bugs with a comment by
"425761728072-pa1bs18esuhp2cp2qfa1u9vb6p1v6kfu@developer.gserviceaccount.com"
from the filter for finding unlabelled network bugs. These are bugs
reported by FindIt and other related tools. They generally already have
a label attached, and there tend to be rather a lot of them.

Going through 200 bugs titled "x% regression in whatever" isn't terribly
productive, and skipping over them makes it easier to miss user-reported
bugs.

Bug: None
Change-Id: I680691ca987746e219a4edb307d418d7fa0bfede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728176Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682832}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Iba4526020982e0b8355c9b75637d1f78d4a94638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700903
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682831}

As per the linked bug, non-null anchor views will become mandatory in
LocationBarBubbleDelegateView. This change modifies IntentPickerBubbleView to
always pass a non-null anchor view. In fact, it already always passed a non-null
anchor view in actual use, since it is only ever invoked in one place
conditional on the anchor view being non-null. As a consequence, this change
deletes the null anchor view path in IntentPickerBubbleView, which removes some
bespoke layout constants (yay!)

This change also refactors IntentPickerBubbleView a bit: IntentPickerBubbleView
itself is built on all Views platforms, but its tests were only built on
ChromeOS. This change therefore makes the tests build on all platforms alongside
the code. As of right now, I think this code is only invoked on ChromeOS, but in
a runtime way that makes it difficult to be sure.

This change also makes private a couple of test-only methods on
IntentPickerBubbleView that used to be public.

Bug: 989080
Change-Id: Id1a9d28ffb5c11e164547ce5c5aac5b26c0ef6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726431
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682830}

This change drops additional checks that rejected the tail suggestions, if the
offered suggestion also came with additional corrections (spelling, spaces etc).

Bug: 973036
Change-Id: I7186593d698fc22cc94992fe1c8df7827adcb7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719267
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682829}

This change replaces the clearReadError() method with implicit behavior
in the getters for the readable and writable attributes. This should be
much more convenient for developers without any change in functionality.

Bug: 893334
Change-Id: I76cab6656a2ad117fcc3d1fda5eaebd052e4d2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722011Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682828}

Right now chrome crashes when user clicks to open dialog right after
the tab model is changed. This is because that we are trying to open up
the current group while it no longer has reference in the new tab model.
This CL fixes this issue.

Bug: 987221
Change-Id: Ia2e3384780f2d56a816ef8def00e02beb50e6493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726614
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682827}

This test was failing under SkiaRenderer, but the failures have not been addressed.
Re-enabling the test, which runs in Chrome-GPU FYI bots.

TBR=ynovikov@chromium.org
Test=ContextLost_WebGL2Blocked

Bug: 984110
Change-Id: I686ac2a6c8fc9dc50976fe5efc94059a10884b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721025Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682826}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 968047
Change-Id: I5202fae8fa6ac5c7567ca9a46cb42a0716eda2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729249
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682825}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 968047
Change-Id: I3be206ebb5e570854acdc961182286e670de7d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728668
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682824}

This patch adds a basic adapter for RecyclerView that follows chrome's
MVC pattern. The API it exposes is intended to be as similar as
possible to the existing ModelListAdapter.

Bug: 909779
Change-Id: Ibda434edadf365c185433614f4a0d1da9e4b9862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650522
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682823}

This fixes a few bugs where new RP code was being run for the old
version of the menu.

Bug: 989426, 989405, 989403
Change-Id: I1b890064b2209eb9a91331b6a84433706193646a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728316Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682822}

controller Impl

Also moved the controller interface to c/b/u/autofill/payments/

This is a small refactoring being part of my loading bar animation CL.
Extract it to a separate CL to unblock other CLs touching save card icon

Bug: 964127
Change-Id: Id3a08746efa0bd84d37cc128338074e714fcaa69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722149Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682821}

We still hasn't launched and I can't delete the metrics before seeing
everything being ok. So let's extend them further.

Bug: 988759
Change-Id: Ia24639ebc5636fb55a6acc8b290b3cc3bd6db21b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728651
Auto-Submit: vitaliii <vitaliii@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682820}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80dc3d15d3e3..5588ed40788d


Created with:
  gclient setdep -r src-internal@5588ed40788d

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I1040ca7013b7a0329c5afff82337161f89c737a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729536Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682819}

This change makes palette switcher keyboard and sreen-reader accessible.
The palette-swicher arrow icon is assigned a role button and is set aria-label "Preview palettes".
Now, when user presses Enter or Space it opens up list of preview-palettes which is identical with click handler.

Each preview-palette like Material, Custom CSS Variables, Page colors are assigned a role button because clicking
anywhere in the preview-palette row or a particular swatch in the palette just opens up the palette.
So, in this change palette is keyboard navigable through tabbing.

Screen-reader accessibility:
When user tabs through each of preview-palette or palette-switcher, it reads name and a role button.

Gif showing preview palette changes https://imgur.com/tFknmcF
Note: Gif updated to show keypresses

Bug: 963183

Change-Id: I560b94d76e7e9a17755cc6cdac1e39643cc7811e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688277
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682818}

Bug: 989314
Change-Id: Idbef0fd0d7fcfb3058b45b8738da41a467b15aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728317Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682817}

Bug: 936114
Change-Id: I3c98fea06875c33dc78a8ab3c82008840d241cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721840
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682816}

Also make PreconnectManager::StartPreconnectUrl()'s NetworkIsolationKey
mandatory, as all callers are now passing one in.

Bug: 966896
Change-Id: Id10c410225c5d8248569443381856a3c12d452aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721513
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682815}

Because synchronization has to be disabled for this portion of the test, add a
half second delay to allow the new iOS13 confirmation dialog to be fully
visible.

Bug: 989615
Change-Id: Ia5322dfc5c67ae4609922b6d883434fc2843a27f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727652Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682814}

This adds methods to net::cookie_util to check whether "SameSite by
default cookies" and "Cookies without SameSite must be Secure" are
enabled. This replaces direct checks of the FeatureList and allows
future changes to the criteria for enabling those features.

Bug: 954551, 953306
Change-Id: If2b7f92b464797b77bf01c80f5eb5511a45ef641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726796Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682813}

We move the platform specific logic to be injected on construction of
LargeIconServiceImpl in the factories.

Change-Id: Ied1bc8d640d38d2a5ceca6dd91358f910decd6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715690
Commit-Queue: Kristi Park <kristipark@chromium.org>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682812}

There are some unexpected results for
WebAudio.AudioContextOptions.sampleRate[1] so let's extend the
expiration date another 6 mo.

[1] Most common value for windows is 22500 Hz, which is a very strange
sample rate. (A typo of 22050?)

Bug: 988810
Change-Id: I410e1e485dea81612f927ec490b04956d36d8825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726396Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682811}

With system priority, the screenshot notification never auto dismisses and
remains forever.

BUG=987928

Change-Id: Ib83a156444970233b6d95654749dbd1cc9c4013e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726764Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682810}

* Add xml files regarding the animated drawable for the IPH.
* Introduce a TabGridIphItemView as the entrance for IPH.
* Add logic in TabListRecyclerView to add a footer to accommodate the
  IPH entrance. This is a workaround before
  https://crrev.com/c/1650522.

Bug: 987043
Change-Id: Ibed6f42c291ebef37277431b910b6ff9aca3da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716138
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682809}

This code was introduced in crrev.com/c/917610 and made use of the (then-new)
Trusted Types API. It turns out, that code doesn't actually work if you enable
TT (because it passes a plain string to a "trusted" API). Instead, we should
just call a lower-level built-in that doesn't do the Trusted Type check.

Change-Id: Ic60700240293908e9cec1a398e1fce3775bb1e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729591Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682808}

ContextProviderImplTest.CleansUpContextJobs is only ran on Fuchsia, hence
there is no need to add the condition.

Bug: 989085
Change-Id: Iee8fe325681b3a38374ab52a1ff29f794a2569f6
TBR: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729471Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682807}

The new text is more consistent with the tooltips on other toggle buttons in the
tray bubble.

Screenshot:
https://screenshot.googleplex.com/6jNM1r6V8rf.png

BUG=986238

Change-Id: Iecbcb6fbee569ab170f82119e879fe9c79c19f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727513Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682806}

These UMAs are no longer needed

BUG=969975, 969976

Change-Id: I905c32c3d86f727886224577d541a1da3f2f0e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706802
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682805}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=zea@chromium.org

Bug: 968047
Change-Id: I605a98e8a1cb3e54f5ef90bee4692278cee9dba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729152
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682804}

Change-Id: I1ad39a83c27a6535cd18c846f6bee8d40f45ab52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705634
Commit-Queue: Xiang Ji <jxiang@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682803}

BUG=None

Change-Id: Idee0f736ea2e37ccdaee3440b778f23d045c4d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729056Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682802}