GitLab

When no break opportunities can fit in a line that has floats and/or
exclusions, such line box should be pushed down to avoid them.

A simple example is "float: left; width: 100%". This patch supports both
100% case and other cases in slightly different code paths since
NGLayoutOpportunityIterator handles 100% case differently.

Rewind() has been used for next lines, but this is the first case where
NGLineBreaker rewinds and process the current line again. Initializing
states is moved to NextLine() from BreakLine() to make this possible.

This patch also includes fix to avoid processing the same floats twice.
This should have been an issue when Rewind() is used, but it was not
handled properly before. The fix isn't very clean though, this should be
revisited.

Moved from a Reitveld CL[1].

[1] https://codereview.chromium.org/2955843002

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ideae5ae00374c500f858bb992d5d3203772829a2
Reviewed-on: https://chromium-review.googlesource.com/582249
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492019}

Refactor FetchDoneCallback and DismissedSuggestionsCallback
to move-only type callbacks, which have a clear lifetime.

Bug: 752051
Change-Id: I0def6b9e9414095f5e7c6dd85f900df36f2f233d
Reviewed-on: https://chromium-review.googlesource.com/602033
Commit-Queue: Andre Gaschler <gaschler@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492018}

Bug: 747136
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5184a67c4848c067d46fd7b559f38b89109cdcfa
Reviewed-on: https://chromium-review.googlesource.com/601507Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492017}

TBR=qyearsley@chromium.org

Bug: 626703
Change-Id: I4313b889c98e9fc98165273dd701cde3c8003c81
Reviewed-on: https://chromium-review.googlesource.com/602233Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492016}

This CL gets rid of the dependency on setAutoAdvance(false), which
might have disabled the reading of data.

If reading of data is paused during the time mAutoAdvance = false,
when we set mAutoAdvance to true, startNextRead() won't be called
automatically. If we don't startNextRead(), Callback#onSucceeded()
will not be called.

Bug: 751700
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I47fa37fb5d71c4ec0fcda5d6fd2ff762c08505d5
Reviewed-on: https://chromium-review.googlesource.com/598992Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492015}

On assignment 'x.a = y' during incremental marking the Dijkstra barrier
suggests checking the color of 'x' and only mark 'y' if 'x' is marked.

Since checking 'x' is expensive in the current setting, as it requires
either a backpointer or expensive lookup logic due to large objects and
multiple inheritance, just assume that 'x' is black. We assume here that
since an object 'x' is referenced for a write, it will generally also be
alive in the current GC cycle.

As a side-effect this CL also
- Remove the need for explicit construction of TraceWrapperMember.
- Fixes swap() performance when tracing is off.
- Enable the use of more TraceWrapperMember where we previously used
  a manual write barrier.

Bug: 
Change-Id: Ic283a2eaac1323aa3019e08ba9fa330900bdd0aa
Reviewed-on: https://chromium-review.googlesource.com/598907
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492014}

Also grab the attempted allocation size when available.

Bug: 748630
Change-Id: Icdf48d6a0cebf27bab2c5965847f607966b03f50
Reviewed-on: https://chromium-review.googlesource.com/585357
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492013}

Before this patch, if a payment app did not have its own default payment
method name, but only supported other non-default payment methods, then
Chrome would filter it out. This unnecessarily constrained some payment
apps to select one payment method to be the default, which is not always
the case. This patch relaxes this requirement.

After this patch, if a payment app does not have its own default payment
method name, then Chrome checks its non-default payment methods as well.

Bug: 735184
Change-Id: I6604c60aad4efa963120f4c66d505ab7e31bf94f
Reviewed-on: https://chromium-review.googlesource.com/600733Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492012}

This refactor simplifies the header and puts the work into a
the source file, where the bulk of the work is in a file-local
template (which primarily exists to factor out the listener creation
logic).

This sets up for a number of follow-up CLs, which combined with
this one give a 20% perf improvement on a microbenchmark of adding
and removing event listeners.

Bug: 752127
Change-Id: I3d5b8cea1560833b6ec867d9d35d44318b6db190
Reviewed-on: https://chromium-review.googlesource.com/599427Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492011}

OpenURLFromTab in headless used the default implementation, that does
nothing. This caused a couple of issues when the rendered asked the
browser to create new content. The most clear effect of this was that
setting window.location via JavaScript from the about:blank page had
no effect, but it also caused issues with other renderer-initiated but
browser-controlled navigations.


R=eseckler@chromium.org

Bug: 739969
Change-Id: I4c1080c2f41d5701b44b8c7e87d8a697c408e539
Reviewed-on: https://chromium-review.googlesource.com/600218Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Luca Versari <veluca@google.com>
Cr-Commit-Position: refs/heads/master@{#492010}

Specifically, this replaces exit code 106 (COULD_NOT_CREATE_PROCESS)
with six new codes to help diagnose these failures.

BUG=672813

Change-Id: I6a482761c34ae06c4f438aa2a30d7bd69afdf819
Reviewed-on: https://chromium-review.googlesource.com/601987Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492009}

This is achieved by talking to a different endpoint for fetching the
OGB sources, which accepts cookies. As a consequence, the cached data
is now cleared when the Gaia cookies change, rather than when the
SigninManager state changes.

Bug: 740462
Change-Id: Id230a118507e32e6f1a17c103c93c8eb5ccb0ba6
Reviewed-on: https://chromium-review.googlesource.com/595990
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492008}

TBR=twellington@chromium.org

Bug: 718689
Change-Id: I3c31179a6cd82564d83a940ca54f79b39aff6289
Reviewed-on: https://chromium-review.googlesource.com/602148Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492007}

This reverts commit 6620ff85.

Reason for revert: flaky on Mac (https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/3516)



Original change's description:
> Enable WebNavigationApiTest.ServerRedirect
> 
> This test passes with iteration count of 100 locally. It should not be
> flaky, but let's try and see.
> 
> Bug: 660288
> Change-Id: I8f190be7f6b6639e048ea59f040ca0421c3b51bd
> Reviewed-on: https://chromium-review.googlesource.com/600492
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491805}

TBR=nasko@chromium.org,alexmos@chromium.org

Change-Id: If1d0082640f0b69c193792dc108045f8cc7dd41d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 660288
Reviewed-on: https://chromium-review.googlesource.com/602307Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492006}

Bug: 699244
Change-Id: I83055b050cad7f85e8b235f40203d559d1f337aa
Reviewed-on: https://chromium-review.googlesource.com/600853Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492005}

The separators of the cells and headers where displayed even if they
had no background.
This CL removes those lines.

Bug: 740565
Change-Id: If6e2ab6225eec5e7cfc0112c8cff475530c479ed
Reviewed-on: https://chromium-review.googlesource.com/602228Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492004}

The test is flaky on Android
[ RUN      ]
PasswordStoreTest.RemoveLoginsCreatedBetweenCallbackIsCalled
[FATAL:scoped_task_environment.cc(192)] Check failed:
!queue_empty_closure_.

Bug: 355145
Change-Id: I53a73974d4eed6d8b6c895e4ec5515547449b231
Reviewed-on: https://chromium-review.googlesource.com/602149Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492003}

Avoids enabling findbar buttons when there is no search match.

TEST=On mac: Search for something not in page, verify next/prev buttons
disabled due to no results, focus away from findbar, do ctrl-f and verify
buttons remain disabled.

BUG=634289

Review-Url: https://codereview.chromium.org/2928333002
Cr-Commit-Position: refs/heads/master@{#492002}

This patch Introduces |SelectionTemplate::IsBaseFirst()| and utilize it for
|Start()| and |End()| as preparation of make |SelectionForUndoStep::From()|
faster.

Bug: 751945
Change-Id: I560c23bc6c4d72de3be3985fd6584805ac9e7da7
Reviewed-on: https://chromium-review.googlesource.com/598664Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492001}

The renderer-side ServiceWorkerDispatcher had OnAssociateRegistration,
which was either called via IPC for service worker controllees, or
directly from ServiceWorkerNetworkProvider for "controllers" (service worker
execution contexts).

But service worker controllees don't actually need to keep track of the
associated registration. I think we needed this in old times when there were
things like navigator.serviceWorker.ready had to be populated with a registration
immediately <https://codereview.chromium.org/477593007>, now it's an async API
that asks the browser for the registration
<https://codereview.chromium.org/894973003>.

Similarly, we had OnDisassociateRegistration, but once OnAssociateRegistration
IPC is removed, all it did was set the controller to nullptr, so it can
be replaced with SetController. It's never called for service worker
execution contexts.

There's more simplificiation possible here, we can possibly remove the
whole ProviderContext interface as now there are no common functions between
controllees and controllers, but that's for follow-up work.

TBR=tsepez for removing messages from service_worker_messages.h

Change-Id: I8b24c831e850351b7da955f80006d1cf51039095
Reviewed-on: https://chromium-review.googlesource.com/599092Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492000}

Layout test for orientation sensor is using assert_array_equals
for DOMMatrix objects, thus, assert will always pass. This CL
fixes this issue by converting DOMMatrix to Float64Array.

Bug: 751015
Change-Id: I599f864e631c667ce90b193590bfc4dda534cab6
Reviewed-on: https://chromium-review.googlesource.com/601971Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Cr-Commit-Position: refs/heads/master@{#491999}

Now that memory-infra has switched to collecting OS metrics
separately from the old path we can remove a lot of the old
code path.

Specifically we can remove:
- ProcessMetricsDumpProvider
- The content/ stub for ProcessMetricsDumpProvider
- The support for OS Metrics in ProcessMemoryDumo
- (Including process_memory_maps and process_memory_totals)
- The logic for registering of ProcessMetricsDumpProvider
- The support in OS metrics for ProcessMetricsDumpProvider
- The PrivatePlatformFootprint structtraits

We also remove the following memory-infra features:
- Peak RSS on recent versions of Android
  (Little used feature, superseded by general peak detection support
  in memory-infra).
- General peak detection support in Linux
  (Currently unused, coming back soon)
- Some OS stats of little use on MacOS

This removes 10 files and ~1000 lines.

Bug: 718809
Change-Id: I858ddc91ce342176c25dfda58cb9d3b1ebb39c6f
Reviewed-on: https://chromium-review.googlesource.com/586721
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491998}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/m4DNZbLMkRo/9fzhqNwqBQAJ

Because this is also supported in Edge 15 and exists in WebKit's IDL,
add an historical.html test covering this and other non-standard
features that existed or still exist in Blink, but are no longer in the
spec, annotated here:
https://chromium.googlesource.com/chromium/src/+/e70c6e15ba896a2e88d0dc05f1a20fb3d4befabf

Bug: 698163
TBR: timvolodine@chromium.org
Change-Id: If8eac7005a652c000d34f12c48bd04194e1e215e
Reviewed-on: https://chromium-review.googlesource.com/597668
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491997}

This was a mistake when I was initially writing this code.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic67f0dd0364c9a03724c626b61c56632c8fa6605
Reviewed-on: https://chromium-review.googlesource.com/600310Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491996}

This reverts commit 2c3ec3ce.

Reason for revert: still failing (https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/27201)

[ RUN      ] WebNavigationApiTest.UserAction
[5936:1628:0804/040823.764:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebNavigationApiTest.UserAction --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\s\w\iou7dp23\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4492_8435\d4492_12222" --disable-offline-auto-reload --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --allow-legacy-extension-manifests --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5936:1628:0804/040824.460:WARNING:render_frame_host_impl.cc(2614)] OnDidStopLoading was called twice.
[5936:1628:0804/040824.539:INFO:CONSOLE(0)] "[FAIL] userAction: Received unexpected event 'onCreatedNavigationTarget':{"sourceFrameId":1,"sourceProcessId":1,"sourceTabId":0,"tabId":1,"timeStamp":0,"url":"chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/b.html"}
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at captureEvent (chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:194:17)
    at chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:223:5
    at EventImpl.dispatchToListener (extensions::event_bindings:403:22)
    at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:140:26)
    at EventImpl.dispatch_ (extensions::event_bindings:387:35)
    at dispatchArgs (extensions::event_bindings:260:26)
    at dispatchEvent (extensions::event_bindings:269:7)", source: chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/test_userAction.html (0)
../../chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc(537): error: Value of: catcher.GetNextResult()
  Actual: false
Expected: true
Failed 1 of 1 tests

Original change's description:
> Enable WebNavigationApiTest.UserAction
> 
> Bug: 662160
> Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe
> Reviewed-on: https://chromium-review.googlesource.com/600768
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491817}

TBR=nasko@chromium.org,alexmos@chromium.org

Change-Id: Ieeabb0b39759aa8b94916d7c10b3c867d106a142
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 662160
Reviewed-on: https://chromium-review.googlesource.com/602147Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491995}

Enabled in https://chromium-review.googlesource.com/599728 but now
failing on WebKit Linux Trusty (dbg) in the waterfall.

Put it with the same test in other places.

Bug: 689781
Change-Id: I37a8e13ae607a18fffe3b60aa4f8812e9aadd448
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/601911Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491994}

- Local Storage
- Indexed DB
- Filesystems
- Service workers
- WebSQL

Bug: 607897
Change-Id: I7fd82d08c651fb8f41dbde9c6af1b723679c621c
Reviewed-on: https://chromium-review.googlesource.com/596088Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491993}

In new-style notification, the resizing behavior of image notification
is different form the non-MD notification.
This CL adds LargeImageView, which implements the specific resizing
behavior.

BUG=737850
TEST=manual

Review-Url: https://codereview.chromium.org/2969603003
Cr-Commit-Position: refs/heads/master@{#491992}

Change integrity calculation to be able to add another
JavaScript file to the Local NTP. To be used when
porting Voice Search (go/local-ntp-voice-search).

Bug: 583291
Change-Id: I9c0c1c1ede827b7f77b14e744b24a495eca70387
Reviewed-on: https://chromium-review.googlesource.com/600429Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Ondrej Škopek <oskopek@google.com>
Cr-Commit-Position: refs/heads/master@{#491991}

Let user select license type during enrollment flow if multiple licenses are available.

BUG=725124

Review-Url: https://codereview.chromium.org/2977033002
Cr-Commit-Position: refs/heads/master@{#491990}

This is an experimental feature to show also lower-resolution favicons
in NTP tiles. This implementation serves for decision-making.

Bug: 752130
Change-Id: I4d09ede341fb63c49845f6aac8b5b547b4473db1
Reviewed-on: https://chromium-review.googlesource.com/600236
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491989}

We mark and invalidate LayoutObject by
- finding first/last LayoutObject by canonicalization and
- traverse on layout tree
However we can those operation at once by traversing flat tree.
For that, this CL changes SelectionState::kInside marking from layout tree to flat tree.
I will change kStart/kEnd marking.
Core part is L517-L549, which replaces old SetSelectionState and CollectInvalidationSet.

LayoutSelectionTest.cpp:
 It traverses LayoutTree using NextInPreorder() and confirm each SelectionState
 and ShouldInvalidateSelection bit.
 This CL introduces InsertLayoutObjectAndAncestorBlocks() from CollectInvalidationSet()
 to construct PaintInvalidationSet in SetShouldInvalidateSelection().

Test expectations update:
 Since we traverse on flat tree, we skip pseudo element, or list style marker.

Bug: 739062
Change-Id: I0717340fb7eef2c130d1281c2c9f5d8ff9b9b586
Reviewed-on: https://chromium-review.googlesource.com/593529
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491988}

This reverts commit b1c5af84.

Reason for revert: CheckClientDownloadValidateRequestNoSignature and CheckClientDownloadValidateRequest fail more than pass on Linux Tests.

[ RUN      ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequest
../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1690: Failure
Value of: HasClientDownloadRequest()
  Actual: false
Expected: true
../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1693: Failure
Value of: fetcher
  Actual: false
Expected: true
[  FAILED  ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequest (41 ms)

[ RUN      ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequestNoSignature
../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1777: Failure
Value of: HasClientDownloadRequest()
  Actual: false
Expected: true
../../chrome/browser/safe_browsing/download_protection_service_unittest.cc:1780: Failure
Value of: fetcher
  Actual: false
Expected: true
[  FAILED  ] DownloadProtectionServiceTest.CheckClientDownloadValidateRequestNoSignature (73 ms)

Original change's description:
> Move URL whitelist checking b4 content analysis
> 
> Refactor checking of URL whitelist to happen before analyzing the
> downloaded file, in order to improve SB check latency for whitelisted
> URLs. Certificate whitelist checks still happen towards the end of
> processing since they rely on file analysis.
> 
> Bug: 526841
> Change-Id: I59e228dea251ff1a03e319efccf1c2a8aec89bc3
> Reviewed-on: https://chromium-review.googlesource.com/587329
> Commit-Queue: Varun Khaneja <vakh@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Reviewed-by: Jialiu Lin <jialiul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491890}

TBR=vakh@chromium.org,jialiul@chromium.org,mortonm@google.com

Change-Id: I1a026c9956034867d0eae39acea4352443db38bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 526841
Reviewed-on: https://chromium-review.googlesource.com/601949Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491987}

Bug: 752132
Change-Id: Ib7320e6156978e6eabe527dedc013609bffedfe9
Reviewed-on: https://chromium-review.googlesource.com/601791Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Hausknecht <dhausknecht@google.com>
Cr-Commit-Position: refs/heads/master@{#491986}

ReadableStream.prototype.pipeTo was using the global Boolean
function. Use a copy of the original value instead to avoid problems
when it is overwritten.

This change also adds a test that ReadableStream and WritableStream
still work when all global objects have been set to undefined.

Bug: 752177
Change-Id: I09c7fb139610c2c9c3bc8780c59615361d8beb55
Reviewed-on: https://chromium-review.googlesource.com/601610Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491985}

This reverts commit c59f6260.

Reason for revert: Broke compilation on Linux ChromiumOS Builder (dbg)

../../components/exo/data_device_delegate.h:28: error: undefined reference to 'vtable for exo::DataDeviceDelegate'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Original change's description:
> Delivers drag and drop methods from Surface to DataDevice.
> 
> The CL lets Surface observe drag and drop events and delegates the events to
> DataDevice thorugh DataDeviceManager.
> 
> Bug: b:31988797
> Test: None
> Change-Id: I9574cd86137922d7527bd297d182a7b45e632c9e
> Reviewed-on: https://chromium-review.googlesource.com/579250
> Commit-Queue: Daichi Hirono <hirono@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491951}

TBR=reveman@chromium.org,hirono@chromium.org,hidehiko@chromium.org

Change-Id: Ie770510e27a19b94f5e621ef41d24138c219104c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:31988797
Reviewed-on: https://chromium-review.googlesource.com/601989Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491984}

The desktop re-authentication flow does not update the sign-in manager.
Here are the explinations why:
* SigninManager::StartSigninWithRefreshToken dchecks that the profile
is not authenticated (see https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_manager.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=105)
* InlineSigninHandler simply updates the refresh tokens in case of a
reauth (see https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=246 )

The mobile re-auth flow calls SigninManager::OnExternalSignin which in
some cases may lead to a unexpected call to GoogleSigninSucceeded.
On iOS this flow does not exists as the iSL always removes invalid
accounts.
On Android, there is a possibility for the SigninManager::OnExternalSignin
to be called in a reauth flow, however the Java code ignores
GoogleSigninSucceeded notifications (see
https://cs.chromium.org/chromium/src/chrome/browser/android/signin/signin_manager_android.cc?rcl=a2b0b2c00ad3b7c02b57fe86b9feba1a4c5221fd&l=347)

This CL makes it explicit that:
* SigninManager does not send GoogleSigninSucceeded notifications on
reauth
* Adds a DCHECK when the authenticated account ID is changed.

TBR=mpearson@chromium.org

Bug: 733226
Change-Id: I85cc4497a0d099447a7d8a46b435e93f39d8d4c7
Reviewed-on: https://chromium-review.googlesource.com/579432
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491983}

Make the Site Details web UI update the default permission strings when they
change without needing to reload the Site Details page.

Manual test - With #enable-site-details on, open https://permission.site. Open
the Page Info bubble, click "Site settings" to open the Site Details page. Make
sure the 'Location' setting is set to 'Ask (default)'. In a new window, open
chrome://settings/content/location and put the two windows side by side. On
chrome://settings/content/location, click the toggle to block location access by
default, and verify the Site Details page drop-down value for location changes
to 'Block (default)'.

Bug: 656758
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1c03acd9b636ea8463e382ae21cc646161267d9
Reviewed-on: https://chromium-review.googlesource.com/597030
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491982}

Bug: v8:6649
Change-Id: I79555121ce72bef536ca99365cc5b12c3a6496df
Reviewed-on: https://chromium-review.googlesource.com/590369
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491981}

Disable BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestBeforeUnloadAndDownloads/1

TBR=chrisha@chromium.org

Bug: 749098
Change-Id: Ia814e450c72b65017025bb3eb11db49c31b1498e
Reviewed-on: https://chromium-review.googlesource.com/601968Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491980}