- 11 Sep, 2018 40 commits
-
-
Sarah Hu authored
In case of a non-ideal scan (user puts the same area of their finger over and over again), the percentage goes up and we should advance progress bar in UI to match Android's behavior. Bug: 880105, b:112692311 Change-Id: I031eca6c2b2450f651784866ffb7ffa105a25ef1 Reviewed-on: https://chromium-review.googlesource.com/1217912Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590373}
-
Ehsan Karamad authored
The BrowserPlugin related tests in the file were to test features that affect BP-based GuestViews; this only includes MimeHandlerViewGuest. This CL moves one more such test to 'chrome_mime_handler_view_browsertest.cc'. This also involves adapting the test such that it creates a MimeHandlerViewGuest instead of WebViewGuest based on BrowserPlugin. The last remaining test in 'web_view_browsertest.cc' will be removed and adapted in a followup CL (to make sure the process is easily reversible in case the new tests end up having issues on bots). Bug: 553069, 330264 Change-Id: Iaa7ba33189ecb8b23e8489dab8e9b2b5e378a9be Reviewed-on: https://chromium-review.googlesource.com/1217147Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590372}
-
Arthur Hemery authored
Allowed the navigation data and params to be passed directly to DidFailProvisionalLoadInternal, instead of revolving around obscure pending_navigation_params_ management. Explicited the forwarding to observers without relying on nullptr DocumentLoader in DidFailProvisionalLoadInternal. Finally, modified a test expectation that would otherwise cause a very ugly hack to become necessary. Bug: 882800 Change-Id: I6ba713939a1ed192e1212e888323b55b1c6e6af5 Reviewed-on: https://chromium-review.googlesource.com/1169464Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#590371}
-
Zach Helfinstein authored
This reverts commit 3a16d8d9. Reason for revert: The method used to identify virtual key events with the old virtual keyboard UI no longer holds true with the new virtual keyboard UI. I'm investigating why that's true, but to unblock progress on SwitchAccess typing, I am reverting this change. Original change's description: > Ignore virtual KeyEvents in SwitchAccess > > Switch access should only use KeyEvents from physical keyboards as > switches; virtual keyboard events should be ignored. > > Added a browser test for SwitchAccess > > BUG=864802 > > Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc > Reviewed-on: https://chromium-review.googlesource.com/1114069 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580321} TBR=dtseng@chromium.org,katie@chromium.org,zhelfins@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864802 Change-Id: I698bbb745e2e1371ecf4e7c800cf8d832919f927 Reviewed-on: https://chromium-review.googlesource.com/1217717Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#590370}
-
Hiroshige Hayashizaki authored
This CL adds generated files for test cases added in https://chromium-review.googlesource.com/1212744. Only manual change in this CL is mixed-content/spec.src.json and all other files are generated by generic/tools/generate.py. Bug: 880986, 880023, 880015 Change-Id: I7be98407c527883176ab6a2e9cfc1fedb1f8bfbe Reviewed-on: https://chromium-review.googlesource.com/1212746 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#590369}
-
Igor Kobylin authored
R=stevenjb@chromium.org Bug: None Change-Id: I70094707baab64a2831c3c1413ea64535ab2e74f Reviewed-on: https://chromium-review.googlesource.com/1185082Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590368}
-
Ryan Hansberry authored
Change HostScanScheduler's primary ScheduleScan() method to allow clients to specify if a Tether host scan should only be performed if the device is offline. TetherComponentImpl's call on this method has been appropriately changed -- Tether now only kicks off a host scan on component creation if the device is offline. Additionally, add a NetworkTypePattern argument to the NetworkStateHandlerObserver::ScanRequested() method that HostScanSchedulerImpl overrides. This allows HostScanSchedulerImpl to only scan if the request matches NetworkTypePattern::Tether(). Relevant Settings and System Tray callsites have been tweaked to request the network types they are actually trying to scan for. Bug: 881820 Change-Id: I72833f821dcb4575e4b28c104fa1a731144fa1b0 Reviewed-on: https://chromium-review.googlesource.com/1217707Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#590367}
-
Ryan Cui authored
Add blacklist for CrSettingsResetPageTest.All (flaky) and ExtensionWebRequestApiTest.WebRequestTypes (failing on ASAN bot). Bug: 874090 Bug: 882631 Bug: 880584 Change-Id: Ie2a5bee8de4497a470a064ea853805a0e74b685a Reviewed-on: https://chromium-review.googlesource.com/1217710Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590366}
-
Christian Biesinger authored
To avoid a useless reference add/decrease R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic1c7fe92164a4249ce7b5c8642bd5efa7a5c8e1d Reviewed-on: https://chromium-review.googlesource.com/1217713Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#590365}
-
Vasilii Sukhanov authored
This reverts commit 7c5aa07b. Reason for revert: we don't need it. The hardcoded string works probaly better for Canary/Beta channels. Original change's description: > Use install_static::GetAppGuid instead of the hardcoded string in BrandcodeConfigFetcher. > > Bug: 769756 > Change-Id: Ifdcb0a5145ffad1d563562e2b2ea2390ff074cdc > Reviewed-on: https://chromium-review.googlesource.com/1213178 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590275} TBR=battre@chromium.org,vasilii@chromium.org,engedy@chromium.org Change-Id: I3819f79aa36e61bfe61a825618496751b11a03ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769756 Reviewed-on: https://chromium-review.googlesource.com/1219616Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#590364}
-
Antonio Gomes authored
This is a follow on of [1], where the sync::HttpBridge logic switched away from URLFetcher to SimpleURLLoader, as part of the network servicification effort. [1] https://crrev.com/c/1174655/ It turns out that the way sync::HttpBridge interpreted the response of an upload request changed after the migration: By default, SimpleURLLoader does not pass a valid response body in case of either HTTP or network errors. What is more, the new logic in HttpBridge::OnURLLoadComplete relied precisely on null-checking the responsebody to verify whether the upload was successful or not. This CL changes this particular check logic so that it matches the previous behavior: only actual network errors account for sync failures (which map to "network connection unavailable" errors) whereas HTTP errors (>= 400 && < 600) still account as a successful uploads. 401 specifically is handled to request expired user credentials in [2]. [2] https://cs.chromium.org/chromium/src/components/sync/engine_impl/net/sync_server_connection_manager.cc?l=84 BUG=844968,878718,880633 Change-Id: I9d0b93b527f103149a7c78ba405dde27cae779f2 Reviewed-on: https://chromium-review.googlesource.com/1217122 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#590363}
-
Chris Hamilton authored
In order to not discard sites with potential unsaved user state it is necessary to run beforeunload handlers to see if they return the empty string or not. When running handlers in this context it is undesirable to launch a modal dialog, but rather to silently block the discard and continue running the page. This CL adds a new BeforeUnloadType to RenderFrameHostImpl in support of this. A follow-up change will expose functionality for invoking DispatchBeforeUnload with this BeforeUnloadType, and returning the results of the unload via a callback. BUG=877550 Change-Id: Iad029fb0f70f9f44695f15c5ca0c0f6e4ed7ff78 Reviewed-on: https://chromium-review.googlesource.com/1208962 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#590362}
-
Max Moroz authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/5185d85264d2..4c916c947ab7 $ git log 5185d8526..4c916c947 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 junyer Adjust a couple of the limits for fuzzing. 2018-08-30 junyer Keep the assert(3) call at the top of the function. 2018-08-30 junyer Check before matching in order to avoid wasting time. 2018-08-30 junyer That didn't fix the error. Trying something else. 2018-08-30 junyer Address MSVC error and warnings. Sigh. 2018-08-30 junyer Add PODArray<> and make BitState use it. 2018-08-28 dsturtevant Move some function documentation closer to the documented functions. 2018-08-25 junyer Tweak a couple of comments. 2018-08-16 lietar Remove NULL case from search_test. 2018-07-11 junyer Fix the "DFA out of memory" error for the reverse Prog. 2018-06-23 keller.e.ben Include operator<<() for StringPiece in libre2.so 2018-06-17 junyer Update Unicode data to 11.0.0. 2018-05-16 junyer Address `-Wclass-memaccess' warnings from GCC 8.x. 2018-05-14 junyer MSVC still needs the pragma in util/logging.h. Sigh. 2018-05-14 junyer Add GCC 8.x to the Travis CI matrix. 2018-05-14 junyer Tweak the FALLTHROUGH_INTENDED macro. Add the ATTRIBUTE_NORETURN macro. 2018-05-05 junyer Use the standard first-byte analysis for the DFA too. 2018-04-23 junyer Add more support for empty prefilter_vec_ to PrefilterTree. 2018-03-15 junyer Note more languages' package sites. 2018-03-06 junyer Try to suppress warnings with FALLTHROUGH_INTENDED. 2018-03-06 junyer We need ubuntu-toolchain-r-test again? 2018-03-06 junyer travis-ci/apt-source-whitelist is no longer updated. 2018-03-06 junyer Add Clang 6.0 to the Travis CI matrix. 2018-03-04 junyer Kludge around System Integrity Protection on Darwin. 2018-02-22 junyer Oops, not in DeBruijnString() though. 2018-02-22 junyer Use ASSERT* macros instead of CHECK* macros in tests. 2018-02-18 junyer Configure CI using Bazel on macOS and on Windows. 2018-02-18 sayrer Omit -pthread option on Darwin 2018-02-18 junyer Try to make windows-cmake.bat more readable. 2018-02-18 junyer regexp_benchmark doesn't need linkopts. 2018-02-15 ckennelly Use sized deallocation for RE2's DFA. 2018-02-13 junyer Don't #include <sys/resource.h> anymore. 2018-02-08 junyer Stop using StringPiece::ToString(). 2018-02-06 junyer Fix some formatting inconsistencies. 2018-01-28 hansenr Add a std::nullptr_t ctor overload to RE2::Arg. 2018-01-11 junyer Tweak the BUILD file formatting. 2018-01-10 loorongjie [Bazel] Do not set -pthread etc. on Windows 2017-12-19 junyer Just /source-charset:utf-8 didn't work. Try /utf-8. 2017-12-19 junyer Specify the source character set for MSVC. 2017-12-13 junyer Try to appease MSVC another way. Sigh. 2017-12-13 junyer Address a couple of MSVC warnings. 2017-12-13 junyer Fix a silly off-by-one error. 2017-12-13 junyer Require Visual Studio 2015 or later. 2017-12-13 junyer Try specifying Visual Studio 14 2015 instead. 2017-12-13 junyer Make CTest extra verbose temporarily. 2017-12-13 junyer Make Regexp::FactorAlternation() not recursive. 2017-12-11 junyer Tweak factoring code and comments for consistency. 2017-12-11 junyer Split Regexp::FactorAlternationRecursive() into rounds. 2017-12-11 junyer Fix the Regexp::FactorAlternation*() argument names. 2017-12-08 junyer Retire Regexp::FactorAlternationRecursive() round 4. 2017-12-07 junyer Write size_t{4} for brevity. 2017-12-07 junyer Adjust the comment to be about GCC 6.x (for x >= 1). 2017-12-06 junyer Test past kFactorAlternationMaxDepth (8). Created with: roll-dep src/third_party/re2/src Bug: 874727 Change-Id: I33fdf09b753e80e0d375c62344a1150595e523f9 Reviewed-on: https://chromium-review.googlesource.com/1219232Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#590361}
-
Lukasz Anforowicz authored
This CL avoids spawning a spare renderer process, when the system is under moderate or higher memory pressure. Bug: 852905 Change-Id: If01e293ed9b53eb2e861146ffa2a0bbb3e2a210f Reviewed-on: https://chromium-review.googlesource.com/1207572Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#590360}
-
Vladislav Kaznacheev authored
New icons are circular an have correct padding. Replaced 32 and 64px with 48 and 192px icons to cover a wider range of scales. Bug: 882176 Test: manual Change-Id: Ib3d084297bdbd81d778bc15ee64cb1cf8578669a Reviewed-on: https://chromium-review.googlesource.com/1219774Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#590359}
-
Ben Kelly authored
Bug: 881961 Change-Id: Ie58d071b3a80f48274991eaed799fc144da1d6a1 Reviewed-on: https://chromium-review.googlesource.com/1214046Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#590358}
-
Steven Bennetts authored
Currently we select the input element contents when focusing back to a <cr-input> element with shift-tab, but focusing forward to a <cr-input> element does not select its contents. This fixes that behavior to always select the contents to be consistent with the behavior of <input>. Bug: 882612 Change-Id: Iecfbd984928571ca7041133f5621d82fd32f4f35 Reviewed-on: https://chromium-review.googlesource.com/1217747Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590357}
-
Aaron Leventhal authored
Bug: None Change-Id: Iab00c7254288d0b1e3d033fa6c3b41a4f3d8ee1e Reviewed-on: https://chromium-review.googlesource.com/1213531 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#590356}
-
Juan Antonio Navarro Perez authored
The previous tweak did not disable all possible webview browsers like, e.g., android-webview-google. Bug: 879151 Change-Id: Ic2b0e22b06893d7e7e769dd50fb86f46bbc9c936 Reviewed-on: https://chromium-review.googlesource.com/1219614 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#590355}
-
Ivan Sandrk authored
Bug: 865947 Change-Id: I82057800a73057435e8ad11c64ba2374e2ef3210 Reviewed-on: https://chromium-review.googlesource.com/1219608 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#590354}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f658fe0d651..56de9d6b2972 git log 1f658fe0d651..56de9d6b2972 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 taylori@google.com Merge "trace_processor: Fix parsing bug" Created with: gclient setdep -r src/third_party/perfetto@56de9d6b2972 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia401e8e9f8e78b05c2b90fe38f7557a849ba671b Reviewed-on: https://chromium-review.googlesource.com/1219417Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590353}
-
Arthur Hemery authored
If condition used pending_navigation_params_ that is always false there. Usage might have been corrupted during refactorings without being noticed, or was never working. Skip was removed, CHECK added as well as a TODO to reintroduce the functionality. Bug: 882800 Change-Id: I0cafc9dda082a395d48783cac03ec0d25a1ec73e Reviewed-on: https://chromium-review.googlesource.com/1202462Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#590352}
-
Albert J. Wong authored
Bug: none. Change-Id: I28b7355d1a7d5cde785fbab40250ae2040c2ff65 Reviewed-on: https://chromium-review.googlesource.com/1212144Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590351}
-
Joanmarie Diggs authored
* Emit checked state changed events for checkboxes and radio buttons. * Emit pressed state changed events for toggle buttons. * Emit indeterminate state changed events for tri-state widgets when their state becomes "mixed." * Remove checkable state for toggle buttons. R=dmazzoni@google.com Bug: 866341 Change-Id: I10e08330408c6f783e202d2c81c6c70d19309d08 Reviewed-on: https://chromium-review.googlesource.com/1219726Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#590350}
-
Boris Sazonov authored
This CL changes SyncAndServicesPreferences to make UnifiedConsentServiceBridge.isUnifiedConsentGiven a source of truth when updating prefs. Before, mUseSyncAndAllServices was used in some places, leading to inconsistencies when UnifiedConsent state can't be changed (for example, because of a custom passphrase). Bug: 882884 Change-Id: Ie9be1b73284a7a818c21d702c47712b787d52846 Reviewed-on: https://chromium-review.googlesource.com/1219927Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#590349}
-
Gabriel Charette authored
This reverts commit 6e2e384b. Reason for revert: Not sure why, but seems a pretty clear culprit for crbug.com/882832 Original change's description: > Update bundled Chrome app icon for MD compliance > > - Update chrome_app manifest to support 32 and 192px icons. > - Use 192px icon as window icon for Chrome browser. > - Move all resource handing related to chrome_app under > OS_CHROMEOS ifdef. > > Bug: 879618 > Test: manual > Change-Id: If3e9fb396424159ea0bf7f2cf61febfd89838b62 > Reviewed-on: https://chromium-review.googlesource.com/1210943 > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589771} TBR=kaznacheev@chromium.org,oshima@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879618 Change-Id: Idd28ce462ab64d417e4c6137a8ecbc7966975f42 Reviewed-on: https://chromium-review.googlesource.com/1219908Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#590348}
-
danakj authored
Currently this methods works as O(N*M), where N = size of imported_resources_ in the provider M = number of resources being received by the provider That is because each received element is removed individually from the imported_resources_ set, and each removal will cost O(N). Instead, sort the incoming resources, then walk through the two sets of resources in parallel, which is O(N+M). During this walk, replace resources to be removed from imported_resources_ with resources that we are keeping as we walk, which is O(1). Then erase the empty space created by this process at the end of the loop, which is O(N). This makes the complexity O(2N+M) = O(N+M). This is similar to the std::remove_if() algorithm, except that we have to write it ourselves to avoid O(M) work at each step, and instead walk the received resources in parallel. We also sort the returned M resources as a prelude, to ensure we can do the walk in parallel. This costs O(MlogM), making the whole thing O(N+MlogM). Similarly, for ClientResourceProvider::ReleaseAllExportedResources() stop removing elements individually. In this case we can use base::EraseIf to iterate through the set, act on each element, and return true if it should be erased. R=piman@chromium.org Bug: 881295 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I94522eb07e2f09b20a10d8f254faa63fd2ab9d0e Reviewed-on: https://chromium-review.googlesource.com/1211908 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590347}
-
Luna Lu authored
For details, please see https://docs.google.com/document/d/1yh_-ayeaFV0EjuR51U641zbrPAB0Baqj6UrC9bT9iqQ/edit#heading=h.7qo26jlhd6ob BUG: 874113, 874629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0762229d550bb7b06518f22657113b4a52e3da6b Reviewed-on: https://chromium-review.googlesource.com/1199858Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#590346}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic68969370562563a90159167bada0b822893ff8b Reviewed-on: https://chromium-review.googlesource.com/1212983Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#590345}
-
Xi Han authored
This CL makes different WebShareTargets a reason to generate an update for a WebAPK. Presently, updating the share_target doesn't trigger an update. This CL originally from ckitagawa@'s CL: https://crrev.com/c/1185522. Bug: 795165 Change-Id: Ie08cf9edaff4cdfbf2e7148aead03c8d92c20f68 Reviewed-on: https://chromium-review.googlesource.com/1190422 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#590344}
-
Christopher Cameron authored
Move Set/GetNativeWindowProperty to the browser-side BridgedNativeWidgetHostImpl. Also, change from using a NSDictionary attached to the NSWindow to just using a std::map -- these properties do not actually need to be attached to the NSWindow. Move Set/RemoveAssociationForView and ReorderChildViews to the browser side, because that's where the views::View hierarchy is stored. Compute the appropriate NSView->rank map and then send that to the BridgedNativeWidgetImpl (in the future, this will be a handle->rank map, when crossing process boundaries). Bug: 859152 Change-Id: I142ec9eb180a81a9e456957bc9f42f32ab7de792 Reviewed-on: https://chromium-review.googlesource.com/1217450Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#590343}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bd6595544171..2473d9472049 git log bd6595544171..2473d9472049 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 halcanary@google.com SkPDF: allocate for single Canvas 2018-09-11 michaelludwig@google.com Base Gradient FP Refactor Created with: gclient setdep -r src/third_party/skia@2473d9472049 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Iffd7bb86c8a54dd52a06872e50182a1905bba396 Reviewed-on: https://chromium-review.googlesource.com/1219986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590342}
-
Steven Bennetts authored
If a technology gets left in the 'enabling' (or any other) list but becomes unavailable, it should not be provided as an available technology. Also, 'prohibited' technologies are correctly prioritized. This CL also modernizes the technology list iterators and only signals a change when the list actually changes. Bug: 809940 Change-Id: I9aa60ea5027f74b52d831e3a872c8ce7ffccb863 Reviewed-on: https://chromium-review.googlesource.com/1186097Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590341}
-
Alexandros Frantzis authored
DRM_FORMAT_ARGB8888 (which is B,G,R,A in memory order) matches the used GL internal format and is also more widely supported by minigbm drivers. Bug: 882825 Change-Id: I909ceb04172e4c7a97c97e9c94a36f3bb467053a Reviewed-on: https://chromium-review.googlesource.com/1219387Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#590340}
-
Che-yu Wu authored
Add an exit code for zip archiver sandbox to report unexpected sandbox disconnection. Bug: crbug.com/881988 Change-Id: Ib38a8cd85876fc8dc186e0c62a377f51d22f5ea2 Reviewed-on: https://chromium-review.googlesource.com/1216025Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Che-yu Wu <cheyuw@google.com> Cr-Commit-Position: refs/heads/master@{#590339}
-
Xida Chen authored
This experiment is already done, so remove these two lines. As long as all bots are green, this should be saefe. TBR=pdr@chromium.org Bug: None Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie27fa10cdde06cb9938cb0d7b5d55ad6fe9946fd Reviewed-on: https://chromium-review.googlesource.com/1219782Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590338}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7cd0e15faf17..375d35e01b11 git log 7cd0e15faf17..375d35e01b11 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 sprang@webrtc.org Make ilnik@ owner in video/ and modules/video_coding/ Created with: gclient setdep -r src/third_party/webrtc@375d35e01b11 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3c5b59c3a9a6c05195e92f0f6d000649dbd445c4 Reviewed-on: https://chromium-review.googlesource.com/1219416Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590337}
-
Ted Choc authored
BUG= Change-Id: Id8b068f4524181e85ab483ec74a300b06a116334 Reviewed-on: https://chromium-review.googlesource.com/1217542Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590336}
-
Ben Pastene authored
That arg has been shown to cause the browser to crash on cros VMs. Bug: 876494 Change-Id: I217451ce65a78b62a947a8b2b77618875e83dd7f Reviewed-on: https://chromium-review.googlesource.com/1217913Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#590335}
-
Yi Su authored
Add metrics for ImageFetchTabHelper::GetImageDataByJs to check if fetching image data by JavaScript methods works very often. If not, remove the JavaScript methods that are not likely to succeed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I22a1bc9f16575d40836b7ed020a1e81a8c6a1b1e Reviewed-on: https://chromium-review.googlesource.com/1213146 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590334}
-