- 02 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2958971d9c5..df861c520636 2020-10-02 hjd@google.com Merge "Remove extra join" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9a5c5a8b6ca693f311f85e4907a5926787e43b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813130}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ieec4e3400ce3fcfa77b184dbc509600a1e973bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443093Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#813129}
-
Greg Thompson authored
High frequency of test timeouts. BUG=1132581 TBR=dbertoni@chromium.org NOTRY=true Change-Id: I5e38acafe2b69fa93d8350f65fe051e5c8d833e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444317Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813128}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2251023b36e6593936b08805061ecac35144b897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443941Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813127}
-
David Roger authored
This CL adds files and plumbing for the UI bubble for profile customization. The bubble is behind an experimental flag. The actual content of the bubble will be implemented in javascript in a follow up CL, in this CL there is only a title and a button that does nothing: https://screenshot.googleplex.com/3JhvoT3kTgXMQ4Y.png Bug: 1130945 Change-Id: I1fab6184a69b3e86a474e9bb896e64f2f79dcbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431567Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#813126}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601596804-53a4ffa238a2dd27e204a4d6f101c3543de8d4a0.profdata to chrome-linux-master-1601618211-256d587047e0fd89a9b32fa8e7b7bfc10ace51d7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I21c2947b0d2272635fcb7edd908faa2258cf03bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445056Reviewed-by:
-
Colin Blundell authored
This CL componentizes the strings used by ads_blocked_infobar_delegate.cc in preparation for componentization of the ads blocked infobar itself. We skip the addition of translation screenshots as this is just a move of existing strings plus the addition of a generic //components-level IDS_RELOAD string that will be used across multiple contexts. Bug: 1116095 Change-Id: I3af1a25ea260e436184bbb75d515a8bd6acd21ce Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440523 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#813124}
-
Anastasiia N authored
Fix creation and destruction of testing profile and user manager in AccountManagerUIHandlerTest. Bug: 1131834, 1131819 Change-Id: I5c7dbf396f5e48cec3285796a6f6a5f60b71d43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438059Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#813123}
-
Fredrik Söderqvist authored
Remove the SVGPaintServer abstraction, folding it into the only remaining user (SVGObjectPainter::PreparePaint). LayoutSVGResourcePaintServer::PreparePaintServer() is transformed into LayoutSVGResourcePaintServer::ApplyShader(). This provides a slimmer abstraction for <paint>s. Bug: 109212 Change-Id: Iae577d846a61a6eae0e3689165ab616cbb70183c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440533Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#813122}
-
Greg Thompson authored
High flake rate. BUG=1133962 TBR=zatrudo@google.com NOTRY=true Change-Id: I41a87c39297b22ba895997593f80257fb0549447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443853Reviewed-by:
-
Greg Thompson authored
This reverts commit 40e6324b. Reason for revert: Consistent test failures on the bots; see https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20666 Original change's description: > [Switch Access] Add menu tests > > AX-Relnotes: n/a. > Bug: 897365 > Change-Id: I9ca877042531bc7d2b57fd27c390a113c63f58b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391383 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#812998} TBR=tetsui@chromium.org,anastasi@google.com,akihiroota@chromium.org Change-Id: I078d4eb89388416ec29bde99ffa2f44865ad2722 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445249Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fcb22ecf0f7e..d91afd8de27a 2020-10-02 vasniktel@gmail.com spirv-fuzz: Refactor fact manager tests (#3879) 2020-10-02 afdx@google.com spirv-fuzz: Integrate spirv-reduce with shrinker (#3849) 2020-10-02 afdx@google.com spirv-fuzz: Only recommend passes when a pass had an effect (#3863) 2020-10-02 stefano.milizia00@gmail.com spirv-fuzz: Merge the return instructions in a function (#3838) 2020-10-01 jaebaek@google.com Debug info preservation in redundancy-elimination pass (#3839) 2020-10-01 jaebaek@google.com Debug info preservation in if-conversion pass (#3861) 2020-10-01 vasniktel@gmail.com spirv-fuzz: Refactor conditions in the fact manager (#3867) 2020-10-01 vasniktel@gmail.com spirv-fuzz: TransformationWrapRegionInSelection (#3674) 2020-10-01 afdx@google.com spirv-fuzz: Enable some passes with high probability (#3860) 2020-10-01 afdx@google.com spirv-fuzz: Do not add constants for Block-decorated structs (#3862) 2020-10-01 vasniktel@gmail.com spirv-fuzz: Fix to FuzzerPassFlattenConditionalBranches (#3865) 2020-09-30 vasniktel@gmail.com spirv-fuzz: Fix TransformationRecordSynonymousConstants (#3868) 2020-09-30 afdx@google.com spirv-fuzz: Fix flatten conditional branch transformation (#3859) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I2725c067453e4ae2df6a28707527831348bb7209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445053Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2821bcd15cf6093dc44f718b56c2bdc32e58439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445089Reviewed-by:
-
Sylvain Defresne authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564, not having a sources assignments filter is the default. No behavior change. Bug: 1018739 Change-Id: I9ad52eeef3c189914ebc89638e50fe1b32aaa216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440584 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813117}
-
Sreeja Kamishetty authored
This CL adds test to ensure that RenderViewHosts are deleted when page evicts from cache. BUG=1109759 Change-Id: I58b040366429a37c4879959b37d6d22ed5402451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336279 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813116}
-
Ben Reich authored
Add a class that emits the minimal set of messages to collect JS code coverage via Chrome Devtools Protocol from a WebContents host. Bug: 1113941 Change-Id: I3119f4417cf3b49a16428888126c3bfa639472c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347265Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813115}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d0e5bfe429c..9cecd7b60ead 2020-10-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-02 tvanderlippe@chromium.org Typecheck sources/WatchExpressionsSidebarPane.js with TypeScript 2020-10-02 sigurds@chromium.org Revert "Convert inspector_overlay to TypeScript" 2020-10-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-02 cpinnamaneni@microsoft.com New context menu for copy value for Form data, query params and request/response headers. 2020-10-01 michael.liao@microsoft.com [Console Pin Pane]: Fixing focus order when deleting expression 2020-10-01 michael.liao@microsoft.com [Elements]: Fixing SR issue for DOM Breakpoints 2020-10-01 Rob.Paveza@microsoft.com Horizontal scrolling in the Application tool is unpleasant 2020-10-01 brcui@microsoft.com Console Errors/Warnings and Issues Counters Accessibility Improvements 2020-10-01 cpinnamaneni@microsoft.com New context menu to copy a payload from a JSON request 2020-10-01 chrche@microsoft.com Fix exception when snippets scripts is an empty array 2020-10-01 andoli@chromium.org [ts] Typecheck data_grid/ShowMoreDataGridNode.js with TypeScript 2020-10-01 andoli@chromium.org [ts] Typecheck data-grid/SortableDataGrid.js with TypeScript 2020-10-01 sigurds@chromium.org Also handle application/octet-stream for source maps 2020-10-01 leese@chromium.org Support virtual inline call frames in DevTools with the plugin 2020-10-01 tvanderlippe@chromium.org Typecheck elements/ImagePreviewPopover.js with TypeScript 2020-10-01 tvanderlippe@chromium.org Typecheck elements/ClassesPaneWidget.js with TypeScript 2020-10-01 alexrudenko@chromium.org Migrate ARIAMetadata.js to TypeScript 2020-10-01 alexrudenko@chromium.org Convert inspector_overlay to TypeScript 2020-10-01 patrick.brosset@microsoft.com Guard against null event.data from worker in the script formatter 2020-10-01 alexrudenko@chromium.org Migrate ResourceUtils.js to TypeScript 2020-10-01 alexrudenko@chromium.org Migrate JSONView.js to TypeScript 2020-10-01 jec@google.com Update WNDT87 Lighthouse to 6.4 2020-10-01 changhaohan@chromium.org Remove dead code in ui/InplaceEditor.js 2020-10-01 tvanderlippe@chromium.org Typecheck elements/PropertiesWidget.js with TypeScript 2020-10-01 wolfi@chromium.org Update protocol 2020-10-01 jobay@google.com Move specialRegexCharacters from String prototype to string-utilities.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069378,chromium:1107766,chromium:1126943,chromium:1130800,chromium:1131801,chromium:1132084,chromium:1132284,chromium:1133060,chromium:1133362,chromium:1134334 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02647f554a69dad463f780a48989bce1f23326b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444806Reviewed-by:
-
Dylan Cutler authored
study. This API leaks whether a users' hardware supports web XR, a bit which could be used with other APIs to build a persistent, cross-origin identity. We instrument this API with a use counter and with instrumentation that reports whether the returned Promise resolves or rejects to UKM for analysis. Bug: 973801 Change-Id: Ic711f652373cb56cd516d321de369f106aab1b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441488Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#813113}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ic3cd9d922dc12131243bc5ab34aad96ee18cb00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440844Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813112}
-
Kent Tamura authored
After this CL, <input type=range> uses LayoutNG. Bug: 1040826 Change-Id: I8e02b38c3b58266ee3f9298e81c9a6a5acbd9749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444631Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#813111}
-
Alexandre Courbot authored
If we are operating in DMABUF mode, then we will try to keep the same frame assigned to the same V4L2 buffer. The number of buffers requested by the client is indicative of the real load, but there is no hard guarantee that we will not receive more frames than that, thus resulting in sub-optimal affinity tracking. Try to prevent this by allocating as many buffers as allowed by the V4L2 API (32) when operating in DMABUF mode. Since these buffers won't have backing memory unless we attach a DMABUF to them, they are virtually free if unused. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: Ibc9ea18835acd4b8d3bc6ffc7393bf0d5d97d04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415908 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813110}
-
Greg Thompson authored
High flake rate. BUG=1131803 TBR=jochen@chromium.org Change-Id: I6c209897183ccd0bdc5582ee0a1673bc2751713f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445170Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Id609bfd6a418bac9ba1b3cc02f1a65b7aeffea28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442834Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813108}
-
Bret Sepulveda authored
This patch adds Chip (under the value LOCATION_BAR_LEFT_CHIP) to the PermissionPromptDisposition enum in permission_uma_util. Since it's hard for PermissionRequestManager to determine whether the chip is being shown as it currently does, this patch also moves the logic for getting the disposition to PermissionPrompt. Bug: 1019129 Change-Id: I56563d245fdf84a6e5acadb361695a15ae775e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438389 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#813107}
-
David Jean authored
Now failing on iOS 12 and 14. Bug: 1104872 Change-Id: I53183dc4f9e8559e02ff49009a0ea97037d5368e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445111 Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#813106}
-
Greg Thompson authored
BUG=764464 TBR=jophba@chromium.org Change-Id: I359f377c5b73f51c14ede790aafa540a90128414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443851Reviewed-by:
-
wutao authored
The music note icon is static. To avoid screen burn, we move the media string view similar to the attribution. 1. Move `MediaStringView` to `AmbientBackgroundImageView` so that we can reuse the same logic to move attribution. 2. Move media string view in small steps on each refresh with in a fixed bounds. Bug: b/168568042 Test: manual Change-Id: Ieff99fbabb559139cb99cb2db808b65234af04d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437736 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#813104}
-
Andrew Shulaev authored
Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: Ibef5d49f819483faa1c5fad7edaf5e781fe947dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440597 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Greg Thompson authored
This reverts commit bfeec8b7. Reason for revert: MSan failures; see https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7726 Original change's description: > Exclude no-update frames for jank detection > > > This CL improves the jank metrics by excluding the delays caused by > frames without intended updates and prevents certain outlier cases > when a high jank percent is reported on a page with very low percent > of dropped frames. > > Bug: 1133058 > Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812988} TBR=sadrul@chromium.org,jonross@chromium.org,mjzhang@chromium.org Change-Id: I3f79f32c75d7e0638f782913b12a4c4be10260d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443732Reviewed-by:
-
Ioana Pandele authored
Due to the fake running state emitted by the bulk check service when it detects that there are no saved passwords, the error is overwritten by Running -> Idle. This CL ensures that when transitioning to Idle, the check manager verifies whether there were any passwords to check and if not, it emits a NoPasswords error message. Bug: 1132880 Change-Id: I134bb010de7efe3739b213a18c5b7f4a4aee42fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440841Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#813101}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I1ef07c4ce3e6747137d79d973bcf84684eb155b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442539 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813100}
-
Richard Knoll authored
Extends the following useful metrics for this launched feature: - Sharing.ClickToCallAppsToShow - Sharing.ClickToCallDevicesToShow - Sharing.ClickToCallDialerPresent - Sharing.ClickToCallDialogShown - Sharing.ClickToCallSelectedAppIndex - Sharing.ClickToCallSelectedDeviceIndex Removes collection of these metrics as the data is not used: - Sharing.ClickToCallPhoneNumberPrecompileTime Bug: 1125769 Change-Id: I28fdeff408c4326f13dddaacbf9266b82452761d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440838Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813099}
-
David Roger authored
clearAllCachedAuthTokens() cleans up the Identity API state allowing the extension to implement the sign-out functionality. clearAllCachedAuthTokens() removes the following data associated with the extension: - Gaia id of an account used in getAuthToken() - All entries in the token cache - Cookies in the web auth flow storage partitions Bug: 1125847 Change-Id: I95173b0f264d45c5c1222e709594ebc7062d0ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398919Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Martynas Sinkievic authored
Add functions which support validating and parsing the JSON matching pattern configuration string into a format supported by |PatternProvider|. Also provide support for versioning and replacing the configuration in |PatternProvider|. Due to the nature of the change, |PatternProvider| was changed to support testing with a synchronously loaded configuration. Change-Id: I662ecb933a4067c0ee6d188defe5e982b85469a7 Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359990Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#813097}
-
Andrew Shulaev authored
Couple of usages seem to use the callback multiple times, thus base::RepeatingClosure is used in these places. Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I3bc08d2a1b9149eeaaa0386f05334b04697be40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440581 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=1121162 TBR=pastarmovj@chromium.org NOTRY=true Change-Id: I2b19fff83f5a8372504854f93c2fd1221afdbba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444311 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Adam Rice authored
The recent fix to stop resetting the stream after close probably deflaked this test. It is not flaking on the CQ. Re-enable it. BUG=1064434 Change-Id: Ibdce899968aa144a6acafc2481245c1b2173898f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442913Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#813094}
-
Greg Thompson authored
This reverts commit 2af0583b. Reason for revert: consistent CaptureModeTest.WindowCapture failures in ash_unittests (e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20786) Original change's description: > capture mode: window capture change. > > In window capture mode, the user should be able to interactively select > a window to capture. when the to-be-captured window's bounds or state is > changed, we should update the capture region to reflect the change as > well. > > Other changes that is worth mentioning in this CL: > - Window stacking order or activation order will not be changed by the > capture window selection change > - If current selected is closed/minimized or becomes invisible, we > automatically select another window under mouse/touch event location. > and if there is no such window, do nothing. > - If another window is activated when a window is selected, if the > activated window is under mouse/touch event location, it will be focused > instead. > - When a mouse moved over a selectable window, change its cursor to > either capture icon or recording icon > > Bug: 1127526 > Change-Id: Icfdbed419dadfe0301b60da693f01010f4a2da2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812976} TBR=xdai@chromium.org,afakhry@chromium.org,newcomer@chromium.org Change-Id: I4f2f3c21ae546ca1442a29d95b58f11f4da3b43f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444990Reviewed-by:
-
Klaus Weidner authored
This adds the needed changes to use dynamic viewports for the ARCore WebXR device, and opts in to using that. It also changes the texture MAG filter used when enlarging a texture to use LINEAR interpolation. This should also be beneficial when using a custom framebufferScaleFactor independent of dynamic viewport scaling to avoid pixelation artifacts. Bug: 1133381 Change-Id: I442124de1090f971edbc822dd3ba8550301c2e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436683 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#813092}
-
Alexandre Courbot authored
When using DMABUFs, it is preferable to use the same V4L2 buffer with the same underlying buffer, as failure to do so results in memory unmappings/remappings in the driver. Use the newly introduced buffer affinity tracker and V4L2Queue::GetFreeBufferForFrame() method to achieve this transparently in the image processor. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I9df69431d0e532c40c0f49ca4e3bb31843b0814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413946 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
