GitLab

- Deletes favicon logic in bookmarks and just calls FaviconForUrl to retrieve favicon.
- Adds TouchIconFromGoogleServer() for all Google Server requests made by FaviconLoader to ensure they stay in the database longer.
- Removing LargeIconService request cancel logic, since it was deemed an unnecessary complexity (https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit)

Change-Id: Ib44d53e4d50ac27c2871bb7916370fc9ccfe6380
Reviewed-on: https://chromium-review.googlesource.com/c/1262414
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599041}

In principle a user should never be in the subpage without a host set
so we didn't bother to put in a default for the case of no set host
when we made the page in the first place. However, this seems to be
causing a11y test failures, so we are using the label text for the
settings main page which is exactly what we want (i.e. the host name)
when the host is set. In other words, this should look the same to the
user.

Change-Id: I03ddf0cd298d9ca8eb832e14cff354c419d5acb6
Reviewed-on: https://chromium-review.googlesource.com/c/1277680Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599040}

The WKWebView frame relative to the image frame has been changed; so
update the touch location.

Bug: 894597
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9
Reviewed-on: https://chromium-review.googlesource.com/c/1277831Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599039}

Transient Crostini windows are supposed to be filtered from the shelf,
but we are checking for a transient parent on window Init, which is
before it actually gets set. This was causing a UAF on profile switching
as MultiUserWindowManagerChromeOS::SetWindowOwner() is not supposed to
be called with transient windows.

Bug: 845843
Change-Id: Iec7b48cb03fff22775c31ce08c398ba750836463
Reviewed-on: https://chromium-review.googlesource.com/c/1266475
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599038}

When a touch event is not handled, WindowEventDispatcher will generate
gesture events from it. However, when those gesture events are marked as
handled that handling doesn't propagate back to the original touch
event.

For bug 852241, the hamburger menu only handles gesture events. On
Windows, selecting an option with a touch would cause the hamburger menu
to close, but because the touch event wasn't marked as handled Windows
would pass it along to the underlying window, causing it to gain focus.
Most of the time it would be gaining focus anyway (since the hamburger
menu just closed) so this isn't noticeable, but the Cast dialog is a
newly-added surface that closes if it loses focus. In this case, it
seems to not appear at all.

Similarly for bug 866421, when the guest window becomes restored it
reveals the window underneath and then Windows passes the event along,
giving it focus.

This patch marks all touch released as handled by default, which
prevents Windows from ever propagating them. These events generate the
tap gestures that cause the state change in the hamburger menu and
window size in the above bugs.

Bug: 852241, 866421
Change-Id: I10a67d56fdc46d5b91282e0f395c895339f71951
Reviewed-on: https://chromium-review.googlesource.com/c/1260507
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599037}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/865321239f56..55ac0aa2f68f


Created with:
  gclient setdep -r src-internal@55ac0aa2f68f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8570cdea9745766fdfb3c8f741685c81d8850ad4
Reviewed-on: https://chromium-review.googlesource.com/c/1277761Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599036}

Make the chrome.autotestPrivate API's getHistograms function
call content::FetchHistogramsAsynchronously() and
base::StatisticsRecorder::ImportProvidedHistograms() to
fetch and incorporate histogram data from other processes,
similar to what chrome://histograms does.

Without this, the function (which is called over the Chrome
DevTools Protocol by Chrome OS integration tests) serves
stale data. For example,
Media.GpuVideoDecoderInitializeStatus samples are missing
since that histogram is recorded from renderer processes.

Bug: 893937
Change-Id: Id6415f1a32b41ad7ddeb251216f09b2314eb5980
Reviewed-on: https://chromium-review.googlesource.com/c/1274892
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599035}

In r597543 we introduced a performance regression
due to the changes in LayoutBoxModelObject::RelativePositionOffset().
One of the main differences is that AvailableHeight|Width()
was called always as part of the method,
while that was not the case before.

This patches moves the calls to AvailableHeight|Width()
to the moment where they are needed, trying to minimize
the impact in performance and come back to previous numbers.

No new tests as it's already covered by existent ones.

BUG=893884,835607

Change-Id: Id8aaba4736a821af9f401492206840c12a2be0e6
Reviewed-on: https://chromium-review.googlesource.com/c/1273117
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#599034}

https://chromium.googlesource.com/angle/angle.git/+log/956ab4d9fab3..f2ed299569c0


git log 956ab4d9fab3..f2ed299569c0 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 oetuaho@nvidia.com Add support for EXT_texture_compression_bptc


Created with:
  gclient setdep -r src/third_party/angle@f2ed299569c0

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Iba0b0ee4efdbd58c43377f5d51954311efa4f5b5
Reviewed-on: https://chromium-review.googlesource.com/c/1277760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599033}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic83a2e5e50d2c992b394098a78add327d973ce34
Reviewed-on: https://chromium-review.googlesource.com/c/1276847
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599032}

Bug: 867488
Change-Id: If8b99bc2e5c4636ed42d5e68d9e08dc099e8bb27
Reviewed-on: https://chromium-review.googlesource.com/c/1277818Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599031}

In the case of a corrupt media files where tracks are not unique, we
need to ensure that map entries are. It isn't sufficient to let ffmpeg
handle this, since it will sometimes report duplicates:
https://clusterfuzz.com/v2/testcase-detail/6184666533724160?noredirect=1
where both the audio and video track have a default track_id of 1.

Bug: 877847
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7e2bc16b39c5d23e9310463c54c9f3cba8bdbfa5
Reviewed-on: https://chromium-review.googlesource.com/c/1269446
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599030}

Updates OOBE update screen to handle
UPDATE_STATUS_NEED_PERMISSION_TO_UPDATE update status. This status is
reported update engine when a new version is found while attempting
an update over cellular connection. To proceed with the update, a user
permission is required.

This updates the OOBE update screen to show a message informing the
user that an update is required, and that updating over cellular might
cause coverage charges. If the user clicks back, the OOBE goes back to
the network selection screen. If the user clicks next, the update
engine is informed of the user permission, and update is attempted
again.

BUG=889948

Change-Id: Icff7a77043677f2fa87dac916e0a2030ade5f728
Reviewed-on: https://chromium-review.googlesource.com/c/1272808
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599029}

CanAccessDataForOrigin currently calls GetSiteForURL() to determine
what should be checked against the process's origin lock.  This isn't
entirely accurate, as GetSiteForURL() defaults to using effective
URLs, which we don't want to use for comparing origin locks.
Fortunately, we also pass in null for browser_context, which
effectively avoids effective URL resolution:
ChromeContentBrowserClient::GetEffectiveURL returns back the original
URL in that case.  This CL change this call to use
DetermineProcessLockForURL() instead, which is more correct.

This CL also removes a stale comment about hosted apps not being able
to set cookies.  That is no longer true, since we now lock hosted apps
to their underlying web origin, which doesn't get in the way of IO
thread enforcements.

Bug: 160576, 718516, 794315
Change-Id: I092e9bf89b3a9fc5807824bbe51d1de6589ddae3
Reviewed-on: https://chromium-review.googlesource.com/c/1276560
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599028}

The FloatRect version of EnclosingLayoutRect shows up rather prominently
in profiling data for both layout and LayoutNG, particularly in the font
metrics and text shaping code. This change reduces the time spent in the
method by half by avoiding overhead and allowing it to be inlined.

Change-Id: Ica28d6a41edf476619f581c2ff2d9471d13f7c12
Reviewed-on: https://chromium-review.googlesource.com/c/1277597Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599027}

Make Files app select "My files" when there are no available volumes,
this to allow Files app to behave properly when volumes subsequently
become available.

Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
non-null |displayRoot| before trying to change to |displayRoot|. This
fixes the error "Cannot read property 'getParent' of null" when Drive
volume becomes available before Downloads volume, which is the default
volume/root.

Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
DriveFsTestVolume can re-mount itself.

Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
Bug: 893161, 884967
Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
Reviewed-on: https://chromium-review.googlesource.com/c/1272418Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599026}

This CL improves the json parse error shown to the user for the declarative net
request ruleset file by prepending it with the ruleset filename.

BUG=None

Change-Id: I3cc907b6223745dd94ae71e78216105d2317ae43
Reviewed-on: https://chromium-review.googlesource.com/c/1275137
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599025}

Reason: When the user browses in guest window the sync service and identity
manager are not available.

Bug: 894377
Change-Id: I8dd48d39f51d54230e7db8ec34bdbb9abd065530
Reviewed-on: https://chromium-review.googlesource.com/c/1277814
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599024}

https://pdfium.googlesource.com/pdfium.git/+log/bfc5f6011dd4..c7f66edd2244


git log bfc5f6011dd4..c7f66edd2244 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 xlou@chromium.org Add functions to get/set ArtBox.


Created with:
  gclient setdep -r src/third_party/pdfium@c7f66edd2244

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:409670
TBR=dsinclair@chromium.org

Change-Id: I5a719678fc11806192a521aa7d38281790c990f2
Reviewed-on: https://chromium-review.googlesource.com/c/1277759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599023}

ContextMenuPopulator was not being wrapped in TabContextMenuPopulator
when a Tab is reparented to a new activity. This may have observers
miss the event |onContextMenuShown|. This CL fixes it.

Change-Id: I1ff2f62adabf44f033202880044b697280869091
Reviewed-on: https://chromium-review.googlesource.com/c/1272637
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599022}

This patch means fix order of arguments
according to BackgroundFetchServiceImpl::UpdateUI().

Change-Id: I6cb0d836aed2fef2862d7ee00eddfff1620c7187
Reviewed-on: https://chromium-review.googlesource.com/c/1261838Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#599021}

Create an UpdateExistingAccessPointRlz function to convert the rlz
strings with dynamic brand code.

Bug: 846033
Change-Id: I1af461d7b617728e52f33b20d1b4ea66085978e2
Reviewed-on: https://chromium-review.googlesource.com/c/1263047
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599020}

It is possible for the first part of the discard padding to be non-zero
when fixing up negative timestamps. This causes a DCHECK crash.

This CL fixes the issue by removing the DCHECK and keeping the max
values of pre-buffer discard padding in the relevant code branch.

Bug: 820825
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idaceff2188b1e88c97285bf8f571042e936d0797
Reviewed-on: https://chromium-review.googlesource.com/c/1277809
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599019}

This reverts commit 65fa1aac.

Reason for revert: Suspect this broke linkedin login credentials.  BUG=894454

Original change's description:
> Reland "[perf] Add browse:media:tumblr:2018 system health story"
> 
> This reverts commit c64ae579.
> 
> Original change's description:
> > [perf] Add browse:media:tumblr:2018 system health story
> >
> > This also add a login helper for tumblr and updates credentials.json
> >
> > Bug: 878390
> > Change-Id: Iba56faf550cb638692899326b217347e04be9932
> > Reviewed-on: https://chromium-review.googlesource.com/c/1256883
> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#596763}
> 
> Change-Id: Ib40cc4b8c7f2fe4d23fe3effd285122e703d1601
> Reviewed-on: https://chromium-review.googlesource.com/c/1264382
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598715}

TBR=ulan@chromium.org,perezju@chromium.org,nednguyen@google.com

Change-Id: I8edcf9a3ea4fc2b9fd72cdd5c9f4545bf3a81ca3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1278466Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599018}

Add some of the timing metrics for the main frame resource to UKM.
Doc: http://shortn/_zTLLhP8F44

Bug: 893923
Change-Id: I7e8dde92e952709fd7a13b50d7912f1fb2afb8ba
Reviewed-on: https://chromium-review.googlesource.com/c/1274464
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599017}

Bug: 875452
Change-Id: I5832a08ed1f13745e46fe64af8d4a61aa6ddb9db
Reviewed-on: https://chromium-review.googlesource.com/c/1278126
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599016}

Previously we would listen to a blur event coming out of the HTML editor
to know when to commit the text. To prevent an internal focus change
we would cancel mousedown events inside the editor. This confused
codemirror, which expects focus to have moved after a right click
and messed up its text selection color.

This patch removes the mousedown canceling, and checks relatedTarget
on the focus event to only commit when focus leaves the editor.

Bug: 894372
Change-Id: Id29f26c75d9f5a12c52679c3cd947987d2b8779e
Reviewed-on: https://chromium-review.googlesource.com/c/1277810
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599015}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/68ad72ca9535..1c128aa9efd9


git log 68ad72ca9535..1c128aa9efd9 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 alanbaker@google.com Validating for new image operands


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@1c128aa9efd9

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I28131468de97d2131d1da0a815e0e4813efc044f
Reviewed-on: https://chromium-review.googlesource.com/c/1277756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599014}

The documentation for TabRestoreService Observer says that
the following callback is invoked whenever the set of entries
changes in some way. But it is not called when an entry is removed.

// Sent when the set of entries changes in some way.
virtual void TabRestoreServiceChanged(TabRestoreService* service) {}

This CL invokes the callback on removal.

Bug: 872303
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ieaca58c62f7281f72eec73b2bef8804522619e0f
Reviewed-on: https://chromium-review.googlesource.com/c/1277646Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599013}

Fixed other JavaScript exceptions.

Test: Launch Chromium with --enable-benchmarking and timer extension
Bug: None
Change-Id: I48fba226f24fad1908254b3065a770e106d8c4a0
Reviewed-on: https://chromium-review.googlesource.com/c/1278044
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599012}

This CL adds required changes to quick_unlock code to allow further integration
into First run UI.

Bug: 852553
Change-Id: Ica3a431c1c24d3f6c658695c8c333a11f528245a
Reviewed-on: https://chromium-review.googlesource.com/c/1247261
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599011}

Bug:89479

Change-Id: Idf1bafd3601041a7b806d794cbac3af9df5dc621
Reviewed-on: https://chromium-review.googlesource.com/c/1275585
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599010}

As BLE pin entry model and BLE device selection model will be added to
WebAuthN UI. AuthenticatorReference -- which is currently defined in
AuthenticatorRequestDialogModel -- will be referenced in both
of these models. To simplify dependency relation between these UI models
and AuthenticatorRequestDialogModel, factor out AuthenticatorReference
to its own class. More specifically this CL does the following:

a) Refactor AuthenticatorReference to its own class.
b) Make AuthenticatorRequestDialogModel own unique_ptr of
   AuthenticatorReference to make ownership explicit.
c) Delegate logic of creating/removing AuthenticatorReference objects
   to AuthenticatorRequestDialogModel as UI models likely needs to be
   notified of this event in following CL's implementations.

Bug: 877344
Change-Id: I8cb8dfe634216385c2f09e19ed5dce7bbd592f78
Reviewed-on: https://chromium-review.googlesource.com/c/1262639
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599009}

This reverts commit 475bfe9d.

Reason for revert: SingleClientCustomPassphraseSyncTest.CanDecryptScryptKeyEncryptedDataWhenScryptNotDisabled and SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData are failing on "Win 7 Tests (1)":
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84570

Original change's description:
> [sync::test] Add single client integration test for custom passphrase
> 
> Add a Sync integration test which exercises custom passphrase flows, including
> the handling and proper functioning of the newly added key derivation method
> (scrypt).
> 
> Add an integration test helper file for encryption-related tasks and modify
> FakeServer and LoopbackServer to allow easier modification of persistent
> entities such as Nigori. Add passphrase-related functionality to
> ProfileSyncServiceHarness to give tests better control over how and when
> passphrase-based encryption is enabled.
> 
> The test uses a gray-box approach, where it tests the client at the
> ProfileSyncService granularity, but injects and inspects entities on the (fake)
> server to ensure that encryption is performed properly. This is necessary
> because, when it comes to encryption, we are not interested merely in that it
> does not hinder existing functionality (e.g. two clients are syncing data
> properly in the presence of a custom passphrase), but also that it provides the
> expected security to the user. For this reason, we use our knowledge of the
> encryption architecture internals to ensure that the data committed to the
> server is encrypted in the expected way.
> 
> Bug: 894148
> Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
> Reviewed-on: https://chromium-review.googlesource.com/c/1274205
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598912}

TBR=treib@chromium.org,vitaliii@chromium.org,davidovic@google.com

Change-Id: I8de4a278a66f4162c29b175b96573acf96dbe1ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894148
Reviewed-on: https://chromium-review.googlesource.com/c/1277834Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599008}

While ARC IME shows up, the back button is used for hiding the virtual
keyboard. This CL rotates the back button while ARC IME shows up to
align with the behavior.

Bug: 845079, 894362
Test: Ran on DUT
Change-Id: Ib96249fa7e9cae23b6b6810780b30c00ba4874c8
Reviewed-on: https://chromium-review.googlesource.com/c/1275987Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599007}

Bug: 864820
Change-Id: I95e766486f718459fa649d7df7b8abd61299b61b
Reviewed-on: https://chromium-review.googlesource.com/c/1268997Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599006}

bug: 871674

Change-Id: Iff106b455e672271b002bcfcec3bcebcdc735207
Reviewed-on: https://chromium-review.googlesource.com/c/1275728Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599005}

KeyboardLockInteractiveBrowserTest.CancelActiveKeyboardLockBeforeFullscreen
has been flaky for a while. Debugging this, I've realized that
this is essentially due to crbug.com/891489 -- a Ctrl-T creates
tab twice, which exceeds the expected tab count and waiting
doesn't stop.

BUG=891489
TEST=none

Change-Id: I3e655cfab9e1797149a76ab06d1f5bfc8d8b2118
Reviewed-on: https://chromium-review.googlesource.com/c/1278265Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599004}

Update docs to reflect the fact that libFuzzer has been ported to
Windows and is now supported there in Chrome.
Also fix miscellanious issues such as wording, capitalization, line
breaking at 80 chars and make examples more windows friendly (remove
enable_nacl=false since it doesn't seem to do anything and add
is_component_build=true since it is needed on Win.

Bug: 892754
Change-Id: I4c3c2aa9a7bd13b5b29b7c0094473e27a4edfbfb
Reviewed-on: https://chromium-review.googlesource.com/c/1277688Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599003}

This CL skips no display desktop files when trying to find an app ID
with wmclass. Some apps create some no display entries and they cause
the current logic to unable to uniquely identify an app entry from the
registry.

BUG=chromium:893690
TEST=Manually verified on an eve device.

Change-Id: I88f24f87d9af125032ea82fd21f8a7b97f3ca998
Reviewed-on: https://chromium-review.googlesource.com/c/1277679Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599002}