- 02 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2d9abef043b..c488f0c909e2 2020-10-02 jmadill@chromium.org Suppress flaky test on Win/Intel/GL. 2020-10-02 vantablack@google.com First pass at increasing inclusivity 2020-10-02 j.vigil@samsung.com Implement GL_OES_texture_stencil8 2020-10-02 jmadill@chromium.org Disable AMD OpenGL testing on Windows ANGLE tests. 2020-10-02 cclao@google.com Vulkan: Add a test and fix the bug with draw/invalidate/clear 2020-10-02 jmadill@chromium.org Skip ResizeWindowWithDraw test on all Linux. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1097198 Tbr: jonahr@google.com Test: Test: angle_deqp_egl_tests Change-Id: Ifc582e7ac5d4b95be03d4637bac147332970f54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813432}
-
Natalie Chouinard authored
These render tests had breaking UI changes introduced in https://crrev.com/c/2424506 and should have been re-baselined by incrementing the revision number (see https://crbug.com/skia/10795). Bug: 1131073 Change-Id: Idf9df5d43a6da8c80ae0c7ac5d1dcc0e88b59b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443400Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813431}
-
Etienne Bergeron authored
This CL is adding unittests for the Pause(...) and Resume(...) API. Fix potential bugs while calling pause/resume multiple times. The underlying platform implementations may not accept double pause or double resume. The related code pause/resume was not covered by previous unittests. Bug: 1133813 Change-Id: I396bed4e2356a3b4bcb8363f0f82d005436022bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446190 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813430}
-
Peter Kvitek authored
Adding this flag prevents sandbox_type.cc complaining about valid sandbox configuration missing in a command line. Change-Id: I076aaf51411c187e36f3b08f6eb5e50199b2b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446656 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813429}
-
Meilin Wang authored
This CL fixes the issue where the bubble size doesn't get updated after switching to another content view possibly with a different size. Screenshot before this CL: https://screenshot.googleplex.com/4GN26KQ6QC6jyo4.png BUG=1106937,1126208 Change-Id: Ie6dda62d93f4d1e5c09212426e8b55bfc5d30cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446773Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813428}
-
James Hawkins authored
This is necessary because Polymer 3 infra does not support flattenhtml. R=khorimoto@chromium.org Bug: none Test: OS Settings -> Networks -> Add Network -> See add wifi icon Change-Id: I8957b3d60aad33e13a785d2fef15922c10218abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446522Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#813427}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/data_reduction_proxy This CL was uploaded by git cl split. R=tbansal@chromium.org Change-Id: Idf2ab419bf07cd41493076a887390d93c1f8266a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435582 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813426}
-
Aaron Colwell authored
Moving logic from SiteInstanceImpl::ShouldLockProcess() and SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() into SiteInfo, because these functions derive most of their behavior from information in the SiteInfo. These functions also represent what the process model should to with specific SiteInfos so it feels like these should be more closely associated with SiteInfo instead of SiteInstanceImpl. This change does not change any behaviour. - Moved SiteInstanceImpl::ShouldLockProcess() to SiteInfo and renamed it to ShouldLockProcessToSite() to make it a little more clear that this method indicates which SiteInfos should cause "is_locked_to_site" ProcessLocks to be used. - Moved SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() to SiteInfo and renamed it to RequiresDedicatedProcess(). - Renamed ContentBrowserClient::ShouldLockProcess() to ShouldLockProcessToSite() and updated overrides so that naming is consistent. Bug: 1085275 Change-Id: Iaf9c036c3fe6d274640ee08377ce2e2fcca3d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427864 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#813425}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/77107392837f..8e5f2c0fe3e8 2020-10-02 jophba@chromium.org Speed up YABV tests by using smaller array of sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Idf73bbf68a4e8ad48d590c6ea4e00359170537df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813424}
-
Dave Tapuska authored
This moves the creation of the LayerTreeFrameSink into WidgetBase while minimally exposing some APIs on the blink platform. This allows us to move the android synchronous compositor frame sink also to be inside blink. BUG=1097816 TBR=tommycli@chromium.org Change-Id: Ie86b6923cb7cae2505d32ee922c5d03bb8198dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429224 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813423}
-
Siyu An authored
Bug: 1112095 Change-Id: I614ec70d4ba183850cd19412c963bd344b7c318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444800 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#813422}
-
Orin Jaworski authored
This CL includes data fixes for several languages to improve Pedal triggering. Issues resolved include: Stray capitalization, duplicate synonyms, synonyms consisting entirely of a single dash, separators consisting only of a single dash, empty cell gaps, and synonyms consisting entirely of ignore group synonyms. Bug: 11347706 Change-Id: Iabc8099db437e518ef2deea34fd41329985e5b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446823Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813421}
-
Jimmy Gong authored
Fully implements the DoNotDisturbController. This class is responsible sending and receiving states in regards to the DoNotDisturb feature of the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I6a4fa96de5920711a7534ae7eff8bb33b9bb35b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439777 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813420}
-
Yi Gu authored
Currently when an SmsService has unhandled request upon destruction, e.g navigating away, we record "Timeout" as an outcome. This is misleading because "Timeout" should refer to the user consent prompt being timeout. This patch renames Timeout to UnhandledRequest and the follow up patch crrev.com/c/2427560 records the right Outcome.Timeout. Bug: 1127397 Change-Id: I151d5f087c416136bc042d12086df3185dbf2b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424894Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813419}
-
Hung Vu authored
This CL handles unit test for shouldSuggestDownloadLocation in DownloadDialogUtils. Change-Id: I39442ffe032550631c8f47f6ecc49529b489903c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446518 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813418}
-
Ben Pastene authored
Adds a `mb.py train` command that will dump json files for every builder (one file for each master) to a specified dir. And hook up `mb.py validate` to also validate the expectations. This won't actually generate the expectations. For now it's silently skipped if the expectations dir doesn't exist. Will create it in a follow-up. To see what the expectations would look like, see patchset 5: https://chromium-review.googlesource.com/c/chromium/src/+/2378273/5 Bug: 1117577 Change-Id: Iaa7be9201d26fe331620f0d666a03a6adbaa2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378273 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#813417}
-
Elly Fong-Jones authored
These methods express that the caller is passing in ownership of the delegate, and assert that the delegate believes it is owned by the widget. This change also corrects a flaw in ownership handling in an ash unittest: some of the created delegates were passed around as raw pointers, and one was sort of leaked (not actually leaked, but destroyed in an extremely non-obvious way). Bug: 1075649 Change-Id: I655dfe3e2466032b85247341f43b1b2d75c0b561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446015Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813416}
-
Peter Kasting authored
Also addresses c/b/ui/views/{read_later,web_apps}/. Bug: 772945 Change-Id: I71a0bb167c8eefb19624240536ca1d98dd2bfb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446022 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#813415}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d696086211d..a6ca9757d3a6 2020-10-02 brianosman@google.com Let skslc use more of Skia's core 2020-10-02 johnstiles@google.com Factor out Inliner candidate list assembly into its own function. 2020-10-02 brianosman@google.com Detect non-2D textures in MetalCodeGenerator and fail cleanly 2020-10-02 brianosman@google.com Fixes to array handling and interface blocks 2020-10-02 bsalomon@google.com Remove unused SkImage YUVA factories. 2020-10-02 fmalita@chromium.org [skottie] Auto-resize and VAlign support for point text 2020-10-02 egdaniel@google.com Remove some unneed read access from vk srcAccessMasks. 2020-10-02 ethannicholas@google.com Revert "Revert "moved SkSL FloatLiteral data into IRNode"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I2d8fe59a3c7347c5d1b8b6956f901edfc771c330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b9855ccf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic0381cd6dce3b49b5a10d911030b0c7effdbf94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446819Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813413}
-
Zentaro Kavanagh authored
- One test file was missed from CL [1] that split up tests [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2442502 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5d52dbcc4b6e90fa8b22a059471167f6d10ef0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446389 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813412}
-
Andre Le authored
- Change the status order in the controller. - Use setter function for find my device status. BUG=1106937 Change-Id: I628512f3b13362acc69982a8df48c0e2ada23658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446969Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#813411}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ida267e2a5dfa7b70d0ea25e5a91a4a6cceafe555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446833Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813410}
-
David Bertoni authored
Bug: 1133034 Change-Id: Iec185526bfa222e601252d9a0e1e7cedde2988cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437307Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813409}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4036e35e8d8d8737a327d6133a193c810eb8e929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382595 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#813408}
-
Sinan Sahin authored
When ContextMenuHelper#setPopulatorFactory is called, the current ContextMenuPopulator is destroyed. If a context menu was showing when dismissed after the populator is destroyed. This is because the populator is accessed when the context menu is dismissed. This CL holds a reference to the current context menu and dismisses it in #setPopulatorFactory. Bug: 1133172 Change-Id: I879a4278c045c3a4c9028b9b4825b5cd497a5e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446775Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#813407}
-
Ionel Popescu authored
The eye dropper test run close to (and sometimes exceed) the 60s timeout limit on MSAN builds. This is similar with other tests that are using the color picker[1]. This change marks the test as slow to avoid timeouts on the MSAN trybots. [1]: http://crrev.com/c/2330086 Bug: 1134580 Change-Id: Ica5b48dd7690a91c507e5c2517e985599333741b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446194Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813406}
-
Sadrul Habib Chowdhury authored
If shared-memory allocation for smoothness-ukm data fails, then handle that error gracefully, rather than crashing out. BUG=1134659 Change-Id: I309e478ce112d9e0303d7aea6619260abac0cfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446929Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#813405}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b494582b95e5..d82d30da43cd 2020-10-02 chonggu@google.com [Fuchsia] Remove fuchsia-ssh-config-dir flag. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133039 Tbr: oysteine@google.com Change-Id: Ia2a835b441e55fe925e94c3413de7806ce7384c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813404}
-
Ben Wagner authored
Skia is removing the old display globals. Chromium is the remaining heavy user of these globals; defining this macro will preserve the existing behavior until Chromium can be updated to no longer use them. Change-Id: I509b6333ea39c60e0b0aab1817513f4f895121a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446776Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d81cd72..f38f24c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib76db6cefac6a5ab0369236fbfc9f02ee6b33ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813402}
-
Jonah Ryan-Davis authored
These tests began failing on Sep 21: conformance/textures/misc/copy-tex-image-2d-formats.html conformance/misc/uninitialized-test.html conformance/textures/misc/copy-tex-image-and-sub-image-2d.html Bug: chromium:1134756 Change-Id: I788ab772a1ee8c5159366404e37abc30a412744d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446654 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813401}
-
Jeffrey Young authored
BUG=none Change-Id: I31c164b88d0724d333b2861ab83cbc1f8b76a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445631Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813400}
-
Yuly Novikov authored
Makes them consistent with other GPU builders. Bug: 1123215 Change-Id: Iff4b08b496bf41df37c9d2fb78dc633a98b633ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446558Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813399}
-
Xiaoqian Dai authored
In window capture mode, the user should be able to interactively select a window to capture. when the to-be-captured window's bounds or state is changed, we should update the capture region to reflect the change as well. Other changes that is worth mentioning in this CL: - Window stacking order or activation order will not be changed by the capture window selection change - If current selected is closed/minimized or becomes invisible, we automatically select another window under mouse/touch event location. and if there is no such window, do nothing. - If another window is activated when a window is selected, if the activated window is under mouse/touch event location, it will be focused instead. - When a mouse moved over a selectable window, change its cursor to either capture icon or recording icon Bug: 1127526 Change-Id: I6cf2abce18e1c38f06dfc3b7def3280b9fd8de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#812976} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446590 Cr-Commit-Position: refs/heads/master@{#813398}
-
Zhenyao Mo authored
BUG=1109268 TEST=gpu_unittests R=kbr@chromium.org,bbudge@chromium.org Change-Id: Ib30e393d223834bea48eebadb8f465fb74a92925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446532Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813397}
-
Tim Song authored
BUG=1106937,1126208 Change-Id: Ic8178b1c481db1b74a9abd775f8e98b30d81e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444126 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813396}
-
Ben Kelly authored
This CL enables a feature to move cache_storage operations off the IO thread and onto a sequence instead. This feature has previously launched on all other platforms. It has been held back until now on ChromeOS due to some measured performance regressions. After a couple months of experimentation we have not been able to shift the regressions. It appears there is just measurable delay from the additional task that is run when mojo messages are targeted off the IO thread. There is not a lot we can do about this unfortunately. The regression show up in cache match time and body reading at P95. Top level UMA such as FCP, however, are neutral. Architecturally we are motivated to launch this in spite of the regressions. We do not want to support multiple threading models into the future. In addition, cache_storage can interfere with other parts of the browser that also need to use the IO thread via mojo message passing. Therefore this CL proceeds with enabling the feature. Bug: 960012 Change-Id: Ie9d5931ce9530dafe101d209a13f65ff22dffddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441125Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#813395}
-
Antonio Gomes authored
chromeos::TabletState is the singleton that actually holds the information about the current TabletMode state. The state getter method is public, but its setter is not. The idea is that only a handful of classes can actually set the state, eg ash::TabletModeController. In the future, Lacros will also be able to create a chromeos::TabletState instance and set the tablet mode state via the (upcoming) use of `zcr_remote_shell` Exo protocol extension. BUG=1113900 R=jamescook@chromium.org Change-Id: I2ec77e7f038095b7e4f9c776683993f6b30c409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443219 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813394}
-
Bruce Dawson authored
thread_watcher_report_hang.cc has various unique functions which are designed to be on the call stack when hangs are reported. Guaranteeing this requires making all of the functions unique and inhibiting tail calls. The tail call inhibiting was only applied to two of the functions so this change applies it to the other two (commented out in one of them) and adds the NOT_TAIL_CALLED attribute to the function they all call. This attribute makes the ordering in the functions irrelevant but there is no cost to having belt and suspenders, so why not? This completes the work of crrev.com/c/1373878. Bug: 905288, 1032679 Change-Id: I383cc3453ab2f506017de1143bc8f3666ed38a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443891Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#813393}
-