GitLab

This patch introduces a HashSet to track custom property additions
when constructing PropertySets, so that duplicates are excluded.
This already happens for standard properties, but is tracked for
them by a BitArray.

Review URL: https://codereview.chromium.org/1709843002

Cr-Commit-Position: refs/heads/master@{#376134}

Bootstrap didn't work due to recent modifications in base.
Unfortunately some new dependencies are required on OSX
and that required adding generated_build_date.h to be
available separately for the bootstrap process.

Tested on Linux and OSX.

BUG=None
TEST=./tools/gn/bootstrap/bootstrap.py
R=brettw@chromium.org,tfarina@chromium.org

Review URL: https://codereview.chromium.org/1692303004

Cr-Commit-Position: refs/heads/master@{#376133}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/427f2503f2ae..14d7b1b3fd8c

$ git log 427f2503f..14d7b1b3f --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1706153002

Cr-Commit-Position: refs/heads/master@{#376132}

Revert of SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager (patchset #6 id:100001 of https://codereview.chromium.org/1700943003/ )

Reason for revert:
Speculative revert as Chrome sheriff. I suspect that this CL causes tons of tests on Mac to fail. See e.g. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/19690

Callstacks in all failing tests contains references to SafeBrowsing.

1   libbase.dylib                       0x00000001195efbc3 _ZN4base5debug10StackTraceC1Ev + 35
2   sync_integration_tests              0x000000010a77225a _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC2Ev + 58
3   sync_integration_tests              0x000000010a757783 _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC1Ev + 35
4   sync_integration_tests              0x000000010a757739 _ZN29SystemURLRequestContextGetterC2EP8IOThread + 105
5   sync_integration_tests              0x000000010a7577db _ZN29SystemURLRequestContextGetterC1EP8IOThread + 43
6   sync_integration_tests              0x000000010a75c9a6 _ZN8IOThread24InitSystemRequestContextEv + 246
7   sync_integration_tests              0x000000010a75c866 _ZN8IOThread33system_url_request_context_getterEv + 358
8   sync_integration_tests              0x000000010a9b7cae _ZN18BrowserProcessImpl22system_request_contextEv + 270
9   sync_integration_tests              0x000000010b1c0e55 _ZN13safe_browsing19SafeBrowsingService10InitializeEv + 101
10  sync_integration_tests              0x000000010a9bc17b _ZN18BrowserProcessImpl25CreateSafeBrowsingServiceEv + 331
11  sync_integration_tests              0x000000010a9bbfe3 _ZN18BrowserProcessImpl21safe_browsing_serviceEv + 275
12  sync_integration_tests              0x000000010a8acf61 _ZN36ChromeResourceDispatcherHostDelegateC2Ev + 177
13  sync_integration_tests              0x000000010a8ad1d3 _ZN36ChromeResourceDispatcherHostDelegateC1Ev + 35
14  sync_integration_tests              0x000000010a9bcda5 _ZN18BrowserProcessImpl29ResourceDispatcherHostCreatedEv + 117
15  sync_integration_tests              0x000000010a6141c0 _ZN26ChromeContentBrowserClient29ResourceDispatcherHostCreatedEv + 320
16  libcontent.dylib                    0x00000001212ba928 _ZN7content26ResourceDispatcherHostImplC2Ev + 1320
17  libcontent.dylib                    0x00000001212baf63 _ZN7content26ResourceDispatcherHostImplC1Ev + 35

Original issue's description:
> SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager
>
> BUG=543161,561867
>
> Committed: https://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399
> Cr-Commit-Position: refs/heads/master@{#376088}

TBR=nparker@chromium.org,vakh@chromium.org,kcarattini@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161,561867

Review URL: https://codereview.chromium.org/1709943002

Cr-Commit-Position: refs/heads/master@{#376131}

BUG=550922

Review URL: https://codereview.chromium.org/1701363002

Cr-Commit-Position: refs/heads/master@{#376130}

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=haraken@chromium.org, hiroshige@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/1701013003

Cr-Commit-Position: refs/heads/master@{#376129}

We were relying on the test completing within 10ms.

BUG=587711

Review URL: https://codereview.chromium.org/1705103004

Cr-Commit-Position: refs/heads/master@{#376128}

This makes conversion clearer and avoids issues with code in v8 implicitly
converting built-in types to LayoutUnits.

No functional changes beyond tiny differences in conversions, most to
avoid unnecessary conversions.

BUG=581254

Review URL: https://codereview.chromium.org/1660863002

Cr-Commit-Position: refs/heads/master@{#376127}

Just kept the part that updates the IsFixed MapCoordinatesMode, since it wasn't
intertwined with the rest and is unique to LayoutBox-derived classes.

BUG=568492
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1700743002

Cr-Commit-Position: refs/heads/master@{#376126}

Switching audio clients to using RestartableAudioRendererSink instead of AudioOutputDevice.

This is the first step towards switching to mixing WebTRC/WebAudio audio
output together with media elements audio on the renderer side.

Interface is instantiated through AudioOutputFactory,
which as of now produces mixer AudioRendererMixerInput for media elements
and AudioOutputDevice for the rest of the clients.

The plan is in a follow-up CL to have it to produce AudioRendererMixerInput
instances for the rest of the clients basing on Finch experiment parameters
and OS (we won't mix on ChromOS and Android in the near future).

******Used to be (changed during the review) - this is if anybody wants to understand the first patches.

Switching audio clients to using RestartableAudioOutputDevice interface as a sink.
This is the first step towards switching to mixing WebTRC/WebAudio audio
output together with media elements audio on the renderer side.

1) A common interface RestartableAudioOutputDevice (which is
RestartableAudioRendererSink and AudioOutputDevice)  is introduced.

2) AudioRendererMixerInput now inherits from it.

3) RestartableAudioOutputDeviceImpl implements it on top of
AudioOutputDevice (aggregated).

4) WebRTCAudioRenderer, WebRTCLocalAudioRenderer and RendererWebAudioDeviceImpl
are switched to use this interface instead of AudioOutputDevice.

5) Interface is instantiated through RestartableAudioOutputDeviceFactory,
which as of now produces mixer AudioRendererMixerInput for media elements
and RestartableAudioOutputDeviceImpl for the rest of the clients.

The plan is in a follow-up CL to have it to produce AudioRendererMixerInput
instances for the rest of the clients basing on Finch experiment parameters
and OS (we won't mix on ChromOS and Android in the near future).

Having RestartableAudioOutputDeviceImpl mimicing AudioRendererMixerInput
behavior allows to seamlessly switch between both implementations in run-time.

At this step the goal was to have as less client code modifications as
possible, in order to not overlay upcoming (hopefully few) mixing bugs with
integration bugs.

BUG=560378

Review URL: https://codereview.chromium.org/1666363005

Cr-Commit-Position: refs/heads/master@{#376125}

BUG=496258

Committed: https://crrev.com/c925513a3212a55d9c56bec2eea2058c47a76612
Cr-Commit-Position: refs/heads/master@{#375701}

Review URL: https://codereview.chromium.org/1692353002

Cr-Commit-Position: refs/heads/master@{#376124}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7cf41d49..89e3e864

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1703203004

Cr-Commit-Position: refs/heads/master@{#376123}

Add required RefPtr<> local bindings of incoming PassRefPtr<>s.

R=haraken
BUG=583376

Review URL: https://codereview.chromium.org/1703113003

Cr-Commit-Position: refs/heads/master@{#376122}

Moving static functions to anonymous namespace for more modern style and better readability.

BUG=587495

Review URL: https://codereview.chromium.org/1707733002

Cr-Commit-Position: refs/heads/master@{#376121}

Allocation may take time, and we don't need to be on the GPU Child
thread to do it. This also removes the explicit synchronization between
the decoder and GPU Child threads during picture set change.

BUG=574241
TEST=vdatest,crosvideo.appspot

Review URL: https://codereview.chromium.org/1643123003

Cr-Commit-Position: refs/heads/master@{#376120}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/842a4f2e34ee..427f2503f2ae

$ git log 842a4f2e3..427f2503f --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1704313002

Cr-Commit-Position: refs/heads/master@{#376119}

Cr-Commit-Position: refs/heads/master@{#376118}

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1705323003

Cr-Commit-Position: refs/heads/master@{#376117}

:host and :host-context must always be in the rightmost compound with
no other simple selectors except a succeding pseudo element in order to
match as the host element is feature-less in that context. It's however
not an invalid selector according to the CSS Scoping spec, so we
shouldn't drop it at parse time.

We could potentially skip adding other selectors to rulesets as well
including selectors like:

:hover:not(:hover), div:not(div), ::content and ::slotted not in
shadow trees, etc.

R=kochi@chromium.org,ericwilligers@chromium.org
BUG=489481

Review URL: https://codereview.chromium.org/1703893002

Cr-Commit-Position: refs/heads/master@{#376116}

This patch adds support for composite modes on clip CSS animations
via element.animate().

This also changes clip to be more strict about when it permits smooth
interpolation between values.
Previously "rect(100px, auto, auto, auto)" would smoothly interpolate
with "rect(200px, 100px, auto, auto)". Now these values will 50% flip
as their distribution of auto keywords do not line up. This behaviour
matches Firefox.

BUG=437696

Review URL: https://codereview.chromium.org/1640643002

Cr-Commit-Position: refs/heads/master@{#376115}

The PluginView method layoutIfNeeded causes WebView plugins to update
their entire lifecycle, but we only call that if their layout is
dirtied. In the presence of some style changes, they can need
invalidation or compositing updates without layout, and our recursive
lifecycle update missed WebView plugins as it only recurses through
the Frame tree.

This change always updates child plugins when
FrameView::updateStyleAndLayoutIfNeededRecursive is called.

BUG=545039

Review URL: https://codereview.chromium.org/1708923002

Cr-Commit-Position: refs/heads/master@{#376114}

Before this CL, ServiceWorkerResponseReader and ServiceWorkerResponseWriter were
asynchronously created in ServiceWorkerCacheWriter. Unfortunately, the cache
writer did not check the validity of ServiceWorkerContextCore before attempting
to create the accessors, so it caused crashes when the context was already gone
due to storage failure etc.

This CL stops asynchronously creating those response accessors, and creates them
when ServiceWorkerCacheWriter is constructed so that the cache writer no longer
has to concern about the validity of the context. If the context is gone after
the accessors are created, diskcache acceess simply fails[1].

[1] https://codereview.chromium.org/1693303002/

BUG=584606

Review URL: https://codereview.chromium.org/1704293002

Cr-Commit-Position: refs/heads/master@{#376113}

This change makes the host start scanning for WiFi APs when a startScan request
is sent from the instance.

BUG=584886
BUG=b/26495967

Review URL: https://codereview.chromium.org/1680483002

Cr-Commit-Position: refs/heads/master@{#376112}

R=michaelpg@chromium.org
BUG=none
TEST=more email

Review URL: https://codereview.chromium.org/1707013003

Cr-Commit-Position: refs/heads/master@{#376111}

R=sky@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1697243002

Cr-Commit-Position: refs/heads/master@{#376110}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ee6c0303c252..842a4f2e34ee

$ git log ee6c0303c..842a4f2e3 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1706963004

Cr-Commit-Position: refs/heads/master@{#376109}

BUG=585066
TEST=manually tested as described in the issue.

Review URL: https://codereview.chromium.org/1706813004

Cr-Commit-Position: refs/heads/master@{#376108}

BUG=
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/1705423002

Cr-Commit-Position: refs/heads/master@{#376107}

Like for siblingRules in [1], we don't need to add rules to
uncommonAttributeRules if the attribute selectors are left of ::content,
::slotted, :host, or :host-context as two elements only may share style
if they match the same elements left of the two former, and anything
left of the two latter may never match.

[1] https://codereview.chromium.org/1695393002/

R=kochi@chromium.org

Review URL: https://codereview.chromium.org/1706793002

Cr-Commit-Position: refs/heads/master@{#376106}

https://chromium.googlesource.com/skia.git/+log/e2412d5738e4..c5eddd7d8d67

$ git log e2412d573..c5eddd7d8 --date=short --no-merges --format='%ad %ae %s'
2016-02-17 herb Add bilerp filtering.
2016-02-17 reed some modes need clamping due to numerical imprecision

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1712443002

Cr-Commit-Position: refs/heads/master@{#376105}

R=sky@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1700873002

Cr-Commit-Position: refs/heads/master@{#376104}

In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990

Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}

Review URL: https://codereview.chromium.org/1637813002

Cr-Commit-Position: refs/heads/master@{#376103}

Keyframe rules injected via CSSOM have no associated source range.

BUG=586085

Review URL: https://codereview.chromium.org/1697973002

Cr-Commit-Position: refs/heads/master@{#376102}

MacViews: Fix views_unittests MenuButtonTest.{ActivateDropDownOnMouseClick,DraggableMenuButtonActivatesOnRelease}

Tests added in r301015, regressed in r363547. They fail on Mac because a
non-simulated cursor position is detected during button creation, where button
states are initialized, thus not detecting a hover state.

the ui::test::EventGenerator is used to simulate cursor position, but isn't
created until after the button widget, which means an unexpected cursor position
is detected between the time of widget creation and EventGenerator creation.
Additionally, using the set_current_location() method does not trigger mouse
events, which means the button's hover state is never detected.

Fix is to create the EventGenerator object before button creation so that
when mouse events are triggered the hit tests will detect mouse hover states.

BUG=579380

Review URL: https://codereview.chromium.org/1670473002

Cr-Commit-Position: refs/heads/master@{#376101}

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely, this let's us get the ctrl key and speak it in the kbexplorer (it probably just stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press modifiers ctrl, alt, search, shift; verify they are read (queued). Press letters, numbers, shifted keys.
BUG=none

Review URL: https://codereview.chromium.org/1702913002

Cr-Commit-Position: refs/heads/master@{#376100}

This reverts https://codereview.chromium.org/1477483003/ which was
intended to fix a problem where media playback in browser tests
triggers metrics events that DCHECK on invalid session ID.

Previous attempt set a dummy session ID, but this could mask bugs
if we ever failed to set session ID correctly.  Instead, explicitly
only set the dummy ID for running browser tests.

BUG=

Review URL: https://codereview.chromium.org/1510973007

Cr-Commit-Position: refs/heads/master@{#376099}

This won't affect Stable based on https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_crash_reporter_client.cc&l=182 .

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622

Review URL: https://codereview.chromium.org/1707203002

Cr-Commit-Position: refs/heads/master@{#376098}

https://chromium.googlesource.com/skia.git/+log/134ad3e5b097..e2412d5738e4

$ git log 134ad3e5b..e2412d573 --date=short --no-merges --format='%ad %ae %s'
2016-02-17 cblume Adding direct access to SkMipMap levels.
2016-02-17 mtklein try plain-old code for sk_memset16/32 now that NEON is compile-time
2016-02-17 msarett Speculative fix for Google3 iOS build
2016-02-17 msarett Return the proper error code in SkBmpRLECodec
2016-02-17 jvanverth Add GrGpu support for Vulkan command buffer flush GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705133002
2016-02-17 robertphillips Mark existing image filter entry points that will be going away with Deprecated GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709753002
2016-02-17 mtklein Don't you just feel bad every time you type 'delete'?
2016-02-17 brianosman Further reduction of GPU workload in shapes benchmarks. Hopefully this squelches the random crashes on Mali 400.
2016-02-17 bungeman Move SkTArray to include/private.
2016-02-17 msarett Delete KTX tests to fix Android build
2016-02-17 halcanary bin/sync-and-gyp: better error checking
2016-02-17 iroth Enable GL interfaces for iOS build
2016-02-17 caryclark add last move to serialized path

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1708063002

Cr-Commit-Position: refs/heads/master@{#376097}

to the property name.

Prior to this patch, multiple calls to inline style setProperty with the
same custom property name cause multiple entries to be created in the
StylePropertySet. This causes inline style getPropertyValue calls to
return the wrong value.

Review URL: https://codereview.chromium.org/1697233003

Cr-Commit-Position: refs/heads/master@{#376096}

Implement chrome.input.ime.setComposition and chrome.input.ime.commitText APIs on Linux and Windows platform.

This cl makes ui::InputMethodBase inherits from ui::IMEInputContextHandlerInterface, thus we can implement functions CommitText() and UpdateCompositionText() once for Linux and Windows.

Make InputImeKeyEventHandledFunction::Run() calls the new added InputMethodBase::KeyEventHandler() in  to set |handling_key_event_|, which indicates whether the IME extension is handling key event. And when |handling_key_event_| == true, we should not setComposition and commitText until it's done to run the callback.

Add helper function UpdateCommitText() and CommitTextToInputContext() in InputMethodEngineBase, which will be override in chromeos::InputMehtodEngine and input_method::InputMethodEngine to implement the API on different platforms.

BUG=517773
TEST=None

Review URL: https://codereview.chromium.org/1657593007

Cr-Commit-Position: refs/heads/master@{#376095}