GitLab

default for writable.

BUG=None
Test=No visible change, cleanup only.
Updated and ran
browser_tests:WebViewTest.Shim_TestWebRequestAPIExistence

Review URL: https://codereview.chromium.org/190483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255785 0039d316-1c4b-4281-b951-d872f2087c98

It's totally unnecessary (and named shared memory is now deprecated).

R=jam@chromium.org

Review URL: https://codereview.chromium.org/189843009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255784 0039d316-1c4b-4281-b951-d872f2087c98

connection whose handshake was not confirmed when that connection is
closed.

Review URL: https://codereview.chromium.org/183853028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255783 0039d316-1c4b-4281-b951-d872f2087c98

The --nacl-loader-cmd-prefix is no longer useful in practice for injecting a
debugger after this:
https://code.google.com/p/chromium/issues/detail?id=118263
https://src.chromium.org/viewvc/chrome?view=rev&revision=230891

We should drop the switch from chromium.

BUG=350158
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/189623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255782 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: caused unit test failures on Mac ASAN bots, eg:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/69/steps/base_unittests/logs/FormatNSInteger

> Define print format macros for NSInteger & NSUInteger
> 
> The size of NSInteger and NSUInteger varies between 32-bit and 64-bit
> architectures, however does not provides macro to safely format them
> and instead recommend casting the value to the larger version that is
> used on 64-bit architecture.
> 
> Using a cast could cause some formatting to be missed (if the type of
> a variable changes), so instead we define our own macros to format those
> types safely.
> 
> BUG=349458
> 
> Review URL: https://codereview.chromium.org/187793003

TBR=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/192023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255781 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341526

Review URL: https://codereview.chromium.org/180273015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350446
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/191233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255770 0039d316-1c4b-4281-b951-d872f2087c98

The code will run behind the kEnableAudioTrackProcessor flag and the behaviour will be compatible with the existing behaviours.

Since AEC dump can be started only once, so we can't re-create a new instance of MediaStreamAudioProcessor when the format changes. This CL will create the MediaStreamAudioProcessor in the constructor of WebRtcAudioCapturer and call OnCaptureFormatChanged() to the MediaStreamAudioProcessor when the format changes.

BUG=264611
TEST=manual enable aec dump in chrome://webrtc-internals and verify the aec dump audio files.

Review URL: https://codereview.chromium.org/187913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348324

Review URL: https://codereview.chromium.org/184223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255768 0039d316-1c4b-4281-b951-d872f2087c98

If creating the temporary file failed, don't try to open it. If we can't open
it for some reason, delete the temporary so the caller can assume strong
exception safety and not have to delete the file on error.

BUG=none

Review URL: https://codereview.chromium.org/183003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255767 0039d316-1c4b-4281-b951-d872f2087c98

Add a config.h for FreeBSD, generated by running "../configure" in third_party/libevent/freebsd/ on a FreeBSD 10.0-amd64 system.

For 32-bit FreeBSD systems, SIZEOF_LONG would be 4, but since both systems
have a strtoll() function this does not matter (see libevent/evutil.c).
Taking 8 for SIZEOF_LONG is also in sync with _EVENT_SIZEOF_LONG as
defined in libevent/freebsd/event-config.h

BUG=350396
TBR=cpu

Review URL: https://codereview.chromium.org/183803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255766 0039d316-1c4b-4281-b951-d872f2087c98

All unit tests suites are now opted into using real NullDraw GL
contexts instead of fake "test contexts". So remove the code to
create test contexts.

Removes the --disable-test-compositor flag as this does nothing
now that no tests use test contexts.

R=sievers@chromium.org
BUG=270918

Review URL: https://codereview.chromium.org/183743014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255765 0039d316-1c4b-4281-b951-d872f2087c98

1. Change the graph from bar-chart to area chat.
Now x-axis shows time line.  It is instinctive.

2. Enable to choose policies in GUI.
It is a waste of time to apply many policies and make different HTML files.
Now it can be done with clicks.  No need to specify a policy in converting json to HTML.

Usage:
$ dmprof /path/to/first.heap > temp.json
$ graph.py temp.json > graph.html  # no need to specify a poilcy
$ chrome graph.html    # open the HTML file in Chrome


BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/189623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255764 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255763 0039d316-1c4b-4281-b951-d872f2087c98

0. Roll icu to r249466 to copy Android-specific icudtl.dat
1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. 
2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that
it's copied to assets directory for Chrome and related targets. 
3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. 
4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets 

Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. 

This also depends on a Blink change https://codereview.chromium.org/183013006/ 

TBR=avi@chromium.org
BUG=72633
TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms.
TEST=On Android, 1. Layout tests 
2. build/android/test_runner.py gtest -s webkit_unit_tests 
--gtest_filter=WebFrameTest.SelectRange*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253938

Review URL: https://codereview.chromium.org/156333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168518

Review URL: https://codereview.chromium.org/182033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255761 0039d316-1c4b-4281-b951-d872f2087c98

For 9 patch scrollbar we want to control stroke and fill separately.

Remove original 9 patch scrollbar resources and update them to current
ones.

BUG=307578

Review URL: https://codereview.chromium.org/188723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346241

Review URL: https://codereview.chromium.org/187583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255759 0039d316-1c4b-4281-b951-d872f2087c98

Extends the unit tests about corner cases to ensure that changes to the implementation don't break these.
Test cases of the internal helper function SplitStringIntoKeyValues are merged into tests of the public function SplitStringIntoKeyValuesPairs. This removes redundancy in the tests and improves coverage of SplitStringIntoKeyValuesPairs.

The helper function is removed from the public header.

BUG=NONE

Review URL: https://codereview.chromium.org/184233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255758 0039d316-1c4b-4281-b951-d872f2087c98

Destruction order should be harmless, but should be cleaned up. CHECKs
should tell us if the controller is being shutdown while callbacks are in flight.

BUG=349651
TEST=none

Review URL: https://codereview.chromium.org/188243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255757 0039d316-1c4b-4281-b951-d872f2087c98

Update several browser_tests / content_browsertests to set iframes' name.
Previously, these tests were relying on the iframe's name being its id
if the name parameter was unset. However, this behavior is against
specification and other browsers. Blink is going to be updated accordingly
but we need to fix the tests on Chromium-side first before we can land the
Blink change.

BUG=347169
R=jochen@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/188813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255756 0039d316-1c4b-4281-b951-d872f2087c98

The size of NSInteger and NSUInteger varies between 32-bit and 64-bit
architectures, however does not provides macro to safely format them
and instead recommend casting the value to the larger version that is
used on 64-bit architecture.

Using a cast could cause some formatting to be missed (if the type of
a variable changes), so instead we define our own macros to format those
types safely.

BUG=349458

Review URL: https://codereview.chromium.org/187793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255755 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244472
TBR=

Review URL: https://codereview.chromium.org/190553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255753 0039d316-1c4b-4281-b951-d872f2087c98

This is now unused on all platforms.

R=aelias
BUG=350142

Review URL: https://codereview.chromium.org/189433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255752 0039d316-1c4b-4281-b951-d872f2087c98

This code is stable for a while now, there's no longer any reason to
be able to quickly turn the feature off.

BUG=chromium:350298

Review URL: https://codereview.chromium.org/189163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255751 0039d316-1c4b-4281-b951-d872f2087c98

This CL is adding a ScreenOrientationListener abstract class with one
implementation that is based on the current mechanism used for listening
to screen orientation changes. The other implementation is based on
DisplayListener but this API is only available from API Level 17.

BUG=342714, 346696

Review URL: https://codereview.chromium.org/179783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255750 0039d316-1c4b-4281-b951-d872f2087c98

It is not used anymore. The standard API keys workflow should be
used instead.
See http://www.chromium.org/developers/how-tos/api-keys.

BUG=350333

Review URL: https://codereview.chromium.org/189603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255749 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255748 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255747 0039d316-1c4b-4281-b951-d872f2087c98

TBR=arv@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/189723011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255746 0039d316-1c4b-4281-b951-d872f2087c98

The docserver is timing out and it has something to do with this. Note
that as part of the rollback I need to make sure that app.yaml and
cron.yaml still increase their versions.

BUG=350640
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/191853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255741 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255739 0039d316-1c4b-4281-b951-d872f2087c98

There are no ModifierObservers anymore. So remove them.

BUG=none
R=derat@chromium.org

Review URL: https://codereview.chromium.org/191523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255736 0039d316-1c4b-4281-b951-d872f2087c98

The remaining uses of context_menu_node_ are easy to convert, but I've left them to a future cl so as to not make this cl any bigger. The main part of this cl is to move the Copy edit command from RenderViewHost to RenderFrameHost. To do that, I also had to convert Cut and Paste at the same time because of BrowserView.

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/183923030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349578
TEST=Manual test by following repro steps
R=fgorski@chromium.org

Review URL: https://codereview.chromium.org/189803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255729 0039d316-1c4b-4281-b951-d872f2087c98

Currenly we have UUID in a lot of places in the EME implementation on Chromium
for Android. But UUID should really just be an implementation detail of
MediaDrmBridge. This CL moves all UUID related code to MediaDrmBridge and uses
key system elsewhere.

BUG=347596
R=boliu@chromium.org, dcheng@chromium.org, ddorwin@chromium.org, joi@chromium.org
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/185993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255727 0039d316-1c4b-4281-b951-d872f2087c98

Reverting to see whether this introduced flakiness in the WebGL conformance
tests on the Win GPU bots. If it did, that means this CL exposed a
preexisting race condition. See Issue 350572.

> Remove --ui-prioritize-in-gpu-process
> 
> It is already always on on Android and Chrome OS. Consensus is that we should
> turn on on all Aura platform. The flag is a noop on other platforms.
> 
> BUG=344083
> 
> Review URL: https://codereview.chromium.org/183883023

TBR=piman@chromium.org
BUG=344083,350572

Review URL: https://codereview.chromium.org/189373012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3803
TEST=browser_tests
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/190823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255721 0039d316-1c4b-4281-b951-d872f2087c98