- 22 May, 2020 40 commits
-
-
Alexander Surkov authored
Bug: 1085421 Change-Id: I3910d3d7d54637dfc054f70dc81ffa2f051c07ae AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212461 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afd8a6c6ae87..88a3b462962d 2020-05-22 herb@google.com turn off 2M glyph test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I6a023b4ffe52ff3770651892db30b31e2bea9762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771348}
-
Hirokazu Honda authored
There are some media features that needs to be overridden in a test. For instance, we want to enable kVaapiVP9Encoder, which is disabled by default now, and also kFFmpegDecodeOpaque to use VpxVideoDecoder to decode vp8 bitstream for a verification. There is no way to enable and disable features in our video tests. After this CL, media::test::VideoTestEnvironment takes feature sets to be either enabled or disabled in a test. Bug: 1045825 Test: video_encode_accelerator_tests --codec=vp8 on eve Change-Id: Ib66d96c124783ca47c3e943d396e6666ebac03ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206872 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#771347}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590119331-fbabb52511f6c610b90717a191978d71b893771f.profdata to chrome-win64-master-1590161669-593ac6a44fd629dc3035fae6d797ac804dd4b719.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f6399797073ae1dd7442387bea42b8b9a92ed28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213586Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590147234-0a723ff3779a785a5a73326d87db7cb98fa45feb.profdata to chrome-win32-master-1590161669-17629765fa6319602482bd35878adc03bc8e5e00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I30d3fc0fd95919ee2faa6418c59b6c9c468f15c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213587Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590147234-3f090f605cbcaf87b1210a2c3aca08f21e49a4ee.profdata to chrome-mac-master-1590161669-1437af88aff1c6cc90f5b4a73d3631f0e7fd0e76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ida925a9a97cd536d965b3320679dd3743789e2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213701Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd9e807ee9a7..9046a4247505 2020-05-22 primiano@google.com Merge "infra: add perfetto.dev site" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f923402a1021a3fcf66b2a9d323c21d19d1615c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213633Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec31488ace66..afd8a6c6ae87 2020-05-22 bsalomon@google.com Change intermediate image sizes in GrSurfaceContext::rescale If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I6efa6eff6c7f404e7487c8a1648376c6163ca1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213632Reviewed-by:
-
Aleks Totic authored
Caption.html - Legacy fails the caption block %ge sizing test. Legacy computed caption block %ge from grid size. I've discussed with tab, and will try to make block %ge caption size be auto instead. - Browsers mostly agree on column-width.html test, 1 difference. It exausively tests how td and col sizes are combined to generate column width. Bug: 958381 Change-Id: I61d0e5a0e67d7fbb122ee5818917ee14d9801da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161571 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771341}
-
Mario Sanchez Prada authored
This reverts commit bcb3ba73. Reason for revert: This migration was wrong because it did overlook that there might be multiple responses being sent from the renderer to the browser process during one serialization process, in which case the renderer will crash due to not havin a valid mojo callback to invoke after the first response is sent. See crbug.com/1085721. The solution is to rework this to have a separate mojo method that will be called from the renderer for each response that needs to be sent back to the browser process, but let's revert this for now and work on that on a follow-up CL. Original change's description: > Migrate FrameMsg_GetSerializedHtmlWithLocalLinks to mojom::Frame > > This CL moves this message out of frame_messages.h and adds a new > method in content::mojom::Frame to allow the browser request from > the renderer the serialization of a RenderFrame's contents, regardless > of whether such contents include same-site or cross-site resources. > > Since this functionality also requires an asynchronous response from > the renderer once the serialization is complete, this CL does also > migrate FrameHostMsg_SerializedHtmlWithLocalLinksResponse, for which > some extra bit have been added to WebFrameSerializer[Client], so that > we can appropriately reply to the browser process when the serialized > data is available. > > In a future CL, this functionality will probably get moved down into > Blink itself, but at the moment there's way too much functionality > in use in Blink's public API, so this CL does not tackle that part > yet, and focused on the migration from legacy IPC to mojo only. > > Bug: 1044088 > Change-Id: I4ce5b3cfe795e5019bb30a278577ec2be3ee2854 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207234 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770794} TBR=kinuko@chromium.org,acolwell@chromium.org,haraken@chromium.org,mario@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044088, 1085721 Change-Id: Ic84a3244aef24fcde881f2316aa75679665e7734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212132Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#771340}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 0e41d647ceaeb2195d5d9ab5ff25c19292a36bf5`. TBR=rnk Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: I48b5bc02e2a21329c51de24366b6ca2c4e9c1f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211510Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771339}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dfa8d5f. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I144d8964de0288f4b32c019c0ab29783408acfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213497Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771338}
-
Rouslan Solomakhin authored
Before this patch, aborting payment on desktop would succeed only before the payment app has been invoked. The invoked payment app was not consulted whether it could be aborted. This patch delegates abort handling on desktop to the payment app. This patch also removes the identity callback from the desktop implementation of PaymentRequest, because aborting requires ServiceWorkerPaymentApp to know the service worker registration ID, which is also used for payment handler host logging, and ServiceWorkerPaymentApp now has a reference to the payment handler host. After this patch, the invoked payment handler receives the abort event and determines whether abort should be performed. (Android already does that.) Bug: 1083242 Change-Id: I267ad820ef06b17fb88bd8b948c22b0e07145fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208105 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771337}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590134157-7528a57fcdaef12919b38ac2ee42ea942a34f878.profdata to chrome-mac-master-1590147234-3f090f605cbcaf87b1210a2c3aca08f21e49a4ee.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idd8298aefa5412b0b7e92800bc5dc368bce95792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213546Reviewed-by:
-
Mike Klein authored
Bug: skia:10257 Change-Id: I44451a0b0e1222968c4c6c23d62de9c407ad5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210321 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#771335}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iad5e16fcafed40a29bc65aa8923dfda0b7ec9d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213328Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771334}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80abb89c3632..ec31488ace66 2020-05-22 mtklein@google.com Revert "Add a tessellation mode that uses indirect draws" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I44e9edc52e3ed0240bfaae92a038009c083956eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213622Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ee5ef3583d8..71f352e32811 2020-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6f723ebbe3b0 to 2cf9621d6d6f (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ic851d144c8698e9b52d5bdecab9bc9bd9d20dc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213542Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590119331-1f693e469085ff93aa0c94ab92b41ec8ed0e78d9.profdata to chrome-win32-master-1590147234-0a723ff3779a785a5a73326d87db7cb98fa45feb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I22551e62a333ecf57c4aed528211de48d2266e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213547Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70e7d879d045..7524d2e6a243 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: I6c9f3fc092ba1d37758a4ca79cbbffc3fc6ca161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213543Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771330}
-
Alexander Surkov authored
line indexes. AccTreeFormatter serializes accessible objects as a combination of role/name/etc. It'd be nicer if the objects were serialized as line indexes from the expectation file. It makes more readable and error proneness serialization. Bug: 1082800 Change-Id: Icf37067c05b967183baa7496bd4e5188a8abc1d0 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202958 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#771329}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea4a9d33f5fa..70e7d879d045 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: Ie924a21eca6dba43c286a26a7e1f1e201a716df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213445Reviewed-by:
-
Michael Achenbach authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b912f2..414d114a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org Change-Id: If7cbfb0cb3dab152b05c76d9c1222f854ccb44b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212206Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#771327}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/96a80283cc0f..0ee5ef3583d8 2020-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3c47dac28208 to b0264b87ffb5 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Iaaffd8544394ae4c15045306c6b033f378649f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213319Reviewed-by:
-
Mugdha Lakhani authored
This removes expectations for non existing tests from the WebLayer WPT expectations file. Bug: 1057771 Change-Id: I5cabe191ac20d1f1dabfb80ac6f05e4d80bbb23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212521Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#771325}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/609a0cffce10..ea4a9d33f5fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I4c5588b71647a4d27dd65c19025e4d847438e948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213313Reviewed-by:
-
Ankit Kumar authored
This CL populates the data of a popup note associated with a highlight. The populated data is sent from plugin to mimehandler. The pepper interfaces are already structured to pass along the popup note text data. The CL also modifies the structures related to highlight in the plugin layer to store the note text, which is then passed on to the pepper layer while sending highlight related data. Unit test has been modified to validate the popup note text value. Bug: 1008775 Change-Id: I0e83b7d04d23922daa20ccd3e5c8e602c6ac5077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208318 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771323}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If788d41bbbaf2f9c7bc72a54e616d04ae0166f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213318Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590119331-9d6af4f8adcea4a27aaea0d62407ee7617e48430.profdata to chrome-mac-master-1590134157-7528a57fcdaef12919b38ac2ee42ea942a34f878.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Icaff70583e7945d85a479260960c87a887ffa957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213443Reviewed-by:
-
Henrique Ferreiro authored
Bug: 1029142 Change-Id: I72eeb7f72b5eac76356f6c0d90942dc429b5b159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185115 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Rohit Agarwal authored
Intent URIs can expose file:// URI which upon external navigation from can result in unhandled FileUriExposedException android exception. This CL adds check in ExternalNavigationHandler to ensure we never send the intents generated by Intent URIs with file scheme to Android which could result in unhandled exception. This CL also adds unit and browser tests. Bug: 1085476 Change-Id: I0cff50d517a491dc27e345372ddcc5c77f8e26cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212169 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771319}
-
Ankit Kumar authored
Bug: 1084957 Change-Id: Ida67162676737644e987a43aaff5cf713a75301e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212221Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771318} -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bc656b61d29..80abb89c3632 2020-05-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I76e137f4f9443397e346df4413ac2e9ec1fa272f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213314Reviewed-by:
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: I17f1433a8303cf2bfbeade76dc196b7a81921236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203347 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771316}
-
Rahul Singh authored
This CL fixes an issue that prevents an app icon from appearing when the Create shortcut dialog is invoked. The dialog is invoked by clicking: Customize and control Google Chrome > More tools > Create shortcut... Cause: The initial CL for shortcuts menu https://crrev.com/c/2146212 modified FilterSquareIconsFromMap() in web_app_install_utils.cc. From: void FilterSquareIconsFromMap(const IconsMap& icons_map, std::vector<SkBitmap>* square_icons) To: void FilterSquareIconsFromMap( const std::vector<WebApplicationIconInfo>& icon_infos, const IconsMap& icons_map, std::vector<SkBitmap>* square_icons) This was done because icons_map can contain both app icon and shortcut icon related bitmaps when a site specifies shortcuts icons in it's web app manifest and the shortcuts menu feature is enabled. The code inside FilterSquareIconsFromMap() iterated over icon_infos while adding bitmaps to the square_icons vector. Those bitmaps were used to generate app icons of various sizes. For some websites like www.google.com icon_infos can be empty. In such cases, the code to populate square_icons in FilterSquareIconsFromMap doesn't run as there's nothing to iterate over. This results in an empty square_icons which in turn leads to no app icon in the Create shortcut dialog. Fix: This CL reverts FilterSquareIconsFromMap() to its state before the shortcuts menu feature landed (no icon_infos argument). In FilterAndResizeIconsGenerateMissing() which calls FilterSquareIconsFromMap, the code checks if kDesktopPWAsAppIconShortcutsMenu is enabled. When the feature is disabled, it calls FilterSquareIconsFromMap(). When the feature is enabled, it calls the newly added: void FilterSquareIconsFromMapDisregardShortcutIcons( const std::vector<WebApplicationIconInfo>& icon_infos, const IconsMap& icons_map, std::vector<SkBitmap>* square_icons){} This method calls FilterSquareIconsFromMap() if icon_infos is empty. Otherwise, it iterates over icon_infos. Testing: I tested this fix by invoking the Create shortcut dialog with the DesktopPWAsAppIconShortcutsMenu feature enabled and also with it disabled. In both cases, app icons showed up as expected. I've also added a couple new unit tests for FilterAndResizeIconsGenerateMissing(). Bug: 1084913 Change-Id: I59bf6ca45e84546a93c891c52014017bd566c8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209968 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#771315}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I57ba4a61297a9834022c6d73998dea8d1079530c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213235 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da90c3765908..9bc656b61d29 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 16e86c0b to f1735ff5 (360 revisions) 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e8b8b8164520 to 96a80283cc0f (13 revisions) 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 8a3cc5c4dfd8 to 65ee6497d620 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1080984 Tbr: lovisolo@google.com Test: Test: Test: angle_perftest --gtest_filter="*Trace*egypt*"Test: Test: angle_perftests Change-Id: Ic95ebf9d698ef97ee456cb63f23177e2bbc84fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213308Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f41b134dc274..609a0cffce10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: Ifee72dde42827fe1d9eca789b5cecd832bb1e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213304Reviewed-by:
-
Pawel Baran authored
Change-Id: If5e0b52e6e6348ea72c708a90da08ef0b189f930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207173 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Tom Anderson authored
These are needed for [1]. Normally, events are only read, but there is a special case for client messages where we want to write an event that will be sent directly to another client. Also the connection setup data doesn't have a corresponding reply, so a special reader needs to be added for this too. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2212976 BUG=1066670 R=msisov CC=sky Change-Id: Ibded85ee3451a891c41ada62f32167bb779ed924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209961 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#771310}
-
