- 24 Jun, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07a3ce625213..e16b0f211117 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bsep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090082 Tbr: bsep@google.com Change-Id: Ic6a7e41857a95e64bfff25d71a71b96dcb5b1457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264012Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46ce35498890..e5f58adc98e4 2020-06-24 lalitm@google.com Merge "ui: remove vsync tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie71d8fdd9accb003ea4a49b64ca35c8f62b7707a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781888}
-
Mirko Bonadei authored
This reverts commit b51cc5df. Reason for revert: Reverting the component build, see crbug.com/1098761. Original change's description: > Remove duplicate symbols in .def for absl.dll > > Bug: None > Change-Id: I89c105a652db701c083a03f1c0c891e00d2e6776 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260754 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Danil Chapovalov <danilchap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781413} TBR=mbonadei@chromium.org,danilchap@chromium.org Change-Id: I85e28005c25270b150503c0f889363e47c4c2ad1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264125Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781887}
-
Xianzhu Wang authored
An opaque layer with transformed rasterization enabled should clear the canvas before drawing the display list because transformed rasterization makes the pixels along the edges of the canvas translucent. I added code to clear the canvas in crrev.com/780083, but didn't modify the GPU raster path. This CL makes them consistent. Bug: 1077071 Change-Id: I2a28f81d7c9da98d1199ae3e72a4068269dd7296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262132Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781886}
-
Javier Ernesto Flores Robles authored
Adds "Button" to table view cells. Adds a11y label for details button. Adds a11y notification for copy menu. Bug: 1044639 Change-Id: Ied49f7d7061bea3152cf41867ac7b65b038fb233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264355 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781885}
-
Becca Hughes authored
Update test target to support other non-JS browser tests. Change-Id: I2626ca89ce5ce19824e30684268a38b127885a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261356Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781884}
-
Julian Pastarmov authored
Now that restrictions apply to macOS similar to Windows the policy documentation needs to be updated to reflect this. Side cleanup - alphabetized the kSensitivePolicies list and removed the DefaultSearchProviderContextMenuAccessAllowed policy from it as it does not need to be on the list as it is guarded by the DefaultSearchProviderEnabled policy like all other policies in this group. BUG=1084222 Change-Id: I3208eeebcaceffdecb225d4f1e92d68446562d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253742 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781883}
-
Xianzhu Wang authored
In CAP, some frame overlays paint contents directly into display items without a composited layer. Now invalidate the FrameOverlay as DisplayItemClient in UpdatePrePaint() (just like pre-CAP always invalidates the GraphicsLayer). Bug: 1047359 Change-Id: Ic3aa9c35f390bea4b0cd142c5a3a01b090cf4909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261134 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781882}
-
Nico Weber authored
PAGE_SIZE now needs an explicit include of mac/vm_param.h. Bug: 1098738 Change-Id: Ib56e3b080919edb08aa12aeae0fe3357d5022881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264255 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781881}
-
Dominic Mazzoni authored
This is motivated by http://reddit.com/r/pics, where there are two levels of divs in-between the link element and the img element. With this small change Chrome provides image labels for pictures on Reddit again. Bug: 1091538 Change-Id: I7a9775b7ff1febe4ae3b5f1741a624e0664b0582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252801 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#781880}
-
chrome://managementAndreea Costinas authored
If the device is offline, there is no default network to read proxy configuration from. Bug:1098234 Test:unit_tests --gtest_filter= ManagementUIHandlerTests.ProxyServerShowReportDeviceOffline Change-Id: I4850cdaace2cbc86e583f32a1bbddcc863e3ecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260652Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#781879}
-
Xianzhu Wang authored
ScrollableArea::LayerForScrolling() works for pre-CAP only. Now use a method working for both CAP and pre-CAP. Change-Id: Ia22c868d3794b685ebf435cc77d83ec30d9d9dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261414Reviewed-by:
-
Elad Alon authored
This makes it clearer that WebRtcEventLogUploaderImpl runs on the same task runner as WebRtcRemoteEventLogManager, and makes following the threading issues easier. Bug: 1092071 Change-Id: I0a72973525a03632b423dc69afc495439dfdaed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260568 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781877}
-
Bruce Dawson authored
The UCRT is not a redistributable component on ARM64 so it can't be a required SDK component. This adjust the required list of files for ARM64. The toolchain roll made these files required which broke the ARM64 FYI bot: https://ci.chromium.org/p/chromium/builders/ci/win32-arm64-rel Local testing shows that this fixes ARM64 builds, at least enough to build base. Bug: 1089996 Change-Id: Ic32526aa48f717cdb8bbe42f2e45e9449ede5164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264153Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Patrick Noland authored
This reverts commit 0b009d85. Reason for revert: Causes several tests to crash on Lollipop Tablet Tests (see e.g. https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4cfd793242a15611/+/logcat_logcat_org.chromium.chrome.browser.page_info.PageInfoViewTest.testShowWithPermissionsAndCookieBlocking_20200624T054824-UTC_09e0d212) Original change's description: > WebLayer: hook up CookieControlsBridge. > > When enabled, and when third party cookies are being blocked, this will > show an extra toggle in the page info bubble. > > Test: run_weblayer_shell example.com --args="--enable-features=\"ImprovedCookieControls\"" > Bug: 1071775 > > Change-Id: Ib0a6d6a1c80cafa4b8aeeea19cb9919df55a7f83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240011 > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781552} TBR=estade@chromium.org,tedchoc@chromium.org,dullweber@chromium.org,nator@chromium.org Change-Id: I7594ba7b5b22dc2b402a5446d90645a9a26930e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264199Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#781875}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/755c65d8b5cc..d95138b684b8 2020-06-24 jakobi@webrtc.org Make stable target adaptation enabled by default. 2020-06-24 danilchap@webrtc.org Add helper for DependencyDescriptor rtp header extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If57434e4cef884a5f9cb60df52a089c04fcd7927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264372Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1098764 Change-Id: Id95c564487b698154fa09e1067ac345bae268680 Tbr: bsep@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264453Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781873}
-
Jihwan Marc Kim authored
PostAnimationFrame is not moving forward and can be removed from the tree. Bug: 1093900 Change-Id: Ia87a3427aea451161386004d811a59c95083320e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256104Reviewed-by:
-
Samuel Huang authored
SuperSize-archive takes a "main input" file parameter. Ideally it is given and is unique. However, the following complicate things: (1) --map-file can be a main input as well as an auxiliary input for another main input. (2) integration_test.py often specifies an ELF file alongside, e.g., an APK file, to represent an extracted ELF file. (3) --ssargs-file a valid "main input" only at command line, and cannot be nested within an .ssargs file. (4) -f identifies main input file, and can be used in .ssargs files. This CL cleans up main input processing and address the above. Details: * Renamed _ParseSsargs() to ParseSsargs() for upcoming use. * Move more checking logic there. * For (1): Resolve exclusion with custom logic in _GetMainFiles() and error handling in _DeduceDerivedArgsAndCheckMainInput(), which was _DeduceDerivedArgs(). * For (2): Add new parameter --aux-elf-file and update tests to use it. Did NOT add --aux-map-file due to low usage. * For (3) and (4): Simplify code by allowing --ssargs-file (and -f with .ssargs) in argparse, and have a single check to reject this in ParseSsargs(). Bug: 1040645 Change-Id: I28e510747b43f3ebcc9dcd9c53006913c97f02dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263012 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#781871}
-
Jérôme Lebel authored
ChromeWebClientTest.WKWebViewEarlyPageScriptAccessibility is flaky. See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8876609033926980304/+/steps/ios_chrome_unittests__iPad_6th_Gen_iOS_12.4.1__on_iOS-12.4.1/0/logs/ChromeWebClientTest.WKWebViewEarlyPageScriptAccessibility/0 TBR: gambard Bug: 1098758 Change-Id: I0b86000acb8b6394fa3b5649903c772f1d3756f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264412Reviewed-by:
-
Hajime Hoshi authored
This CL adds BackForwardCacheTiming::first_input_delay_after_back_forward_cache_restore indicating the time duration between the last navigation start time when the page is restored from the back-forward cache, and the time when the first input task is processed. (the back-forward cache version of FID.) Bug: 1014174 Change-Id: I41f345d584c5a38982137273e045c44ddc2166e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242709 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781869}
-
Michael Ludwig authored
Bug: 1098743 Change-Id: Icbc4204c4f220851d4208efd6dad1ea5bd3d0c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264252 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#781868}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15229ea0..fb3f068d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib18ea3a147e8b44e04db0fc13af3679afe662c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781867}
-
Wez authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2255200 which added the flaky suite to the waterfall/CQ. TBR=chonggu, dpranke Bug: 1097962, 1090068 Change-Id: I9e01dfa08e7811d54296c1810e0265f80d645e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264312Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#781866}
-
Hans Wennborg authored
New Rev: 8c11f011735fedf71002e0f2f29a4a3a9546136e Upstream Review: "Include base/check.h in test_platform.h" https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2253746 TBR=johannes Bug: 1031540 Change-Id: Ibc4e620d5b535b7a07f55f0742b6a28b086b50df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263832Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#781865}
-
Bret Sepulveda authored
This reverts commit e16ff9f1. Reason for revert: Bot was still red after revert: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/15944 Original change's description: > Revert "Add StoragePartitionConfig class." > > This reverts commit 225f6f4c. > > Reason for revert: I think this is causing failures in: > virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html > http/tests/workers/worker-usecounter.html > virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html > and the "webkit_lint" step. > See example failure: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/47132 > > Original change's description: > > Add StoragePartitionConfig class. > > > > Introducing StoragePartitionConfig to make it easier for code to > > directly request the StoragePartition they need instead of having to > > go through the indirection of site URLs. Grouping the 3 attributes of > > a config into a class also makes several call sites simpler. This is > > being done as part of an effort to reduce the amount of code that > > depends on site URLs. > > > > - Created class for storing the storage partition > > <domain, name, in_memory> tuple. > > - Update GetStoragePartitionConfigForSite() and related code to use > > this new class. > > - Create BrowserContest::GetStoragePartition() method that takes > > StoragePartitionConfig as a parameter so future callers do not need > > to construct a site URL to get a storage partition. > > - Remove StoragePartitionImplMap::StoragePartitionConfig struct and > > convert StoragePartitionImplMap to use the new StoragePartitionConfig > > class. > > > > Bug: 1085275 > > Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240 > > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Reviewed-by: James MacLean <wjmaclean@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Auto-Submit: Aaron Colwell <acolwell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781691} > > TBR=acolwell@chromium.org,alexmos@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org > > Change-Id: Iec47df87cb66a779d2d569e825c9b4ecccf1f2ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1085275 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263216 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781798} TBR=acolwell@chromium.org,alexmos@chromium.org,bsep@chromium.org,karandeepb@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1085275 Change-Id: I6eaf4a96de9e08f93e450f708cf6eea5c33ec5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264292Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I97aecbf2f9195b3bae677de832446ebc48c386e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263653Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781863}
-
Hiroki Nakagawa authored
After https://crrev.com/c/2164926, ExecutionContext::GetAgent() does not return a null Agent instance anymore. This CL removes an unnecessary null check in WorkerThread class. Bug: 1074766 Change-Id: I08020af4507dc78d4cfe9236f62549c359146e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263433Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#781862}
-
Misha Efimov authored
This is needed for proper dev signing of binaries executed on the device. The alternative https://crrev.com/c/2232816 would use `setup-gn.py` script, which is more invasive. The default ios_app_bundle_id_prefix is "chromium.org" which is most likely NOT going to work for anybody. Pass the "bundle-id-prefix" argument with company-specific prefix value, for example: ``` cr_cronet.py gn -i --bundle-id-prefix="com.google" ``` Bug: 1091876 Change-Id: Id8357be2eabf5fb51b9229694c5476cfbac1bf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241186Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#781861}
-
David Tseng authored
The version can be like 11.0.1. The numbering scheme appears to have changed at some point from 1.6. R=anastasi@google.com TBR=anastasi@google.com Fixed: 1090010 AX-Relnotes: n/a Change-Id: I7fb926a0c0792ae45aea76ca1e2c097ceb8a1de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264192Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781860}
-
Max Curran authored
Bug: 1022099 Change-Id: I4bd8dd20fa7c8ffaf70d43829c6eebf170757d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261259Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781859}
-
Bret Sepulveda authored
This CL disables: virtual/omt-worker-fetch/external/wpt/workers/modules/dedicated-worker-import.any.worker.html http/tests/workers/worker-usecounter.html virtual/omt-worker-fetch/http/tests/workers/worker-usecounter.html TBR=nhiroki@chromium.org Bug: 867532 Change-Id: I65e133aef1c9841bfa8b43dd5c10a9b4f866a69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264054Reviewed-by:
-
Noel Gordon authored
Style directory tree drop target (tree-items) for files-ng. If they can accept a drop, they should have gray background (same as :hover color). If they cannot accept, they deny the drop and they should have a pinky- red background (G Red 50). Add CSS style for these cases (accepts and denies). Update the transfer controller code to add or remove classes .accepts and .denies as needed to accept or deny a drop. Note the files-ng design does not say what to do when the active folder (drawn blue) cannot accept a drop, so my decision was to turn it pinky- red too. Similarly, what to do if it can accept a drop was unspecified, so my decided to turn it gray (same as the :hover color). This way, all directory tree-items have the same drag-drop effect color regardless of whether a tree-item is the active folder or not. Bug: 1002394 Change-Id: I4ee09697e0910d56239fd56ff4760352cb9290f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262380 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781857}
-
Hugo Benichi authored
Also do not consider shill::kIPConfigProperty as a possible IP configuration dictionary. This is instead always a single string or a list of string referring to DBus path strings of IP configuration objects and therefore never contains immediately useful properties. BUG=b:143258259 BUG=b:145960788 TEST=Compiled. Flashed eve, checked ARC++ connectivity for various types of networks. Change-Id: I330edf9e2cd747252cd81a00b883f6f6094c88ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217686Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Auto-Submit: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#781856}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/654e6c9ed0c3..55c5fa2666a8 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 839704450200 to fbb9dc2cf1af (1 revision) 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9167e1e22a46 to eb0a25a189b7 (3 revisions) 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 7e8789fe571a to a173c025f8fe (1 revision) 2020-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 76ddcca9f3a4 to 45c73d999ed8 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Id1cfa52b934e1e001580ed324c7f227697d93a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263188Reviewed-by:
-
Behdad Bakhshinategh authored
This reverts commit 822a9853. Reason for revert: crbug.com/1098750 Original change's description: > Ensure no frames have been decoded for video context loss tests. > > Once we have a valid video frame back from the decoder, we assume the > decoder is good and toss the encoded data we hold onto for fallback. > > It's unclear to me how the current tests have ever worked. Since we > only fire canplaythrough after 4 frames have been decoded. > > The fix for this is to ensure we don't decode any frames before > triggering the gpu crash. This is fine for the purpose of this test > which is for testing the rendering and not decoding. > > R=kbr > > Bug: 1082761 > Change-Id: I7e798ff219ded36582b1576919b6e5bf9541f5fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258772 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781665} TBR=dalecurtis@chromium.org,kbr@chromium.org Change-Id: I02d1798b3799971d24229d95150cc76113ff9575 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264254Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781854}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592981921-d7f3480d3d068518c011ab351ddf99cd52e5b689.profdata to chrome-win64-master-1592992485-a3304fe8e62cee32c33382f74cb798b9cbbe04f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: Ica5c5755e2d2d4426a065c3d3595fcab0f1a185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263184Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5478250.html" to utilize |selection_test()| and renames to "copy_and_paste_with_link.html" for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I71860eb0a193814aae6b0aa63a5e42cf4e31bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262161 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#781852}
-
Gauthier Ambard authored
When the sessions are being restored, the UserAgent is wrongly restored because the AUTOMATIC description wasn't added to the list of string describing the different UserAgent. Fixed: 1097794 Change-Id: Idf6d4e68a2e7b1ae634809deba2c7e03f3a2ac88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256216 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#781851}
-
Jérôme Lebel authored
This reverts commit 053f6124. Reason for revert: AddAccountSigninManagerTest fail on iOS 12: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9356 Original change's description: > [iOS] Remove unused ChromeIdentityInteractionManager APIs. > > This patch removes the old, unused APIs for adding an account to Chrome. > > Bug: 1078815 > Change-Id: I0ec5d29af7566d8287090ee83b8a67d4a1abb9ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226809 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781345} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: I7aa551337517a9c2b4a106e1530b7add58d00f8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264333 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
