- 05 Dec, 2020 18 commits
-
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: I1d55e3df22e9b16427de44ba229a1ce05528c6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572997Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833951}
-
Liquan (Max) Gu authored
Before the CL, CPRService did PaymentUiService.getContactSection().getSelectedItem(). This is not convenient for unit tests because the tests have to mock the contact section and the selected item. This CL changes it so CPRService accesses the selected contact by proxy of PaymentUiService. Bug: 1155582 Change-Id: I393f27594024cfb609ba99f212ac034c92a19b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575341 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833950}
-
Dan Sanders authored
Creation of ImageBitmaps from VideoFrames is implemented using a viz::RasterContextProvider in //media. Such a thing is available from Platform on the main thread, but not in workers. This CL exposes the underlying viz::RasterContextProvider from WebGraphicsContext3DProvider so that the //media code can be called using the SharedGpuContext context. Bug: 1148849 Change-Id: Ie69e84e423f7e6f4aca13b7b86bcf178b3e15958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570331 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#833949}
-
David Schinazi authored
This CL adds all information from connection close frames to netlog to facilitate debugging. R=renjietang@chromium.org Change-Id: Ia158f2e711aa455e30a790e80e1739b5707fc346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575696 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833948}
-
Kyle Williams authored
Resolve transient compiler errors when referencing functions do to missing COMPONENT_EXPORT annotations. BUG=b:174842932 TEST='autoninja -C ~/chromium/src/out_${SDK_BOARD}/Release chrome chrome_sandbox nacl_helper' Change-Id: I1867ff1703b1337910788967f5df02ae16be5dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574496Reviewed-by:Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833947}
-
Jeffrey Kardatzke authored
This reverts commit 78556ccd. Reason for revert: Fixed crash Original change's description: > Revert "media: Fix crash when releasing decoder with ChromeOS CDM" > > This reverts commit 883c24e8. > > Reason for revert: Segfaults if not encrypted content > > Original change's description: > > media: Fix crash when releasing decoder with ChromeOS CDM > > > > When the VaapiVideoDecoder was released, if it was using the CdmContext > > it would have a callback associated with the CDM. Upon destruction of > > the decoder, that callback would be destroyed automatically which makes > > a call into the CDM. The CDM is being destructed on another thread, so > > there was a race and this could cause a crash. > > > > The fix is to maintain a CdmContextRef in the decoder which keeps the > > CDM alive until the decoder is destroyed. > > > > BUG=b:153111783 > > TEST=Page refresh 10 times in a row w/ CDM did not crash > > > > Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 > > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833863} > > TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I11cd7d74a92bca26e51727ccbc494cc178008320 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:153111783 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575717 > Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Cr-Commit-Position: refs/heads/master@{#833914} TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: b:153111783 Change-Id: I5776a90da74977ac1d6286a9d6148939175cff4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575718Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#833946}
-
Hiroshige Hayashizaki authored
Reflecting https://github.com/WICG/import-maps/pull/229 Bug: 848607, https://github.com/WICG/import-maps/issues/207 Change-Id: Id056b3fd27489ecdfe45456220fd1d8c01dc8d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833945}
-
Jeffrey Kardatzke authored
This doesn't fully fix VP9 decrypted decoding, but it makes the VP9Decoder changes cleaner than they were. It also adds a call that was missed in the accelerator for setting the crypto params if we seek back to clear content. This still has corruption on screen, especially if there's UI activity over the video. But still not sure how that matters. BUG=b:153111783,b:155509231 TEST=VP9 decrypt+decode works mostly Change-Id: Ib2ee90e6ce8fb6f2087c595e1a765e0481cc6249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567150 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#833944}
-
Ken Buchanan authored
Add IdpNetworkRequestManager, which controls state for network transactions between the browser and the Identity Provider. This change also adds the initial sequence for the permission-based flow. Bug: 1141125 Change-Id: I0e836c7a00543fcd239aff44a5ee6bbc13daced9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569373Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833943}
-
Jacques Newman authored
Basic implementation of NGGridLayoutAlgorithm::ComputeMinMaxSizes. Bug: 1045599 Change-Id: I0780fba7bc3384bead7ebc059f872e010751b45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569848 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833942}
-
Adam Ettenberger authored
third_party/blink/renderer/bindings/core/v8/dictionary.h is included by dom_rect.h, but this seems unnecessary since neither dom_rect.h or dom_rect.cc use blink::Dictionary or other structures defined in that header, so removing the include. Bug: none Change-Id: I9e55447a979e4cc0a16c187c88104c04eabfab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575049Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833941}
-
Yue Li authored
Since we only use the first result from search request, set the page size to 1 to reduce the delay. Bug: b/173239982 Test: None Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#833940}
-
Yue Li authored
Extend the expiry milestone of AutoSelet chrome flag which is still in use. Bug: None Test: Locally build and test Change-Id: I9f36f407f80812b5109db8297d4fb990817c54aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574075Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/download. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=shaktisahu@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ib95d998cea01e034527987da76662d47710783f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575375 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b37eb4854762..2008dd6e00cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139446,chromium:1144019,chromium:1152718,chromium:1153038 Tbr: sergeyu@google.com Change-Id: Ia95030153fed9f06ff749c922f9f1b02da5dec66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833937}
-
Danyao Wang authored
The Payment Request API requires that show() be called with a transient user activation. This CL adds enforcement behind a runtime flag. Bug: 825270 Change-Id: I39782301f5c4aaed32a664d3803c9142747dc41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574781Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#833936}
-
minch authored
Bug: 1147245 Change-Id: I1927ea3fc3ddf88e62719fca4677407e64604cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564328Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#833935}
-
David Maunder authored
The display logic was written before the user ability to turn off price drops was introduced. The code needs to be updated to hide the price box (upon next render of the tab grid) if the feature is turned off. Turning the feature off means the SHOPPING_PERSISTED_TAB_DATA_FETCHER is null. Bug: 1155731 Change-Id: I734ffd3538ee62cbd5ea8314d7f6eb76a5931985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575419 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833934}
-
- 04 Dec, 2020 22 commits
-
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4324.9-1606733211-benchmark-89.0.4337.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4339.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7b75fe645b5d5d0d52bf6a87f372924f3f38dfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833933}
-
adamta authored
Adds a feature flag to toggle between the existing NTP and the new, refactored one. Bug: 1114792 Change-Id: I605ccd3ace368bb2c6dc0683fe9a7af11f566cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575438 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#833932}
-
Carlos IL authored
The current explanation for the mixed form interstitial was ambiguous as to what "not completely secure" meant. This replaces the string with one that explicitly mentions an insecure form. Bug: 1153964 Change-Id: Ie07496b36cc26655fd1d7afcc01e5a32b864c41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575395 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833931}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fcbaead2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia363b8af10717a541e19844baf6214b4c3b42c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575856Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833930}
-
Sinan Sahin authored
Bug: 1134912 Change-Id: I8810edf6705672216d5ee92546045c4ae32f8c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572685 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#833929}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I31becf49da4355d6f881826924a7959690bb47b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575113Reviewed-by:
-
Josh Santana authored
Renamed methods in translate_prefs.h and translate_prefs.cc that used "blacklist" and "whitelist" to more inclusive/descriptive names like "NeverPromptList" and "AlwaysTranslateList" This required me to also go through and fix the references to these methods in a variety of files. More name changes to come for the rest of Translate API, but due to the amount of affected files with just translate_prefs I kept this CL only to the scope of prefs. Bug: 1028966 Change-Id: I959b8e1aa6cc1cc2510b6eca2589635d214795bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568155Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Joshua Santana <joshsantana@google.com> Cr-Commit-Position: refs/heads/master@{#833927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc3c41b8742a..ae95077db60b 2020-12-04 nifong@google.com fix another m44 bug in debugger 2020-12-04 johnstiles@google.com Use references instead of pointers for Metal out params. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ic4591d34850f1d5970a178fb89df2981af44ed9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575441Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f31b78e90e1e..c532048062be 2020-12-04 natlee@microsoft.com Add testing and implementation for lazy init compressed textures 2020-12-04 senorblanco@chromium.org Fix base vertex toggle. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ib7c364c6d178b3376d94a372c5a879a89490b23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575799Reviewed-by:
-
Elly Fong-Jones authored
I missed disabling these when disabling failing mac-arm64 tests. They will be fixed as part of fixing the linked bug. Bug: 1154345 Change-Id: I344ad7adab1c8bde228ead069c2a9fa21a1d6dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575345Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833924}
-
Clark DuVall authored
The chrome split can take a long time to load, so we get significant improvements in startup time if this work is offloaded to a background thread. Ideally, we would give as much time as possible to allow this preload to finish, which means running as much code as possible which does not depend on the chrome split during the preload. This required refactoring much of attachBaseContext into the base module, and moving the pieces which could not be easily moved to the base module into onCreate. The order of startup generally goes: 1. Application.attachBaseContext 2. Each provider is instantiated in order, and onCreate is called 3. Application.onCreate If a provider lives in a split, it will call createContextForSplit on the application. This will end up being the first thing needing the chrome split, which will wait for the preload to complete. This is why ChromeFileProvider was moved to the base module, so there could be more time to preload. Pinpoint runs: Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/16925180d20000 -7% messageloop_start_time -3% first_contentful_paint_time -3.8% navigation_commit_time Android Go: https://pinpoint-dot-chromeperf.appspot.com/job/115e53e7520000 -18.7% messageloop_start_time -1.5% first_contentful_paint_time -2.1% navigation_commit_time A couple notes: - setUsageAndCrashReportingFromNative was removed from UmaUtils because it is never used, and allowed for much more easily bringing UmaUtils into the base module. - I wanted to make sure PureJavaExceptionHandler is still set up as early as possible, so left it in attachBaseContext. This required loading PureJavaExceptionReporter by reflection if an exception happens, since it has many hooks into chrome code. - MainDexApplicationImpl is no longer needed since all the common code was moved to SplitCompatApplication Bug: 1150600 Change-Id: Idd6c11293e47fa5e8bd6eb30c14535e60c204867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570125 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833923}
-
Jesse Schettler authored
Update responsive app dimensions to conform to the spec at https://carbon.googleplex.com/cros-ux/pages/scanning/responsiveness. Bug: 1059779 Change-Id: I2225a97125d33be917dce1e5945dfb6908e1ed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575738 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833922}
-
Jesse Schettler authored
Ensure each select element has a unique id that can be used to find the element in tast tests. Bug: b:173556456 Change-Id: I90b232af27559020f556bb451b1748c8c566c55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575757 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /chrome. The methods themselves will be removed in a follow-up CL once all call sites have been removed. Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Iee7432af1c85476a4f052f08ba1e2e62660574da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575328 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#833920}
-
Ben Pastene authored
crrev.com/i/3447173 allocates the machines for this. Bug: 1140727 Change-Id: I0b92100a9b9f449202d7a8c13f4ff1d3f76e1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575749Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833919}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib895e1f00288155e9c8f58fc5bda773cc58f456b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572985Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833918}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607070900-a3f370d99263588b261e824540349b020ef94941.profdata to chrome-win64-master-1607082643-c2f5265b374c0786e9c504f581789ab6e6bb2b7f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8b2bc7b0581471877af97ec193ed0d5071ed3d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575104Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /services/device/usb. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Id274f5e9679078c6071f058b95969d7dfae9d19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575333 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833916}
-
Xiaocheng Hu authored
This patch adds a basic UA style sheet for the 'decimal' and 'disc' counter styles, and plumbs them into RuleSet. This is in preparation to implement tree-scoped counter style references. Bug: 687225 Change-Id: If4effec939a2bfdedc5079e95c4c593f622db652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574071Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833915}
-
Jeffrey Kardatzke authored
This reverts commit 883c24e8. Reason for revert: Segfaults if not encrypted content Original change's description: > media: Fix crash when releasing decoder with ChromeOS CDM > > When the VaapiVideoDecoder was released, if it was using the CdmContext > it would have a callback associated with the CDM. Upon destruction of > the decoder, that callback would be destroyed automatically which makes > a call into the CDM. The CDM is being destructed on another thread, so > there was a race and this could cause a crash. > > The fix is to maintain a CdmContextRef in the decoder which keeps the > CDM alive until the decoder is destroyed. > > BUG=b:153111783 > TEST=Page refresh 10 times in a row w/ CDM did not crash > > Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833863} TBR=xhwang@chromium.org,jkardatzke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I11cd7d74a92bca26e51727ccbc494cc178008320 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:153111783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575717Reviewed-by:
-
Ian Kilpatrick authored
After some investigation (building testcases) this doesn't appear to be needed. Bug: 958381 Change-Id: Iaaac7e3579ecfff5fcee1a4b2055dcaabf3cd3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575739 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833913}
-
Carlos IL authored
Hidden class sections of interstitials are used for UI that is not being displayed, but for main-content and details, display:block was being added (and replacing display:none). This caused the sections to become audible in screen readers even when they were not visible. Since any section with class=hidden is not visible, this does not change the visible layout of the interstitial at any point. Bug: 1061611 Change-Id: I18179097e4b15659c2bb0ad5ebb556d9cebb114d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575329 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833912}
-
