- 18 Nov, 2019 40 commits
-
-
Chris Davis authored
Update ETW manifest usage so chrome.dll can be used to register the ETW provider. Prior to this a DummyChrome.dll was needed which registered the ETW provider used by Chrome. The chrome_events_win.man file was updated to be a general application manifest containing a instrumentation section. The chrome_events_winTEMP.BIN and MSG00001.bin files are auto-generated by the manifest compiler. chrome.dll size (release x64) Before: 122,627,584 After: 122,629,120 Total Increase: 1536 bytes BUG: 1024949 Change-Id: Ibb3783da20a35a5caeabab93bd2da10a2cf67faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896040Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#716375}
-
Jeremy Roman authored
The separate observer has a couple of advantages. Firstly, it allows waiting and access to occur after the content::Portal (and its interceptor) may have been destroyed. Instead, it's valid as long as the Portal is valid when the observer is created. Secondly, it allows examination of the activate result. Since there are existing tests which rely on the ability to observe activation immediately after a portal is created or adopted (ideally we would more explicitly sequence these events in the test, but this is not always possible), the created observer is augmented with the ability to run a callback immediately (rather than after the run loop quits, which is subtle due to other work in the same task and nested run loops). This is used to create a PortalActivatedObserver immediately when the Portal is created, before the browser UI thread can process any task which might either activate or destroy the Portal. This mostly makes PortalInterceptorForTesting an implementation detail of the more specific observers. Change-Id: I6ee3bd8e847235654cc4a063659818e2e970c2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900258 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#716374}
-
Xianzhu Wang authored
- compositing/3d-cube.html is modified to a pixel test instead of a ref test because there seems no way to make the ref test pass. The new pixel result is platform independent. - compositing/video/video-controls-layer-creation-squashing.html is modified from a ref test to a text test because what we care about is how we composite the layers. - paint/invalidation/compositing/*-float-under-*-inline.html are updated to expect the new LayoutNG result. They are now expected to fail with LayoutNG disabled. - Other rebaselines. Change-Id: Ieeb195dfeea6b8478cf90b77f03a0a84984f6281 Bug: 726075, 591099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915459Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716373}
-
Mike Wittman authored
Implements browser tests to verify that startup profiles taken in the browser and child processes are received by the metrics provider. To work within the test timeouts and to avoid non-determinism this requires a couple adaptations to be made to the code when run under these tests. The profiling period is reduced from 30 seconds to one second, and profiles are taken in all renderer processes. The behavior is enabled by providing a 'browser-test' argument to the existing 'start-stack-profiler' switch. The main thread profiler for browser tests is moved later, after the command line is set up, to be able to observe the added switch argument. StackSamplingConfiguration is made responsible for the sampling parameters, reusing the GetSamplingParamsForCurrentProcess() function which was previously unused. Bug: 1011877 Change-Id: Ibad55178ebd3ff5ea497971868c9619210c2c8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900262 Commit-Queue: Mike Wittman <wittman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#716372}
-
nancy authored
AppServiceAppModelBuilder is used to replace InternalAppModelBuilder. AppService integration to ui/app_list has been enabled for a couple of months, so it should be safe to remove InternalAppModelBuilder. Unit tests are updated to use AppServiceAppModelBuilder. I will use a separate CL to move the internal_app_model_builder_unittest.cc to src/chrome/browser/ui/app_list/app_service/, and convert it to AppService unit tests. This CL still uses internal_app_model_builder_unittest.cc, as it is more clear to show the change. BUG=1016159 Change-Id: I2d537aa940eae29201dd64bb7b345d3ae820d777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919534Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716371}
-
Matt Wolenetz authored
Flaky timeout occurs on linux and mac10.10 for testIFrameWithExtensionsSource, and on mac10.10 for testNoSuchElementExceptionMessage. BUG=1026018 TBR=jbudorick@chromium.org Change-Id: Ib91536f5ab2f81262a9ae913ceaf6944b0b98283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922647Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716370}
-
Bettina authored
Previously, we filtered out low reputation sites from the modal warnings shown for phished svaed passwords. However, low reputation and phished sites should be both shown as warnings. Bug: 1026000 Change-Id: I425198650c387bdccbb72769c45d054f91075e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921654Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#716369}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/39da10b5563f..ff2f380fd37a git log 39da10b5563f..ff2f380fd37a --date=short --no-merges --format='%ad %ae %s' 2019-11-18 robertphillips@google.com Only access the scissorState's rect when it is valid 2019-11-18 brianosman@google.com Remove some SK_API from src/ 2019-11-18 halcanary@google.com DEPS: add third_party/externals/libgifcodec 2019-11-18 halcanary@google.com GN tool: copy_git_directory.py script 2019-11-18 michaelludwig@google.com Make TessellationHelper resettable Created with: gclient setdep -r src/third_party/skia@ff2f380fd37a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I0e5733b3bd23c21874e02dcb3af03fef9f21e602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716368}
-
Donn Denman authored
Fixes a highlight bug in the narrow panel of the expanded old Bar layout. Now we adjust the x touchpoint offset by the position of the narrow panel in the tab. BUG=1025905 Change-Id: I2adf0ddf72283454bc711ae4cfb4d3975fc92351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921346 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#716367}
-
Glen Robertson authored
Change-Id: I813d1797761da3d52369484f211695bc22af0dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914589 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716366}
-
Jinfeng Ma authored
1. Update related comments. 2. Rename the local variable which may assign to this Vector. Bug: 1006173 Change-Id: I5ff5c6b3c9e6b10504fe988480df879209be5f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921927Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716365}
-
Shakti Sahu authored
This CL adds 1 - Fixes default favicon to show the globe icon 2 - Fixes vertical alignment of favicon 3 - Adds the close button back 4 - Makes open_in_new_tab button visible only when in full state Bug: 1025085, 1025084, 1025088, 1023659 Change-Id: I2dff5b9949fb33dba4c0b6f009ca5ee92503d8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918646 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Joel Hockey authored
Terminal System App is not able to access chrome.storage.sync so we will provide terminalPrivate functions to store settings as a syncable pref. Bug: 1019021 Bug: 1022250 Change-Id: I54e089f1a07f520eaf3747ac405a56e883ba1908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921016Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#716363}
-
Kevin Ellis authored
This patch aligns the following methods with the spec: playbackRate setPlaybackRate updatePlaybackRate EffectivePlaybackRate reverse https://drafts.csswg.org/web-animations/#reversing-an-animation-section Per spec, we no longer reset the start time when a new pending time is required. The variable playback_rate_ now reflects the rate currently in effect, rather than the rate that will be in effect once the animation is ready. Bug: 960944 Change-Id: I65dd99515462e0041b43ff208bc523f6b2920563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895372 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#716362}
-
Renjie Tang authored
Bug: 978745, b/142269595 Change-Id: I6b16514985602f3e8463d2934ae5bb767a0f9af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922590Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#716361}
-
Joe Mason authored
This is a reland of 71d76ec9 with two changes: * Disable the unit test on Windows 7, which does not support nested jobs. * Remove a bogus NOTREACHED that was causing the child process to die too early. On the CQ bots it happened to die just before we called TerminateProcess anyway so this didn't cause failures there. Original change's description: > Kill the software_reporter_tool process if the browser exits early > > Assign the software_reporter_tool process to a job object with the > KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed > if it's still running when the browser exits. > > R=proberge > > Bug: 1016939 > Change-Id: I87dfc907cc853add1721f80c589051896ed4e857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715997} R=proberge Bug: 1016939 Change-Id: I633ebe5f87ab694e4c48a3097bda7c13d0ad4ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922474Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#716360}
-
Lukasz Anforowicz authored
ExtraRequestCompleteInfo relies only on origin-related parts of the url. This means that we can replace the |GURL url| field with |url::Origin origin_of_final_url|. This helps sanitize the URL in the future (possibly removing the path and/or query parts in some cases). Bug: 973885 Change-Id: Iac54c27a5f8d3b1d80463f0092d31324cc928fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894153 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#716359}
-
Matthew Jones authored
Bug: Change-Id: Ic4c8a01624c33202feccc4c24932ebf449dcd488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922411 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#716358}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f6ea6efa9de..665be402b23d Created with: gclient setdep -r src-internal@665be402b23d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia17c50b70829865608c8420e83ef70ca59b578ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716357}
-
Matt Wolenetz authored
This change expands the disabling of this test from Win ASAN to everywhere due to flakiness on wide variety of builders. BUG=1026001,998369 TBR=karandeepb@chromium.org Change-Id: I51b0ae7596a0c8739cce0713a1c11803546a1979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922559Reviewed-by:
-
Tarun Bansal authored
Fallback prerender requests to preconnect when it's not possible to do a prerender. This primarily affects low memory devices. This is behind kPrerenderFallbackToPreconnect feature. Currently, this fallback is enabled for only the prerenders initiated by omnibox. This CL extends it to other cases as well. Change-Id: Iaf51b73d10a6c8f90f06ab4629ecf7d13f4a992f Bug: 943442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920430Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#716355}
-
Rayan Kanso authored
Grab available icons and pipe down to contacts provider. Bug: 1020564 Change-Id: Ia81bb00567a937ea3f6e7aa3a992cdaac2e9d16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893068Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#716354}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91513b431669..2577dd772d69 git log 91513b431669..2577dd772d69 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 vapier@chromium.org cbuildbot: abort on all legacy cq build code paths Created with: gclient setdep -r src/third_party/chromite@2577dd772d69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib88add6b706f8fbe1edc6a7255db521832cb8c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922410Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#716353}
-
Matt Menke authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1914973, I moved the V8 proxy resolver code from net/ to services/proxy_resolver, but didn't update the namespace, for easier review. This followup CL fixes the namespace of the moved code. Bug: 1007962 Change-Id: Ic4d44a2773c732437073496de9a07e2cf362d303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914943Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#716352}
-
Doug Arnett authored
Bug: 1025861 Change-Id: I439831c35802d9a0238ad8f482814724a4c289ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921639Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#716351}
-
Andrew Xu authored
There is no reason to hide the hotseat when the shelf context manu is showing. If there is any edge case that we really need to hide the hotseat with the context menu showing (I cannot come up so far), we should close the context menu first. Add a unit test case for this scenario. Bug: 1020388 Change-Id: If38d376fff27a1fd63f02c1a6a7cb323e73e8936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747386 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/839a6520..94acd86a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f481247de3aebc9d7023e52a348d9a7773678a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716349}
-
Daniel Cheng authored
Bug: 1025358 Change-Id: Iadef27f215c7a4dccd307ad32f4fbe5649403fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919821 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716348}
-
Daniel Nicoara authored
Provide a way to resize the Webview independent of it's container. Follow-ups will remove the LayoutManager. Though, for now we need to leave it so it doesn't break the current behavior. Bug: b/143612326 Test: Manually on device Change-Id: I913ecc699eafa4fd3feb46e07db6a894ecb53747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922557Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#716347}
-
James Hollyer authored
In order to be more explicit use BindOnce instead of Bind. Bug: 1007640 Change-Id: Ifd0e754b189da878c76832b62efab23e1895d4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864097Reviewed-by:
-
Ken Rockot authored
This reverts NaCl processes to use only the Legacy IPC Channel (over Mojo) for all IPC, rather than bootstrapping them as Service Manager service processes just so they can then bind an IPC Channel. To support this, Browser/ChildProcessHost is modified to support such processes if so configured at construction time. This "legacy mode" for ChildProcessHost can be removed if/when NaCl processes are removed from Chrome. Some light groundwork is put down for further refactoring as well: namely the Mojo invitation ownership is lifted into ChildProcessHost, and a ChildProcessHost::IpcMode enum is introduced to select what mode different process types will operate in. Follow-up CLs will introduce a new IPC mode and incrementally port all other process types to it. IpcMode::kServiceManager will be removed in the near future, and IpcMode itself will be removed completely (bringing ChildProcessHost back down to only one mode of operation) once kLegacy can be removed too. Bug: 977637 Change-Id: I1abec0fe8ad7b2a18bddcdd467657447c641370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915320Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#716345}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/dd6b19ec37f3..0d10afabcf7a git log dd6b19ec37f3..0d10afabcf7a --date=short --no-merges --format='%ad %ae %s' 2019-11-18 9856269+sarahM0@users.noreply.github.com Add spvc parser support for control flow instructions (#894) Created with: gclient setdep -r src/third_party/shaderc/src@0d10afabcf7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ie3d523e7bc8c81b83f2243d7ba36fe50e1564200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922408Reviewed-by:
-
Tommy Steimel authored
This CL adds logic to MediaNotificationService::Session to dismiss its MediaNotificationItem after an hour of inactivity when paused. Bug: 1025439 Change-Id: Ie2374b1f25bcbf332dace4ffa1220507d22f1a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920017 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#716343}
-
jonross authored
A series of skia_renderer_pixel_skia_gold_tests began failing on Windows when ran with SkiaRenderer on NVidia. This suppresses those tests until the root cause can be fixed TBR=ynovikov@chromium.org TEST= skia_renderer_pixel_skia_gold_test Bug: 1003040 Change-Id: I0c6353b8583f75e90dfb8a7005ee79fe2ce08e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922233Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716342}
-
Andrew Grieve authored
Bug: 1003532 Change-Id: I8b3ec212067c0bfd145258e645c42db7ae140790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919734 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
shrekshao authored
Driver workaround for BaseVertexBaseInstance Extension on Mac exists in ANGLE. We need to turn it on for passthrough on Mac. Bug: 1025719 Change-Id: I8223e50f52430e657fa6a0ceb334099d2f6418b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922357Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#716340}
-
Peter Kotwicz authored
This CL refactors CustomTabTaskDescriptionHelper in preparation for making WebAPKs use CustomTabTaskDescriptionHelper This CL: - Makes CustomTabTaskDescriptionHelper a LifecycleObserver and moves logic to determine whether to customize the task desckription to CustomTabTaskDescriptionHelper - Replaces the use of TabModelSelectorObserver and TabModelSelectorTabModelObserver with CustomTabActivityTabProvider.Observer - Replaces CustomTabTaskDescriptionHelper#mCurrentTab with CustomTabActivityTabProvider#getTab() BUG=989912 Change-Id: Iebde1ece8b00bf5c532b2f38ed1cfec24a4f1982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907520 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#716339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8ea23db0091..39da10b5563f git log a8ea23db0091..39da10b5563f --date=short --no-merges --format='%ad %ae %s' 2019-11-18 nigeltao@google.com Optimize SkWuffsCodec pixbuf zero-initialization 2019-11-18 egdaniel@google.com Make GrSemaphore no longer derive from GrGPUResource. Created with: gclient setdep -r src/third_party/skia@39da10b5563f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I982a68de46c7211e90f32a586fa6967fe2b1b453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921563Reviewed-by:
-
Tina Wang authored
Bug: 1025981 Tbr: jbudorick@chromium.org Change-Id: I80bfe9163aa1f270e3af452f73cb8424974b64e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922191Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716337}
-
Alex Ilin authored
This CL updates ProcessMemoryDumpTest::CountResidentBytesInSharedMemory test to use the new shared memory API. The old API, base::SharedMemory, is being removed. Bug: 795291 Change-Id: I9aa24c6f80c8a75f669b983f8ac1731b76d167dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920120Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716336}
-
