- 15 Nov, 2019 40 commits
-
-
Rohit Rao authored
This reverts commit c273c91d. Reason for revert: Tests fail due to multiple elements matching in SettingsMenuBackButton(). Original change's description: > [ios] Move password settings tests to EG2 > > Bug: 987646 > Change-Id: I9e21ec812293136797b80af8c4b189331941a111 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903363 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715258} TBR=eugenebut@chromium.org,gambard@chromium.org,djean@chromium.org Change-Id: I6cf4a218cfc12f341591ee4a1ddaaf79f8e8d307 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918183 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715554}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a01b4b322a5..11c487a891eb git log 1a01b4b322a5..11c487a891eb --date=short --no-merges --format='%ad %ae %s' 2019-11-14 timvp@google.com Manually copy dEQP data files to output directory Created with: gclient setdep -r src/third_party/angle@11c487a891eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: If5681401b20a7d90cf4291351bcb08bd7cb28b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715553}
-
Daniel Rubery authored
This CL adds tests that verify that when the Finch flag or policy are disabled, no data is uploaded. Fixed: 1021943 Change-Id: I41d61614d84a169d48e878802b84815b384d0442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904614 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#715552}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::EmbeddedSearch using PendingAssociatedReceiver, AssociatedReceiver, and AssociatedRemote. Bug: 955171 Change-Id: Ia318dd332a4d77f2deb287b47d7338159ad43047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897402Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#715551}
-
Xiaohan Wang authored
Currently PipelineImpl always uses the CreateRendererCB to create the Renderer asynchronously, which involves a post to the render main thread and another post back to the media thread. This has caused regressions in start-to-play-time especially on lower end devices. This CL partially restores the previous behavior by creating a default Renderer on the main thread before pipeline start. The default Renderer will be used in normal cases so we avoid the round trip to the main thread to create the Renderer. In special cases where we need a different Renderer, the CreateRendererCB will be used to create one. Bug: 1018372,1023579 Test: Tests updated Change-Id: I71627a959cdfe12cd0f5ef0ee358f461323f5a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915226 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#715550}
-
Nate Fischer authored
The link to the android_emulator page should have been an absolute link, not a relative one. Bug: 918221 Test: tools/md_browser/md_browser.py android_webview/docs/webview-shell.md Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6bae38ef2b111534604beae2442fc28e93038f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913616 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715549}
-
Dave Tapuska authored
This change moves the definition of EnforceInsecureRequestPolicy from FrameHost to LocalFrameHost in blink. It removes the public definition on the WebLocalFrameClient as it isn't necessary anymore. BUG=1008432 Change-Id: I4d9723af3bb59d5cf05484a86f46bee834feb3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894021 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715548}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/026ada55a386..166ae14e035b Created with: gclient setdep -r src-internal@166ae14e035b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:925041,chromium:1023537 Change-Id: I125649cb270b8596b6931bd6d8244fd59a8e1a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715547}
-
Wez authored
This reverts commit f93bc96d. Reason for revert: This broke the fuchsia-*.cast bots, e.g. see https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/60162 with this assertion firing. Original change's description: > views: Assert toolkit_views=true in BUILD.gn > > Now that Chromecast Linux enables this, all builds that link //ui/views > are enabling this in GN. Add an assert so that accidental dependencies > are diagnosed by "gn gen". > > Bug: 1021770 > > Change-Id: I681645e97f69c22ee0410c1dba95319fddef7038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898622 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715524} TBR=spang@chromium.org,robliao@chromium.org Change-Id: I5f0d6bba6d10ac475ba89926abe523391695f1ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918654Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#715546}
-
Evan Stade authored
The crash is pretty rare and I'm not sure what scenario triggers it. It seems like it should be covered by existing tests (FindTest.java), but apparently is not. Bug: 1022056 Change-Id: I065e3a3034d030f9aef30fd2f0c6735a94a7d688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911968Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#715545}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef60c912..cd162a62 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb508d308e57707665b81807ccf053ffb95ad0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917089Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715544}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/935c827ec93c..6ced335afb0e git log 935c827ec93c..6ced335afb0e --date=short --no-merges --format='%ad %ae %s' 2019-11-14 aboxhall@chromium.org Update Accessibility model when Accessibility pane is shown. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6ced335afb0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1024700 Change-Id: Ie363112baffc7b12f77942fb005c03a9f748d99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918559Reviewed-by:
-
Wanming Lin authored
This CL removes NDEFPushOptions.timeout relevant implementation and tests per spec change at: https://github.com/w3c/web-nfc/pull/428/files Bug: 520391 Change-Id: Ifea11f4a7bbe8b126d8a4a32169fcaacebfb0f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894677 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#715542}
-
James Vecore authored
The multidevice setup dialog is run in a separate window with a new html head/body as a non-modal dialog/window. The <head> element did not have a <title> element which caused ChromeVox to read "Web Content" as the page title. This CL adds a localized dialog title as a <title> element to the <head> element. The ARIA spec does not allow using something like role="dialog" on <title>, <head>, or <body> so we have no easy way to make accessibility announce the window as a dialog. To work around this, we explicitly add "- Dialog" to the title to give a pause and read like it would for an in-window dialog. This is done based on related advice here: https://groups.google.com/a/google.com/g/cros-system-services/c/2YRC80T875M Fixed: 1005994 Change-Id: I4e7c6963961711449c83374482b37430c57b818d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914902Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#715541}
-
Gary Kacmarcik authored
This adds an option that can be called from the website to ensure that the correct permissions are granted for IT2ME. This needs to be done through the ME2ME NMH because the IT2ME NMH is combined with the host code and it is possible for the OS to kill the host process as part of the permission granting process. Change-Id: I7e09444b5d6dcb4acfeea454fd3af197bbeab151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918297 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715540}
-
Ken MacKay authored
Bug: internal b/143493376 Change-Id: I5452d711c6c6b95da551f17ee528c7544b39d005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918292Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715539}
-
zhaoyangli authored
Major changes at WprProxySimulatorTestRunner: - Added a new class variable |host_app_path| for eg2test. - Changed command running test from iossim binary file to Xcodebuild. Created command with |Eg2testsApp| and |LaunchCommand| classes from xcodebuilder_runner.py. - Moved it to a new file wpr_runner.py for clearer structure. - Changed runner tests correspondingly and moved them to new file wpr_runner_test.py. Other changes: - In run.py, added |host_app_path| parameter when initializing |WprProxySimulatorTestRunner|. - In test_runner.py, deleted trusted certificate if exist as it can't be overwritten per permission settings. Moved trusted cert related logic to wpr_runner.py. TEST=src/ios/build/bots/scripts/run.py --app src/out/Debug-iphonesimulator/ ios_chrome_autofill_automation_eg2tests_module-Runner.app --host-app src/out/Debug-iphonesimulator/ios_chrome_eg2tests.app --args-json "{\"test_args\": [], \"xctest\": true, \"test_cases\": [], \"restart\": false, \"xcode_parallelization\": false, \"xcodebuild_device_runner\": false}" --out-dir ${ISOLATED_OUTDIR} --retries 3 --shards 1 --xcode-build-version 11a420a --mac-toolchain-cmd mac_toolchain --xcode-path /Applications/Xcode.app --wpr-tools-path ${WPRPATH} --replay-path /Users/zhaoyangli/Desktop/projects/auto-auto/recipeReplayDataSubset --iossim src/out/Debug-iphonesimulator/iossim --platform "iPhone X" --version 13.0 Bug: 1003605 Change-Id: Id336fa2e0a73cd0331dc2b97333e7e8a562180da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876757 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:John Budorick <jbudorick@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715538}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/966c82596b15..1a47081b61b7 git log 966c82596b15..1a47081b61b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 vapier@chromium.org cros: speed up basic commandline parsing Created with: gclient setdep -r src/third_party/chromite@1a47081b61b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I47a0ef1a1208dfc11016b36b715a5cc35e26bd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918561Reviewed-by:
-
Weiliang Chen authored
This is a reland of 79e07a5d Was reverted due to crbug.com/1022911 but unit test fix is landed. Original change's description: > viz: Use Build Flags to Maintain A Single Overlay Candidate Type (Reland) > > For each platform, we only use one overlay candidate type. Use build > flags to manage that. This also helps unify different platforms' > ProcessForOverlay API. > > This CL is a kindred spirit with crrev.com/c/1664476, but is rebased on > top of ToT and crrev.com/c/1739980. This is CL 2/? for the overlay > processor refactor. > > R=rjkroege > > Bug: 963597 > Change-Id: I3a560bf8da3c8e86227cb7c43d15ba4c437b8764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753810 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713453} Bug: 963597 Change-Id: I45e8c4740eb3e37bf6e775bcebfc5861eee87fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909644 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#715536}
-
Yuri Wiitala authored
Includes updates to "platform glue code" to support recent platform API changes. https://chromium.googlesource.com/openscreen/+log/21b5adc8409a..fb75b099385f $ git log 21b5adc84..fb75b0993 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 miu OpenScreen: Add WeakPtr, resolve some dangerous networking code issues. 2019-11-14 rwkeane PlatformClient: Use in Demos + Cleanup 2019-11-07 miu Move UdpPacket from platform/api to platform/base. 2019-11-08 jophba Move compound_rtcp_parser_seeds folder 2019-11-12 rwkeane DNS-SD: Publisher 2019-11-08 miu Merge platform/api/platform_client.h → platform/impl 2019-11-08 rwkeane DNS-SD: Implement GetDnsRecords method 2019-11-08 miu Minimize platform/api/logging.h, consolidate macros/impl elsewhere. Created with: roll-dep src/third_party/openscreen/src R=jophba@chromium.org,mfoltz@chromium.org Change-Id: I864a5ce9f066d497beea1de4862cb36ae98f9cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918362 Auto-Submit: Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715535}
-
Benjamin Beaudry authored
AXPlatformNodeTextRangeProvider::FindText() creates a range positioned in the root node. The range |start| and |end| positions are never in the right anchor (since text is in most cases inside of a AXInlineTextBox and never on the root element) and the offset is in many cases wrong too. This change fixes it by first creating the positions in the lowest common anchor of the |start_| and |end_| positions. 1. Get lowest common anchor. 2. Create the FindText() valid positions in the lowest common anchor. 3. Call AsLeafTextPosition() on both new positions. 4. Create the range with the positions located in the leaf nodes. The range is then located in the appropriate anchors. Bug: 847971 Change-Id: I5e5f037cf12e16281f44a79ca15c5e6ba0e74c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900402Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715534}
-
Thomas Lukaszewicz authored
Added operators and type conversions to ColorRecipe and ColorTransform that allow for a cleaner and more intuitive use of these classes. Bug: 1887666 Change-Id: I2f0d3455da349c5c39025c6cdf5b1da9ed5e07c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912782 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#715533}
-
James Cook authored
Also clean up enums.xml slightly. A comment was misplaced and "CustomLoginFlags" is used on all platforms for flags metrics, not just Chrome OS. Bug: 1013466 Change-Id: I38531bdcd6bfa17e8e259dc9bb23b2ec1bbbab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918143 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715532}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of ac0e2c90 Original change's description: > Add RenderTests in StartSurfaceLayoutTest for native tab > > Add one more RenderTest for native tab. Choose NTP in incognito mode > for its consistency. > > Also fix the issue about thumbnails being not freed in > http://crrev.com/c/1903402. > > Bug: 983170 > Change-Id: I68d3f08184cb4b9504935a53f893bb7ea9473ba6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903620 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713961} Bug: 983170, 1023299 Change-Id: I7af29c83bc2a9fb6fc13a460522e2d624eddbd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916299 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715531}
-
Bailey Berro authored
Previously, there were navigation stops on each of 1) a user's picture 2) a user's name and 3) a user's email address. With this change, the picture is skipped, and the email address is read as a description of the name, removing unneccssary tab stops Bug: 1023643 Change-Id: Ic54430b7b6c96454eae8d1ccbe297122ae92f3f9 Fixed: 1023643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913055 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715530}
-
Kyle Horimoto authored
Before this CL, the notification was not shown because the stage was set to UPGRADE_ANNOYANCE_NONE. This CL changes this logic such that if there is no RelaunchNotification policy, this is set to UPGRADE_ANNOYANCE_LOW. Fixed: 1019854 Change-Id: I63c58e9fbcea5f7b71983ed2e41d730e1f23cb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900298 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#715529}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/336e51f68564..90c88f097366 git log 336e51f68564..90c88f097366 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 gbeaty@chromium.org Reland "Fetch the input commit ref when both ref and id are specified." Created with: gclient setdep -r src/third_party/depot_tools@90c88f097366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150 Change-Id: I819e27bbc379be7d064a8fed77c1d27a71a5f080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918560Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c95e54b558d9..c1c4634dcb07 git log c95e54b558d9..c1c4634dcb07 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 reed@google.com add some api helpers (extracted from different CL) 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-14 benjaminwagner@google.com Use Clang for CMake build 2019-11-14 herb@google.com Hoist regenGlyphs out of per glyph loop Created with: gclient setdep -r src/third_party/skia@c1c4634dcb07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I50167ba9d0b257d7bae38e4165085eb77c33d74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918480Reviewed-by:
-
Toni Barzic authored
HomeScreenController should minimize non-foreground windows without animation when handling requests to go to home screen. Instead of just using WindowState::Minimize() on each window, use window_util::HideAndMaybeMinimizeWithoutAnimation(). The later should ensure that windows are properly minimized without using animation. BUG=1024659 TEST=Open an android app, then another app above it. Tap Home button. The app in the foreground animates to the home screen; the android app gets minimized without animating. Change-Id: Idb9caa86891b2f21e2127333acfca8dbaea9ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918092Reviewed-by:Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715526}
-
Nicholas Verne authored
Bug: None Change-Id: I3b7a78025ea186768f4f9f81bb40df8c341f70fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916530 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#715525}
-
Michael Spang authored
Now that Chromecast Linux enables this, all builds that link //ui/views are enabling this in GN. Add an assert so that accidental dependencies are diagnosed by "gn gen". Bug: 1021770 Change-Id: I681645e97f69c22ee0410c1dba95319fddef7038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898622 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715524}
-
Wez authored
Modify HistoryService and CancelableTaskTracker to track and check their home sequence/thread in Release builds, to get visibility into potential threading issues. Bug: 1009795 Change-Id: Id85a818111e8d2540a4bc4e333c88d7461a93a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918222 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
Yue Li authored
Remove the web container feature flag. Since we want the feature only with the launcher UI, we can use the launcher UI flag instead. Bug: b/144383302 Test: Manual Test Change-Id: I5ecc9bce9d59624e430eb690a6dc8e5df1cbae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918181Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715522}
-
Tommy Li authored
It seems that in the past, we've hardcoded the ChromeOS launcher page context to have no default match. But that seems unnecessary, since nothing in chrome/browser/ui/app_list even looks at the default_match() member. I'm removing this because we want to keep the Autocomplete controller as generic as possible without any special cases. ChromeOS launcher can simply ignore the default match if it wants to, and indeed it seems to. The goal of this CL is to unblock removing the default_match_ member variable entirely, since it's always equal to results_.begin() if that first match has |allowed_to_be_default_match| set to true. Bug: 1016845, 363656 Change-Id: Ifd9f72c71c20b3e49bc4fa006353d980f7ba55a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913559Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715521}
-
meacer authored
This CL adds a new interstitial with custom strings and makes it viewable from chrome://interstitials page. It does not yet hook into the SSL error handler path to trigger the interstitial based on the new net error. Bug: 1014711 Change-Id: Ia66567cbb825c35910745aad181006041ae5b537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913882 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#715520}
-
Kyle Horimoto authored
The feature is not yet complete, so the flag cannot expire in M-80. Change-Id: I22dfbbbdb209d8a68e0dd4912a9f50f29204344b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918361 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#715519}
-
Wez authored
ImageFetcherImpl invokes ImageDataFetcherCallbacks asynchronously using PostTask(). This could result in the callback being run after the caller has deleted the ImageFetcherImpl, which is likely unexpected behaviour, and may result in a use-after-free of the calling object. Bug: 1009795 Change-Id: I2468b9e54dabea8d067b87395661ca11380e560f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918360 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#715518}
-
Ken MacKay authored
Fix some issues in MixerInputConnection which caused incorrect rendering delay or failure to start the stream. Bug: internal b/143135800 Test: cast_media_unittests Change-Id: I2c1a39da00aa36d36f72741cb374a1b87e5b46bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918180Reviewed-by:
-
gogerald authored
Bug: 1017396 Change-Id: I53528b77e5c44f6244c74b45c7a6e8c6c7beead1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917340 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#715516}
-
Sammie Quon authored
This will improve precision, which will remove some janking scrolls. Test: manual Bug: 1024679 Change-Id: Ieb639acb81857407fff296cb52f51f8333289c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912988Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715515}
-
