GitLab

This patch flips the PaintNonFastScrollableRegions flag to be enabled by
default. For more information about PaintNonFastScrollableRegions, see:
https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view

The expectation has changed for compositor-touch-hit-rects-global.html
which is now correct and was incorrect due to https://crbug.com/992708.
The underlying bug has not been fixed.

Some expectations have new invalidations because going from scrollable
to non-scrollable (or vice versa) causes a scroll hit test display item
to disappear (or appear). paint/invalidation/resize-iframe-text.html and
paint/invalidation/compositing/iframe-inside-squashed-layer.html are
examples of tests changed due to this.

Some expectations have larger invalidations because the
resizer's scroll hit test display item uses the entire box as the
display item client. destroy-overlay-scrollbar.html and
destroy-scrollbar.html are examples of tests changed due to this.

Bug: 864567
Change-Id: Ia83de472ac2df10df09dd4476449dd6329848d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734214Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688631}

Introduce CWVCreditCardSaver for clients to interface with saving api.
This also adds support for saving cards to gpay if needed.

Bug: 993130
Change-Id: I7bc0acfe6553428f03f0e3f8c22a0824508f015b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752560
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688630}

It was already marked flaky in desktop_common but needs to be marked as
such in desktop_memory as well.

TBR=monicaciocea@chromium.org,eyaich@chromium.org

Bug: 859500, 995813
Change-Id: I2d93395a23d987ec11a2e3cd6d231d952ff50b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762488Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688629}

This makes the field show up in the protocol log in sync-internals.

Bug: none
Change-Id: I04b4fec941ab5d1dae76b03d5b0aed27c55a82a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762241
Commit-Queue: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688628}

It does not flake under ASAN in local tests, anyway. Let's see!

Bug: 674475
Change-Id: Id1f9f960610cca08e860e45af3d5f5a3821f7519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762352
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688627}

TBR=estade@chromium.org

Bug: 995851
Change-Id: I3598ab3248f8bf93701107e56a31ae4757c9358c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762328Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688626}

Submatches normally have the same relevance as their parents
and are thus sorted positionally with them. However, if
there are demote-by-type rules in effect, a parent (or a
submatch) can have an altered relevance and thus be
sorted away from their family.

This CL records within each submatch the type of its parent
so that it can be sorted identically.

Change-Id: I396dba33ba8808a2bae62b79352962f611feb23e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721041
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688625}

Bug: 995652
Change-Id: I86b5c45f7ac1274d12f1c088fac7b0e97e085ba7
Tbr: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761639Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#688624}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0be80f8179c5..f878992e96bd

git log 0be80f8179c5..f878992e96bd --date=short --no-merges --format='%ad %ae %s'
2019-08-20 saklein@chromium.org AndroidService: Refactor uprev and unpin endpoints.
2019-08-20 saklein@chromium.org cros_sdk_lib: Improve run chroot version hook call.
2019-08-20 saklein@chromium.org cros_workon: Improve error message for invalid ebuilds.

Created with:
  gclient setdep -r src/third_party/chromite@f878992e96bd

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic6d5e196ef8404b7857be0a872cad83beec33637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762271Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688623}

Otherwise, if it's destroyed through TLS, it can hang forever waiting
for a signal from the StackSamplingThread which never occurs.

This is going back to the behavior prior to
https://chromium-review.googlesource.com/c/chromium/src/+/1638578

R=ssid@chromium.org

Bug: 995323
Change-Id: I08863f5ee8ccd01c70b95bbce5fc28922dc06d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761291Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688622}

Bug: 992597
Change-Id: Id18b03656b8cacac0d4a815d0602dfb4ec51a5ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761427Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#688621}

Allows to import from the core module in tools/perf without bringing
the whole of Telemetry as a dependency.

This will be particularly needed by the results_processor, to be able
to run it on a separate swarming task from where Telemetry ran.

Should be safe to land after all impacted scripts have been updated in:
https://chromium-review.googlesource.com/c/chromium/src/+/1760218

Bug: 981349
Change-Id: I75898455c3f261859ec2fe3d2cba2248c8b3ef17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762070
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688620}

- Changes SerializedData return type to base::span<const uint8_t>. The
  old type, Vector<const uint8_t>, forces a copy. Changing to span will
  enable us to avoid copying cached code as it's passed from the browser
  via a mojo_base::BigBuffer. Eventually, we'll be able to move the
  BigBuffer to CachedMetadata.

Bug: chromium:992991
Change-Id: Ic4ac00282f3e0346649a1266e33cb57e1b40551a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758727Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688619}

This is an attempt to reduce heap usage in merges.

BUG: 982452
Change-Id: If17dad64ab8adde29384765720c210e7f5e72601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762083Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688618}

Bug: 927957
Change-Id: I5919885840a41ffec4e458382158aa40747bd64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760420Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Felipe Cerqueira <cerqueira@google.com>
Cr-Commit-Position: refs/heads/master@{#688617}

This service is run in the GPU process and its interfaces are bound only
by the browser, brokering unfiltered requests from renderers. Logic is
simplified by removing all dependencies on Service Manager APIs, in
favor of the browser's brokering logic talking directly to
GpuProcessHost and maintaining a persistent connection to the service.

Bug: 977637
Change-Id: I9047889de659b8ff61df4bae40867d3b81d8127f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761689
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688616}

These events got moved to the "fonts" category.
They are currently dropped and not visible in slow-report traces.

R=oysteine@chromium.org

Bug: 867931
Change-Id: I8940165b5196f074cac9735057ff60b129015cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758340Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688615}

This is a reland of https://crrev.com/c/1648886

It was reverted due to a crash in a non-cq bot, see https://crbug.com/976331.

Patchset 1 shows the original patch and the specific non-CQ bots that failed on them are red.

Patchset 3 has the fix, and shows that the bots are now green.

I believe the bug is related to oilpan memory management in the custom struct I created. So instead I used a simpler std::pair to hold the callback and AsyncTaskId.

TBR: pfeldman@chromium.org
Bug: 851531
Change-Id: I625dacd61ea663097605df1f10e26baa58ce07c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761289
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688614}

Existing print_job_unittest doesn't need print_preview and add
a trivial unittest for PrintViewManagerBasic to exercise the code.

Bug: 993255
Change-Id: I2897c4cf9e46fbfc893a5868a544c5757efd6295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757022Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Joel Klinghed <the_jk@opera.com>
Cr-Commit-Position: refs/heads/master@{#688613}

Avoid potential unnecessary copies by using emplace consistently.

No intended functional changes.

Bug: 995605
Change-Id: I4e937338a05e6f7322d2813f2f633f0037cd4b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761649Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688612}

The `CreateNextWord*Position` functions were not updating their iterator
in certain edge cases, which caused an infinite loop.  (Notably, the
`CreatePreviousWord*Position` functions *are* updating their iterators
in the same scenarios.)

The new test included in this change would hang before the fix.

The following is a detailed description of the error scenario:
-- Start with a AXTextPosition (at index 0) at a high level in the tree.
-- Call one of the `CreateNextWord*Position` functions.
-- These functions start by getting a "leaf" text position, which drills
   down deeper in the tree.  Specifically, they drill down into a node
   that includes placeholder text (which appears as part of their
   hypertext, but not in the hypertext of the outer node).
-- The function then tries to advance to the next word, and finds a
   valid word stop.
-- The end of this loop compares the new position against the original.
-- operator==/CompareTo must adjust the positions to be relative to the
   same node, which it does using repeated calls to GetParentPosition().
-- GetParentPosition() determines that the text-offset in the deep node
   is not valid in the outer node, so it resets the index to zero.
   (This workaround was added in CL:1661548.)
-- As a result, CompareTo determines that the two nodes are equal.
-- Therefore, we loop in CreateNextWord*Position.
-- Because the iterator was not updated, we loop infinitely.

Bug: 994871
Change-Id: I6e5880bfa7073e2ca672d281fca223e90e5fe288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758590Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688611}

This CL moves the permission checks that used to exist in the
ExtensionTabUtil::ScrubTabForExtension method into its own util method
so that the level of scrubbing of data that needs to happen can be
determined in the context from which it is requested. This will
ultimately help in allowing WebUI to get non-scrubbed data.

Bug: 994337
Change-Id: I6c7cd37b1cb0f64233759ccac7aa9b8097234482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755052
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688610}

It returns the matrix with transform origin applied. Useful where we
want to get whole matrix that this transform node will apply.

Also fix a bug in CullRect::ApplyTransforms() where we missed the
origin.

Change-Id: If671470a5c9ea0e8a46e128692862bb0779d005f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757081Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688609}

We were showing the nav widget in the right conditions, but we were
not hiding it aggressively enough.

Add tests to prevent future regressions.

BUG=992336

Change-Id: I4d19473f514b8979c940daa008e16a43e3de9773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761492Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688608}

This CL adds NetworkIsolationKey as an argument to H2-support-checking
methods in HttpServerProperties, and makes consumers pass in the correct
key.

Bug: 969890
Change-Id: I8ea06693a470eef3ca24ec8d269ce5ac131e312f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753807Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688607}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5c6b118c..f624b9be

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0032e6229b83cf1202e7c5a5063e2ac6c3995e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757862Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688606}

Bug: 994291
Change-Id: I48fe790dbf6c686e83264b638b0b031eb801d626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762239Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688605}

Bug: 900706
Change-Id: Id3940f6d3321f22159a577e3634ea926f6870b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755409
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688604}

Add three bots to CQ for any changes to sandbox/win:

 * win-asan
 * win10_chromium_x64_dbg_ng
 * win7-rel

This is because any sandbox changes can be particularly sensitive
to OS version/configuration.

BUG=750886

Change-Id: I4ff315f65e220591a0835069342b51ab2549d183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762384Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688603}

... with translations: origin and post_translation.

This reduces the size of TransformNode by 108 bytes.

Bug: 993937
Change-Id: I52b60dfba9a34b1062960cbd78a9bababd0e6a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759891
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688602}

TBR=marinaciocea@chromium.org,robertma@chromium.org

Bug: 995817
Change-Id: I854a366775f515744bc9422cf5e58c16a99fa25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762350Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688601}

Bug: 992491
Change-Id: Icf791568a56e5dafb9f280021aad4a0742520fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733726
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#688600}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I0de7982a275451bcc781621c8fae884d9ddb66de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700942
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688599}

Using wpt-import in Chromium 3fb589c1.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
iclelland@chromium.org:
  external/wpt/feature-policy

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ib5b023b71030a64d76e1403dc27ce60a8f8d73ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762408Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688598}

This is a reland of d9dbade3

Original change's description:
> [Traffic Annotations] Run extractor.py on waterfall
> 
> linux-annotator-rel and win-annotator-rel will now test traffic
> annotations with extractor.py, as well as the clang tool.
> 
> Also updates a traffic annotation in management_ui_handler.cc, since
> extractor.py doesn't understand #ifdefs. As a workaround, this
> CrOS-specific annotation is moved to a CrOS-only file.
> 
> TESTED=
>   Ran traffic_annotation_auditor_tests.py locally, excluding the
>   --no-filtering configs.
> 
> Bug: 966883
> Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675994}

Bug: 966883
Change-Id: I5d3275315565b0592c86feedb564fa5cbf154e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761146Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688597}

Update the description string shown for `File editing` on
chrome://settings/contents.

Bug: 992175
Change-Id: I88d6283d8b481989f2af8cd24e20fc560f1b9c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760962Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Auto-Submit: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688596}

Make RenderingContext::IsOriginTopLeft() the source of truth for flip-y
state and update the associated pixel test to verify this.

This fixes incorrect rendering of low latency canvas2d on Windows since
CanvasResourceProviderSharedImage started being used.  This resource
provider doesn't support single buffering mode if overlays aren't being
used which is what caused the flip-y state to be inconsistent.

Also includes minor cleanup in CanvasResourceProvider to store important
state in the base class instead of duplicating in many subclasses.

Bug: 994866
Change-Id: Ia955bfa87380ecfb3772b017528434182cbd391a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759214
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688595}

It's unused. This CL is a refactor with no intended behavior change.

Bug: 994926
Change-Id: Ied6ff61da33b3f69b1cd49ffb310fe4e0668c192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761261
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688594}

Bug: 988461
Change-Id: I86be68ebf6ad07bf680f11c49864a4ccb056e19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761276Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688593}

Screenshot (<1024px) : http://screen/ktdXzvCgc0c
Screenshot (<512px) : http://screen/kPDKQRi0dyo

Bug: 994545, 993915
Change-Id: Iecf2c2c7865e9d8aaf905fe43124193f03b2beda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757290
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688592}