- 30 Jul, 2019 40 commits
-
-
Varun Khaneja authored
Due to lack of use, and because we never started using a different version number since the initial launch. Bug: 975127 Change-Id: Id0dfb75ee065d8fffc87f289a09d58c149cad930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720748 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682388}
-
Patrick Monette authored
Expose IsThirdPartyInitialized() so it can be used instead of blacklist::IsBlacklistInitialized while setting up the beacon. Bug: 986926 Change-Id: Ib8fce7d60a5ac1a9b61324d7fd040263e8e62aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719290 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682387}
-
Sinan Sahin authored
Currently, the direct share icon content descriptions are set to the application name. This causes issues if an app has multiple activities that can be used to share. E.g. The Drive app has "Save to Drive" and "Copy to clipboard," but TalkBack reads them both as "share via Drive." As a fix, this CL changes ShareHelper#getShareableIconAndName to return the activity label instead of the app label. If the activity label is null, the app label is returned by default. Bug: 986545 Change-Id: I1174ca962deb9efbe25c432967c60f68ea855e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721854Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#682386}
-
Guillaume Jenkins authored
The REST endpoint for the spelling service is ready to be fully launched. It has been enabled at 1% of stable for 2 weeks now, and between control and enabled on Dev/Canary/Beta/Stable: - HTTP status code metrics have been stable, though we have noticed between 0.5% and 0.9% of requests give a 403. We will need to keep an eye on those, but they do not warrant delaying the endpoint migration. - Proportion of failed requests has gone slightly down. - Mean latency (ms) of requests has gone slightly down. For those reasons, we are ready to fully migrate the spelling service to the new REST endpoint. Code cleanup will follow shortly, once we've confirmed that things are stable. Bug: 943108 Change-Id: I19d394bed58db178dde682ffe168e651ee9e5125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724666Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#682385}
-
Vladimir Levin authored
We might create child frames, and those frames will need to create a URL loader factory. Since we override the factory before we actually parse and create child frames, we can't set it directly on all possible children. Instead, when asked to create a factory and we don't have an override, navigate the ancestor chain and check if any of the ancestors have an override. This also adds a Clone function, since we need to be able to retain multiple copies of the override (one for each of the child frames, and one for self). R=yhirano@chromium.org Bug: 986050 Change-Id: I5d1023379eb4b7c305e3b07640ee6a4d31a2d9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717677Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682384}
-
Donn Denman authored
This fixes a minor layout error in the Contextual Search Bar when a Definition is shown in an RTL language. BUG=989121 Change-Id: Ifc5a198155e7726710f26f78bbc6387492d411cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726200 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682383}
-
Kristyn Hamasaki authored
Add enum for |full_text_| properties and convert ElideBehavior, Shadows, and HorizontalAlignment. Change-Id: I6d5263f380010906844b6a46c3003ece8126bfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715727Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#682382}
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes. These matchers are currently used in 10+ tests, convert them to compile under EG2. Bug:922813 Change-Id: Ia5439922119d456446071c4c747a4230bb7a9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725333Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682381}
-
Kristyn Hamasaki authored
Change-Id: Iaf08c1356f929605bef59a5e6e9a1829e9b868ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721293Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#682380}
-
Geoff Lang authored
This caused ANGLE's symbols to not be generated and uploaded with official builds. BUG=988958,988444 Change-Id: I428e5664755bb969fbe771c2a9d303f90d26a017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724840 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682379}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8cf27f85. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I504480a3ebfe6815f295613ccef1e38af4d79885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724646Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682378}
-
Guohui Deng authored
Also, verified that such function is visible. Bug: b/131411395 Test: With internal CLs, build on one device and cast a youtube page. Change-Id: I55ae72fa2ae71ab6495e7b32c16150a678086773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721555 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682377}
-
Jacques Newman authored
We should not have supported getting a child tree sibling. Child trees are always considered to be an "only child." This change removes the ability to traverse to a child tree using PlatformGet*Sibling, as valid usage of that method requires a sibling to exist. PlatformGetChild will now return nullptr if the node has a child tree and the specified child index is not 0 Updated test. Bug: 987472 Change-Id: I5b69e169531f3448a317f7b8d698cea5857b7ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717912 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682376}
-
Kristyn Hamasaki authored
Change-Id: I908f618d809e4d6414d85a8867156a676cc8c032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721352Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#682375}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I0994c106955ba9961cfed1fa2814bd4b7745fd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724507 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682374}
-
Yuke Liao authored
The Monorail component for code coverage was renamed from: Tools>CodeCoverage to Infra>Test>CodeCoverage, and this CL updates the references. Change-Id: I886422c5b8f839570ade415354fe2c122ee35ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726371Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#682373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42f9ab2813ad..da76f1d1887d Created with: gclient setdep -r src-internal@da76f1d1887d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I05992fef64d27b780a35063cc3e994f28d029b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724405Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682372}
-
Daniel Rubery authored
Remove some SBDownloadFeedback metrics that weren't being used, and where we don't have any near-term plans for them. Bug: 984184, 984209 Change-Id: I35c5e77f20170ec4e8b8bba71b811f12c1d9899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725161 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682371}
-
Alex Cooper authored
Updates XRRigidTransform's constructor to throw a TypeError if it receives a Position with a w component assigned to anything other than 1 and an InvalidStateError if the length of the Orientation component is 0 Bug: 977703 Change-Id: Ie75ddff1e1bafd55ea58844c074751aedf11fcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725319 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#682370}
-
Sofiya Semenova authored
Change-Id: I76b80b77cf72e91d83b89a002c598e8447f9f1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723307Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sofiya Semenova <sofiyase@google.com> Cr-Commit-Position: refs/heads/master@{#682369}
-
Kristyn Hamasaki authored
Change-Id: I2d2e633ef1867a55a23d27a733454f519af5a4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721184Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#682368}
-
Yue Zhang authored
Currently when user clicks to add a new tab in TabGridDialog, we try to create a new tab which takes the last tab in this group as parent. However, this can be problematic when all tabs are closed in this group. This CL fixes this issue. Bug: 987885 Change-Id: I1a6c83f9bfe8e55669ed5424cb7f096e277a91e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726413Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#682367}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4da34bf74723..8cbf662b296a git log 4da34bf74723..8cbf662b296a --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bsalomon@google.com Always set GL_[UN]PACK_ALIGNMENT to 1. 2019-07-30 senorblanco@chromium.org Dawn backend: add asserts for unimplemented functionality. 2019-07-30 halcanary@google.com experimental/editor : handle word-left and word-right 2019-07-30 reed@google.com simplify canvas after looper's demise 2019-07-30 mtklein@google.com small refactors Created with: gclient setdep -r src/third_party/skia@8cbf662b296a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Iee6b80f1fd0d773c5222fd27b5ac0baef26bba68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682366}
-
Ahmed Fakhry authored
BUG=987868 TEST=Run ClusterFuzz Reproduce locally Change-Id: I617ff4b44943aa10e957780bfcba6f69a6d485aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725510 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#682365}
-
Vlad Tsyrklevich authored
Instead of using crashpad's crashpad_handler, refactor Android to use our own custom chrome_crashpad_handler (also used by macOS) and have it also pass through the CrashpadHandlerMain entry point so that it picks up any custom crashpad hooks we want to install. CQ-DEPEND=CL:1707405 Bug: 973167 Change-Id: Id6d91a35ce12e547b4a7c92d07f869c96afae797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708838Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#682364}
-
Majid Valipour authored
Previously we propagated scroll snap properties [1] from viewport defining element's style to the viewport. However this is not spec compliant [1] and more importantly our behavior is different from Gecko. This patch fixes this issue by having these properties propagate from document.documentElement instead. TODO: better understand the backward compat impact. Note that this can cause previously snapping viewport to no longer snap if the web developer has declared the snap type on body as opposed to document and body is viewport defining element [1] scroll-snap-type, scroll-padding [2] https://github.com/w3c/csswg-drafts/issues/3740 BUG= 952711 TEST= wpt/css/css-scroll-snap/scroll-snap-type-on-root-element.html Change-Id: I2d84095decb3af52f6a99c52a5a1a8d5c92fcf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704859 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682363}
-
dpapad authored
Specifically: - Update v1_0/generate_gn.sh to expect a Polymer version number. - Update v1_0/reproduce.sh and v3_0/reproduce.sh to pass a version. - Add a new tools/polymer/generate_gn_v3.py, which uses acorn to parse a JS file and extract JS imports. - Update third_party/polymer/v3_0/package.json to list acorn as devDependencies (and move rollup to devDependencies as well). These files are necessary to type-check WebUI code that uses Polymer3. Bug: 970885 Change-Id: Iae3e3e2afdb58056af6ac944a7bc4b88e87108c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717524 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#682362}
-
Kristyn Hamasaki authored
Change-Id: I62b3a596f6437bade39a6800430e5ddb43bc4023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721511Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#682361}
-
Caitlin Fischer authored
Bug: 988089 Change-Id: I69bcbcbf3bd18181db15304711f8b17ce8104eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721083Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#682360}
-
Wei Li authored
Add back the product icon as the bubble title icon. Also align the bubble's content area to the beginning of the title text instead of the the title area. BUG=979530 Change-Id: Iea4132d713dc43a13f4871ed85ae5ee09c66ecb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723303Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#682359}
-
Ahmed Fakhry authored
BUG=988530 TEST=Manually Change-Id: Ifbd2b8184490b14e146bb822791347de4b36a975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724121 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682358}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7b57c5bb770f..35ad5221fb55 git log 7b57c5bb770f..35ad5221fb55 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bryan.bernhart@intel.com Resource Management 3: Buddy allocator Created with: gclient setdep -r src/third_party/dawn@35ad5221fb55 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0cf420fdd9fe4cbe79c69e346f8593be1b0233fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682357}
-
Clark DuVall authored
This also merges UIThreadExtensionFunction and ExtensionFunction since there's no need for them to be separate anymore. This was made possible because WebRequest has moved to the UI thread, and it was the only API using IOThreadExtensionFunction. Follow up CL will remove references to UIThreadExtensionFunction. Bug: 980774 Change-Id: Ibe9a4433d1d564877b4277cf5e36734c46f53695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718990Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682356}
-
Ken MacKay authored
Bug: internal b/138645210 Change-Id: I9de9df6663290767bcb4657a9f8e7cd09346fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726629Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682355}
-
Kehuang Li authored
As crbug/946657 has been fixed, fulfill the TODO in the unittest. Bug: internal: 133880006 Test: Run unit tests. Change-Id: I7cbc5ac0ea18b19cf584c8842b1d3405fb663e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724930Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#682354}
-
Vaclav Brozek authored
This CL teaches CSVPassword to unescape CSV values. Bug: 934326 Change-Id: Id99e89b6e84f9b47216e6eac0f735fc4084a9cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698403Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682353}
-
Varun Khaneja authored
R=drubery, holte Bug: 975560 Change-Id: I2aaa33f95a249aaf14fadddf5672b2ce9d82ced6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721461 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#682352}
-
Sam Sebree authored
This change implements the EvaluationSteps Callback which is intended to be used by v8 during SyntheticModule::Evaluate. ValueWrapperSyntheticModuleScript::EvaluationSteps is responsible for setting the default export of the provided module to the value wrapped by the ValueWrapperSyntheticModuleScript Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=967018 Change-Id: I07b3be40832b9497169ed0a38a1fcc251e681f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725472Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682351}
-
Natalie Chouinard authored
There are no longer any non-support library Alert Dialogs in Preferences, so this theme can be removed from this activity (but is still necessary on other activities). The other preference-specific styles removed here were applicable only to framework preferences and are no longer used now that all preferences have been migrated to the support library. Bug: 967022 Change-Id: Id367c240486b8f4bf6b892f859cd1aba5d16da73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711146Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682350}
-
Steven Bennetts authored
This replaces networkingPrivate calls for everything except setProperties and forgetNetwork (neither of which have been migrated to mojo yet). Bug: 853953 Change-Id: I7f0ddbf180dad6a79a282b38a721e795ed0976d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717747 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682349}
-