GitLab

BUG=488345
NOTRY=true

Review URL: https://codereview.chromium.org/1134233004

Cr-Commit-Position: refs/heads/master@{#330091}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/85f7e6e..4a0f1d2

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1140233002

Cr-Commit-Position: refs/heads/master@{#330090}

Summary of changes available at:
https://chromium.googlesource.com/android_tools/+log/0c03d3bfef..3445d55bd6

BUG=487391

Review URL: https://codereview.chromium.org/1142583002

Cr-Commit-Position: refs/heads/master@{#330089}

There was a missing break in the switch for handling the error state in
BackgroundSyncProvider::GetRegistrationsCallback.

BUG=488451

Review URL: https://codereview.chromium.org/1130313003

Cr-Commit-Position: refs/heads/master@{#330088}

This is to solve the general perf problem of per-webview
ActivityWindowAndroid when there are a lot of webviews in an activity.
It is kept in a WeakHashMap, and ActivityWindowAndroid only weakly holds
the Activity, to ensure Activity can still be gc-ed.
ActivityWindowAndroid.destroy is called by CleanupReference.

Also make WindowAndroid global and leaking. This is ok since it only uses
the Application.

BUG=487487

Review URL: https://codereview.chromium.org/1138113004

Cr-Commit-Position: refs/heads/master@{#330087}

Revert of Disable blink_perf.canvas on linux. (patchset #1 id:1 of https://codereview.chromium.org/1129383007/)

Reason for revert:
Possible fix has landed, reverting to see if bot goes green.

Original issue's description:
> Disable blink_perf.canvas on linux.
>
> This has been red going on a week now.
>
> BUG=488059
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/2e2d7141b8f141bfb194427afde9fb2bf1ed5486
> Cr-Commit-Position: refs/heads/master@{#330085}

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488059

Review URL: https://codereview.chromium.org/1142643002

Cr-Commit-Position: refs/heads/master@{#330086}

This has been red going on a week now.

BUG=488059
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1129383007

Cr-Commit-Position: refs/heads/master@{#330085}

Another step in the investigation of no-username forms. Are we dealing with small forms that only contain one password field, or with larger but somehow malformed forms?

BUG=456728

Review URL: https://codereview.chromium.org/1099033004

Cr-Commit-Position: refs/heads/master@{#330084}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7558a74..85f7e6e

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1145533003

Cr-Commit-Position: refs/heads/master@{#330083}

Currently remote commands fetch depends solely on invalidation, evaluate and
possibly remove this after invalidation service is landed and tested.

BUG=480982

Committed: https://crrev.com/610f47342c8d725e239513ac17727a176d161495
Cr-Commit-Position: refs/heads/master@{#327765}

Review URL: https://codereview.chromium.org/1106193003

Cr-Commit-Position: refs/heads/master@{#330082}

BUG=467832

Review URL: https://codereview.chromium.org/1017453005

Cr-Commit-Position: refs/heads/master@{#330081}

This CL passes the "configure" and "source" flag to VolumeManager. Additionally
all other volume types have those flags, so we can add a link to disable Drive
as it's configuration. Finally, logic for displaying the "eject" icon has been
simplified.

TBR=fukino@chromium.org
TEST=browser_test: *FileManagerPrivateApi*Mount*
BUG=447101

Review URL: https://codereview.chromium.org/1137383002

Cr-Commit-Position: refs/heads/master@{#330080}

BUG=

Review URL: https://codereview.chromium.org/1132063006

Cr-Commit-Position: refs/heads/master@{#330079}

Append underscore to the name of
QuicNetworkTransactionTest::http_server_properties member to match other
members.  Use it directly instead of *(session_->http_server_properties)
throughout tests.

BUG=

Review URL: https://codereview.chromium.org/1130783008

Cr-Commit-Position: refs/heads/master@{#330078}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c338ecf..7558a74

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1132203006

Cr-Commit-Position: refs/heads/master@{#330077}

BUG=

TBR=bauerb

Review URL: https://codereview.chromium.org/1130253010

Cr-Commit-Position: refs/heads/master@{#330076}

Revert of Moves SQLitePersistentCookieStore to net/extras/sqlite. (patchset #25 id:470001 of https://codereview.chromium.org/1016643004/)

Reason for revert:
Seems to break content_unittests QuotaPolicyCookieStoreTest.TestPolicy. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester for details.

Reverting to see if the bot turns green again. I am unable to find any other CL that can cause this.

Original issue's description:
> Moves SQLitePersistentCookieStore to net/extras/sqlite.
>
> The application of special storage policy is split out into a new class,
> QuotaPolicyCookieStore, in content/browser/net.
>
> BUG=467596
> TEST=No visible impact.
>
> Committed: https://crrev.com/57adf29fb4e46a49272610140b097f85e1e805f5
> Cr-Commit-Position: refs/heads/master@{#329950}

TBR=rsleevi@chromium.org,mef@chromium.org,nharper@chromium.org,avi@chromium.org,rohitrao@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467596

Review URL: https://codereview.chromium.org/1134113007

Cr-Commit-Position: refs/heads/master@{#330075}

This changes ProxyResolverV8Tracing to use the new ProxyResolver and
ProxyResolverFactory interfaces.

BUG=467403
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1126513002

Cr-Commit-Position: refs/heads/master@{#330074}

This CL adds an event which notifies extension about changed list of volumes
which can be requested via chrome.fileSystem.requestFileSystem.

TBR=benwells@chromium.org
TEST=browser_tests: *OnVolumeListChanged*
BUG=440674

Review URL: https://codereview.chromium.org/1146463002

Cr-Commit-Position: refs/heads/master@{#330073}

Changed url parameters for DeviceAttributeUpdate[Permission]Request
attribute_update[_permission] to device_attribute_update[permission]

BUG=488117

Review URL: https://codereview.chromium.org/1126273005

Cr-Commit-Position: refs/heads/master@{#330072}

Updated StatusUploader to expose an API to determine if session data uploading
is allowed, and updated screenshot remote command to call this function.

BUG=487261

Review URL: https://codereview.chromium.org/1135413002

Cr-Commit-Position: refs/heads/master@{#330071}

Revert of Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) (patchset #1 id:1 of https://codereview.chromium.org/1130413005/)

Reason for revert:
This CL most likely breaks Chrome. I can't find any other reason to this issue:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64

Reverting to see if it helps.

Original issue's description:
> Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)
>
> This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
> See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85
>
> This previously landed in CL 981593002 but got reverted in CL 1131323002
> as it broke the Windows GN bots. The GN script now adds BoringSSL to the
> "public_deps" if necessary, so the include path is correct then.
>
> BUG=328475
>
> Committed: https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c
> Cr-Commit-Position: refs/heads/master@{#330066}

TBR=jiayl@chromium.org,thakis@chromium.org,juberti@chromium.org,gcasto@chromium.org,jbauch@webrtc.org,mail@joachim-bauch.de
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=328475

Review URL: https://codereview.chromium.org/1139233002

Cr-Commit-Position: refs/heads/master@{#330070}

This CL starts to build nacl_helper_nonsfi_unittests.
The binary is not yet enabled to run on bots. It will be done in a following CL.

TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
BUG=358465

Review URL: https://codereview.chromium.org/1137553003

Cr-Commit-Position: refs/heads/master@{#330069}

The comment suggests that one can manage the factory instance using the Singleton class.
That is not possible as Singleton<T> has private methods only and declares only T::GetInstance as friend.
BrowserContextKeyedAPIFactory<X>::GetInstance cannot be defined by users however.

That misleading comment was added here
https://chromiumcodereview.appspot.com/11682005

Review URL: https://codereview.chromium.org/1135343003

Cr-Commit-Position: refs/heads/master@{#330068}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3215e43..c338ecf

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1129223006

Cr-Commit-Position: refs/heads/master@{#330067}

This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85

This previously landed in CL 981593002 but got reverted in CL 1131323002
as it broke the Windows GN bots. The GN script now adds BoringSSL to the
"public_deps" if necessary, so the include path is correct then.

BUG=328475

Review URL: https://codereview.chromium.org/1130413005

Cr-Commit-Position: refs/heads/master@{#330066}

This CL adds a launcherPage.hide() API which can be used by custom
launcher pages to implement custom hiding behavior. The API only works
if the custom launcher page is showing and does nothing otherwise.

BUG=481712

Review URL: https://codereview.chromium.org/1137503005

Cr-Commit-Position: refs/heads/master@{#330065}

Revert of Add the chrome.fileSystem.onVolumeListChanged event. (patchset #2 id:20001 of https://codereview.chromium.org/1135383002/)

Reason for revert:
Seems to break browser_tests failed interactive_ui_tests on
Linux Chromium OS ASan LSan Tests (1).

This CL was the best I could find in the blame list. Reverting as Chrome sheriff to see if it helps.

See https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1252

Original issue's description:
> Add the chrome.fileSystem.onVolumeListChanged event.
>
> This CL adds an event which notifies extension about changed list of volumes
> which can be requested via chrome.fileSystem.requestFileSystem.
>
> TEST=browser_tests: *OnVolumeListChanged*
> BUG=440674
>
> Committed: https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f
> Cr-Commit-Position: refs/heads/master@{#330047}

TBR=benwells@chromium.org,mtomasz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440674

Review URL: https://codereview.chromium.org/1145563002

Cr-Commit-Position: refs/heads/master@{#330064}

This expands the documentation on the protobuf definition for the
ExtensionCacheSize policy to mention the minimum allowed value and the
default.

BUG=none

Review URL: https://codereview.chromium.org/1123253004

Cr-Commit-Position: refs/heads/master@{#330063}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ea59f1a..3215e43

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1135253006

Cr-Commit-Position: refs/heads/master@{#330062}

As each tiling iterator in raster and eviction queues iterates one
priority rect, those iterators know the priority rect for tiles. Thus
picture layer tilings compute priority rects only because iterators do
not pass that information to tilings. Therefore, unnecessary priority
rect computation can be avoided by passing priority rect information
from iterators to tilings.

Review URL: https://codereview.chromium.org/1126813002

Cr-Commit-Position: refs/heads/master@{#330061}

This is a reland of https://crrev.com/1117853002, which failed to compile
in CHECK_GT(size_t var, 0), and CHECK_LE(size_t var, 100) because the compiler
handles the numeric literals as signed. So compiler complained about comparing
signed and unsigned. This is fixed by using unsigned numeric literals like 0UL
and 100UL.

Calculates per-frame encode latency, which is basically the time delay from
input of each VideoFrame (VEA::Encode()) to output of the corresponding
BitstreamBuffer (VEA::Client::BitstreamBufferReady()).

It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.

Also fix a wrong comment.

BUG=345181
TEST=Check "Encode latency for the 50%/75%/95%" in output logs.

Review URL: https://codereview.chromium.org/1139913009

Cr-Commit-Position: refs/heads/master@{#330060}

BUG=479246

Review URL: https://codereview.chromium.org/1129293007

Cr-Commit-Position: refs/heads/master@{#330059}

TBR=benwells@chromium.org
BUG=483615

Review URL: https://codereview.chromium.org/1141193002

Cr-Commit-Position: refs/heads/master@{#330058}

This mirrors the change in chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc in https://codereview.chromium.org/1131993005/

BUG=362214

Review URL: https://codereview.chromium.org/1138383007

Cr-Commit-Position: refs/heads/master@{#330057}

Changes:
- Update notification with type = PROGRESS, so the content is updated
  even when the message center is opened.
- Popup the notification when the download is interrupted or completed
- Add browser tests
- Fix the string ID of interrupted download

BUG=446112, 468562
TEST=run browser_tests

Review URL: https://codereview.chromium.org/1105953002

Cr-Commit-Position: refs/heads/master@{#330056}

Cr-Commit-Position: refs/heads/master@{#330055}

This CL expands padding of breadcrumbs from 5px to 9px.
Along with it, some padding are reduced to keep the overall layout.

BUG=480720
TEST=manually

Review URL: https://codereview.chromium.org/1128023006

Cr-Commit-Position: refs/heads/master@{#330054}

A new pool of resources -consisting of GpuMemoryBuffers, textures and
images- has been added to media/video and an instance is now allocated
in VideoRendererImpl.
This pool, disabled in this cl, will allow VideoRenderImpl to convert
software VideoFrames into VideoFrames backed by native resources.

Once we enable this conversion the software video playback will
benefit from this in different ways:
 - Reducing the number of copies of VideoFrame buffers, potentially
   having only one when native GpuMemoryBuffers are available.
 - Moving one copy in the media thread and removing it from the critical
   path.

BUG=485859

Review URL: https://codereview.chromium.org/1133563010

Cr-Commit-Position: refs/heads/master@{#330053}

Revert of [Chromoting] Show any startup errors in the LoadingWindow. (patchset #5 id:80001 of https://codereview.chromium.org/1139543002/)

Reason for revert:
Syntax error in the JS, breaking the closure bot and almost surely doesn't work well/breaking something in remoting.
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/22330/steps/compile/logs/stdio

Original issue's description:
> [Chromoting] Show any startup errors in the LoadingWindow.
>
> Show any connection errors during startup in the LoadingWindow rather
> than creating a new error window for the error.
>
> This cl also adds a new updateErrorMessage method to the MessageWindow
> to update the message and reset the message window as appropriate for
> an error message (disabling the spinner, updating the button label).
>
> BUG=
>
> Committed: https://crrev.com/d44e8a774ce99a89c350d10d5b3f9f644eb0c3d1
> Cr-Commit-Position: refs/heads/master@{#330022}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1144593002

Cr-Commit-Position: refs/heads/master@{#330052}