GitLab

An extension is granted activeTab permission when the user invokes it on
a certain site. Currently, this grants host permission to the extension
until the user performs a (not-same-document) navigation or closes the
tab.

With RuntimeHostPermissions, we apply a similar model to extensions with
withheld permissions, but make the permission grant "sticky" while the
user is on the same origin - that is, the permission is only revoked on
cross-origin navigation or tab close.

Apply this behavior to activeTab as well. There's not really an
increased security risk here, since the extension already has access to
the site. This also simplifies the code by reducing the differences
between activeTab and RuntimeHostPermissions.

Update tests for activeTab to reflect the new behavior, and update
public documentation to include the change.

Bug: 898617
Change-Id: I6772cf7d88ed53ceb4540e06adf33d5f17bbb4b0
Reviewed-on: https://chromium-review.googlesource.com/c/1298420Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604805}

Change-Id: If78728aac86b3108e6525cffcee0dfc6122db607
Reviewed-on: https://chromium-review.googlesource.com/c/1312180Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604804}

WebRTC will improve its IP handling with mDNS and replace private IP
addresses with mDNS hostnames when signaling ICE host candidates to the
application. See the Internet Draft (draft-mdns-ice-candidates-02) for
the detailed approach.

This CL defines a Mojo interface of mDNS responder and implements it as
a service that will be consumed by WebRTC.

Bug: 878465
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4b644286467622b3dfdb728a9d5f3a4bde9fc1ec
Reviewed-on: https://chromium-review.googlesource.com/c/1182875Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#604803}

Adding the annotation makes it clear which fields are protected by
base::Lock, and enables compile-time analysis to verify this.

BUG=893739,887645
TEST=compiles

Change-Id: Ibf8ff9b73f218fcd3cfeb4387e7ad406418ef522
Reviewed-on: https://chromium-review.googlesource.com/c/1303405Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604802}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0

$ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s'
2018-10-31 jerryturcios08 Correct grammatical error in README.md
2018-10-30 absl-team Googletest export
2018-10-30 misterg Googletest export
2018-10-29 absl-team Googletest export
2018-10-29 akonradi Add Optional() to the cheat sheet doc.
2018-10-29 misterg Googletest export
2018-10-29 misterg Googletest export
2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock
2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest
2018-10-26 absl-team Googletest export
2018-10-24 absl-team Googletest export
2018-10-24 misterg Googletest export
2018-10-24 jeffvd.a216 Change CMake googletest download location in docs
2018-10-23 durandal Googletest export
2018-10-24 peter_jiachen Disable extensions and force standard
2018-10-24 peter_jiachen Revert previous changes
2018-10-24 peter_jiachen Fix -std=c++11 flag
2018-10-23 joelanderson333 add documentation of manual c++11 specification
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 gennadiycivil Update advanced.md
2018-10-23 svg153 ACTION table format
2018-10-22 absl-team Googletest export
2018-10-19 gennadiycivil Update .travis.yml
2018-10-18 gennadiycivil Update .travis.yml
2018-10-18 misterg Googletest export
2018-10-16 absl-team Googletest export
2018-10-17 kakkoko Fix incorrect XML file name in help message
2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault
2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls()
2018-10-16 jonathan.wendeborn Don't fully qualify enum member
2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict
2018-10-12 robert Change types to remove cast warnings.
2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString
2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac
2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a
2018-10-09 absl-team Project import generated by Copybara.
2018-10-09 misterg Internal Change
2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file
2018-10-06 ryee88 fix typo
2018-10-10 spartucus Update .gitignore
2018-10-09 misterg Remove non-variadic pre C++11 AnyOf
2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple.
2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed
2018-10-09 absl-team Apply [[noreturn]] to Abort()
2018-10-09 gennadiycivil Update Makefile.am
2018-10-09 gennadiycivil Update BUILD.bazel
2018-10-09 gennadiycivil Update README.md
2018-10-09 gennadiycivil Delete CHANGES
2018-10-09 gennadiycivil Delete CHANGES
2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9
2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs
2018-10-08 misterg always define define GTEST_LANG_CXX11 1
2018-10-08 misterg Remove non-variadic pre C++11 AllOf
2018-10-05 gennadiycivil Update primer.md
2018-10-05 misterg Remove pre-C++11 code from gtest-printers
2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h.  This is for use in abseil exception safety testing.
2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits
2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest.
2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests
2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506
2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt
2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e
2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt
2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c
2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45
2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28
2018-10-01 misterg Googletest export
2018-09-27 durandal Googletest export
2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD
2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt
2018-09-26 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again"
2018-09-25 gennadiycivil Keep one MinGW build, remove the others
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Update appveyor.yml
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4
2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update Makefile.am
2018-09-25 gennadiycivil Update .travis.yml
2018-09-25 misterg automake
2018-09-25 misterg test automake c++11
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 gennadiycivil Update configure.ac
2018-09-25 misterg typo
2018-09-25 misterg autotools c++11
2018-09-25 misterg autotools c++11
2018-09-25 misterg test
2018-09-25 misterg include c++11 for autotools
2018-09-25 absl-team Googletest export
2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds"
2018-09-25 misterg Googletest export
2018-09-24 misterg Googletest export
2018-09-20 absl-team Googletest export
2018-09-25 misterg enable MingW on PR
2018-09-25 misterg C++11 autotools build
2018-09-25 misterg adding c++11 to appveyor mingW
2018-09-25 misterg typo
(...)

Created with:
  roll-dep src/third_party/googletest/src

TBR=thakis@chromium.org

Bug: 893369
Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1310634
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604801}

NVDA doesn't seem to be picking up the accessibility event on the zoom
level label. This change sends an alert event on the zoom bubble
instead.

Bug: 849472
Change-Id: I391e01bb952325b133cf9362d80c473140717a44
Reviewed-on: https://chromium-review.googlesource.com/c/1305242Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604800}

This uses the undocumented pthread_chdir_np() to change the launching
thread's PWD for the duration of the posix_spawn() syscall. There is no
other way to change directories when using posix_spawn, other than an
exec trampoline.

Bug: 179923
Change-Id: Ic6ab10cd1cb5be2f008b434b3546c05f080ef9b1
Reviewed-on: https://chromium-review.googlesource.com/c/1311258Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604799}

Currently redirect is not supported for download in non network service
code path without a renderer where we handle the network request with
UrlDownloader.

We have two legit use cases for redirect in UrlDownloader.

1. Retry, we won't assume the renderer exists and the download URL is
the final URL.

2. Background download in normal user profile. It should be legit for
all clients to redirect.

Bug: 883387
Change-Id: Ib517b3a1e23fbfac939386c0f2341a15a54b70ab
Reviewed-on: https://chromium-review.googlesource.com/c/1312114
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604798}

This is a quick fix for crbug.com/888215. crbug.com/901092 will track
the longer term fix, which will likely require quite a bit more work.

Bug: 888215
Change-Id: I071ea0a1508e486211789073c43050f4cd56accb
Reviewed-on: https://chromium-review.googlesource.com/c/1313414
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604797}

Bug: 870460
Change-Id: I1c8e20231d88fb7cb87b1bb2a31b6edcb031f6aa
Reviewed-on: https://chromium-review.googlesource.com/c/1313751
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604796}

Run the main flakiness_cli script using vpython. Also add pandas (and
dependencies) to src/.vpython itself.

Bug: 875251,878994
Change-Id: Ib0160b18c9bd2423659ac13d24979eccf91c2d7c

TBR=nednguyen@chromium.org

Change-Id: Ib0160b18c9bd2423659ac13d24979eccf91c2d7c
Reviewed-on: https://chromium-review.googlesource.com/c/1238569
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#604795}

Blink is using a suboptimal hash function both in hashing quality (i.e. collisions)
as also in speed as since 2004 new and faster hash functions were developed.

Based on testing on ARMv7 and x86, CityHash seems like a good alternative based on
both performance, portability and quality. For further data:
https://aras-p.info/blog/2016/08/09/More-Hash-Function-Tests/

We should consider next adding xxHash as it performed better on AArch64.

Bug: 735674
Change-Id: I8c7ccf2d834a42a9fcb01e2cc80ecda1e1c01772
Reviewed-on: https://chromium-review.googlesource.com/c/1311798Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604794}

Bug: 889222
Change-Id: I718533eef1b76bdee504b678038e598f79146e5f
Reviewed-on: https://chromium-review.googlesource.com/c/1311806
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604793}

ValueStoreFrontend doesn't need any weak reference. So make it
not extend SupportsWeakPtr.

Bug: None
Change-Id: I85cf06bc225965a3530ac4e67b9d26f7a18d46df
Reviewed-on: https://chromium-review.googlesource.com/c/1308473Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604792}

R=rch@chromium.org

Change-Id: I3a55b40b2cfa68a11f486ad824ea6158a1ee5b18
Reviewed-on: https://chromium-review.googlesource.com/c/1313509Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604791}

This CL introduces an alternative constructor for
PaintWorkletGlobalScope which will make it call the threaded constructor
for WorkletGlobalScope. The choice of which type to use is made in
PaintWorklet::CreateGlobalScope, based on the OffMainThreadCSSPaint
blink feature flag.

This CL should have no behavioral change when OffMainThreadCSSPaint is
not specified.

Bug: 890759
Change-Id: Ie971883e605a61e13c6dcdda7ad43487d1c840bb
Reviewed-on: https://chromium-review.googlesource.com/c/1273151
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604790}

Bug: None
Change-Id: I803d275d90716696644d0800572400b9b1053627
Reviewed-on: https://chromium-review.googlesource.com/c/1287932
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604789}

This better indicates it is only for tests.

BUG=none
TEST=none

Change-Id: Ife73cabedb8f7b653ad3f4102a143f1248aa508b
Reviewed-on: https://chromium-review.googlesource.com/c/1313052Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604788}

This flag will control whether or not the new custom tab bar UI is used.

Bug: 853593
Change-Id: Ie8ab91d10fc6543ab560a50795dd5e26b8e31146
Reviewed-on: https://chromium-review.googlesource.com/c/1312135
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604787}

CSP has a directive 'connect-src' that can prevent xhr requests. We proxy these requests to the
native iOS app to circumvent CSP. The native apps then takes the response and returns it to the
original xhr object. This fixes all remaining CSP issues with translate on iOS.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I53e633bffbf6fea4b025651ad1c0efe8f367aaf7
Bug: 686364
Reviewed-on: https://chromium-review.googlesource.com/c/1285513
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604786}

- small anti-alias effect difference of texts, rounded borders
- rounding difference of opacity
- invisible gradient differences
- mask-with-added-filters.html is a SPv2 progression.

Change-Id: I0bc0dbe84e586d7a89f7f27da55e1e5fffd6119a
Reviewed-on: https://chromium-review.googlesource.com/c/1305890
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604785}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ee6b6e6e335..8f8a50d00a8b


git log 5ee6b6e6e335..8f8a50d00a8b --date=short --no-merges --format='%ad %ae %s'
2018-11-01 ehmaldonado@chromium.org gclient: Make built-in vars available for expansion.


Created with:
  gclient setdep -r src/third_party/depot_tools@8f8a50d00a8b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=agable@chromium.org

Change-Id: I8d68205337dbf098fe4fc41c7f24e658fb0090c2
Reviewed-on: https://chromium-review.googlesource.com/c/1313690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604784}

With OOP-D enabled Compositor::SetDisplayVSyncParameters() won't
necessarily be called anymore as most of that logic moves to the GPU
process. This means that |refresh_rate_| won't be updated ever and would
be incorrect.

The vsync interval in received BeginFrameArgs is equivalent to the
refresh rate, so plumb that information out of cc::Scheduler and back
into ui::Compositor. This should always work correctly.

This CL also removes ContextFactory::GetRefreshRate(). This set the
initial value for |refresh_rate_| in tests. This no longer serves any
purpose, as |refresh_rate_| is only used for metric reporting that
doesn't impact tests. Tests that want to run faster already setup a
BeginFrameSource with the appropriate shorter interval.

Bug: 899300
Change-Id: I8f7dcbb984a4cd804712d39a571e43ad627c9d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1311077Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604783}

https://webrtc.googlesource.com/src.git/+log/096d016accb0..3e4c77f1c128


git log 096d016accb0..3e4c77f1c128 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 alessiob@webrtc.org Fix AGC2 fixed-adaptive gain controllers order.


Created with:
  gclient setdep -r src/third_party/webrtc@3e4c77f1c128

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1f260f4564e8750cedc6dacbc5d1451d8b9fcb74
Reviewed-on: https://chromium-review.googlesource.com/c/1313629Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604782}

Change-Id: Ib2200678698b6ed7c2a7cc22390ff3df58227add
Reviewed-on: https://chromium-review.googlesource.com/c/1313557
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604781}

- Update string
- fix text not centering on small screens.

Bug: 900378
Change-Id: Iad5640c486974c1e515df9f2519e828098d900da
Reviewed-on: https://chromium-review.googlesource.com/c/1308909
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604780}

This is part of a reverted CL crrev.com/c/1300993, this is the part
that had caused flakiness on MSAN.

Change EntryList |updateSubDirectories| method to read its content
using FS API, which turns it into async. EntryList is used by MyFiles
so Downloads folder appearance is delayed comparing to previous
approach. Some tests expected Downloads to be readily available then
they become flaky, crrev.com/c/1313709 fixes this for most tests.

Fix unittest that started failing because it metadataModel was null.

Bug: 899664, 889511
Change-Id: If7cf4dea331938cb5919ef4a0ebaa73afaa2ec20
Reviewed-on: https://chromium-review.googlesource.com/c/1313711Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604779}

Metric collection was missing in OnFinishEnrollmentFailure.

Bug: 870138
Change-Id: Ia10d63753f7732257b1e7195d117fa4725ba1542
Reviewed-on: https://chromium-review.googlesource.com/c/1313754Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604778}

This is what we already do in the internal version

Merge internal change: 219706088

R=rch@chromium.org

Change-Id: I6dec6e90cd0022fd1047551b7aa7fd4b939c9d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1313333Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604777}

This serves as documentation on how to trigger a stale preview page and
checks for the regression in the attached bug.

Bug: 898570
Change-Id: I17475d4e0f39021507f2365836e6d7955c4f7fd1
Reviewed-on: https://chromium-review.googlesource.com/c/1313744Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604776}

Flush is necessary for GLRenderer but not SkiaRenderer. So make it optional.

Bug: 897838
Change-Id: I96df913b7afd1fb6bf84314e3bd7ee0ed25ac497
Reviewed-on: https://chromium-review.googlesource.com/c/1312298Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#604775}

Bug: 891212
Change-Id: Ib4026c1e896ec188cab54c4e30c8ac2f8eb6b98f
Reviewed-on: https://chromium-review.googlesource.com/c/1305496Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604774}

The logic in PreviewsHints::CreateFromConfig() has been modified so that
it now strips out optimizations that are disabled and only allows one of
each optimization type within a PageHint. Duplicate types encountered
are also stripped. This makes it so that enabling an experimental
optimization will automatically disable a subsequent optimization of the
same optimization type in the same PageHint. If all optimizations for a
page hint are stripped, then the page hint is also stripped.

This fixes a bug related to disabled page hint optimizations being
usable, as the disabled optimizations will no longer exist in the
hint cache.

As a result of this change, when the total page hints with resource
hints exceeds the cap, the number of page hints added will always
exactly match the cap. This is due to the logic for stripping hints
allowing us to add hints that only include some of their page hints.

A DCHECK has been added verifying that non-resource loading hint
optimizations never contain resource loading hints.

Additionally, the description of |whitelisted_optimizations| for the
PageHint proto has been updated to match expectations that it will be
provided as an ordered list.

Unittests have been added to verify that the stripping is handled
properly and that the number of page hints allowed stops exactly at the
cap. Some issues with unittests in PreviewsOptimizationGuideUnittest
using InitializeMultipleResourceLoadingHints() have also been fixed.

Bug: 900725, 900733
Change-Id: Ic8d8ce2de98e4e2993cab994906c3b2e43c31a22
Reviewed-on: https://chromium-review.googlesource.com/c/1311796Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604773}

Remove more dead code.

Bug: 812085
Change-Id: I1ba634e3fb41d61511736dc7c057a5bbc5903c78
Reviewed-on: https://chromium-review.googlesource.com/c/1300315
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604772}

This is based on Yiming's CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1241756
The idea is to store the autofill profile data in each test recipe at record time,
then load the data from the recipe when testing. This makes recording the tests
less fragile, and running the tests more self-contained.

Note that, as per Yiming, validateField still takes explicit information as to
what to validate, because websites may do some formatting on the autofilled data,
so a profile field such as "2018" might be validated as "18".

Bug: 881096
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia87e4d3ee0419264a3f37c18f6e19ee7ae5d6bf3
Reviewed-on: https://chromium-review.googlesource.com/c/1257855
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604771}

Avoid a call to CreatesNewFormattingContext() in the common case
and avoid a useless addref/release.

Change-Id: Ibda986a22c5f30d710ea3088b57afb2104207262
Reviewed-on: https://chromium-review.googlesource.com/c/1310475
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604770}

Bug: 895633
Change-Id: I6ce9829dedf5af302cce660d9d8bc09f7d63af39
Reviewed-on: https://chromium-review.googlesource.com/c/1313075Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604769}

This is part of a reverted CL crrev.com/c/1300993, but this is the safe
part of it. I don't expect this to cause flakiness.

Change updateSubDirectories:
- use arrow function and const;
- change error callback calling style to match the same style used by
success callback (without if).
- change check from isFakeEntry to check for presence of the method
that's used "createReader".

Change the sorting to be an method, so it can be customized per
sub-class, later it will be used to sort My files to show Linux and Play
files at the bottom.

No changes in behaviour for users.

Change-Id: Ie8542464a360b5ed1970183dc888003119b423a9
Reviewed-on: https://chromium-review.googlesource.com/c/1313710
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604768}

Uses the GUARDED_BY annotation for the field we have protected by a
base::Lock in the VR browser test code.

As a result, switches all lock acquiring to AutoLock since the
annotation doesn't currently work with manually acquiring and
releasing.

Bug: 901136
Change-Id: I62b7726ca4ad56778b0354436a8f6d84f47fe86b
Reviewed-on: https://chromium-review.googlesource.com/c/1313752Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604767}

This adds an assignment that was removed in
http://crrev.com/f8c5470dd7bfe253825cce3272a1bbba913190dd

Bug: 901170
Change-Id: I43135804d2f0f6bee8ae3038cfc7682ccbfd7552
Reviewed-on: https://chromium-review.googlesource.com/c/1313337
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604766}