- 05 Feb, 2020 34 commits
-
-
Kent Tamura authored
Enable rendering of the shadow element of <select>, and remove anonymous block in LayoutMenuList. * HTMLOptionElement::ParseAttribute(): Update the shadow element content on option[label] change. * HTMLSelectElement::UpdateFromElement(): Fold LayoutMenuList::UpdateFromElement() into here. If option_style_ and InnerElemnet's style are inconsistent, update InnerElement's style. * HTMLSelectElement::UpdateMenuListLabel() Move the code in LayoutMenuList::UpdateInnerStyle() here. Also, kick TextChanged ax notification which LayoutText::ForceSetText did. * MenuListInnerElement::CustomStyleForLayoutObject(): Set "display: block" Add custom style which the anonymous block used. * layout_menu_list.{h,cc}: Remove a lot of code. * ax_layout_object_test.cc: Add tests to check if AXLayoutObject::StringValue() respects to text-transform and -webkit-text-security. * web_tests/accessibility/notification-listeners.html: Remove TextChanged notification expectation. After this CL, <select> won't notify TextChanged in this test scenario. The text is changed before creating LayoutObject and AXLayoutObject. Bug: 1040828 Change-Id: Ia0c19f0897ab2d1461e457c83adceda2c0739f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024250Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738416}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I7728ca5b5bfda31be35c10609a2602e6efd6adfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035518Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738415}
-
Md. Hasanur Rashid authored
This CL update the function GetOriginUsageOnFileTaskRunner to use url::Origin instead of GURL. Bug: 598424 Change-Id: Id88ee97f35f68dbc557c86e07f4431fb95271676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032556Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#738414}
-
Rachel Sugrono authored
When an item in a check-select is deleted, onFileSelectionChanged_ must ensure that the current index wraps to stay in bounds of the new selection. When we wrap, favor the bottom entry. Tests coming. Tbr: alex Bug: 803259 Change-Id: I0a6c1f4a22770ad48040695f2b170dcd0db50459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035474Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#738413}
-
Kenneth Russell authored
conformance/extensions/webgl-compressed-texture-astc.html conformance/extensions/webgl-compressed-texture-s3tc-srgb.html are failing on webgl2_conformance_gl_passthrough_tests on Intel GPUs after recent ANGLE changes. Tbr: jdarpinian@chromium.org Bug: 1048861 No-Try: True Change-Id: Iffa429a14ba13a19ef8d3b32cd34c343d7ef9e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037829 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#738412}
-
Darren Shen authored
Change-Id: I51f0c14c738ba2a6592ddd8ae73726fe2802d926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035816 Commit-Queue: dstockwell <dstockwell@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738411}
-
Kenneth Russell authored
This reverts commit 5019665f. Reason for revert: broke capture_unittests on chromeos-amd64-generic-rel per http://crbug.com/1048934 Original change's description: > Reland "Call MFShutdown in places where MFStartup is called" > > This reverts commit 5be12bf8. > > Reason for revert: Fixing the issue, and running on more trybots > > Original change's description: > > Revert "Call MFShutdown in places where MFStartup is called" > > > > This reverts commit abf9a1f5. > > > > Reason for revert: Broke tests on Win7 dbg, see linked bug > > > > Original change's description: > > > Call MFShutdown in places where MFStartup is called > > > > > > Bug: 1012527 > > > Fixed: 1012527 > > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332 > > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738063} > > > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org > > > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1012527 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738130} > > TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org > > Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1012527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738344} TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org Change-Id: Ieba1f172a5a2bed58e338f15c638c6deae8b0685 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012527, 1048934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037855Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738410}
-
Kenneth Russell authored
This configuration's been forced to use only the integrated GPU due to graphics driver bug workarounds, so these tests don't pass on this configuration. Tbr: enga@chromium.org Bug: 1047573 No-Try: True Change-Id: Id6e436ae118a1fbb552cfebd995f689b274f893e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037826 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738409}
-
Regan Hsu authored
This CL copies over the final strings that are missing from browser settings to OS settings, and removes the browser string provider from OS settings. Bug: 967888 Change-Id: Iebf0880fb3ef94df67e9bc4fea14ad286b0c18ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036263 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738408}
-
Anand K. Mistry authored
Constants defined in the mojom are re-exported as part of the public API. Adding the mojom as a public dep ensures the header files are generated before trying to compile any dependent target. Bug: 939235 Change-Id: I80b72bcf2ab7a722ebdd3c6c2703fbb546affad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037298Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738407}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ae44760. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I85a7219e516a2ae566bca595883c26e13f359ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037935Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738406}
-
Isabella Scalzi authored
Previously the way that Files App checked whether a file could be deleted was different depending on which method that was taken to delete the file. Some places were also calling private methods. Fix this: Make common helper |deleteEntries| that deletes the files specified if possible. Change quick_view_controller.js to use this helper. Note: |canDeleteEntries_| does not check root and fake entries because |canExecute| must behave differently for those types of entries. Also clarify comments and fix closure types. Tbr: alex Bug: 803259 Change-Id: I9c128857b8c3e70f3f287d08a9130fb0728ae249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035502Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738405}
-
Rafael Cintron authored
Graphics drivers periodically allocate internal memory buffers in order to speed up subsequent rendering requests. These memory allocations in general lead to increased memory usage by the overall system. Calling Trim discards internal memory buffers allocated for the app, reducing its memory footprint. Calling Trim method does not change the rendering state of the graphics device and has no effect on rendering operations. There is a brief performance hit when internal buffers are reallocated during the first rendering operations after the Trim call, therefore apps should only call Trim when going idle for a period of time or during low memory conditions. Bug: 1048920 Change-Id: Ic6a27fc5b05eb4084c85726fd3c4f82837f786a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037816 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738404}
-
Stephen Chenney authored
This is in preparation for reporting forced update reason in UMA and UKM. Bug: 1041295 Change-Id: I92518c9e62e0ea36bde0ccb873b221a347d281f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018005Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#738403}
-
Bailey Berro authored
Enables the resolution change modal by default. Bug: 860097 Change-Id: I5774c8b710d3744c8e09e158aecbed5dafcfabb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038076 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738402}
-
Yue Zhang authored
http://crrev.com/c/2024495 makes SelectableItemView inflate modern_list_item_view in its onFinishInflate(). However, even though SelectableTabGridView extends SelectableItemView, it doesn't use the views within it. Thus, this CL removes content from SelectableItemView right after it is inflated to ensure the UI is correct. Bug: 1047595 Change-Id: Ia4da1559c039be95a6463368c642b3c53f4f7c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033805 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738401}
-
Xiao Yang authored
1. Add method to get eid from deeplinks and append to lists¬es mainview link url. 2. Update lists¬es url. 3. Add deeplink parameter "type" to support shopping list. Bug: b/145951425 Change-Id: If063962ddd01e13d738e439f00a159249cea4e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990147Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#738400}
-
Wei Li authored
The change is to prepare for stable 1% launch at CL/293181353. BUG=none Change-Id: Ib0a583917c5b9d4858bbf4cb73c8386f44a0fa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036798Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#738399}
-
Tetsui Ohkubo authored
When Chrome is in forced tablet mode (--force-tablet-mode=touch_view) and display rotation is set through setDisplayProperties(), ScreenOrientationController::GetCurrentOrientation() keeps returning landscape-primary regardless of the rotation. It prevented some tests from working as intended. TEST=tast run eve-DUT arc.SoftInputMode BUG=1032881 Change-Id: I2b40db9fea2af4a066a0fb8f4d37a870b87d603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032693Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#738398}
-
Jiawei Li authored
Removed usage of deprecated methods. Merge-With: eureka-internal/358999 Bug: Internal b/148628557 Test: bindings_manager_cast_browsertest, unittests. Change-Id: I435e9cf0e5a5a19e178c10d4cf99eef5ce4b36b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037028Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#738397}
-
Sam Sebree authored
Reland "[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key." This is a reland of 2292ef33 This change addresses the bug in which the color picker selection ring gets placed in the top left corner after closing a color picker with (255,255,255) is selected. Bug: 1046648 Change-Id: I78e0fd3175ad1b1cfac9226dc451062ec9e14b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036346 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738396}
-
Yue Zhang authored
Currently, popup tabstrip doesn't update when user uses swipe gesture to switch between tabs. This CL fixes this issue and adds some tests. Bug: 1048732 Change-Id: I967769ccec7dc7220a7528b72c628e0f76fc1cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037835Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738395}
-
Clark DuVall authored
WebLayer was crashing in Monochrome because BundleUtils.setIsBundle() was never called. This looks like it was caused by http://crrev.com/c/1989243. Bug: 901465 Change-Id: I6f2220b3def3d1783677f8a48b5b4555fd896bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036267 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738394}
-
Maksim Moskvitin authored
Sync.EncryptEverythingWhenCryptographerNotReady has a better alternative - filtering by passphrase type. HasAccessToken* histograms are buggy and replaced by NigoriConfigurationWithInvalidatedCredentials histogram. Bug: 1036875, 1037330 Change-Id: Ic4b590b7a6b8d7f5ecf19607b3a2c5852fd0e0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035978Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#738393}
-
Yue Zhang authored
In the popup TabStrip used by Duet-TabStrip integration, there is a crash in RecycleView when user very intensively clicks on the TabStrip favicon to close multiple tabs. The stack indicates that the recyclerView is trying to remove the same ViewHolder in two consecutive remove operations, and the second call would crash. The fix introduced in this CL is to early end the animation if we know for sure that this item is going to be removed. This should help with better identifying the ViewHolder to remove. This fix is inspired by the discussion here: https://b.corp.google.com/issues/34184109 and the CL here: https://critique.corp.google.com/#review/188055979/depot/google3/java/com/google/android/apps/play/music/app/ui/common/MediaListRecyclerFragment.java Even though we early end the animation, there should be no visible animation change from the UI perspective. Bug: 1045944 Change-Id: I0d8a7b098e17cdc86c4ae3227cd9dc1ba37b2adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036874 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738392}
-
Yue Zhang authored
Currently, when user uses swipe gesture to switch from a single tab to a tab in tab group, the tab strip doesn't show up. This is due to this tab selection doesn't fire a reset tab strip event. This CL fixes this issue and adds tests. Bug: 1048824 Change-Id: I05ad51709eb6274afc41f4fc6ddbd8ce396640a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037844Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738391}
-
tby authored
PS1 is the original reland, PS2 is the re-reland, including: 1. A fix for the original problem in structured_metrics_provider.cc 2. A test covering that case into s_m_p_unittest.cc 3. A deleted include that's no longer necessary after another CL. This is a reland of 4b79ed37 Original change's description: > Reland "[Structured metrics] Add metric collection and upload logic." > > This is a reland of 2fe77415 > > Original change's description: > > [Structured metrics] Add metric collection and upload logic. > > > > This is the final CL for the core of the structured metrics system. It > > ties together the KeyData class (for managing keys and computing hashes) > > with the metrics provider, and implements logic to: > > > > 1. Hash and store incoming structured metrics events. > > 2. Provide stored metrics events for upload. > > > > It also adds integration tests for the system, checking that an event > > created through the public API is correctly prepared for upload. > > > > Other misc changes: > > > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > > to events_template.py, to fix some bad style. > > - Added a missing RemoveObserver call to the metrics provider dtor. > > > > Bug: 1016655 > > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > > Commit-Queue: Tony Yeoman <tby@chromium.org> > > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735748} > > Bug: 1016655 > Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736590} Bug: 1016655 Change-Id: I54b06543c5ac3075cd1256d651d3232e6739c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034387 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738390}
-
Khushal authored
The API docs mention that this flag should be added to buffers destined for HardwareComposer. It was inadvertantly removed in: https://chromium-review.googlesource.com/c/chromium/src/+/2036374 R=liberato@chromium.org,vikassoni@chromium.org Bug: 1021007 Change-Id: If8e3b8f8fad7219829d8866fead24b844baef9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036486 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738389}
-
Olivier Li authored
Bug: 1034046 Change-Id: Id471b00549b34887039dcddb3d4c22a6d7f0a9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033428 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#738388}
-
Toni Barzic authored
Adds few missing mirrored x transformations for app list folder view: * folder_item_icon_bounds_, which is intended to be in the folder view's coordinates, were calculated from apps container bounds without adjustments for RTL (messing up folder show/hide animation original/target bounds) * reparent drag location was transformed from folder item coordinates in container view to container view coordinates to root apps grid view coordinates, both steps without RTL adjustments. BUG=1048841 Change-Id: I7a158858e6e9067b2711a3b2d53a1f452ad5dd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037645 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738387}
-
Adam Ettenberger authored
When calling AXPlatformNodeBase::FindTextBoundary, it would attempt to get the hypertext of the node, but this was returning an empty string for UI controls causing ui::FindAccessibleTextBoundary to fail. This CL merges AXPlatformNodeWin::TextForIAccessibleText into AXPlatformNodeWin::GetHypertext so that it can handle UI controls. Bug: 1047906 Change-Id: I84f0f5d1241e9b634b481dbbc49fdefc7c706d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036363Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738386}
-
Rakib M. Hasan authored
The layout test results viewer shows tests that have different results then the expected results specified in the non flag specific test expectation files. The results viewer uses the flag and base expectations per test fields to find these tests. We need to re add these per test fields. Bug: 1047602 Bug: 986447 Change-Id: I0bf603b13672e6b97a3840275c8670a13679e830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036359 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#738385}
-
bttk authored
Make CachedMetrics during initialization have 50% chance to have all histogram samples bypass it's cache and immediately forward metrics to RecordHistogram (which now uses CachingUmaRecorder). The state of the bypass is reported with a synthetic field trial: - AndroidCachedMetrics.Control - AndroidCachedMetrics.HistogramsBypassCache Bug: 1046181 Change-Id: I7fe1d9d4edf6ccf8a6b2dde0348324aaf797f032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031443 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#738384}
-
Dale Curtis authored
This replaces the indefinite blocking during pulse::InitPulse() with a timed wait of 5 seconds. We will now fall back to ALSA if we fail to connect to pulse within that time. I suspect this has the same root cause as issue 986021, but the fix for those hangs disabled the audio process, which makes the browser process now hang on startup. R=jrummell Bug: 986021, 1047655 Test: Local tests with manual shutdown of Pulse fall back to ALSA. Change-Id: I337ef88bd953f56ef0bd9969a42f190200520a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037817 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738383}
-
- 04 Feb, 2020 6 commits
-
-
Yao Xiao authored
What: This relands http://crrev/c/1993140 that was reverted in http://crrev/c/2035374. The diff: in OverlayInterstitialAdDetector::MaybeFireDetection, switch to main_frame->ContentLayoutObject()->HitTestNoLifecycleUpdate for the hit test. Why: We don't need LocalFrameView::UpdateAllLifecyclePhasesExceptPaint as we don't need to recurse into child document. Forcing the update would change the document lifecycle state, that would break the test expectations of FrameThrottlingTest.ThrottledLifecycleUpdate and would introduce flakes for AccessibilityActionBrowserTest.ImgElementGetImage. Bug: 1047921 Change-Id: Ic99420e125788d446bb11202848634ddc6e07841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034054 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#738382}
-
Greg Thompson authored
This change makes UpgradeDetector an observer of the process's BuildState, removing its own detection. It instead creates an instance of either an InstalledVersionPoller (for desktop Chrome) or an InstalledVersionUpdater (for Chrome OS) to do the actual detection work. BUG=1043624 Change-Id: Ib04b0f588a3d035f2ce0300561ed86d9024c7b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017352 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738381}
-
Henrique Nakashima authored
FeatureUtilities is not accurate anymore, as this shouldn't contain code for specific features anymore, and it is (and has been) a stateful class. The responsibility of this class is to cache feature flags for use without native being loaded. This is CL 3/5 for renaming FeatureUtilities. Bug: 1012975 Change-Id: I8b4c72a65361379ec34272bdff55edf416d35b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028111 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#738380}
-
Ian Kilpatrick authored
This patch introduces variants of: Resolve{Main,Min,Max}{Inline,Block}Length With a callback function to provide the MinMaxSize, or IntrinsicBlockSize as needed. This in instead of logic used by other algorithms via. NeedMinMaxSize et. al. There are pros/cons to this approach: Pro - Much more precise (and easier to maintain) calls to NGBlockNode::ComputeMinMaxSize and NGBlockNode::Layout. Con - Duplicate logic for Resolve*Length. I tried moving Resolve*InlineLength to all being callback based but some other refactoring needs to occur first (mainly an additional ng cache). An alternate version of this patch would be either: 1) A NeedsMinMaxSize / NeedsIntrinsicBlockSize similar to other callers of these functions. 2) Adding the branch before the Resolve*Length calls to check if we need to provide the appropriate argument. Bug: 845235 Change-Id: I8e26e0171adc60a7e3d244af3cb21e119b2653f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027075Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a3ade44d9f4..cecc4d627631 Created with: gclient setdep -r src-internal@cecc4d627631 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1d0910de3a5a395180e1a6b1953c5aa838b415a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738378}
-
Alex Moshchuk authored
This reverts commit 919ba484. Reason for revert: New test PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported is consistently failing on linux-chromeos-chrome. First failing build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2687. Test output (CRASH): [ RUN ] PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported [1:1:0204/141234.652201:WARNING:hugepage_text.cc(182)] The ordering seems incorrect, fall back to small page [7821:7821:0204/141234.715769:WARNING:audio_manager_linux.cc(52)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [7821:7884:0204/141234.746168:ERROR:arc_property_util.cc(224)] arc-build-properties is not found [7821:7884:0204/141234.746216:ERROR:arc_property_util.cc(276)] Failed to read /usr/share/arc/properties/default.prop: No such file or directory (2) [7821:7884:0204/141234.746237:ERROR:arc_property_util.cc(295)] Failed to expand /usr/share/arc/properties/default.prop [7821:7821:0204/141234.760051:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier. [7821:7821:0204/141234.761643:ERROR:proximity_auth_profile_pref_manager.cc(189)] Failed to find local state prefs for current user. [7821:7821:0204/141234.816422:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier. [7821:7821:0204/141234.824119:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier. [7821:7821:0204/141234.827132:WARNING:remote_commands_service.cc(40)] Client is not registered. [7821:7821:0204/141234.831227:WARNING:wallpaper_controller_client.cc(370)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [7821:7821:0204/141234.872150:ERROR:account_manager_migrator.cc(256)] Could not find a refresh token for the Device Account. [7821:7821:0204/141234.876165:WARNING:drivefs_session.cc(62)] DriveFs mount failed with error: 3 [7821:7908:0204/141234.954453:WARNING:google_brand_chromeos.cc(39)] Brand code file missing: /opt/oem/etc/BRAND_CODE BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55a6a7352149 base::debug::CollectStackTrace() #1 0x55a6a72c17b3 base::debug::StackTrace::StackTrace() #2 0x55a6a782e765 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f81d61164b0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354af) #4 0x55a6a7a68a22 net::test_server::EmbeddedTestServer::DoAcceptLoop() #5 0x55a6a730574f base::TaskAnnotator::RunTask() #6 0x55a6a731511a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #7 0x55a6a7314eb7 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() #8 0x55a6a736d6a9 base::MessagePumpLibevent::Run() #9 0x55a6a73159c8 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #10 0x55a6a72efb57 base::RunLoop::Run() #11 0x55a6a7328939 base::Thread::ThreadMain() #12 0x55a6a735f3ce base::(anonymous namespace)::ThreadFunc() #13 0x7f81d9fbf6ba start_thread #14 0x7f81d61e841d clone Original change's description: > Reland "[Payments]Don't show "add card" button when basic card is not requested." > > This is a reland of 08e5b730. The cl > got reverted because of the added test failing on ChromeOS_Chrome_Linux > build. > > Original change's description: > > [Payments]Don't show "add card" button when basic card is not requested. > > > > This is a Desktop only change to ensure that the "add card" button is > > shown in payment method window only when the "basic card" method is > > supported. > > > > Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923 > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735978} > > TBR=rouslan@chromium.org > > Change-Id: I90d4febb944d48cfe009c0c0e1511f9d493d1762 > Bug: 1046514 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037639 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738334} TBR=rouslan@chromium.org,sahel@chromium.org Change-Id: Idfe37889ed1bc2effd9bec6ae075559c293a0fcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037828Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738377}
-