Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 05 Feb, 2020 34 commits
  3. 04 Feb, 2020 6 commits
    • Yao Xiao's avatar
      Reland overlay-interstitial-ad detection, switching to HitTestNoLifecycleUpdate · 0530ba2f
      Yao Xiao authored 
      What: This relands http://crrev/c/1993140 that was reverted in
http://crrev/c/2035374. The diff:
in OverlayInterstitialAdDetector::MaybeFireDetection, switch to
main_frame->ContentLayoutObject()->HitTestNoLifecycleUpdate for the hit
test.

Why: We don't need LocalFrameView::UpdateAllLifecyclePhasesExceptPaint
as we don't need to recurse into child document. Forcing the update
would change the document lifecycle state, that would break the test
expectations of FrameThrottlingTest.ThrottledLifecycleUpdate and would
introduce flakes for AccessibilityActionBrowserTest.ImgElementGetImage.


Bug: 1047921
Change-Id: Ic99420e125788d446bb11202848634ddc6e07841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034054
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: default avatarStefan Zager <szager@chromium.org>
Reviewed-by: default avatarBryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738382}
      0530ba2f
    • Greg Thompson's avatar
      Make UpgradeDetector detect updates via observing the BuildState. · 08451a4e
      Greg Thompson authored 
      This change makes UpgradeDetector an observer of the process's
BuildState, removing its own detection. It instead creates an instance
of either an InstalledVersionPoller (for desktop Chrome) or an
InstalledVersionUpdater (for Chrome OS) to do the actual detection work.

BUG=1043624

Change-Id: Ib04b0f588a3d035f2ce0300561ed86d9024c7b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017352
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738381}
      08451a4e
    • Henrique Nakashima's avatar
      Rename FeatureUtilities to CachedFeatureFlags. · 732f0565
      Henrique Nakashima authored 
      FeatureUtilities is not accurate anymore, as this shouldn't contain
code for specific features anymore, and it is (and has been) a
stateful class.

The responsibility of this class is to cache feature flags for use
without native being loaded.

This is CL 3/5 for renaming FeatureUtilities.

Bug: 1012975
Change-Id: I8b4c72a65361379ec34272bdff55edf416d35b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028111
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738380}
      732f0565
    • Ian Kilpatrick's avatar
      [FlexNG] Lazily calculate the MinMaxSize and IntrinsicBlockSize for flex-items. · 4b4053d0
      Ian Kilpatrick authored 
      This patch introduces variants of:
Resolve{Main,Min,Max}{Inline,Block}Length

With a callback function to provide the MinMaxSize, or IntrinsicBlockSize
as needed.

This in instead of logic used by other algorithms via. NeedMinMaxSize
et. al.

There are pros/cons to this approach:
Pro - Much more precise (and easier to maintain) calls to
      NGBlockNode::ComputeMinMaxSize and NGBlockNode::Layout.
Con - Duplicate logic for Resolve*Length.

I tried moving Resolve*InlineLength to all being callback based but some
other refactoring needs to occur first (mainly an additional ng cache).

An alternate version of this patch would be either:
1) A NeedsMinMaxSize / NeedsIntrinsicBlockSize similar to other callers
   of these functions.
2) Adding the branch before the Resolve*Length calls to check if we
   need to provide the appropriate argument.

Bug: 845235
Change-Id: I8e26e0171adc60a7e3d244af3cb21e119b2653f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027075Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Reviewed-by: default avatarDavid Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738379}
      4b4053d0
    • chromium-internal-autoroll's avatar
      Roll src-internal 9a3ade44d9f4..cecc4d627631 (1 commits) · ecde9593
      chromium-internal-autoroll authored 
      https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a3ade44d9f4..cecc4d627631


Created with:
  gclient setdep -r src-internal@cecc4d627631

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I1d0910de3a5a395180e1a6b1953c5aa838b415a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037696Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738378}
      ecde9593
    • Alex Moshchuk's avatar
      Revert "Reland "[Payments]Don't show "add card" button when basic card is not requested."" · 1b541203
      Alex Moshchuk authored 
      This reverts commit 919ba484.

Reason for revert: New test PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported is consistently failing on linux-chromeos-chrome.  First failing build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2687.

Test output (CRASH):
[ RUN      ] PaymentMethodViewControllerTest.DoNotShowAddCardWhenBasicCardIsNotSupported
[1:1:0204/141234.652201:WARNING:hugepage_text.cc(182)] The ordering seems incorrect, fall back to small page
[7821:7821:0204/141234.715769:WARNING:audio_manager_linux.cc(52)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
[7821:7884:0204/141234.746168:ERROR:arc_property_util.cc(224)] arc-build-properties is not found
[7821:7884:0204/141234.746216:ERROR:arc_property_util.cc(276)] Failed to read /usr/share/arc/properties/default.prop: No such file or directory (2)
[7821:7884:0204/141234.746237:ERROR:arc_property_util.cc(295)] Failed to expand /usr/share/arc/properties/default.prop
[7821:7821:0204/141234.760051:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.761643:ERROR:proximity_auth_profile_pref_manager.cc(189)] Failed to find local state prefs for current user.
[7821:7821:0204/141234.816422:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.824119:INFO:profile_network_context_service.cc(246)] Using built-in cert verifier.
[7821:7821:0204/141234.827132:WARNING:remote_commands_service.cc(40)] Client is not registered.
[7821:7821:0204/141234.831227:WARNING:wallpaper_controller_client.cc(370)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[7821:7821:0204/141234.872150:ERROR:account_manager_migrator.cc(256)] Could not find a refresh token for the Device Account.
[7821:7821:0204/141234.876165:WARNING:drivefs_session.cc(62)] DriveFs mount failed with error: 3
[7821:7908:0204/141234.954453:WARNING:google_brand_chromeos.cc(39)] Brand code file missing: /opt/oem/etc/BRAND_CODE
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x55a6a7352149 base::debug::CollectStackTrace()
#1 0x55a6a72c17b3 base::debug::StackTrace::StackTrace()
#2 0x55a6a782e765 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f81d61164b0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354af)
#4 0x55a6a7a68a22 net::test_server::EmbeddedTestServer::DoAcceptLoop()
#5 0x55a6a730574f base::TaskAnnotator::RunTask()
#6 0x55a6a731511a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#7 0x55a6a7314eb7 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()
#8 0x55a6a736d6a9 base::MessagePumpLibevent::Run()
#9 0x55a6a73159c8 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#10 0x55a6a72efb57 base::RunLoop::Run()
#11 0x55a6a7328939 base::Thread::ThreadMain()
#12 0x55a6a735f3ce base::(anonymous namespace)::ThreadFunc()
#13 0x7f81d9fbf6ba start_thread
#14 0x7f81d61e841d clone


Original change's description:
> Reland "[Payments]Don't show "add card" button when basic card is not requested."
> 
> This is a reland of 08e5b730. The cl
> got reverted because of the added test failing on ChromeOS_Chrome_Linux
> build.
> 
> Original change's description:
> > [Payments]Don't show "add card" button when basic card is not requested.
> >
> > This is a Desktop only change to ensure that the "add card" button is
> > shown in payment method window only when the "basic card" method is
> > supported.
> >
> > Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923
> > Commit-Queue: Sahel Sharify <sahel@chromium.org>
> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735978}
> 
> TBR=rouslan@chromium.org
> 
> Change-Id: I90d4febb944d48cfe009c0c0e1511f9d493d1762
> Bug: 1046514
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037639
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738334}

TBR=rouslan@chromium.org,sahel@chromium.org

Change-Id: Idfe37889ed1bc2effd9bec6ae075559c293a0fcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037828Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738377}
      1b541203