- 07 Oct, 2020 30 commits
-
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //device. R=agl@chromium.org, reillyg@chromium.org, satorux@chromium.org Bug: 1113033 Change-Id: I03766d214b4920e5f27d4ad6d690a6b57135c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454305 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814490}
-
Hung Vu authored
This CL changes the UI behavior when a storage that doesn't have enough space for the download is chosen, a "not enough space" error text will be prompted below the storage name. All implementations are wrapped in feature flag. Bug: 1118207 Change-Id: I6e9e6c497d4b2b97dbda32faa98314731c6244f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436312 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814489}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //testing. Bug: 1113033 Change-Id: Ic55848e4cd6b3ba004bb455c4f12fe490febbe3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450928Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814488}
-
Joel Hockey authored
This reverts commit e739fc50. Reason for revert: reland with fix for camera.CCAUISettings in crrev.com/c/2454769 Original change's description: > Revert "Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps" > > This reverts commit 4d4f20fc. > > Reason for revert: https://crbug.com/1132535 > > Original change's description: > > Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps > > > > Screenshots: > > http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1 > > http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818 > > http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71 > > > > When Chrome OS did not support external protocol handlers, it > > replaced browser/ui/views/external_protocol_dialog with > > browser/chromeos/external_protocol_dialog which states that no > > handlers are available. ARC has added a dialog which is shown > > when any android apps can handle a link. This CL uses the > > standard ExternalProtocolDialog for Guest OS apps when ARC does > > not handle a link, but Guest OS can. > > > > * Renamed CrOS version of ExternalProtocolDialog to > > ExternalProtocolNoHandlersDialog. It is still used when no handlers > > are found. > > > > * Changed ui/views/external_protocol_dialog to now be compiled into > > CrOS, but leaving out > > ExternalProtocolHandler::RunExternalProtocolDialog which is provided > > in the CrOS version: chromeos/external_protocol_dialog.cc. > > > > * Replaced platform_util_chromeos OpenExternal to Launch the registered > > Guest OS app. This function was previously not ever called in CrOS. > > > > Bug: b/168506505 > > Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Jason Lin <lxj@google.com> > > Cr-Commit-Position: refs/heads/master@{#810381} > > TBR=ellyjones@chromium.org,xiyuan@chromium.org,thestig@chromium.org,joelhockey@chromium.org,lxj@google.com > > > Bug: b/168506505,1132535 > Skip-Translation-Screenshots-Check: True > Change-Id: I52bfc2a8169a018076790df8a63c253c29ded64c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434014 > Commit-Queue: Jason Lin <lxj@google.com> > Reviewed-by: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#811144} TBR=ellyjones@chromium.org,xiyuan@chromium.org,thestig@chromium.org,joelhockey@chromium.org,lxj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/168506505 Bug: 1132535 Change-Id: Iebea2aeaad1cddae89c96fcbefab49c96152927f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454350Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#814487}
-
Ryan Hansberry authored
BlePeripheral references must remain valid even after the peripheral is no longer found during a scan. Bug: 1135801 Change-Id: If3df9f9de414760fc6a00bebfff94a8861fdeb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454378 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#814486}
-
Joel Hockey authored
Split slow test into 3 to hopefully avoid timeouts. Bug: 1135410 Change-Id: I4612e8b13740665bdf994ef17d7dc2fb4ab623d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450139 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814485}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1432250e2c60..3f8200abfd9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1117343,chromium:1124873,chromium:1133558,chromium:1134108,chromium:1135318,chromium:912681 Tbr: liberato@google.com Change-Id: I6bc2aaa609fc15b079f57ea87e707ca502bf6445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454531Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814484}
-
Sunny Sachanandani authored
The CL to fix HDR color banding issues (https://crrev.com/c/2411731) introduced a bug by holding on to the last swap chain which asked for the video processor in DCLayerTree. This CL attempts to fix that in the least impactful way so that it can be safely merged to M87. Bug: 1126365 Change-Id: I2cbae929738598782b59e5d3390fcc4dddfc5673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444189 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#814483}
-
Kuo Jen Wei authored
Bug: 1135030 Test: Manually with chromevox. Change-Id: Id57fa54f5d01dc485a418ee1d209a14af2310698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451832 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#814482}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/090d2b61..f36b3a38 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I26792430e538c09ce75a7e2b6d86d4d93bab0528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814481}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/d10bbe3dc764..c0588b0ea3a6 $ git log d10bbe3dc..c0588b0ea --date=short --no-merges --format='%ad %ae %s' 2020-10-06 bnc Change Huffman encoder benchmark to typical character distribution. 2020-10-06 bnc Improve http2::HuffmanEncodeFast() by skipping rest of iteration if possible. 2020-10-05 dschinazi Deprecate quic_send_key_update_not_yet_supported 2020-10-05 bnc Remove BoundedHuffmanSize(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ifd343c2636960ed80b1342e0b1c3936ddcb8579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454405 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#814480}
-
Collin Baker authored
The flakes seemed to be caused by interactive_test_utils::MoveMouseToCenterAndPress() sometimes clicking the wrong button, or no button at all. This CL instead simulates clicks by calling View::OnMouseEvent directly on the target buttons. Bug: 1135850 Fixed: 1134534 Change-Id: Ic73acffd2496f8c2fc20b33d8d2553cca97cdb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454632 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#814479}
-
Matt Falkenhagen authored
To prepare for testing on the Beta channel. Bug: 1092329 Change-Id: Ibc0fe7ff8548f1c20d52a88b116b86246ac104ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452089Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#814478}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010060700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/cY-8ZoI1hF9OCrUkPPPIqRyZKuwcbFij1QVQ9lXI3LUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I172178d0f8c21741917007518b273508d446e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452614Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814477}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_UuPjDwlNnn - Diagnostics App (after) http://shortn/_4Aem4oahU9 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id15c38b3453ca77dabd8e215cd5dbd1d6a94418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441680Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814476}
-
Michael Moss authored
Diff installer creation runs on the same hosts that the build runs on, so should create binaries for the same architecture. BUG=1119472 R=mark@chromium.org, thakis@chromium.org Change-Id: I58772ce20b47cf9ce854a095de3aac3cf697d5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454390 Commit-Queue: Michael Moss <mmoss@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#814475}
-
Noel Gordon authored
Add AdobeRGB1998 color profile data, encoded in a JPEG JFIF APP2 color profile segment per ICC spec so it can be inserted in a JPEG image. Bug: 1132695 Change-Id: I46fee551fff8df522621130ec5ff16aa66838002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454431Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814474}
-
Nick Harper authored
Change-Id: I227efe6a9597c87dc426889192e9be71c94c0462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454834 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814473}
-
Daniel Rubery authored
We are seeing crash stacks when constructing the ClientSideDetectionService since the SafeBrowsingService has not yet been notified of the creation of the Profile. This is because in certain circumstances (e.g. https://crash.corp.google.com/browse?reportid=defdca17c66310c3) a renderer is created for this Profile before ProfileManagerObservers are notified. We can solve this by checking for the DisableClientSidePhishingDetection flag explicitly, instead of calling into ClientSideDetectionServiceFactory, which has the side effect of creating a ClientSideDetectionService if it does not yet exist. Bug: 1131885 Change-Id: If9116613f1914ab1beee25296847840f91c52e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451523Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#814472}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie1a222cd154985d67aadca185de4c6c016be2851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814471}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //native_client_sdk. R=sbc@chromium.org Bug: 1113033 Change-Id: I6624ab46edbee706de8f0fcbab959b366e12fa40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454495 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814470}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I8972870aab6d8bd87c8b4233c0f53240bc904aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445481 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814469}
-
Brandon Wylie authored
Only used like a regular Android activity. Bug: 1123209 Change-Id: I3d68e4a3b9e984fa565249c40f03ea239c850b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453797 Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814468}
-
Sergey Ulanov authored
web_tests use headless windows, i.e. they create windows, but never call Show(). The tests expect the window to report the initial size specified in PlatformWindowInitProperties.bounds passed during initialization. ScenicWindow wasn't using PlatformWindowInitProperties.bounds, as result the compositor wasn't running so the pixel tests were timing out. This change updates ScenicWindow to report the size requested by the caller until Show() is called. Bug: 1067477 Change-Id: Ieaf0757b0a90e3582d4ffd8fadb2db73e9ddd076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446539Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814467}
-
Sean Topping authored
Including the WebContents header fails when a target doesn't depend on content. Instead, we should only forward declare these classes in the Cast web primary interfaces (CastWebContents, CastWebView, CastContentWindow). Merge-With: eureka-internal/461423 Bug: None Test: CQ Change-Id: Id18c669c7d39f4ed847a8c4970f5d6c8847a234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454370Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#814466}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010060700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/GbpR7xJNVich1jbMRLPopW3O8mPtdmhWFHDEbcl4H2cC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/169630668 Tbr: media-app@grotations.appspotmail.com Change-Id: I558e064a775b89b82b538a6290bab975ae6c2c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814465}
-
David Bertoni authored
The SelfUninstall and SelfUninstallNoPermissions test are flaky when run by a SW-based extension. This CL moves them to the base class, so they are only run as legacy extensions. Bug: 1132581 Change-Id: Iec1fce201f58d833b7d9b124e658d0ae0219db1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446836Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814464}
-
Joel Hockey authored
In Chrome OS, GetDefaultBrowser() runs in ChromeAppDelegate::NewWindowContentsDelegate::OpenURLFromTab() where it will either navigate internally when it detects that the current running chrome is the system default, else it calls platform_util::OpenExternal(). The current implementation of CrOS OpenExternal() does an internal navigation, however as part of b/168506505, we are changing this to use guest_os::Launch() to launch VM apps. Since chrome is always the default browser in Chrome OS, we can change GetDefaultBrowser() to return IS_DEFAULT, which ensures OpenExternal() is no longer called for internal navigations and it can be used solely to launch VM apps. Bug: b/168506505 Bug: 1132535 Change-Id: If9ba4d065c9b01b1c9afd180b833a04f50c5cebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454769 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814463}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //ipc. R=tsepez@chromium.org Bug: 1113033 Change-Id: I94e0ae5d58bec857d39a95c1c4d580466cc14bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453874 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#814462}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //gin. R=jbroman@chromium.org Bug: 1113033 Change-Id: I45578bd0888045471f4e8e4edcb6b65b4138ed8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453753 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814461}
-
- 06 Oct, 2020 10 commits
-
-
Takumi Fujimoto authored
Establish a strong virtual connection in the following cases: - Launching a session without the invisibleSender field set in its presentation URL - Making a connection to receiver-0 Otherwise create an invisible virtual connection, including cases where we're requesting media status to show in the global media controls. This is consistent with the behavior in virtual_connection_manager.js and presentation_url.js in the component extension. Bug: 1133502, b/168566028 Change-Id: I9b7c9c3937bb4ac1f2a95fa2f8aa42a16616971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439012 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814460}
-
Sinan Sahin authored
This is the second attempt at fixing the NPE. Bug: 1133172 Change-Id: Icff7ecd432adcd7f8ccd85da0b0ab9558e028103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453442Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#814459}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ic7306c6f227ce0193402fe919a7a7a281fe9f927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446049 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814458}
-
Charlene Yan authored
Bug: 1129675 Change-Id: I9897758b712c3d4d2473c00ec8d89bb060f5ea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436593Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814457}
-
Robert Sesek authored
Accessing that Mach service is crashing the mac-10_13_laptop_high_end-perf bot. Bug: 1135413, 1126350 Change-Id: I866ff9bc8265eb91ff8a08b7957e48e3c277939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454494 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814456}
-
Eric Lawrence authored
Replace a TODO comment with a bit of information about cross-browser compatibility of the character encoding used in HTTP Basic credentials. Change-Id: I91160cd3c1d7401044fddd7a03c7a42d71bb4f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453470Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814455}
-
Scott Violet authored
As the test html has a border-right-width, so should the reference. BUG=1134184 TEST=test only change Change-Id: I7dc96193feae66b743160af33c572a24bd1c45e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447090Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814454}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //fuchsia. R=fdegans@chromium.org Bug: 1113033 Change-Id: Ic16fee164424a34b4dd77c65aba1befce3a482bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454303 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#814453}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ica69cdfa0325461711373bef5258284ade11b841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434147Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814452}
-
Sammie Quon authored
Test: none Bug: 1134390 Change-Id: I9d1333178f2b006fec25dcc69e30708df68e5b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454373 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#814451}
-