- 10 Sep, 2018 40 commits
-
-
Dominic Battre authored
Disabled test due to flaky timeouts that are observed on all platforms. TBR=jkarlin@chromium.org Bug: 882077 Change-Id: Icdc062abcfff372060ce8cb173adbf4aba542b40 Reviewed-on: https://chromium-review.googlesource.com/1215327Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#589885}
-
Vladislav Kuzkokov authored
The previous version just checked whether long edge duplex mode is available. Bug: 842063 Change-Id: Ia36246bdb1bedad04a03c592dd4622264413c7d8 Reviewed-on: https://chromium-review.googlesource.com/1113189 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589884}
-
tzik authored
v8::PersistentValueMapBase<> is an old style non-copyable type. It has private declaration-only copy ctor and assignment. That is inherited to v8::GlobalValueMap<>, and brought to DOMWrapperMap<>. That implies, DOMWrapperMap is a non-copyable type, but detected as copyable type by a defaulted copy constructor. That confuses std::optional and causes a build error on C++17 mode of Chromium. This mark DOMWrapperMap as non-copyable explicitly to fix the build error. Bug: 752720 Change-Id: Iff22df3cd108475ece9ba0c7cc4878a30d3bcb43 Reviewed-on: https://chromium-review.googlesource.com/1214908Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#589883}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7027dc081cb..b33290d08211 git log d7027dc081cb..b33290d08211 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 sakal@webrtc.org Return null from PCFactory#createPeerConnection on failure. 2018-09-07 steveanton@webrtc.org Use C++11 style for loop in webrtcsdp.cc 2018-09-07 danilchap@webrtc.org Cleanup RtpPacketizerVp9 2018-09-07 mbonadei@webrtc.org Fix no_exit_time_destructors in ortc. 2018-09-07 hta@webrtc.org Add "tones remaining" argument to DTMF ontonechange callback 2018-09-07 danilchap@webrtc.org Make RtcpTransceiver destructor non-blocking Created with: gclient setdep -r src/third_party/webrtc@b33290d08211 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I529a29d35257c955f4fe00fce7d48f522dfa1b75 Reviewed-on: https://chromium-review.googlesource.com/1214723Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589882}
-
Bernhard Bauer authored
Read-only properties can be initialized with a Builder. Migrate KeyboardAccessoryModel and AccessorySheetModel to be based on PropertyModel. Change-Id: I22f461f904ccefe1ecdde12d7ead62bacb0acf29 Reviewed-on: https://chromium-review.googlesource.com/1179885 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589881}
-
Florent Castelli authored
Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tWzutytXsqc/lGaWCFdHAgAJ Bug: 800767 Change-Id: Ibb8339e65abdb4cbb91549ffc4e64e18b36a0efd Reviewed-on: https://chromium-review.googlesource.com/1097413Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589880}
-
Marina Ciocea authored
This reverts commit 1055dd5b. Reason for revert: Fixed failing audio browser tests. Original change's description: > Revert "Temporary check global histogram allocator in audio service output controller." > > This reverts commit 9624dedb. > > Reason for revert: breaking webrtc tests: https://ci.chromium.org/buildbot/chromium.webrtc/Linux%20Tester/42679 > > Original change's description: > > Temporary check global histogram allocator in audio service output controller. > > > > Add a temporary check to investigate audio service experiment output controller > > histograms count mismatch. If histogram persistent memory is not setup before > > output controller metrics are reported, the check will fail > > (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days > > after gathering data from canary. > > > > Bug: 867827 > > Change-Id: I1f18c12c2aa2741a27c0bf82f383de70e273fd24 > > Reviewed-on: https://chromium-review.googlesource.com/1205606 > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589117} > > TBR=olka@chromium.org,marinaciocea@chromium.org > > Change-Id: I238d02410407268ca30f06666d346181158624a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 867827 > Reviewed-on: https://chromium-review.googlesource.com/1209542 > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589132} TBR=olka@chromium.org,marinaciocea@chromium.org Bug: 867827 Change-Id: I08cce13476f851d9ab24434add30f65abbf1e600 Reviewed-on: https://chromium-review.googlesource.com/1215246Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589879}
-
Yuki Yamada authored
This CL moves the methods that is for storing/loading exceptions into blink::ErrorEvent. These methods were in blink::V8ErrorHandler, but they are not related to it directly. Bug: 872138 Change-Id: I9e60a9b58e786309d9410d47849b53233a47bd27 Reviewed-on: https://chromium-review.googlesource.com/1212248Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589878}
-
Alexandr Ilin authored
This CL adds an asynchronous proxy lookup request to the PreconnectManager after the synchronous request was removed in https://crrev.com/c/1165550. The idea is that we don't need to wait for a host to be resolved before a preconnect if a proxy is enabled. Since we don't have a synchronous API for proxy lookup anymore, we issue both host and proxy requests in parallel. Then we wait until either one of the requests completes with success or both requests fail. Bug: 838763 Change-Id: Ib3fa47884ba82d1fc12c62f7fd24dd21c279e9c5 Reviewed-on: https://chromium-review.googlesource.com/1202222 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589877}
-
Yuki Shiino authored
Change-Id: Ia39fa0a613024591ddc4917100546f0aa9c0eb0b Reviewed-on: https://chromium-review.googlesource.com/1215534Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589876}
-
Dominic Battre authored
TBR=rdevlin.cronin@chromium.org Bug: 882213 Change-Id: If68c1be2e7ca400a86f18fe984ec8ee3525dceb7 Reviewed-on: https://chromium-review.googlesource.com/1215325Reviewed-by:
-
Erik Språng authored
Bug: chromium:853185, b:111781384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7bc0dc619503bbb5d0b1ed5420187f0338e160a4 Reviewed-on: https://chromium-review.googlesource.com/1201859 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589874}
-
Mythri Alle authored
For Incognito mode (and other cases where code caches are disabled) we do not create the GeneratedCodeCacheContext or the GeneratedCodeCache. It is required to verify they are non-null before using them. Bug: chromium:881792, chromium:881881 Change-Id: I9cf47ed45e88c2e4df1f4d0a499149893332c98a Reviewed-on: https://chromium-review.googlesource.com/1215682Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589873}
-
tzik authored
This CL adds missing #include for "base/macros.h", "base/logging.h", "base/callback.h", and <vector>. They used to be included indirectly through "base/optional.h", but they should be explicit. Tbr: sky@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I17da47493055828db25326b7e6dcc07f828b78ef Reviewed-on: https://chromium-review.googlesource.com/1214904Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#589872}
-
Dominic Battre authored
TBR=verwaest@chromium.org NOTRY=true Bug: 881207 Change-Id: I94bf1aba386877948036d28cefe08629a817531c Reviewed-on: https://chromium-review.googlesource.com/1215287Reviewed-by:
-
Dominic Battre authored
This test crashes with a check on Linux. On Linux CFI it crashes very frequently. FATAL:render_frame_metadata_provider_impl.cc(41)] Check failed: render_frame_metadata_observer_ptr_. TBR=khushalsagar@chromium.org Bug: 880948 Change-Id: Ie2a536e1a72f9fb00f5f1515b1683b87e87d807e Reviewed-on: https://chromium-review.googlesource.com/1215286Reviewed-by:
-
Marc Treib authored
On a configuration failure, PSS is temporarily in an inconsistent state until the error is processed (by calling OnUnrecoverableErrorImpl). If we call an observer during that time, and the observer calls PSS::GetTransportState, then that could trigger a DCHECK. It's arguable whether calling OnSyncConfigurationCompleted on an error even makes sense. It looks like none of the clients can do anything useful in that case anyway. So let's just not call them. If they're interested in the error, then they should listen for OnStateChanged instead. Bug: 880080 Change-Id: If4179cd530f3e625bd53de466c059e051b36f42d Reviewed-on: https://chromium-review.googlesource.com/1210083Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589869}
-
Daniel Bratell authored
There are more than one namespace named features, and specifically there are both ::printing::features and ::features. When the compiler knows about both and is inside namespace printing, referring to "features" will resolve to ::printing::features even if ::features was intended. This happens in jumbo builds in some configurations. The fix is to clarify what features namespace is intended by using a :: prefix. An alternative fix would be to remove ::printing::features to ::printing::printing_features. Change-Id: I0499ed98c3ad699e89dce8f1141c327937ba0a87 Reviewed-on: https://chromium-review.googlesource.com/1213167Reviewed-by:
-
Yutaka Hirano authored
It is flaky. Bug: 869758 Change-Id: Ic9c29ced0103a11ae284b10d49466fa317c605b2 Tbr: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1215508 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589867}
-
Yannic Bonenberger authored
Bug: 755477 Change-Id: I59ca20a9d958a2bcad929b9a83b1ab9053ee8d42 Reviewed-on: https://chromium-review.googlesource.com/1212062Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#589866}
-
Mohamed Amir Yosef authored
The directory implementation is different because directory keeps a copy of the server data and then compares it to the newly version. For USS, no copy is maintained and hence we have to create specifics and push to the server when there is a local update. Bug: 516866 Change-Id: Ic0a43b210866120c8ec209681e719d634fa10255 Reviewed-on: https://chromium-review.googlesource.com/1206410Reviewed-by:
-
Dominic Battre authored
It may make sense to increase the number of shards instead but I am not sufficiently knowledgable of capacity planning to do this change. The reason for increasing the timeout is that this bot times out consistently. TBR=rcui@chromium.org,sky@chromium.org Bug: 874090 BUG: 847585 Change-Id: I14f9d2eccbead7ef403e346deda5442a82d5ea27 Reviewed-on: https://chromium-review.googlesource.com/1215283Reviewed-by:
-
Daniel Bratell authored
Some test code was compiled into chrome which in jumbo builds broke the linking. In non-jumbo builds the code was probably eliminated by the implicit dead-code-removal in the linker (an .o file that is completely unused is ignored). Also changing an #include "foo.cpp" to #include "foo.h" since that caused similar linking errors related to duplicate code. Change-Id: I6c39314fadc3a82f48135755cc7de1a540006ae5 Reviewed-on: https://chromium-review.googlesource.com/1213166Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589863}
-
Dominic Battre authored
Disabling this test as it regularly (~50% of times) times out on Linux and Windows. The test is fine on MacOS. TBR=rdevlin.cronin@chromium.org Bug: 882342 Change-Id: I23dd794332f57cbbd46ba167efc562041f7e9dff Reviewed-on: https://chromium-review.googlesource.com/1215284Reviewed-by:
-
David Jean authored
When opening: https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing When searching: https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing In action: https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing Bug: 879570 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I51f88361a79703c55f03e2befb745ca3701ce577 Reviewed-on: https://chromium-review.googlesource.com/1193932 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#589861}
-
Erik Luo authored
Bug: none Change-Id: Ic24e0f08fa6d55461d7bdd50d6164b00e47ab950 Reviewed-on: https://chromium-review.googlesource.com/1200402 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#589860}
-
Sergio Villar Senin authored
It's currently using URLFetcher. It should use SimpleURLLoader instead to make it eventually work with the network service. Bug: 872876 Change-Id: I1b0a0b3fcab7f96ca576d8dae47c62f7218a31e2 Reviewed-on: https://chromium-review.googlesource.com/1203955Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#589859}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/038f252b7691..c55b114a75a0 git log 038f252b7691..c55b114a75a0 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1cee042197da..a735ee2f6df8 (1 commits) Created with: gclient setdep -r src/third_party/skia@c55b114a75a0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I14908a0bb00355089415b93e9178afc7940942f2 Reviewed-on: https://chromium-review.googlesource.com/1215086Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589858}
-
Dominic Battre authored
This test fails at least once in 95% of all try runs. It is the most flaky on Linux builders. TBR=shuchen@chromium.org,azurewei@chromium.org Bug: 882338 Change-Id: Ie7ca412494b5f4e89c28f58e8786b07615cda1e1 Reviewed-on: https://chromium-review.googlesource.com/1215025Reviewed-by:
-
Kunihiko Sakamoto authored
Now dump-signedexchange supports the b2 format, so let's use it. Bug: 803774 Change-Id: Ie0f1040f2c6428a4ada41095f1226f8ed8e12c99 Reviewed-on: https://chromium-review.googlesource.com/1215522 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Darren Shen authored
In UpdateInsetsForWindow, we assume that a window can only have one RenderWidgetHostView. However, it looks like for the hangouts app, the window has multiple RenderWidgetHostViews, all of which need to be updated. Test: Manual Bug: 764211 Change-Id: I1c9b60e4c1f9a05a0c9e0c6683c72781115ee925 Reviewed-on: https://chromium-review.googlesource.com/1215424Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#589855}
-
Leo Zhang authored
Remove unused keyboard flag kEnableExperimentalInputViewFeatures which is faulty now. Bug: 880659 Change-Id: Ia4bb8ec3cfd4f38393fe9e6f270563fc7c313245 Reviewed-on: https://chromium-review.googlesource.com/1212427Reviewed-by:
-
Gauthier Ambard authored
I am adding myself as owner for BVC. Commits: crrev.com/c/1131511 crrev.com/c/1131191 crrev.com/c/1127031 crrev.com/c/1078734 crrev.com/c/1030393 Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3b721dc4476a8cd37ac737adad0f19711c5040fc Reviewed-on: https://chromium-review.googlesource.com/1199802Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#589853}
-
Raymes Khoury authored
The old NTP should show a permission prompt when the first voice search happens. However when permission delegation was enabled it caused the wrong origin to be used for the request: chrome://newtab instead of the search origin (e.g. google.com). This CL fixes the origin so that the search origin is again used for the request. This bug does not impact the new NTP. Bug: 881742 Change-Id: Ic70c39d2adb2efafbea3f5c8b89d462c9f01352c Reviewed-on: https://chromium-review.googlesource.com/1214976Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589852}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1212423 and fixes timing ordering of PerformanceNavigationTiming attributes. Background: `fetchStart` of PerformanceNavigationTiming comes from |fetch_start| of NavigationTiming, which is set by NavigationRequest. Since NavigationRequest isn't aware of service worker interception `fetchStart` could come earlier than `workerStart` when the navigation is routed to a service worker. However, `fetchStart` is supposed to come after `workerStart`. We can address this mis-ordering by using worker ready time. When worker ready time is greater than |fetch_start| of NavigationTiming, use worker ready time as |fetch_start|. Justifications: - `fetchStart` is should be recorded after redirects end. - `fetchStart` is should be recorded after `workerStart` if a service worker intercepted the navigation. - There seems no particular ordering between `redirectEnd` and `workerStart`. - NavigationRequest already updates |fetch_start| for redirects. Bug: 782958 Change-Id: I90bdeaee73d361c9d35024f13fd0d3f91ba42b02 Reviewed-on: https://chromium-review.googlesource.com/1215426Reviewed-by:
-
Jia Meng authored
This reverts commit ea692f36. Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) Original change's description: > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > Bug: 881215 > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > Reviewed-on: https://chromium-review.googlesource.com/1209000 > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589843} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1215603Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589850}
-
Trent Apted authored
ImageLoaderClient::tasks_ is effectively unused since r316185. All it does now is cause a big JS memory leak whenever a thumbnail is loaded. This obsoletes ThumbnailLoader.OptimizationMode. Only the Gallery app's "ribbon" uses this, and it just passed the default arg. It is the only caller of ThumbnailLoader.load(), so there's no need to have any optional arguments. Bug: 881680 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic1e9a7affee8e81ed3ba4b235b956dd2c3c71d13 Reviewed-on: https://chromium-review.googlesource.com/1214966Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589849}
-
Wei Li authored
Usually, user exits tab fullscreen mode by clicking 'ESC' button as suggested by exit bubble on Mac. However, during tab fullscreen user can still click the green traffic light button from the slide-down system menu to exit fullscreen. In this case, the toolbar style has to be updated as well. This CL fixes this by calling UpdateFullscreenTopUI() from BrowserNonClientFrameViewMac::OnFullscreenStateChanged() where all the transitions from fullscreen to non-fullscreen mode would pass through. BUG=879158 Change-Id: I089fa90a260d16681b84eada5759c4e7c60a4f6f Reviewed-on: https://chromium-review.googlesource.com/1213319Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#589848}
-
Alex Lau authored
This adds a fake local ARC volume for testing. Initial integration tests added check that 1) the "Toggle Play Folders" button work in hiding and showing the non-default Android files and folders. 2) the "Toggle Play Folders" button is shown inside Play Files but hidden from the "Recents" pane. Bug: 877371 Test: Tested on Chromium build. Change-Id: Ic35de5ebb06f901ad229c9b35f1917ac9353a459 Reviewed-on: https://chromium-review.googlesource.com/1201637 Commit-Queue: Alex Lau <alexlau@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589847}
-
Luciano Pacheco authored
Metadata model provides an "update" event which is triggered anytime a metadata item has been updated from the backend. Any UI part that to display latest metadata should listen to it and update the UI accordingly. Change the directory tree to listen to Metadata "update" event to update the "shared" icon. A listener is added for every expanded folder to listen to updates for its sub-folders. When a folder is collapsed its listener is removed. Change |onExpand_| function to fetch all metadata values from |LIST_CONTAINER_METADATA_PREFETCH_PROPERTY_NAMES|, instead of |DIRECTORY_TREE_METADATA_PREFETCH_PROPERTY_NAMES|. Directory tree needs the metadata "can*" to setup permission accordingly in the context menu. This is only fetched for Drive roots, since only Drive implements these metadata. Change |updateSharedStatusIcon| function to use the cached metadata value. This fixes the issue where it would trigger metadata requests to backend too early, because this |updateSharedStatusIcon| is called from SubDirectoryItem constructor. Remove Metadata cache invalidation calls (notifyEntriesChanged and notifyEntriesRemoved) because directory tree doesn't update metadata directly. Fix MockVolumeManager to work with other volumes other than Drive, by extracting the VolumeManager implementation to detect RootType to a common function |getRootTypeFromVolumeType|. Remove constant |DIRECTORY_TREE_METADATA_PREFETCH_PROPERTY_NAMES| since its use has been removed in directory_tree.js. Add MetadataModel |removeEventListener| to be able to remove listener of MetadataModel "update" event. manual tests for Drive "shared" icon. New integration tests for "shared" icon will be added in follow up CL. Bug: 880187, 880189 Test: Unittest for |insideMyDrive| and |insideDrive| functions and Change-Id: Ibe8320e7b0981d8e9556ebb8a922d7db2f16860c Reviewed-on: https://chromium-review.googlesource.com/1203596 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
