- 23 Sep, 2020 40 commits
-
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the Origin Policy WPTs to use the header to block features, rather than to implicitly allow them, which as a test mechanism, will work both before and after the behaviour change. Bug: 1095641 Change-Id: I3e40480a23ebaea942df661b9a3ff233d108e495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425003Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#809801}
-
Elly Fong-Jones authored
Bug: 1131496 Change-Id: If7089f0f68571ab61b47110de9767c8ffd526c8d Tbr: alemate@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425393Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809800}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee7ae7aba2c9..edea3d95c996 2020-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from d19622688af4 to e7fcc14d450b (1 revision) 2020-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0a863bc36554 to ae8b33cdea62 (1 revision) 2020-09-23 jmadill@chromium.org Isolated script args in restricted trace tests. 2020-09-23 jmadill@chromium.org Suppress two more compute shader tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I9a3e903c0b98632dd490025a94195d278e9c1f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809799}
-
Allen Bauer authored
Bug: <none> Change-Id: Idb6a8fe933c0e71ce4a02e7f4ac5de4241367725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424832Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#809798}
-
Stephen Nusko authored
This has increased to a 7% flaky rate so disable for now. Bug: 1104211 Change-Id: Ie2413d02e00675892ee8956ac411b426773c3c77 No-Try: True TBR: johnchen@chromium.org CC: mythria@chromium.org,tmrts@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426487Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809797}
-
Andrew Grieve authored
And add some color :) Bug: None Change-Id: I9c5be022139b4732572e16637ab7d29b0b22b36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424826 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809796}
-
Christian Biesinger authored
These tests were written by Mozilla. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: Ic677aa61807a03783c8a70e93dac57de89c7428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425845 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809795}
-
Joshua Pawlicki authored
Specifically, the test app should install and register itself by: 1. Call --install on its bundled updater. 2. Use IPC registration to register the test app's presence. Also, this CL unifies the test app appid on Win and Mac, and fixes ownership / initialization issues associated with the test app initializing services prior to updater installation. There are also some minor code cleanups around repeated vs once callbacks. Change-Id: Ib033be4479ded6b83637f24b133eea4f38004fac Bug: 1122773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422138 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809794}
-
Esmael El-Moslimany authored
Bug: 1116329 Change-Id: Idad6c2885c852c6044a591e0a2a3112adead8d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424383Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809793}
-
Stephen Nusko authored
This fails ~10% of the time, trying to take a memory dump. Disable until this is investigated. No-Try: True TBR: johnchen@chromium.org CC: eirkchen@chromium.org,ssid@chromium.org Bug: 1095610 Change-Id: I7303d2b91e7ed6c7addf4be0a19bf6fd0e9336d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426606Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809792}
-
Findit authored
This reverts commit 7ff62f12. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 809777 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdmZjYyZjEyMGUyNTUzMmRmYWU2NjAzNTE0NTJiN2JkODM3MzM3NjQM Sample Failed Build: https://ci.chromium.org/b/8868354221177409968 Sample Failed Step: compile Original change's description: > Report installation stages in increasing order > > This CL reports the installation stages for force installed extensions > in an increasing order. This is done in order to investigate > the extensions stuck in CREATED stage. > > Bug: 989526 > Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809777} Change-Id: I692551b411e6f50b1a75e54c9d941920e0a370c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424816 Cr-Commit-Position: refs/heads/master@{#809791}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I2573d65f79ca9371e00ec1aa9f2c23f4a0c26b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425355Reviewed-by:
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: I5fc16143e7425d84ee0d6cfc55b863063d725f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418805Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809789}
-
Yoshifumi Inoue authored
This patch makes |NGInlineNode::ShapeText()| not to reuse partial |ShapeResult| with letter-spacing to avoid applying letter spacing multiple times. In the CL[1], we stop reusing full |ShapeResult| with letter spacing but we reuse partial |ShapeResult|, e.g. before/after replaced text. [1] http://crrev.com/c/2397105 Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing Bug: 1124446, 1130611 Change-Id: I6132d0106038cb7d8ba8cf6ac02493e903804f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423648 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Gang Wu authored
This reverts commit 9183c032. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester Original change's description: > Make LayoutManager observer notification async > > The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves. > > Bug: 1129783 > Change-Id: Ia482a109576539d54f171950468e490972e72bc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418981 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809386} TBR=dtrainor@chromium.org,hanxi@chromium.org,pnoland@chromium.org Change-Id: Ic1028b99d727da8bf2b85955745068de1eaa45bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426724Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f46b7d67f8f2..2daeda990573 2020-09-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-23 sigurds@chromium.org Only query coverage model if it is available 2020-09-23 kimanh@chromium.org [typescript] TypeScript-ify front_end/ui/ShortcutsScreen.js 2020-09-23 jacktfranklin@chromium.org Enforce that .data= calls in LitHtml are typecast 2020-09-23 jacktfranklin@chromium.org Document mutation helpers for frontend unit tests 2020-09-23 aerotwist@chromium.org Adds support for loading text resources in Runtime 2020-09-23 changhaohan@chromium.org Disable CSS Grid experiment by default 2020-09-23 sigurds@chromium.org Add IOModel to Browser, Frame, and worker targets 2020-09-23 sigurds@chromium.org Reinstate fix after migration accidentally reverted 2020-09-23 tvanderlippe@chromium.org Add component hooks to conductor 2020-09-23 sadym@chromium.org Fix DevTools idle state emulation e2e test 2020-09-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-23 szuend@chromium.org [ts] Type-check sources/FilteredUISourceCodeListProvider with TypeScript 2020-09-23 szuend@chromium.org [ts] Type-check sources/ScopeChainSidebarPane.js with TypeScript 2020-09-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-22 chrche@microsoft.com [Loc] Add collect-strings step to generate en-US and en-XL.json 2020-09-22 sadym@chromium.org Roll Puppeteer from v5.2.1 to v5.3.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1047356,chromium:1069378,chromium:1122511,chromium:1126047,chromium:1129881,chromium:1130513,chromium:1130981,chromium:1131147,chromium:1131420 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f0c67beb7868d0600784674d3241db27604b568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425901Reviewed-by:
-
Owen Min authored
The following policies are renamed. The new names will be launched in M87 and the old one will be deprecated at the same time. DeviceNativePrintersBlacklist => DeviceNativePrintersBlacklist DeviceNativePrintersWhitelist => DevicePrintersAllowlist DeviceNativePrintersAccessMode => DevicePrintersAccessMode DeviceNativePrinters => DevicePrinters UsbDetachableWhitelist => UsbDetachableAllowlist QuickUnlockModeWhitelist => QuickUnlockModeAllowlist PrintingAPIExtensionsWhitelist => PrintingAPIExtensionsAllowlist DeviceUserWhitelist => DeviceUserAllowlist Bug: 1098051, 1098048, 1105183, 1105185, 1103813, 1103814, 1119444, 1103816 Change-Id: I7c224d64bb3e9434e87ab7528d4be06070f4c599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424656 Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809785}
-
Stephen Nusko authored
This benchmark fails ~20% of the time, and causes excessive flakiness disable until the benchmark owner has investigated and fixed. No-Try: True TBR: johnchen@chromium.org CC: qiangchen@chromium.org,mbonadei@chromium.org,phoglund@chromium.org Bug: 1129497 Change-Id: I11b892cdcd85d578d1e3589faa3bd3c9cd5ad0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426444Reviewed-by:
-
Elly Fong-Jones authored
Apparently this is a known problem with nacl builds; see the linked bug. Bug: 1047205 Change-Id: Ic822cda7ecdc53e72288332498103bdde2db35bf Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425395Reviewed-by:
-
Mohamed Amir Yosef authored
This got accidently broken in crrev.com/c/2421449c Bug: 1115952 Change-Id: Iea77f166db0a8491c466e56f461336b0f294961c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426046 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809782}
-
Glen Robertson authored
Iteration order was implied but never stated before. We need to rely on it for correctness. eg. crrev.com/c/2398449 Change-Id: I2050dffb44da68950261db319981537178fea2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407622 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809781}
-
Gabriel Marin authored
These are indicative of unsupported perf record commands. BUG=b:169068625 Change-Id: Id04dd286cd77ab0ee6d04f9e3e3ff3986802c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424710Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#809780}
-
Philip Jägenstedt authored
Bug: 1131471 Change-Id: I46758dfffb63e98f42a262b6e398a01beca3bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424093 Auto-Submit: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809779}
-
Morten Stenshorne authored
Don't let contents of boxes with non-visible overflow affect initial column balancing block-size estimate. Bug: 829028 Change-Id: I7d4be18001da7f41676f1254df43ab0e083e3ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425043 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Swapnil authored
This CL reports the installation stages for force installed extensions in an increasing order. This is done in order to investigate the extensions stuck in CREATED stage. Bug: 989526 Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809777}
-
Alex Turner authored
Registers binders to allow UkmRecorderInterface to be used in worker contexts. As these binders are not currently registered, calling WorkerGlobalScope::UkmRecorder() causes a renderer crash. This can occur when MediaSource::isTypeSupported() is called in a dedicated worker context (with experimental web features enabled). Bug: 1122971 Change-Id: If79cbd74cf7d88c66a9fc0eda820c60b682dc5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424504Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#809776}
-
Eric Seckler authored
|time_delta| can be a rather large microsecond value, multiplying with |process_cpu_time_delta| can cause uint64 overflow. Instead, compute a double factor from time_delta/total_delta first. Bug: 1129004 Change-Id: I8ff9fd6a03551d1bdde29d263f76b1f5857ed3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424192Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#809775}
-
Benoit Lize authored
This CL adds accounting for the thread cache, and surfaces the data in about:tracing when the thread cache is used for the FastMalloc() partition. The recorded data shows that for FastMalloc(), the current settings catch the vast majority of allocations, at a small memory cost, and that most allocations are on the main threads, as expected for FastMalloc(). Bug: 998048 Change-Id: Iaa55deb12f0c04dd7f301e15c7497b817f4843e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424309 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809774}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ie9ae99bb4a06167a424fd9bd79d26d30e6531b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422139 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809773}
-
Maksim Moskvitin authored
There might be no events triggerring lazy initialization of StandaloneTrustedVaultBackend while device registration needs to be completed. This CL removes lazy initialization logic and backend is now always initialized in client ctor. Bug: 1102340 Change-Id: I83a4e4d79bd7dc0f076d9795a814b514e143f99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424305 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809772}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6db3a24c19e7..75e5ed6161fc 2020-09-23 shaobo.yan@intel.com Support Noop Copy for B2T, T2B and T2T Copies 2020-09-23 cwallez@chromium.org Fix deprecation errors for indexFormat being set. 2020-09-23 cwallez@chromium.org Fix compilation on ChromeOS 2020-09-22 enga@chromium.org Pass the old/new VkImageLayouts to Vulkan image import/export 2020-09-22 brandon1.jones@intel.com Change wgpu::Color from floats to doubles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1c3b392c89abcb0e87dca1993cfc880db3a10223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425895Reviewed-by:
-
Harald Alvestrand authored
In certain cases involving stopped transceivers, a sender or receiver can be created with an already closed DTLSTransport, which will cause the state to be set to "closed" even when it is already closed. Allow this case. Bug: webrtc:11840 Change-Id: I21aad316f5cf74a6b4bf18ac87fcf460afc74531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424260Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#809770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aad83522fd17..80f8eba22fbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tschumann@google.com Change-Id: Ia07a96abff2785413e513577c6af5ca888387f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425897Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809769}
-
Brian Ho authored
Currently, enabling SkiaRenderer on Chrome OS causes the entire screen to flicker due to partial enablement of HW overlays [1]. To remedy these synchronization issues, we need to schedule the primary plane overlay with a valid fence. On Android, this is accomplished via platform-specific code that extracts a fence from a GLImage [2][3]. In this CL, we take a more robust approach by creating the fence on OverlayRepresentation read. The OutputPresenter can subsequently use this fence if it exists/ the SharedImage type supports it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2342262 [2] https://source.chromium.org/chromium/chromium/src/+/master:gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc;l=75;drc=23f61cb65a94208dc2c4728e895e87d47f64a8b6 [3] https://source.chromium.org/chromium/chromium/src/+/master:ui/gl/gl_surface_egl_surface_control.cc;l=323;drc=5c860faff8acca32094b87f229b630519326372e Bug: 1114290 Test: CrOS with SkiaRenderer doesn't flicker Change-Id: Ie429ef6dab66fce18d6b3f37133c4bb9ecf602cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404148Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#809768}
-
Mariam Ali authored
This CL capitalizes the letters for Guest and Incognito in the chip menu to follow the guide in go/chromewords. Screenshot: https://screenshot.googleplex.com/AcFJbt6g6skM2oY.png Bug: 1105763 Change-Id: I208f3b9f7ab9150b33d84d60b76342b1199a830c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421667 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#809767}
-
Avi Drissman authored
This shouldn't be necessary; when the last frame is deleted the observer should remove itself. However, for paranoia's sake, remove the observers as sessions are closed. Bug: 1123557 Change-Id: If0109eafee7fd2ba38480849b99ee42bbafe5b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424711 Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809766}
-
Christoph Schwering authored
The feature is not referenced in the code. Bug: 1007974 Change-Id: I21b990a88044af91bfb4da4abb47c26280ce01bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409942 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#809765}
-
Peter Boström authored
As BubbleDialogModelHost::Close() tear-down (removal of model_) is synchronous, but views isn't. We need to check and see if the model_ has been destroyed when checking for the initially-focused view. A TODO is left to see if we can prevent GetInitiallyFocusedView() from being called after Widget::Close() has been called. Bug: 1106422, 1130181 Change-Id: I8056c3dd242e9ec5ce8fc909a0f558dc7a264dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425363Reviewed-by:
-
David Jean authored
Removed orientation [uikit_]ui_util fncts that relied on [[UIApplication] sharedApp].keyWindow. Change-Id: I2936c5c1afd2c682fa967db896ba3b5161144be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424085 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809763}
-
Christoph Schwering authored
The feature is not referenced in the code. Bug: 1007974 Change-Id: Iadd81ab6d92f9b459ab9249d1d8cbbfec4327f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409699 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
