- 17 Oct, 2019 19 commits
-
-
Tommy Steimel authored
This CL makes GMC notifications clickable. When clicked, the tab that originated the media is focused. Bug: 1011052 Change-Id: I4f14cf8f5d19e12afbb5eaf11c1b8e7ac1a042c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862868 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706728}
-
Peter Kasting authored
Because the location bar used to be light even in dark windows, the find bar had a hack to use the non-incognito NativeTheme object. Now that the location bar is dark in incognito, this hack is incorrect. Remove it. This also means View::SetNativeTheme() is only called by test code, so this renames it accordingly so people don't add additional non-test uses. Bug: none Change-Id: Id0a3363c0d3457cdfdff5ab81bff9be7ce34f15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864515Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706727}
-
Mike Dougherty authored
BreadcrumbManagerObserver allows objects to listen for newly added events to BreadcrumbManager. Bug: 1003922 Change-Id: I4a493bb12aa50ff6c36f2965ac55600abbc9d711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864520 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706726}
-
Scott Violet authored
This is a stale dependency that isn't necessary anymore. BUG=none TEST=none Change-Id: I904c2854f6c9e06b32de243962541692a983fa41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864330Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706725}
-
dpapad authored
There is no clear benefit of using the file generated by polymer_modulizer() for type checking (for the case where html_type is 'v3-ready'). Moreover this causes the lines reported by Closure compiler to not correspond to the lines under src/. Bug: 965770 Change-Id: I56f7ed3dd18419ac549736aa2bfff863fc4c58d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865660Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706724}
-
Charles Zhao authored
Bug: 1012936 Change-Id: Iac49d866aa30160da097179506e0bc6bb1cae024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865910Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706723}
-
Linkun Chen authored
Bug: b/141204302 Bug: 1015146 Test: try on device Change-Id: Ieec8e915e27375e3cda3f9390eb762cda1e8735d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563645 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706722}
-
Jinsuk Kim authored
BottomSheet for gesture navigation should have the lifecycle as same as that of the tab it was brought up for. Bug: 1011073, 1009338 Change-Id: Ibf86a5710e9cef3a4d7bc513b89d331054228fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851889 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706721}
-
Johannes Henkel authored
This keeps pending messages in a list, and identifies waiting_for_response with a hash map. In this way we avoid reordering messages coming from the client. Previously, we ordered some messages coming from the client by their call_id, but this assumes that the client sends them in order of their call id, which isn't always true. Change-Id: Idd87e37fff64736117a9d0d780e7bf4f20e59974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863631 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706720}
-
Anand K. Mistry authored
DeleteEntry() was incorrectly ignoring the |recursive| argument and always doing a recursive delete. This can cause server-side data loss in certain rare situations. BUG=chromium:1013901 Change-Id: Ia8eda8798b3cefc66765855d6e01608c235ecc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864498Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#706719}
-
Kai Ninomiya authored
Change-Id: Icb87787c40cbc263addffcc63b9b9d09074bf504 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865675 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706718}
-
Thanh Nguyen authored
This CL adds a fuzzer for TokenizedString. Bug: 1014837 Change-Id: Ia36339e59adc386800b19dd3d2245dff9ce629f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864500Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706717}
-
Johannes Henkel authored
Change-Id: I5b5a3ee8905833e825e0a813fc34a6448f69c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865664Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706716}
-
John Delaney authored
This CL adds two regression metrics for the heavy ad intervention. The first is reload rate of pages with heavy ads. An increased reload rate with the intervention may indicate broken content. The second metrics records whether a heavy ad frame is removed by the page prior to page end. An increase in this number may indicate that pages are removing the error page frame and loading new ads into the slot. Both of these metrics are intended to be looked at in an a/b experiment. Bug: 1012882 Change-Id: Idd6a7ddce6d72130c9c5977765a0d5646a8ec4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850314 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706715}
-
Shakti Sahu authored
This CL removes the blue tint from the favicon and sets the default icon to default favicon instead of chrome logo. Bug: 1014348 Change-Id: Ida83b849ef2cac7861f56a6a68c39fea80a569b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861503 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#706714}
-
Carlos IL authored
Bug: 987294 Change-Id: I3b66e537e9edc5420a0b6d3d1a0664ee8cbfcd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846052Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#706713}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4283206673b9..81607380ef4e git log 4283206673b9..81607380ef4e --date=short --no-merges --format='%ad %ae %s' 2019-10-16 vapier@chromium.org cros_test_lib: make popen mock less annoying 2019-10-16 vapier@chromium.org cros_test_lib: fix VerifyTarball under python 3 2019-10-16 mmortensen@google.com Have determine_chrome_version use a build_target to match controller call. Created with: gclient setdep -r src/third_party/chromite@81607380ef4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia56851f4bbe13cd198808b8187ebc36ce6d4961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706712}
-
nancy authored
The ARC app uninstall dialog's layout is different with the extension/Web App/Chrome App uninstall dialog, so use different layout for the ARC app uninstall dialog. The icon for the ARC app is not the window icon, but used for ImageView. So update the ARC app uninstall dialog to keep the consistency with the current ARC app uninstall dialog. BUG=1009248 Change-Id: Ia624312b2b55dabfbbc43ea04aac0e35f8b44fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861794 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#706711}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e180b591d166..7f426898efe0 git log e180b591d166..7f426898efe0 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 enga@chromium.org Skip BufferUploadPerf 16MB SetSubData on all backends. 2019-10-16 senorblanco@chromium.org Fix missing #include. Created with: gclient setdep -r src/third_party/dawn@7f426898efe0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1014946 Change-Id: If256f71c495ce83468f3f119792ecd938ca5239f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706710}
-
- 16 Oct, 2019 21 commits
-
-
Joe DeBlasio authored
This CL converts back to the small infobar layout for Safety Tips and updates the icon to the 'info shield'. This helps mitigate small screens cutting off infobar titles by using the smaller-fonted layout. It now looks like this: https://drive.google.com/open?id=14-kCTwgzlkjjhVzVmX4hY-6YnJfynzar Bug: 1008562 Change-Id: I1dd2809f36aea74b5d154bffa53cd601d45053fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864289 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36446f281ca2..1dfc77cc08ee git log 36446f281ca2..1dfc77cc08ee --date=short --no-merges --format='%ad %ae %s' 2019-10-16 robertphillips@google.com Add unit test to exercise GrTextureFreed message handling after a context abandon 2019-10-16 herb@google.com Introduce SkGlyphSourceBuffer 2019-10-16 robertphillips@google.com Work around un-safe downcast in PromiseLazyInstantiateCallback destructor after a context abandon 2019-10-16 mtklein@google.com remove ternary min/max 2019-10-16 halcanary@google.com CanvasKit: Switch to WebGL 2.0 2019-10-16 brianosman@google.com Starting to hack up HDR transfer function support 2019-10-16 mtklein@google.com add used_in_loop bit to skvm::Builder::Instruction 2019-10-16 halcanary@google.com [minor] SkGlyphRunList public before private 2019-10-16 mtklein@google.com Reland "mark which SkVM tests should JIT or not" 2019-10-16 mtklein@google.com Revert "mark which SkVM tests should JIT or not" 2019-10-16 nifong@google.com Enable SKSL in skia_nanobench, enforce resources being present. 2019-10-16 egdaniel@google.com Switch GrFillInData to use GrColorType instead of GrPixelConfig. 2019-10-16 mtklein@google.com mark which SkVM tests should JIT or not 2019-10-16 mtklein@google.com add a TODO about lifetimes and hoisting 2019-10-16 brianosman@google.com Interpreter: Reflect all uniform variables in ByteCode Created with: gclient setdep -r src/third_party/skia@1dfc77cc08ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:1011368,chromium:1014993,chromium:1011368,chromium:1014993,chromium:960620,chromium:b/141263986 b/141871494 Change-Id: Ief4993c9d41055916d9bb5057e36c55bfaaaa9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706708}
-
Clark DuVall authored
These were broken from http://crrev.com/c/1854204 Change-Id: I566c48d4f3c03708d56280804e750563189257d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864517 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706707}
-
Gary Kacmarcik authored
Bug: 1015201 Change-Id: Ie5e1751391f6cd265b3012457ae266d7afecf3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866009 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706706}
-
Mei Liang authored
This CL sets the Tab-to-Grid animation background color to be the same as the tab switcher background color. Change-Id: I7dc736dfa6dcdeda5a0a6f9dc4f49917b2cb9188 Bug: 1013001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854167Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706705}
-
Jacob DeWitt authored
The immersive version of this test consistently passes, but the inline version consistently times out on some bots, especially mac ones. Split the test into separate files for the two session types so that we can run the more important immersive test while we try to fix the inline test (which is lower-priority). Bug: 1013444 Change-Id: Ia0f021c8d1d482385218c4dfd66ee3d8cbc94c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865677Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#706704}
-
Sajjad Mirza authored
Add Windows support into the wrapper and have the toolchain invoke it when use_clang_coverage = true. Also clean-up the code for the default exclusion list. Bug: 989828 Change-Id: Ie4e40721e7b007831c299978b37315dad1c521c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863328 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706703}
-
Nico Weber authored
GOOGLE_CHROME_BUILD is more a branding thing. Since COM_INIT_CHECK_HOOK_ENABLED is also gated on OFFICIAL_BUILD (which is more an optimization thing), this doesn't have an effect on production Chrome. Branded builds without official build optimizations will get the com init check hook after this CL, but likely very few people build in that configuration, and it shouldn't matter much for them. Bug: 961769 Change-Id: Ib7dd98843c33c6571b53cd0007d260af422e0976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864718 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706702}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/abb67699b6e2..780eaa6043f2 $ git log abb67699b..780eaa604 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 fkastenholz Change "&SomeQuicStringPiece[1]" to "SomeQuicStringPiece.data()+1" 2019-10-16 rch gfe-relnote: Use QPACK Dynamic Table in the toy client and server, but not in the test client and server. Protected by disabled --v99 flag. 2019-10-16 fayang gfe-relnote: n/a (flag counts) 2019-10-15 nharper Add newlines to quic_client_interop_test output 2019-10-15 dschinazi Fix auto-setting IETF stream flow control limits 2019-10-15 renjietang Change max_push_id related version guard to VersionUsesHttp3. 2019-10-15 rch Change QuicSpdySession::SendMaxPushId() to use max_allowed_push_id_ instead of requiring the caller to pass it in explicitly. 2019-10-15 rch Make the toy QUIC server send responses of arbitrary length based a number specified in the path. 2019-10-15 bnc Signal error if Insert Count Increment causes overflow. 2019-10-15 dschinazi Add rebinding support to quic_client_interop Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I67ee10f329b012d9d2e4c08d1420dac7baaad90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865349 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706701}
-
Brian Sheedy authored
Enables the AR tests on Nougat, as AR support was recently added to N in crrev.com/c/1854802. Bug: 1012972 Change-Id: Ie9c309a34fc78e930e6317a268cc1906ea90f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863954Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706700}
-
Brian Sheedy authored
Switches uses of PrintResult in the WebRTC browser perf tests to PerfResultReporter and whitelists browser_tests for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I7ff090bcdeaf3906491b85993456f07313cd4a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856825Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706699}
-
Alexey Baskakov authored
Decouple icons pixel data from WebApplicationInfo metadata. The Update and Sync-Initiated installs will use it to override icon pixel data. See next CL: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 Bug: 860583 Change-Id: Ief987de76bfd1389835c1318e57fb7d79ac4728d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861443 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#706698}
-
Alan Cutter authored
This CL updates the web app sync behaviour to ignore sync changes to web app manifest fields. This is in preparation for automatic local manifest updating which may set device specific values so we must not sync these changes to avoid creating sync wars. See: https://chromium-review.googlesource.com/c/chromium/src/+/1811402 The existing implementation (check name & description) is from the initial implementation of bookmark app sync: https://chromium.googlesource.com/chromium/src/+/d93fcd51386a104ce54d9577ae0df8957d310c89 The fact that it doesn't sync for any of the other fields is likely an oversight when those fields were added. In the near future these synced fields will be used as fallback values for the first sync install on a device, see: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 After the initial sync install these fields are no longer useful to us as we will attempt to match the live site manifest rather than other devices. Bug: 926083 Change-Id: I146b3f4f1ddcd58b4766f69a12c3c0a61e6f495f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737818Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706697}
-
David Tseng authored
Change-Id: I42bf3c7b46578b2694a15af9e3aafc9a0c232484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864379Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706696}
-
gogerald authored
This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1824126/4 It is the fifth patch of splitting the bigger one https://chromium-review.googlesource.com/c/chromium/src/+/1797069 It also splits out FakeboxDelegate for future refactors. Screenshots: https://drive.google.com/file/d/1RuLYCqP-PDR_czA-Q-csK0c9yd-tGJNZ/view?usp=sharing https://drive.google.com/file/d/1oN3JWCRKE1UH2rypQYvQwTFPgJY1JdE5/view?usp=sharing Bug: 982018, 1013693 Change-Id: I3cee0015c72c0b3fdbaf8db91dcf1da549ee89cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825165 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706695}
-
Ken Rockot authored
This is an implementation of the Service Manager's Connector mojom interface which can be used in isolation without any dependency on an actual Service Manager instance. It serves as a transitional helper for code to migrate away from Service Manager APIs incrementally. Bug: 977637 Change-Id: I98e7edabfe36f98f0d9e817e3b8d8c4de23cb67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854210Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706694}
-
Peter Kasting authored
Bug: 918220 Change-Id: I59de7158479d82f4775638b3e31645f18b818759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865656 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706693}
-
Tommy Steimel authored
This CL changes the GMC dismiss button to show whenever the media notification is hovered or focused instead of whenever the media is paused. This means that users can dismiss while media is playing, which will stop playback. Bug: 1008907 Change-Id: I5342a4e1e7238a16203687e57dfe6608b2ab35be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859584Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706692}
-
Ken Rockot authored
This behavior was unintentionally broken by https://crrev.com/91216c0f Bug: 1014220 Change-Id: Ibf2e961c4d98987fc24b6e028b81f8ac89b4fe94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860477Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706691}
-
zhaoyangli authored
The file and class don't follow current convention. Remove the class and it's use case from codebase. Bug: 1002989 Change-Id: I0896cb1a010d19e24d5157cc5275f10e167c7a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865428Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706690}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e096591e. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I2df8cbb5beeb4841b3f0e3f2aa529d9f4bf199da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864243Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706689}
-