- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71b438c741141bb240587a2eff5f1d696144d857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792686}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34efe0da102..8c7ecc1c06f4 2020-07-29 reed@google.com Revert "Revert "Never share pixels when we make a subset image"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8f54932ae7aaabff8d63814a7f6ffd3f0de99bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325976Reviewed-by:
-
Sreeja Kamishetty authored
Instead of clearing the user data on renderer crash, this CL clears the data only after starting next navigation when the RenderFrame goes to created state. Bug: 1099237 Change-Id: I3816d5c32ea36b4f651430076a262ae9b71b84bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292492 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792684}
-
Alex Ilin authored
Upcoming updates to the multi-profile experience make the "main" color of the profile more prominent on several surfaces. One of these surfaces is the profile picker window which should have access to colors attributed to unloaded profiles. Currently, the profile theme info is stored in profile preferences which are read from the disk when a profile is loaded. This CL caches required colors in ProfileAttributesStorage. Data from ProfileAttributesStorage can be accessed without having to actually load a profile from disk. The colors are updated every time the profile's theme changes. This is implemented by listening for the chrome::NOTIFICATION_BROWSER_THEME_CHANGED notification in ProfileThemeUpdateService. Bug: 1102384 Change-Id: I4683ded5d7182117dd2a712437f64f1f00ceed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317796 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792683}
-
Mikel Astiz authored
Instead of manually creating keyed services using deprecated TestingProfile APIs, it's more appropriate to access a keyed service that is not null in tests. Change-Id: I49ecd1425a3bc2f4aa533c52aa3530da568a5bd8 Bug: 789214,1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325919Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792682}
-
Victor Hugo Vianna Silva authored
This CL fixes the linked bug by ensuring the plaintext password property in ShowPasswordBehavior is reset when the element is pointed to another credential, i.e. when "entry" is changed. The result is that removing a credential, or doing a search filter will hide any plaintext passwords being shown. Before what happened was: - Deleting a pwd would update the savedPasswords array in MergePasswordsStoreCopiesBehavior. - The backing array of the iron-list of pwds in PasswordsSection would be updated. - The "entry" properties of the PasswordListItem in the iron-list would be updated *but* the "password" properties wouldn't be updated. Contrary to what one may believe, removing an element from the backing array of an iron-list doesn't actually remove the corresponding element from the DOM. The CL also makes the visibility state of the password in the edit dialog not be synced with the corresponding row in the pwd list anymore. Bug: 1110290 Change-Id: Ibb5d10999b4c966fcf382f5a18e76ce462090188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325731 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792681}
-
Matt Jones authored
This patch replaces the obsolete ScrimView widget with the new scrim component in the autofill assistant. Some of the tests that included waiting for elements to be removed from the test web page have been updated to use criteria helpers, making them a bit less flaky. This patch also includes a change to how the touch delegate is attached to the scrim: it is now only attached if a delegate is set as it would otherwise interfere with the gesture detector. Bug: 1062099 Change-Id: I79547256efa62eef7bc1d86090942a8471a60285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308454 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#792680}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596002257-98af7ef1af792787ca531e13e152ea25d40693fb.profdata to chrome-mac-master-1596023419-4b4a08e94302fde0805a3dccb841fbad1e992234.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibe64428b888271632ed25175549a849faaf7827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325978Reviewed-by:
-
Rainhard Findling authored
* Adds the reboot functionality to the reboot button of the safety check Chrome cleaner child. This allows users to directly reboot their machines from safety check, instead of being forwarded to the Chrome cleaner UI first. Bug: 1087263 Change-Id: Ie10ab48cd6452fb23e737de3d8a01c3be0edff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299742 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792678}
-
Joel Hockey authored
Bug: 1109941 Change-Id: If9c7cf3656685f0339338a78afee7dbc07e16cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325432 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792677}
-
arthursonzogni authored
Display a console error whenever the COOP header is ignored by chrome due to the origin being untrustworthy. This will help developers understand why their Cross-Origin-Opener-Policy isn't effective. Bug: chromium:1110821,chromium:1059303 Change-Id: I1965391da92154376d0e2a9699a697091389b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325917Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792676}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fbf20a6507ed..d8380b6383dc 2020-07-29 janscheffler@chromium.org Migrate `front_end/settings` to `devtools_entrypoint` 2020-07-29 jacktfranklin@chromium.org Reland "Migrate `front_end/toolbox_bootstrap` to `devtools_entrypoint`" 2020-07-29 szuend@chromium.org [cleanup] Fix imports for 'bindings' and 'common' unit tests 2020-07-29 sigurds@chromium.org Invalidate console viewport once new issue is detected If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1110102 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6ede338d47c76080d123c5b4aedb1cdda3500ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325971Reviewed-by:
-
Roman Sorokin authored
This CL modifies code in a way that GaiaScreenHandler is owned and handled by GaiaScreen. TBR=alemate@chromium.org Bug: 1079199 Change-Id: Idea2f8b9a2974007286e9e8562d1bcee0f2df423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279800 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#792674}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6aaf3124709d62805436b15471ee16a79f1aaa6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324679Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792673}
-
Sebastien Lalancette authored
Added a new Delete action to History entries' context menus. Selecting that action will delete the focused entry. Regarding the business logic of the action (deleting the entry), this CL reuses the existing delete logic used by entries' accessibility actions. Bug: 1093302 Change-Id: Id1a21fe441ee922d63e10107e9bdbaadadc7be75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308849Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#792672}
-
arthursonzogni authored
There are 3 function to get a DomWindow from an isolate: - LocalDOMWindow* EnteredDOMWindow(v8::Isolate*); - LocalDOMWindow* IncumbentDOMWindow(v8::Isolate*); - LocalDOMWindow* CurrentDOMWindow(v8::Isolate*); The difference is explained by: third_party/blink/renderer/bindings/core/v8/V8BindingDesign.md For same-origin accesses to a window's method, the wrong V8 context was used. Instead of being the "calling" context, it was the "called" context. Using IncumbentDomWindow instead of CurrentDOMWindow fixed the issue. See response from: https://bugs.chromium.org/p/chromium/issues/detail?id=1109153#c2 COOP access reporting: [ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530 [10/N] https://chromium-review.googlesource.com/c/chromium/src/+/2315024 [11/N] this patch. Bug: 1090273 Change-Id: I3da021c33af25831a242f64ff732556aa6775a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323250Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
David Roger authored
This CL passes the profile color and the text color from native (C++) to WebUI. The text color is computed to have good contrast with the background. Light color and light mode: https://drive.google.com/file/d/1A1tdffEMp2I0zwk2fofD59_GCSY59s67/view?usp=sharing Light color and dark mode: https://drive.google.com/file/d/1FCTLApc_z5JT1tSC2yzKilSBZyzIUpbP/view?usp=sharing Dark color and light mode: https://drive.google.com/file/d/1HeH2iFhUdRMXFX6yUJOcHX68u5JfGmpF/view?usp=sharing Dark color and dark mode: https://drive.google.com/file/d/1ZYHFAcHIsU1Qa96aMsT0nalZR3an9Yjm/view?usp=sharing Bug: 1076880 Change-Id: I4ee51b8f1d178e57d3e6375b75affa72ae8e5582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324422 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#792670}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0320db93. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I28b101bf67dbaacf026407ef0ee23fc07549caf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324323Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792669}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8af6641ce8e..14ca9390e34a 2020-07-29 dberris@chromium.org Revert "auto-triage: Revision range url support non-chromium revision" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I987e4fa0e2243998b9eedc32cb1af7e45101fa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325903Reviewed-by:
-
Oleg Davydov authored
This commit moves expire date of the following histograms: * Extensions.ExtensionCacheCount * Extensions.ExtensionCacheSize Also ownership of these histograms is now in sync with other histograms related to policy-based extensions. This makes sense since cache is used on Chrome OS for them. Bug: 975705, 984259 Change-Id: Ie8d364df4cefeeb5d16ca1d7ef872c8cc7a8dcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260640 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#792667}
-
Oleh Lamzin authored
Use closure compiler for browser tests. Fix compilation error for MessagePipe.sendMessage since it expect object or undefined. Bug: b:158566609 Change-Id: I0c3cc042d9fbfd6da801d67ac8d6f27b37ffaa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320593 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#792666}
-
Gauthier Ambard authored
Fixed: 1106735 Change-Id: Ib40832dff0096b0c01788a9209b3bc45f440e8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317950Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4866d0ad5f3c..c34efe0da102 2020-07-29 thestig@chromium.org Fix use of undefined TARGET_OS_SIMULATOR for Non-Metal builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3592e18d1a0f82e1358acad7eecc3c073c0adcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325896Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bf57c8f..3bb07848 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I618efa9bf562701eb428357f80491599d59e6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324508Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792663}
-
David Tseng authored
The change https://chromium-review.googlesource.com/c/chromium/src/+/1980612 explicitly unloads various component extensions deemed to be risky. Unfortunately, the hash for ChromeVox (which was supposed to not be risky) was *wrong*, so it was being unloaded mysteriously. Test: obtain the hash for ChromeVox (extension id mdn....), via logging and print the hex hash. Verify after correcting the hash in profile_helper.cc, on-device, doing things like clicking the "Add Person" button doesn't unloads ChromeVox. Fixed: 1094031 Issue details: On the login screen, invoke the "Add Person" button. result: ChromeVox is unloaded i.e. #2 0x57e72acd8634 content::RenderFrameHostImpl::~RenderFrameHostImpl() #3 0x57e72acd8520 content::RenderFrameHostImpl::~RenderFrameHostImpl() #4 0x57e72b0bb120 content::RenderFrameHostManager::~RenderFrameHostManager() #5 0x57e72acd2449 content::FrameTreeNode::~FrameTreeNode() #6 0x57e72bffe68d content::FrameTree::~FrameTree() #7 0x57e72c20defa content::WebContentsImpl::~WebContentsImpl() #8 0x57e72c20e928 content::WebContentsImpl::~WebContentsImpl() #9 0x57e72c3d2490 extensions::ExtensionHost::~ExtensionHost() #10 0x57e72c3d253c extensions::ExtensionHost::~ExtensionHost() #11 0x57e72c40f857 extensions::ProcessManager::CloseBackgroundHost() #12 0x57e72c40fabe extensions::ProcessManager::OnExtensionUnloaded() #13 0x57e72c3ea211 extensions::ExtensionRegistry::TriggerOnUnloaded() #14 0x57e72c3e8f3a extensions::ExtensionRegistrar::DeactivateExtension() #15 0x57e72c3e8be7 extensions::ExtensionRegistrar::RemoveExtension() #16 0x57e72f781d0b extensions::ExtensionService::RemoveComponentExtension() #17 0x57e72f761c47 extensions::ComponentLoader::Remove() #18 0x57e72cb46908 chromeos::ProfileHelperImpl::ClearSigninProfile() #19 0x57e7304c57c1 chromeos::GaiaScreenHandler::StartClearingCookies() #20 0x57e7304c58dc chromeos::GaiaScreenHandler::ShowGaiaAsync() #21 0x57e72ca0362b chromeos::LoginDisplayHostCommon::ShowGaiaDialogCommon() #22 0x57e72ca04686 chromeos::LoginDisplayHostMojo::ShowGaiaDialog() #23 0x57e72fbfd2ef ash::LoginShelfView::ButtonPressed() #24 0x57e72f27480c views::ButtonController::OnKeyPressed() #25 0x57e72f2c2624 views::View::OnKeyEvent() #26 0x57e72f266a3b ui::ScopedTargetHandler::OnEvent() #27 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #28 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #29 0x57e72e80fd89 ui::EventSource::SendEventToSinkFromRewriter() #30 0x57e72f2cf9e0 views::Widget::OnKeyEvent() #31 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #32 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #33 0x57e72ebb9387 aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x57e72e8381c3 ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x57e72e85f4fd ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent() #36 0x57e72e85f24c ui::InputMethodChromeOS::DispatchKeyEvent() #37 0x57e72ebb217f aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x57e72ebb1a28 aura::WindowEventDispatcher::PreDispatchEvent() #39 0x57e72e80eedd ui::EventDispatcherDelegate::DispatchEvent() #40 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #41 0x57e72e80fece ui::EventSource::EventRewriterContinuationImpl::SendEvent() #42 0x57e72c649a27 ui::EventRewriterChromeOS::RewriteKeyEventInContext() #43 0x57e72c6492fe ui::EventRewriterChromeOS::RewriteEvent() #44 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #45 0x57e72fb88588 ash::KeyboardDrivenEventRewriter::RewriteEvent() #46 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #47 0x57e72fb88e9b ash::SpokenFeedbackEventRewriter::RewriteEvent() #48 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #49 0x57e72fbec429 ash::TouchExplorationController::RewriteEvent() #50 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #51 0x57e72fb5e078 ash::AutoclickDragEventRewriter::RewriteEvent() #52 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #53 0x57e72fbdf76b ash::MagnificationController::RewriteEvent() #54 0x57e72e80fd68 ui::EventSource::SendEventToSinkFromRewriter() #55 0x57e72fb9bb93 aura::WindowTreeHostPlatform::DispatchEvent() #56 0x57e72fb9d8dc ash::AshWindowTreeHostPlatform::DispatchEvent() Change-Id: Ibead7896cecddcb3da8bb4a553137f65700248f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324108Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792662}
-
Yutaka Hirano authored
v8::Promise::Resolve can run user code synchronously, which caused a UAF in ScriptPromiseProperty. Fix it. Bug: 1108518 Change-Id: Ia9baec6eef0887323cd88ceb1d3fa0c14fdb77ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325499Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/499d49011a1d..501bbf2a9325 2020-07-29 fmayer@google.com Merge "Add --all-heaps to heap_profile script." 2020-07-29 fmayer@google.com Merge "Allow to target all heaps." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1f852b81d468cc696c3e5957486fa153bd10eea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325895Reviewed-by:
-
Marc Treib authored
This CL parameterizes CredentialsFilterTest so that all the tests runs with features::kEnablePasswordsAccountStorage both enabled and disabled. (So far, CredentialsFilter doesn't actually depend on this feature, but it soon will, see linked bug.) Bug: 1105846 Change-Id: I389e80a0880df188c72bfb16056d04e90c029455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324844Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792659}
-
Nohemi Fernandez authored
Several matchers that are used only within sign-in internal code have been exposed in public APIs. This causes confusion for developers on which is the correct API to use resulting in inconsistent code. Simplify the options by offering a more limited API. Bug: 1103274 Change-Id: I0c476962dd216a0ef79e1c7a17008fbcbf5deeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324424Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/125702be66eb..fbf20a6507ed 2020-07-29 nidhijaju@google.com Removing "other origins" UI from DevTools Service Worker tab 2020-07-29 jacktfranklin@chromium.org Fix invisible border on computed styles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:807440 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia174692cf17ffa81d8383080ebb9d1acd893ab99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325901Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I74437d49622940df951e2f817a82f7274a383b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324676Reviewed-by:
-
Roman Sorokin authored
This CL fixes the issue when one invalid "password changed" token triggers online reauth two times - on the login screen and in the session. Check in the session happens before the new token is backfilled with the online login triggered on the login screen. So this CL adds backoff time between two consecutive checks. Also moved more relative logic into TokenHandleUtil. Fixed: 1094030 Change-Id: Ica0a9c547f14e8f0bc743fdab87fff7bf49c56c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300441 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
RegisterClient and UnregisterClient methods will be invoked in different threads at the same time. This causes ASAN crashes. Bug: 1092385 Change-Id: I67ed7fd1925bde72770c8c5b4f737258e9564de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324689 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792654}
-
Benoit Lize authored
This CL has two purposes: - Cleaner separation between the "allocate memory" and the "cookies/tag" parts of the allocator. - Move as much code as possible outside of the spinlock-protected area. The first one is useful to make code clearer, but also to ease experimentation with a thread cache, as it doesn't need to know about tags with this breakdown. The second one improves concurrency, as for instance the zeroing of potentially large allocations (up to 1MiB) doesn't need to be protected by the spinlock. There is a side-effect though: The tag update is no longer protected by the lock. This is not an issue, as tags do not need to be unique globally (they won't anyway, due to the limited tag space). Bug: 998048 Change-Id: I301b1bc1946f01bfcea490e478fbf2bc8383aed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310410 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Vikas Soni authored
Remove |copy_required| and replace it with an enum |copy_mode|. This is done since in future texture copy will not be always required for webview and hence |copy_required| will not always be true. When AImageReader is enabled, texture copy can be skipped and resource sharing across different context can be achieved via AHardwareBuffer. TBR=dcheng@chromium.org Bug: 1091945 Change-Id: Ie482546cc2f28128b487a55205a3c7411bc2a86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306670 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792652}
-
Mugdha Lakhani authored
This splits part of chrome_render_frame.mojom into render_frame_prerender_messages.mojom and creates a class PrerenderRenderFrameObserver to handle the StartPrerendering mojom message. The motivation is to remove chrome deps from PrerenderContents so it can be componentized. Bug: 1096088 Change-Id: I60146c2af867e7b57de392c97e010dc481338d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324842 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#792651}
-
Henrik Boström authored
This allows us to run more tests than if we mark a single file as timing out. Important to ensure we don't cause regressions when rolling https://webrtc-review.googlesource.com/c/src/+/180481 into chromium. # TBR since I am just moving things around and want to unblock a reland TBR=hta@chromium.org Bug: chromium:1110833, chromium:1071733 Change-Id: Ib9f9cefe3fd89d764495a41a66422f191761df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324251Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792650}
-
Alexander Alekseev authored
DC layers are Windows-only and not useful for Ash. Bug: 1075612 Change-Id: If88a257a6cd2c889ba36914dbbfa290fc7511f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321773Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#792649}
-
dizg authored
Screenshot: https://drive.google.com/file/d/1z0MLt2zTldb5ZQIzoUc06XTQjS5ID5kx/view?usp=sharing Bug: 1105865 Change-Id: Ifccc725b28a2cc1e3d13532e61730633e0c0981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320673Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b237356836f2..a8af6641ce8e 2020-07-29 fancl@chromium.org auto-triage: Revision range url support non-chromium revision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: eseckler@google.com Change-Id: I7c2c22f4193aebc840deb994e0c7574a3d48c162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325891Reviewed-by:
-
