- 28 Feb, 2020 40 commits
-
-
Stephen Chenney authored
The Paint Holding feature revealed that a lot of time is spent committing main thread document update output to the compositor impl thread. Unfortunately, we have no breakdown of the ProxyCommit metric into the time waiting for the compositor thread to begin processing the commit, and the actual commit processing time. This change records the compositor commit start time and passes it back to the layer tree host to then feed back to the local frame UKM recorder. UMA is also updated to record the separate wait and commit times. Bug: 1031702 Change-Id: Ic083a94aa267b4332e402464c2a8b9b00d75aade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076179 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745515}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 1026641 Change-Id: I6fd3ee2edef8a427eb43444f643b750693e58b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079081 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#745514}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 1026641 Change-Id: Ic1a1d402ae94bee668ddb7f449b0a57f1004f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079075 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745513}
-
Aaron Gable authored
I mistakenly thought that the "ci" acl_set granted this triggerer permission. It doesn't, so the triggerer permission has to be granted separately. Bug: 1057074 No-Try: True Change-Id: Ie9fb7270ff76eda2ee4b946bd1f79e94fd4f0178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080196 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#745512}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bde9fcce155f..55f681faf391 git log bde9fcce155f..55f681faf391 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 robertphillips@google.com Splitup GrSimpleMeshDrawOpHelper.h 2020-02-28 jvanverth@google.com Initialize D3D format table. Created with: gclient setdep -r src/third_party/skia@55f681faf391 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I6d00c772bdc7100e7d1f281e681aeb1c0a4a6199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745511}
-
behdad authored
blink_gc is also added to the reruns of representative performance tests. New categories were added earlier in: https://chromium-review.googlesource.com/c/chromium/src/+/2071905 Bug: chromium:1055893 Change-Id: I8553fdb3aa3b6a56fe58f61bf5f561db966067e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078835 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#745510}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1026641 Change-Id: I6c19f61e4bd125aab58741e0d4a98f8411f9cf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078428 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745509}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4eca785b40e3..96c6bce9e4f3 git log 4eca785b40e3..96c6bce9e4f3 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 szuend@chromium.org [utilities] Remove Array#select 2020-02-28 mathias@chromium.org Enable no-else-return lint rule with autofix Created with: gclient setdep -r src/third_party/devtools-frontend/src@96c6bce9e4f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549,chromium:1057042 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I862a67b16b0f7e7d04038c2abadb0c34a18d48d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080309Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 1026641 Change-Id: I6ea3c67e54a44bae1414f39ce1fb343cfb3a2c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079073 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745507}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 1026641 Change-Id: I8d1d6f3c2d6da8d599078e727b0c27587f664017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078661 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#745506}
-
Dan Harrington authored
The annotation was changed, but the XML file wasn't updated to correspond. See bug. TBR=msramek@chromium.org Bug: 1057089 Change-Id: Idaec65e76aa95741c45874131c6ca92d52ff37a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080456Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#745505}
-
Gabriel Charette authored
Migrate off base::ThreadPool()-as-a-trait in /chrome/browser/media/webrtc/webrtc_event_log_manager.cc This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 1026641 Change-Id: I1a06918db9cf2e701dfd03e9d6455eecdfdb0d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079085 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745504}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=steimel@chromium.org Bug: 1026641 Change-Id: I86672714403013e0c9cd53df3b9919b497e72552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078423 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745503}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=asvitkine@chromium.org Bug: 1026641 Change-Id: I4ec15c2ebfc60e84bc8d8e2d7bdf6dc9f0f783b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079079Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745502}
-
Geoff Lang authored
TBR=zmo@chromium.org BUG=1056984 BUG=1030835 Change-Id: I491b8c1d38f9637d37a92cb6d4b84e7ff2a5d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079463Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745501}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e5fe285a7ef..416d37452275 git log 3e5fe285a7ef..416d37452275 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 jmadill@chromium.org PipelineCache: Handle nullptr mismatch of specialization info. 2020-02-28 sugoi@google.com Implement ASTC support Created with: gclient setdep -r src/third_party/swiftshader@416d37452275 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I365e26cfa261fbdb6f6ec34a9e7d2f982488785d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080452Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1026641 Change-Id: I781bcf648308b5583f5d85308ee0383b7f69be02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078420 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745499}
-
Aaron Leventhal authored
When objects are only programmatically scrollable, e.g. overflow:hidden, as opposed to overflow:auto|scroll, do not mark them as scrollable. Bug: 1055344 Change-Id: Ib5ade11a7a92720d6571acf6d65112696f2a2535 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070232Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#745498}
-
Toni Barzic authored
Updates how animating shelf background's drag handle layer bounds are calculated. Instead of directly using bounds from that the drag handle view has within the opaque shelf widget, calculate the animating drag handle bounds directly by centering the drag handle within the animating background bounds. Opaque background bounds are calculated based on the shelf widget size, which may differ from the animating (in-app) shelf size (e.g. on home screen). Using the opaque background drag handle bounds for animating background would displace the drag handle when that is the case. Change-Id: I51cb9a4d031286329784162193627bb09c608043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079839Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745497}
-
Ahmed Fakhry authored
This CL implements a new responsive layout for the desks bar in overview, which makes its height a function of the display height rather than constant (when the layout is not compact). This will be very useful for large screens, as well as in portrait mode (since will have more room for desks' editable names). Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1042981#c4 BUG=1042981 TEST=Manually. Change-Id: I7335766d699f081a62819bd77daa9c0a9e6021eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076786Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745496}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I21dc10859842208b355245137ba5d141e52c9b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080415Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745495}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I4293b7f09d887a68911bfbf1c4e26cdf82c55304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080248Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745494}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 1026641 Change-Id: I17edfca297131ab8f59d9f9391a401ec11b30ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079077 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745493}
-
Lei Zhang authored
The histogram data has been steady over time, so there is no new insight from collecting new data. Bug: 1037199 Change-Id: Ib429623bcc75a807e0fe7107b0f507d49b29c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076848Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Chris Lu authored
Fixed: 1056251 Change-Id: I531de3583a0877e1925f1a8c322c11610f3b4416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078842Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#745491}
-
Changwan Ryu authored
Extend the StartupTimeActivity to handle different intent options to measure different startup scenarios. Bug: 1055970 Change-Id: Ib0616ee40cc4d2833ab69f994faedf9abf6345c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068646Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745490}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=mark@chromium.org Bug: 1026641 Change-Id: I38da1f6c3416d9f3539129fcb0977d3edc5980e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079151 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#745489}
-
Maks Orlovich authored
This previously inherited settings from the base profile even if they were configured not to, which e.g. made client hints in incognito be improperly influenced by the normal profile state, as noticed by Aaron Tagliaboschi (and originally started to fix in a different way in https://chromium-review.googlesource.com/c/chromium/src/+/2034051) This also appeared to cause some weirdness with important site computation (bug 993021) and with some device permissions. Bug: 1052406, 993021 Change-Id: Ieeaaf0d508161568455ed077be820fd03831afdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047446 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#745488}
-
Henrique Nakashima authored
Use the generic way of checking if a feature flag is enabled in CachedFeatureFlags. There is a slight functional change: if the value is queried before native is loaded, and then a different value is cached when native is loaded, a second query will now give the same result returned in the first. Bug: 1012975 Change-Id: I314455b927d5f4a46aeb13de922682cc600e7056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079532Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745487}
-
Koji Ishii authored
This patch fixes painting floats in self-painting inline. To support this, this changes |PaintFloatingItems| to use |NGInlineCursor| to traverse descendants. Bug: 982194 Change-Id: I234ec7f32f895add62fe782aef133705fa7a7e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078379 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745486}
-
Jan Wilken Dörrie authored
This change generalizes the SortKeyIdGenerator to take arbitrary types as keys, and allows customization of the id type and key comparator. This will be useful when we need to generate ids for compromised credentials as well. To make the name more generic the class is renamed to IdGenerator. TBR=schwering@google.com Bug: 1047726 Change-Id: I1b9e25aa4ccd0a732c810bde20163d46d5a46d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080430Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745485}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1026641 Change-Id: I165a26f5d13f84d1f7ef03228e5faa34fe7c9a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078660 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745484}
-
Chris Harrelson authored
Bug: 1045421 Change-Id: Ic152bb2d1c88e34e3de012b4da9164ca1ff822ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079304 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745483}
-
Manu Cornet authored
Change-Id: Icab080ad2cffd4b0e46c4075c2bb0c23beca9e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079254Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#745482}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=poromov@chromium.org Bug: 1026641 Change-Id: Ie31be4a6fa7de7ffb33681dee388fde3bb97a911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078663 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#745481}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=ganesh@chromium.org Bug: 1026641 Change-Id: If0f5732e700bbf9cc8631d53913d3049bec345f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078424 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#745480}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=proberge@chromium.org Bug: 1026641 Change-Id: I16138ae911bc05fa34eec4bed07eef11eb1ee74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078427 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#745479}
-
Olivier Robin authored
hang-report field was done asynchronously and too late to be consistently present in the crash reports. It seems that the flag was only present in case of a second freeze. Set the flag synchronously before generating the crash report. Bug: 1056178 Change-Id: Ia7958c61a01dd9ffa592f3ba6b86481b50e8c89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074220Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745478}
-
Thomas Lukaszewicz authored
Fixed a visual artifact on ToolbarButton where the insets of the border may not have updated correctly, depending on how the animation timing ended up resolving. This was caused by not recomputing the border when the height of the ToolbarButton changed, resulting in incorrect border insets. Bug: 1053917 Change-Id: Ia15ffaf7a5d08f75b4d88bc61deb7bcc3382df2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067384 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745477}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=zentaro@chromium.org Bug: 1026641 Change-Id: I020767964acaf25eb38bd90aac0352c8e835ee72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079078 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745476}
-
