GitLab

https://build.chromium.org/p/chromium.perf.fyi/builders/One%20Buildbot%20Step%20Test%20Builder
is failing because the isolate target isn't being built on Linux Builder.

Bug: 758630
Change-Id: I793fed5a265b21762ba0a0cb6a669a3ba79f7ef6
Reviewed-on: https://chromium-review.googlesource.com/683462Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504500}

BUG=756002

Change-Id: I1bed16c5636231f948e841ab704ae74935865128
Reviewed-on: https://chromium-review.googlesource.com/685794Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504499}

This CL is a CSS only change that aligns text labels in cr-link-row
elements to the start (rather than centering the text).

Bug: 768751
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6d95194f8b14bb4da559ab7f095b2efcc21af0b3
Reviewed-on: https://chromium-review.googlesource.com/685536Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504498}

Using wpt-import in Chromium 61373a39.
With Chromium commits locally applied on WPT:
5961265c "img-decodes: Rework image decodes to align with the reworded spec."


Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2453

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I85e25ffcddbf1628c5de8f5dfdf553b0461dd9dd
Reviewed-on: https://chromium-review.googlesource.com/685715
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504497}

Rewrite the IsOobeOptInActive() method since voice
interaction OptIn flow could be inside session and could be active in
existing user.

For example, user decline PlayStore terms and voice interaction value prop,
but press the voice interaction shortcut later (after logout and login again).
In that case, there will be two PlayStore OptIn dialog, both OOBE
version and default version.

Also rewrite the unittest for the method in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/676488

BUG=b/65493952

Change-Id: I6a25d5483014952c2d699c92ae68cbe4e4a03493
Reviewed-on: https://chromium-review.googlesource.com/660921
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504496}

This CL makes ServiceWorkerScriptURLLoader check the path restriction defined in
the Service Worker spec:
https://w3c.github.io/ServiceWorker/#service-worker-script-response

Bug: 748415
Change-Id: I651f83050752a869d0fe9cde1e415d02da70a2c1
Reviewed-on: https://chromium-review.googlesource.com/684104
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504495}

Enabled with Chrome Home flag:
+ Add space to match 72dp left padding for 'remove close tab' text
+ Change 'remove closed tab' text to 14sp Med google 500

Bug: 753473
Change-Id: Ie4352cd271a70126876aeb156e9d5840cb209d13
Reviewed-on: https://chromium-review.googlesource.com/685264Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504494}

Exposing //tools/v8_context_snapshot as a public dependency for the
"chrome" target does not do anything useful when one is building the
"chrome" target.

BUG=764327

Change-Id: Ia1b6bc6cf643a4981085cf58c72be7c1f3dd44b4
Reviewed-on: https://chromium-review.googlesource.com/683469Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504493}

Changes,
1. Don't handle the scroll gesture events in AppListButton::OnGestureEvent, let
   the ShelfView handle it instead.
2. Add a test for the swiping on applist button to open launcher.

Bug: 758071
Change-Id: I71557411e9de6cd21bdb76c52dfb545a1e621783
Reviewed-on: https://chromium-review.googlesource.com/685535
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504492}

With network servicification, the NetLog will eventually move out of
the browser process, but for now, I'm just removing all use of it
outside of URLRequestContext::net_log(), so that the in-process
NetworkService object can create, configure, and own it.

Bug: 767450
Change-Id: I9f8c1add2ae0fd55ec6a209fe3920412a0aac2a2
Reviewed-on: https://chromium-review.googlesource.com/677278
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504491}

This is a reland of e3f445df
Original change's description:
> Remove //chrome/android:chrome alias
> 
> Downstream rename is now complete.
> 
> Bug: 731186
> Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
> Reviewed-on: https://chromium-review.googlesource.com/684956
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504437}

Bug: 731186
Change-Id: I82816beec565bcd3a86c849a7e79caf006dde851
Reviewed-on: https://chromium-review.googlesource.com/685399Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504490}

Both LocationBarLayout and CustomTabToolbar will emphasize the https
scheme if the toolbar uses the defualt color theme.

BUG=726565

Change-Id: I9d9ed97a1a245cf8262fa43008cee5184e1657ca
Reviewed-on: https://chromium-review.googlesource.com/676199
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504489}

CreateObjectProxy() method must be called after the construction of
ThreadedWorkletMessagingProxy is completed. Otherwise, the subclass's
CreateObjectProxy() method will not get called as expected.

Bug: 691782
Change-Id: Ib148193a8fbb53a6232a1275fe2015a619c91452
Reviewed-on: https://chromium-review.googlesource.com/676137
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504488}

Bug: 
Change-Id: Id86544d32aa805ee09e6846aadbb397048a961c0
Reviewed-on: https://chromium-review.googlesource.com/685555Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504487}

HistogramSet has a different default output filename when using Telemetry; we
need to account for this in run_telemetry_benchmark_as_googletest so that that
script can find the histogram output if present.

Bug: 744736
Change-Id: I1fec4a2d86e7e0a9700bc0b44160b78f0484d866
Reviewed-on: https://chromium-review.googlesource.com/683780Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504486}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0b563bed301e..cf05c91b6757

$ git log 0b563bed3..cf05c91b6 --date=short --no-merges --format='%ad %ae %s'
2017-09-26 rnephew [Telemetry] Make `run_benchmark list` support SUPPORTED_PLATFORMS and StoryExpectations.
2017-09-26 bokan Fix telemetry's IsBrowserRunning check

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib18dd6f4f4d74929f8bd689ab2ecbf07e5466632
Reviewed-on: https://chromium-review.googlesource.com/685509
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504485}

Added a test in interstitial_ui_browsertest that checks back button has
the correct behavior after opening chrome://interstitials and
navigating to an interstitial

Bug: 767804
Change-Id: Ic77509d205561c39d2e397589da31110481d4e92
Reviewed-on: https://chromium-review.googlesource.com/682535
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504484}

Change-Id: I7b96f53f5d3385bb192224078a56bbe36e92eb07
Reviewed-on: https://chromium-review.googlesource.com/680054Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504483}

BUG=746967

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Id9106a040641386eea32988ce44cd2324e36798b
Reviewed-on: https://chromium-review.googlesource.com/684657Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504482}

The upload uses CopySubTextureCHROMIUM which is compatible with
immutable textures, as it does not change the texture size. It used
to use CopyTextureCHROMIUM, which is not compatible, and had a unit
test describing this. But in reality this has changed, so always make
the resource immutible, and stop checking for that when recycling.

R=piman@chromium.org

Bug: 768976
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia9a31769fcc6c513291b6e67be4dea07d1c02168
Reviewed-on: https://chromium-review.googlesource.com/685742Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504481}

The test validates that empty legacy device ids properly validate prefs
as VALID_SECURE_LEGACY. The name and expectations will be changed in
https://chromium-review.googlesource.com/c/chromium/src/+/655929 which
disallows empty legacy device ids.

Bug: 500085
Change-Id: Id99434c6441928b0faaeb1d5f7357d99fe8ef9a6
Reviewed-on: https://chromium-review.googlesource.com/685483
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504480}

This is a hack around b/66493165 that should be removed when a GVR fix
is released. We manually find the views GVR adds to the hierarchy and
resize them/re-generate their Drawables for the new density.

Bug: 767603
Change-Id: Iacf40d81281d2e1a9423c095935d861b15be68fa
Reviewed-on: https://chromium-review.googlesource.com/682107Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504479}

R=thestig@chromium.org
TBR=dpranke@chromium.org

Change-Id: I87d84b80e0dd994cd11d684d7d9733b51a4058c6
Reviewed-on: https://chromium-review.googlesource.com/683455
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504478}

Now that we have support in Blink for suggestion markers that remove themselves
after applying a replacement, we can enable support for Android SuggestionSpans
with FLAG_MISSPELLED set.

Bug: 672259
Change-Id: I01b9542bace2a6f9196bb1501b71062dfc35bd27
Reviewed-on: https://chromium-review.googlesource.com/679475Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504477}

Change-Id: Id17b44c1ea5a3ccdb726c9495b8b6e66e2bc46b7
Reviewed-on: https://chromium-review.googlesource.com/685540Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504476}

Adds new stories that exercise things that sometimes cause performance
problems for accessibility: live regions, large data tables, scrolling
large complex sites, and typing in a contenteditable, and expands the
system_health benchmark to track accessibility metrics.

Bug: 712417
Change-Id: I8384083146650b3fae35ea223892053a7e0c0be4
Reviewed-on: https://chromium-review.googlesource.com/663208
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504475}

Dispatch the commands in Page domain through an UberDispatcher. Follow up
CLs make this change for the other domains (Browser, Target).

This is in preparation for adding WindowManager domain.

BUG=758061

Change-Id: I35e9dcae13ee9f80e4d81054bdfaf2c5292785ad
Reviewed-on: https://chromium-review.googlesource.com/674263
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504474}

Adding a test for https://crrev.com/502847.

Bug: 766982, 763812
Change-Id: I23bd8d27cb2b83ee527f12a9103f82e8eac0b115
Reviewed-on: https://chromium-review.googlesource.com/682597
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504473}

This method will be used to gracefully handle SSL errors when WebState
is not in a tab.

Bug: None
Change-Id: Iee02ce69deda84d595e6bd5ab815317afb82f12d
Reviewed-on: https://chromium-review.googlesource.com/683464
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504472}

R=thestig@chromium.org
TBR=michaelpg@chromium.org

Change-Id: Ie26a81bf7f3bbf0beaf64565ae703c5134c997e7
Reviewed-on: https://chromium-review.googlesource.com/685268Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504471}

In the layer impl unittest.

Bug: None
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5b1de75269b30c160e1ffc369aff09a353d8ca10
Reviewed-on: https://chromium-review.googlesource.com/685259
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504470}

When CCT opens url like https://expired.badssl.com, the strikethrough
scheme sometimes does not display. This is because in CustomTabToolbar,
updateSecurityIcon does not demphasize the url before emphasize it and
this causes OmniboxUrlEmphasizer.hasEmphasisSpans() sometimes returns true
and prevents the emphasis. To fix the problem, remove the
hasEmphasisSpans check and always deEmphasizeUrl before emphasizeUrl the
url.

BUG=754985

Change-Id: I16143c4237d71ce9d5b860597f523942d314ba25
Reviewed-on: https://chromium-review.googlesource.com/675769
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504469}

Implement HDCP check in CastCdm. Given all Cast video products provide
HDCP or equivalent content protection, the check is performed at
platform level for all key systems, instead of querying each CDM.

Note: Use command line arg
--enable-blink-features=EncryptedMediaHdcpPolicyCheck to enable the API.

BUG=internal b/64899044
TEST=Custom test page

Change-Id: I5d56aa471d91675b546e433f05f32f359d817915
Reviewed-on: https://chromium-review.googlesource.com/676102Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504468}

Instead of waiting until the test harness timeouts the test, we
wait for a set period of time for the about:blank window to open,
after which we fail the test.

Bug: chromium:765738
Change-Id: I8635c19683a3791801bc3e75a3fc3bf16872b6f2
Reviewed-on: https://chromium-review.googlesource.com/676283
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504467}

Change-Id: I41469fc27e3c88e8aff19532abd2d5ac307824bf
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/682651Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504466}

This Cl fixes a race in Time Zone Resolver Manager when checking if Local State
has been initialized.

Bug: b/64065854
Change-Id: If681dc675e0219fda7c9b37307c7f205394c62fd
Reviewed-on: https://chromium-review.googlesource.com/682734
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504465}

Code clean up and no behavior change.

Bug: None
Change-Id: I503e2ada644d827be7a5fe8b3e7f228130287b36
Reviewed-on: https://chromium-review.googlesource.com/685299Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504464}

Before this patch, when the user closes the PaymentRequest error message
that states "Transaction failed, please try again,"
PaymentResponse.complete() promise would be rejected. This is contrary
to the spec, which says the PaymentResponse.complete() promise should be
resolved when the user closes the UI.

Spec:
https://www.w3.org/TR/payment-request/#complete()-method

This patch changes the behavior of closing browser to resolve the
PaymentResponse.complete() promise instead.

After this patch, when the user closes the PaymentRequest error message
that states "Transaction failed, please try again,"
PaymentResponse.complete() promise is resolved with undefined.

Bug: 756298
Test: CompleteTest.ResolveCompletePromiseOnUnknownError
Test: CompleteTest.ResolveCompletePromiseOnUserClosingUI
Test: https://w3c-test.org/payment-request/payment-response/complete-method-manual.https.html
Change-Id: If21b4b1c459432acf6f3156ddf26304f04f87918
Reviewed-on: https://chromium-review.googlesource.com/682794
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504463}

Bug: 482154
Change-Id: I634489e826f6f92d45977d438a6e1f39e862a330
Reviewed-on: https://chromium-review.googlesource.com/677585Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504462}

Instead of being friended by the SimpleFeature class, have unittests
use the public setters. In addition to being more clear, this cleans up
the header file.

Bug: None
Change-Id: Ia20359cf8ca35fc55eca8df1b7414b1d4f3ffea1
Reviewed-on: https://chromium-review.googlesource.com/679741
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504461}