- 12 Jan, 2021 40 commits
-
-
Tibor Goldschwendt authored
Tests ModuleDescriptor.initialize, which is the only function of that class with non-trivial logic. Adding tests is a precursor to making changes to that class in subsequent CLs. Change-Id: Ib023f014f21e547bcbf38776781a95b6d83b3e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623653 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842396}
-
Nick Diego Yamane authored
So far, a RepeatingTimer is used to abort the ClipboardOzone's requests and it's not being properly stopped when it's triggered (timeout). This switches to a OneShotTimer as well as resets pending_request_ after the internal run loop quits, so covering both the successful and abortion cases. R=dcheng@chromium.org Bug: 1165466 Change-Id: I5e7108b93999aa4632a2834b1667cf75aa7d1cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622285Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#842395}
-
cfredric authored
This brings the implementation into alignment with the final paragraph of https://github.com/cfredric/sameparty#sameparty-vs-samesite-enforcement-modes, which states that if a site is not a member of a First-Party Set, its cookies will be subject to SameSite rules, rather than SameParty rules. Bug: 1143756 Change-Id: Ie4c9066c874d9e7a42a6d8504f33d4b6e669ff7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613194Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#842394}
-
Yunke Zhou authored
Bug: 1130502 Change-Id: I7ac24f02a9ef1b41a7c3a25641069c38d85bee78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620260Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#842393}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I776e58dc007726678b1a4d05ee0be8c91c2b6cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601022 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#842392}
-
Yoichi Osato authored
TBR=paulirish@chromium.org Bug: 1163793 Change-Id: Ib5de555db523a6aaf48d4829b3323b8e3c8e22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623731 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842391}
-
Michael Bai authored
- Records if AwG is current Android autofill service. - Records if and when the server type predication is available when feature is enabled. - Records if AwG provides the suggestion and if user accepts the suggeston. Bug: 1151542 Change-Id: I246aee27cdef757902351a5e43973bea2e6f15e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612220 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842390}
-
Luciano Pacheco authored
Generate JS modules for file in //ui/file_manager/file_manager/foreground/js/ui, files: - multi_menu.js - mult_menu_button.js - munit_menu_unittest.m.js Bug: 1133186 Change-Id: I9cdd0b22118a2ae7bc578aae40c5eeb16022759c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621856Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842389}
-
Nancy Wang authored
Modify the full restore component parameter to use the consistent parameter name 'profile_path'. BUG=1146900 Change-Id: I9dadccd5811eb1ad56c9e01149941a65ff8912cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620119 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842388}
-
Jonah Chin authored
This reverts commit 4107e01f. Reason for revert: https://crbug.com/1164407 This CL is to test if this codepath can be reverted, or if follow up code depends on it too much. Original change's description: > Change texture subset logic in PaintCanvasVideoRenderer > > This CL is to simplify how PaintCanvasVideoRenderer::Cache manages > video frames whose |visible_rect| is smaller than their |coded_size|. > By always using SkImage::MakeFromAdoptedTexture, texture lifetime > management is now always handled internally by skia. This will make the > transition to OOPR here much simpler. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I2177b2deeea893fa5331afbe8796761253db2759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451213 > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818045} TBR=dalecurtis@chromium.org,khushalsagar@chromium.org,jochin@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1164407 Change-Id: Icf21a46f0917345030942d35ba77b58557b5f72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621783Reviewed-by:
Jonah Chin <jochin@microsoft.com> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842387}
-
Louise Brett authored
Bug: 1157273 Change-Id: I5531b30ccc8c2ce4d956c67880d1a74d93754073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619243Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Louise Brett <loubrett@google.com> Cr-Commit-Position: refs/heads/master@{#842386}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation (https://sites.google.com/corp/google.com/chrome-code-health/) and changes the two remaining occurrences in chrome/test/base of base::Closure to base::OnceClosure, as they are used in a waiter method that can only be invoked once. Bug: 1007643 Change-Id: If7040fe9041e88cfa89314224d98423aa6696432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623193Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842385}
-
Caroline Rising authored
Bug: 1163938 Change-Id: I03c223c41de3196be12d9d4283087dfa04ec38e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621676Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#842384}
-
David Bertoni authored
Service Worker support is now available in the Stable channel, so there is no longer a need for channel overrides. Bug: 1165397 Change-Id: Ie5a7e5a0b58814b40bcb94f437b784904f6164f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612028Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842383}
-
Tsuyoshi Horo authored
This member variable was introduced for Service Worker link registration by https://codereview.chromium.org/1781783002. Service Worker link registration was removed from the specification. And the logic was removed by http://crrev.com/c/792731. So this variable is not used anymore. Bug: 788604 Change-Id: Ieaf4f3cb31526d9767f4a6666f2c26a1109d0605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622357Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842382}
-
Sara Kato authored
Bug: 1159562 Test: build Change-Id: I9619c4861c34dc6bcd537d752b4b57602ec4fdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615722 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842381}
-
Reilly Grant authored
This change expands the manual test for transferIn() to send much more data and assert that many overlapping transfers will still complete in the correct order. Two changes are necessary to make these tests pass. First, when aborting a transfer on device close the ERROR_REQUEST_ABORTED should be mapped to an AbortError DOMException. Second, transfers should be tracked in a list rather than a map so that iteration order is well defined. Bug: 1153647 Change-Id: I248ce4724e391216783a6873809aca43e4690b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591928 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842380}
-
Harry Cutts authored
Bug: none Test: check virtual keyboard still appears with drawing tablets connected to a device in tablet mode, and that buttons on the drawing tablet (if any) still work. Change-Id: I7502a585443bda79c448c46e379703258d62ba81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622759Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#842379}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de32c3d2de00..2c65da28a2ee 2021-01-12 natsu@google.com Default roll_aosp.sh to copy artifacts to vendor partition 2021-01-12 jmadill@chromium.org Vulkan: Use angle::FormatID instead of VkFormat. 2021-01-11 stha09@googlemail.com libstdc++: fix incomplete type for FramebufferCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:957519 Tbr: timvp@google.com Test: Test: ./scripts/roll_aosp.sh and build in AOSP Change-Id: Id14dfd0c2c2df4159dcb6a052a826ca031b9323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842378}
-
Ian Kilpatrick authored
Previously if our initial block-size was indefinite, and we were a flexbox - we'd apply a series of additional invalidations to ensure correctness. These are cases where we can't guarantee "trust" in the value of NGLayoutResult::IntrinsicBlockSize, as it depends on "extrinsic" constraints such as a parent forcing a fixed-block-size or a %-block-size changing. In an upcoming patch, there are more cases where we treat an *initial* block-size as indefinite, even though ComputeBlockSizeForFragment will return a definite size. E.g. there will be a difference between ComputeBlockSizeForFragment, and ComputeInitialBlockSizeForFragment. This change makes the cache more precise in the above case, by always calling ComputeBlockSizeForFragment, but (importantly) giving an indefinite intrinsic-block-size where we can't trust NGLayoutResult::IntrinsicBlockSize. Bug: 1033476 Change-Id: I798fe7d50247a4eec0131ec46061b33484347e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621976 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842377}
-
Corentin Wallez authored
This avoids doing the conversion from WTF::String to an enum once in the Blink bindings and once in the WebGPU module. Bug: chromium:852089 Change-Id: I8765631c2b0562bdabfc6af246cab0453de63593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621754 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#842376}
-
Yoichi Osato authored
This reverts commit f4b58578. Reason for revert: caused layout test CRASH: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/94262/overview Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (3/3) > > Bug: 1138155 > Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307 > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842305} TBR=falken@chromium.org,mstensho@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org Change-Id: I5b4756817dd149a9f721c5aaeb2da54aadaf4308 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623572Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842375}
-
Zufeng Wang authored
Makes subcategories searchable, but they don't appear in the search result snippets. Bug: b/172533871 Change-Id: I6b1e053929bc1a4ecada135ae582a5deba1e673a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620740 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#842374}
-
Clark DuVall authored
This was reverted because the latest androidx.lifecycle library performs thread checks in the ComponentActivity constructor. The constructor calls LifecycleRegistry.addObserver(), so we can just override that method and make it a no-op when loading on a background thread. Bug: 1150600, 1160614 Change-Id: I52e6eb63ce0b4a9c90c002fe34281298b02ef9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622005Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842373}
-
Alan Cutter authored
This CL does 3 things: - Hides the Extensions menu item from web app windows when no Extensions are installed. - Fixes a bug exposed by the updated test where the Extensions puzzle piece would show when an Extension was installed due to the layout animation. - Addresses comments from https://chromium-review.googlesource.com/c/chromium/src/+/2602305 Bug: 1164829 Change-Id: I75e3fc5e8a7262316947b7322b825a10be3bb848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621512 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#842372}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d08c55317628..537f11c11412 2021-01-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08a68dbd375f0fac31446100baa181eb6d5ab960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842371}
-
Chromium WPT Sync authored
Using wpt-import in Chromium da4ff2f2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ide515c126e4da5b2cd43b10c1057cfa1f34fe21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622460Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842370}
-
Yoichi Osato authored
This reverts commit d409e5a5. Reason for revert: Caused IOS build error. example https://ci.chromium.org/ui/p/chromium/builders/ci/ios-device/176674/overview Original change's description: > Enable building ANGLE's end2end and white_box tests everywhere > > Previously were disabled on iOS and Fuchsia > > Bug: angleproject:5417 > Change-Id: I3e73e11b728ebfacb8082ce90f333193cb44a3d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621926 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842338} TBR=ynovikov@chromium.org,dpranke@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib8cf39cb0a73198f27cebbe997dd2d7350811655 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623730Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842369}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I4143b62d2dbafe909db0454ba7b013955da121bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622330Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842368}
-
Olga Gerchikov authored
Updated procedure that computes scroll timeline progress to accommodate for overlapping offsets. The update is to find last matching interval in the list of offsets. This is analogous to CSS property overrides where last specified property is applied. Bug: 1094014 Change-Id: I7d5c84e58bfea021f931b702d66a87d2d28aaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508356 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842367}
-
Stephen Chenney authored
Code in DarkModeFilter was applying a dark mode color filter to any painted content that had some other shader associated with it. Such shaders come from gradients, mostly, but also tiled images and some background images. This patch limits the application of the dark mode color filter shaders that are not images or paint records. The former because we should not be applying a naive color filter to images, and the latter because they should already have filters dark mode filters applied. Fixes: 1160239 Change-Id: Id7dfbf999d43d7a9f5953d1f5a5edc5a1c92fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622989 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842366}
-
Keishi Hattori authored
ast_type_traits namespace was removed in https://reviews.llvm.org/D93244 Change-Id: I93b7cb789085185036f257a764afc3d6ee7c47ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612589Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842365}
-
Eugene Zemtsov authored
plus some minimal C++ code to make things compile Bug: 1094179 Change-Id: Idea9b5fec09aeb19be4748c1746178744e5991e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619621 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842364}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7be859d6f99690fd6a819dc6cb4bfeb9b1d360b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842363}
-
Yoichi Osato authored
This CL disables DragMultipleTabsRightIntoGroup and DragAllToSeparateWindow on windows. TBR=sky@chromium.org Bug: 1164561, 1128774 Change-Id: I49c825f1950af449e765f0a3f2a1918b1ddfb3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623570Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842362}
-
Yutaka Hirano authored
- DataElement::SetToEmptyBytes and DataElement::AppendBytes are used only by tests. Remove them. - Pass base::Time by value, rather than passing by reference. Bug: None Change-Id: I50180b3dbf7292063a6221de424499f8ca907eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595761 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842361}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I77c6539836d48687d78151f947ee26fb2f0b58ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617056 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#842360}
-
Lukasz Anforowicz authored
This CL makes VerifyThatBrowserAndRendererCalculatedOriginsToCommitMatch slightly stricter - it now requires that browser-side and renderer-side have to agree whether the origin to commit should be opaque (previously browser-side origin would be ignored if renderer-side was opaque). The above is achieved by the combination of the following changes: 1. Extracting NavigationRequest::ShouldCommitOpaqueOrigin to account not only for sandbox flags, but also for network errors. Accounting for network errors in GetOriginForURLLoaderFactory allows to simplify (a bit) RFHI::ExtractFactoryParamsFromNavigationRequest.. 2. Focusing the origin calculations and checks on cross-document navigations. 2.1. Moving the VerifyThat...OriginsToCommitMatch call to RenderFrameHostImpl::DidCommitNewDocument (next to a similar check for browser-side vs renderer-side sandbox flags). 2.2. Tweaking NavigationRequest::GetOriginForURLLoaderFactory to use the last committed origin for same-document and back-forward-cache navigations. 3. Tweaking NavigationSimulatorImpl::BuildDidCommitProvisionalLoadParams to more accurately simulate the product code, by taking into account CSP headers that (through sandbox directive) end up committing an opaque origin. This new ability had to be used in one of unit tests tweaked by this CL. Bug: 888079 Change-Id: I86edbd6920a1e17abb4e1d20104c5356a4dc3ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581008 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf65caef0129..6f7379c80b03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com Change-Id: I36880c105b84b666583b876c6520db1e51f7568a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842358}
-
Sophie Chang authored
This is a reland of 9a33bf90 RELAND_REASON: This one got wrongly reverted. https://chromium-review.googlesource.com/c/chromium/src/+/2622582 should be reverted instead. TBR=sky@chromium.org,waffles@chromium.org Original change's description: > Componentize OptimizationHintsComponentInstaller for reuse on iOS > > This also makes the component available on incognito (which was an > oversight in previous support to have optimization hints be in incognito) > > Bug: 1154790 > Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842267} Bug: 1154790 Change-Id: I547245f282f4088368e05f4910a414cea49b741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622583 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842357}
-