- 25 Nov, 2020 40 commits
-
-
Luciano Pacheco authored
Rename references to the type `FilesMetadataBox` to `FilesMetadataBoxElement`, because that's the type name generated by Polymer. The polymer_modulizer() doesn't support the syntax of assigning the Polymer to a variable that was in use. Bug: 1133186 Change-Id: I0242b5e4e48fbb7040681186eaebccec7cae384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554281 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830878}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/377448c7bd4c..724b0bf4449d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com,ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com,ezemtsov@google.com Change-Id: I74eced8ae449bf4328cf034529b2668113a8be89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559383Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830877}
-
Hajime Hoshi authored
This CL is reland of http://crrev.com/c/2531155 with some test fixes. WebFilesystem doesn't have notions of handlers or connections, then it should be safe to allow pages with WebFilesystem to be put into the BFcache. Let's allow WebFilesystem for BFcache in order to improve the BFcache hit rate. This is implemented behind a flag and the feature is disabled by default. This means that this CL doesn't change the behavior by default. We might enable the feature later. Bug: 1144133 Bug: 1151235 Change-Id: I3b3526f180c19d33d6ca16a88efe400fe9bd2c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557160Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830876}
-
Bao-Duy Tran authored
Bug: 1134465 Change-Id: I6570020a4b3bc9f517884cbb99563d767f34142a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551853 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#830875}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib06c2df5f186002038697ab7249525c3a12ff06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556839 Commit-Queue: Ricky Liang <jcliang@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830874}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/185795f02ceb..759af7f40213 2020-11-25 jophba@chromium.org Logging cleanups If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id8315b51989441bbfc3f9256f592275b99741f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830873}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: If582db43dbb09f4483f0d15124ed2ec02fa27c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559497Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830872}
-
Yoshifumi Inoue authored
This patch utilizes |Position::FirstPositionInNode()| instead of constructor with |PositionAnchorType::kBeforeChildren| to reduce source code size and preparation of getting rid of |kBeforeChildren|. Bug: 592887 Change-Id: I66640fe772d506965f901326b39604dd83e9d408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556733 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#830871}
-
Leo Lai authored
We are obsoleting `TpmIsBeingOwned()` of cryptohome API. BUG=b:172775884 TEST=chromeos_unittests. Change-Id: Ia6752e3c06ccce3c7c78ebdda2cbe281204a30df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556881Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#830870}
-
Koji Ishii authored
This patch unifies two different access to |box_fragment_|, one as a field and one as a local variable, in |PaintObject|. This patch has no behavior changes. Change-Id: I2075fc9c88e62fafe0575c84a6a1310c2c3f5531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557701 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#830869}
-
Alex Kalugin authored
Forward arguments for WebContentsUserData::CreateForWebContents in order not to create redundant CreateForWebContents methods in tab helpers derived from WebContentsUserData. Bug: 1152253 Change-Id: I86237c6b76b76bea97ba3c0e4f2281084a383dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544946Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#830868}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606240669-251229982c87402ee7b9ccf8ab49774406a74762.profdata to chrome-mac-master-1606262372-c28fabe0f518396be3e19b31d10fd57f4542b836.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49b5b9efd1d9bc66a6efac0dbedb49805bdf3f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559389 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I31d5380b67a5900e4577333574384a386a6aed56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537454 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830866}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Id2b68ce53c9613b9d4fafe53e600fc77d7be3b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545968Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830865}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I110fd5cacaa1310e27953d913a22f460ccbf3535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550003 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830864}
-
Moe Ahmadi authored
This ensures a gap between the bottom of the absolutely positioned realbox dropdown and the application window. before: screenshot/6PQpiSvXPyW6DC6 after: screenshot/3CMRkUqeztEw6tU Fixed: 1135056 Change-Id: I8cb44916cb8effedf250c962441f258aa5e6916c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559637 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830863}
-
Daniel Cheng authored
Though the original code used blink::EnumerationHistogram to record these metrics, they have been migrated to use UMA_HISTOGRAM_EXACT_LINEAR since they do not conform to the standard expectations of enumeration histograms. Bug: 1047547q Change-Id: I1f69cd1985874246061a7d13f93816a26c7a2487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524587Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Chris Hamilton authored
The migration in https://crrev.com/5075457e9b changed the task runner that |main_task_runner_| was bound to. This in turn caused the check base::ThreadTaskRunnerHandle::Get().get() != main_task_runner_ to always return true, meaning stream events were never processed. Modifying this to check main_task_runner_->BelongsToCurrentThread() fixes the infinite dispatch issue. BUG=1150822 Change-Id: Ia5699d94424ff56a6ce6f0333370c17ff2b786ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559313Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#830861}
-
Michael Hansen authored
Sets up the labels for the radio buttons on the contact visibility page to fix an extra stop when using a screen reader. Fixed: 1148462 Bug: b:168841167 Change-Id: I8b31ccfafdc856aa51b1f36fa44ec5317ea9935c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559091Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#830860}
-
Chris Thompson authored
This filters SCTs included in SCT auditing reports to only those that are valid (i.e., from a known log with a valid signature). Reports that don't have any valid SCTs are dropped. This also means that we won't collect reports for non-public certificates (by definition, a logged certificate is public). This replaces the prior logic which explicitly excluded certificates that weren't issued by known roots. This also combines adding the SCTs to the report and computing the SCT hash, which lets us avoid encoding and copying the SCTs multiple times. Bug: 1129197 Change-Id: I9223f66628088f2a512966859846fd3982ebefcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422435 Commit-Queue: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830859}
-
Ben Reich authored
When collecting JS code coverage for Files app, $i18n labels are being replaced per normal, but that causes a mismatch in character offsets in the JS coverage data compared to the original JS source files. Disable $i18n{} JS string replacements for ChromeOS FilesApp extension when the --devtools-code-coverage flag is supplied. For now, the only builder running the Files app tests with the JS code --devtools-code-coverage flag is a CI builder: linux-chromeos-js-code-coverage which is in development. Followup CLs will start updating the files app tests to work with both this disabled $i18n{} mode, and the normal app $i18n{} replaced mode, using a files app browser test sendTestCommand helper called 'devtoolsCoverageActive' (added in this CL). :Gallery*:*FilesApp*:*SelectFileDialogExtension* Bug: 1152612 Test: browser_tests --gtest_filer=*AudioPlayer*:VideoPlayer*\ Change-Id: I62eb2c66ea0c2d7ef0158dedbc41928d6e3b75ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559234 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830858}
-
Noel Gordon authored
Require onPiexModuleFailed argument to PiexLoader.load: update Closure markup to say that: clients do need to handle WASM module failure. Bug: 1145029 Change-Id: If1819ff780433772d0aa135687a4f2af1741103a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557765Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830857}
-
Joel Hockey authored
Refactor dialog into static function where it can be reused by drag and drop. Event type name 'failed_plugin_vm_directory_not_shared' will also be used by CrostiniEventType. Remove FAILED_PLUGIN_VM_TASK_EXTERNAL_DRIVE error and only use FAILED_PLUGIN_VM_DIRECTORY_NOT_SHARED which is slightly renamed. FilesApp can detect when entries are in MyFiles volume or not and show the correct message of move vs copy. Bug: 1144138 Change-Id: I14072bcc3514f598428936dcad04b0468e432de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557819Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830856}
-
Chris Thompson authored
Adds a CertAndCTVerifier class, which is a new CertVerifier wrapper type which composes certificate and certificate transparency (CT) verification as part of CertVerifier::Verify(). This also removes all direct usage of CTVerifier, making the only "public" API the CertVerifier::Verify() API. This also fixes MockCertVerifier to fix a violation of the API contract of CertVerifier::Verify(). Now it is guaranteed that deleting the verifier will result in any outstanding Requests to be canceled and their callbacks reset. As a side effect, this allows MockCertVerifier to control both cert and CT results in CertVerifyResult in tests (particularly useful in integration tests where setting up test certs with valid SCT is challenging). Bug: 848277 Change-Id: If37fe21f0f5328a0a48a964d9525066614ce0439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531113Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Yi Gu authored
The test has been flaky (score > 1500): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=ContextMenuBrowserTest.OpenLinkInProfile TBR=lazyboy@chromium.org Bug: 1121731 Change-Id: Icce1cbf09bce21b38d70cf5f783e765bab2fecf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559002 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830854}
-
Arno Renevier authored
tests in third_party/blink/web_tests/external/wpt/websockets/unload-a-document/ have wss variant. But when opening a popup, they don't pass the location.search parameter to their children. So for example, 001.html?wss will 001-1.html. And since 001-1.html has no knowledge of the wss param, it will (incorrectly) open an insecure sockets. Because of that, tests in websockets/unload-a-document always run the insecure variant. This patch fixes the issue. Bug: 801564 Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Arnaud Renevier <arenevier@fb.com> Cr-Commit-Position: refs/heads/master@{#830853}
-
Zhaoyang Li authored
As the bug is fixed, enable ResultDB in all iOS builders. This change reverts crrev/c/2465924, crrev/c/2536932, crrev/c/2551288. Bug: 1136998 Change-Id: I7cd8f397a51f5d041b932598ead014c3bdc654e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558787Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#830852}
-
David Bertoni authored
Bug: 1136568 Change-Id: I6e3e121e1d6c682c1465284755d4e518388cb970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551740 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830851}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Id6b8fa4436c9928752683e2ba799fb04822d5ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546308Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830850}
-
Josh Simmons authored
If a share fails to remount after suspend, a race condition can cause the SmbService's share map to be changed while it's being iterated over, ultimately resulting in Chrome crash due to invalid pointer dereference. Take a copy of the map's keys and iterate over them so that the map itself can be safely mutated during the resume process. Test: Run suspend_stress_test and ensure Chrome doesn't crash Test: unit_tests --gtest_filter="*SmbFs*" Bug: 1147299 Change-Id: I9b3982a381951b72f594fc2067992a8df9f9b204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559473Reviewed-by:
Anand K Mistry <amistry@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#830849}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch Bug: 1052397 Change-Id: I085e3628f84a38fb8a65f2924a324f8e672963be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531154Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830848}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f77eb468fc4..bafeede2b523 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fed88f41..10f56916 (830583:830729) 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision acfa5a01..fed88f41 (830473:830583) 2020-11-24 landrey@webrtc.org Fix timout message while uploading to the dashboard 2020-11-24 landrey@webrtc.org Replace all infinity values before uploading to the dashoard 2020-11-24 philipel@webrtc.org Removed unused H264 specific code from RtpFrameReferenceFinder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea75f7e1e09375067863028a3a97acee9b372088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559324Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I17c9ddc55b9d70727df3c2af5ed762fc4b8d1c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538864Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830846}
-
Fergal Daly authored
https://crrev.com/c/2532535 added a DumpWithoutCrashing but it was triggering on cases that were unrelated to the bug. It was reverted to keep it out of M88. https://crrev.com/c/2538863 readded the debugging, this time called from 2 more places and excluding crashed frames. This has led to no DWOC reports (while the original crash continues). This seems to imply that crashed frames are actually involved. This CL allows the DWOC to happen on crashed frames again. It removes the call from CreateSpeculativeRenderFrameHost because that is expected to involve crashed frames sometimes. Bug: 1146573 Change-Id: I9a8e34825bbdb89468916947d56532d1da217269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557859 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830845}
-
edchin authored
Design doc: go/bling-phishguard This CL further removes a dependency on WebContents from PasswordProtectionRequest. Previously the Request class inherited from WebContentsObserver so that it can self-cancel when the WebContents is destroyed. Now, the Request class is composed of a RequestCanceler, whose subclass RequestCancelerContent inherits from WebContentsObserver. The RequestCanceler now observes WebContents destruction and cancels the Request. Also, the Request class conforms to the CancelableRequest interface, which allows it to be canceled. Bug: 1147967 Change-Id: I53c8494b5806afb6c325599ffea6da6457ce75c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553190Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830844}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I8afb9b363d1863ff2b148273b293c40c46ff6172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546349 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#830843}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95ab83f6fe25..36d06a806f69 2020-11-24 jlavrova@google.com Fixing background rectangle sizes for Flutter 2020-11-24 brianosman@google.com Run SPIR-V validation on SkSL unit test output 2020-11-24 csmartdalton@google.com Add experimental prints for conic max error to Wedge sample 2020-11-24 reed@google.com Simplify bitmapprocstate to just store bool for bilerp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I40429acc4d995d828193fdf4d18caf71214d7280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558928Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I6cbd0a7076046dd7da356ea1fd30760645c2f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537445Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830841}
-
David Bienvenu authored
This finishes the conversion for this directory, except for the typedef for CancelCallback, which is used externally. Bug: 1007788 Change-Id: I5471ff1e1917aa95122cb62c3c6ec0084fa38319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551747Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Clark DuVall authored
The fix for crbug.com/1146745 started using the ClassLoader from ContextUtils.getApplicationContext() for loading service classes. In the browser process, this ClassLoader will be the chrome module ClassLoader. DecoderService runs in it's own process, so the application does not load the chrome specific code. This change makes sure the application ClassLoader can actually load the service class before replacing the passed in context. Bug: 1152467 Change-Id: I82b4081afc349fec2e540a5763586153b50b67b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558957Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#830839}
-
