GitLab

Reject a message with a bogus object id, rather than null crashing.

BUG=451752
R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/874983003

Cr-Commit-Position: refs/heads/master@{#313145}

v1 uses "X-Privet-Auth".
v3 uses "Authorization".

Privet v3 client should use "Authorization: Privet anonymous" before pairing.

BUG=449864

Review URL: https://codereview.chromium.org/878463002

Cr-Commit-Position: refs/heads/master@{#313144}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/873483005

Cr-Commit-Position: refs/heads/master@{#313143}

net: manual removal of segu-info.com.ar from HSTS list.
Cr-Commit-Position: refs/heads/master@{#313142}

Only release the result of a register request to a tab if it's still the foreground tab when the result is received.

BUG=451165
R=arnarb@chromium.org,reillyg@chromium.org

Review URL: https://codereview.chromium.org/872603003

Cr-Commit-Position: refs/heads/master@{#313141}

TBR=creis@chromium.org

Review URL: https://codereview.chromium.org/851813002

Cr-Commit-Position: refs/heads/master@{#313140}

For tests, there are some difficulties to guarantee it being called just once.

This is a retake of https://codereview.chromium.org/866973004/,
which didn't work with some tests.

R=agl@chromium.org, sky@chromium.org
TEST=RenderThreadImplBrowserTest
BUG=

Review URL: https://codereview.chromium.org/872973003

Cr-Commit-Position: refs/heads/master@{#313139}

R=mbarbella@chromium.org, tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/873233003

Cr-Commit-Position: refs/heads/master@{#313138}

Replace the notification system with a static callback list in
BrowsingDataRemover.

BUG=chromium:268984
TEST=BrowsingDataRemoverTest and ExtensionBrowsingDataTest pass.
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/874613004

Cr-Commit-Position: refs/heads/master@{#313137}

As a solution to a problem the Account Tracker will assume a stale
refresh token when it cannot get access token. Backoff logic in
token fetcher handles the case where service might not be reachale
and situations like that.

If the user signs in properly the account will be re-added.

BUG=452131
R=zea@chromium.org,dimich@chromium.org

Review URL: https://codereview.chromium.org/878713002

Cr-Commit-Position: refs/heads/master@{#313136}

BUG=angleproject:896

Review URL: https://codereview.chromium.org/873383002

Cr-Commit-Position: refs/heads/master@{#313135}

Add missing views class names so that correct view's class name show up in chrome://tracing instead of just "View".

BUG=450703

Review URL: https://codereview.chromium.org/863223002

Cr-Commit-Position: refs/heads/master@{#313134}

BUG=None

Review URL: https://codereview.chromium.org/851503005

Cr-Commit-Position: refs/heads/master@{#313133}

BUG=

Review URL: https://codereview.chromium.org/820603002

Cr-Commit-Position: refs/heads/master@{#313132}

We're working on UI junk elimination and this is to help identify the class/methods that spend too long on UI thread.

BUG=450703

Review URL: https://codereview.chromium.org/869453002

Cr-Commit-Position: refs/heads/master@{#313131}

BUG=450771
TEST=none

Review URL: https://codereview.chromium.org/875143002

Cr-Commit-Position: refs/heads/master@{#313130}

https://codereview.chromium.org/74253002 removed the only use.
No behavior change.

BUG=452130
TBR=eroman

Review URL: https://codereview.chromium.org/876823002

Cr-Commit-Position: refs/heads/master@{#313129}

NOTRY=true

Review URL: https://codereview.chromium.org/874403003

Cr-Commit-Position: refs/heads/master@{#313128}

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/866573003

Cr-Commit-Position: refs/heads/master@{#313127}

Using deps caused pulling a bit of mojo code to chrome.exe. That
caused weird unresolved externatls problems during Windows GN build.

Review URL: https://codereview.chromium.org/876783003

Cr-Commit-Position: refs/heads/master@{#313126}

BUG=450724
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/864923002

Cr-Commit-Position: refs/heads/master@{#313125}

347f025 Remove unused modexp512-x86_64.pl.
6ae7f07 Only send sigalgs extension in 1.2-capable ClientHellos.
4189bd9 Test application data and Finished reordering.
78e6978 Disable NPN and Channel ID in DTLS.
33e799f Don't allow CCS just before CertificateVerify in DTLS.
c898ce7 Add generated documentation to .gitignore
2a0e72f Fix segfault with empty fields as last in the config.
df1cda3 Use inner algorithm when printing certificate.
e3b2467 sha256-armv4.pl: fix typo.
8604eda Add Broadwell performance results.

See https://code.google.com/p/webrtc/issues/detail?id=4223

BUG=none

Review URL: https://codereview.chromium.org/874363003

Cr-Commit-Position: refs/heads/master@{#313124}

This patch also moves the logic which decides on enabling/disabling double tap
to a common place to be reused both in touch emulation and android gesture detection.

BUG=425586,325506

Review URL: https://codereview.chromium.org/859973003

Cr-Commit-Position: refs/heads/master@{#313123}

Some ComponentLoader unit_tests are crashing on official chromeos bot
in IsNormalSession() due to uninitialized user manager.
This is hit when loading quickoffice component extension, which is
guarded with #if defined(GOOGLE_CHROME_BUILD), thus it's seen only on
official builds.

This makes sure that UserManager is initialized before checking
if a user is logged in.

Example trace:
#0 0x00000b44302e base::debug::StackTrace::StackTrace()
#1 0x00000b442c6c base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x0000f776f410 ([vdso]+0x40f)
#3 0x00000d702745 user_manager::UserManager::Get()
#4 0x00000e4c4bec extensions::ComponentLoader::EnableFileSystemInGuestMode()
#5 0x00000e4c5811 extensions::ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages()
#6 0x00000e4c523e extensions::ComponentLoader::AddDefaultComponentExtensions()
#7 0x000008fa03ff extensions::ComponentLoaderTest_LoadAll_Test::TestBody()

BUG=None

Review URL: https://codereview.chromium.org/874483005

Cr-Commit-Position: refs/heads/master@{#313122}

BUG=451851

Review URL: https://codereview.chromium.org/869383003

Cr-Commit-Position: refs/heads/master@{#313121}

Update some dialog strings for unmasking/updating expired cards.
TODO: Actual month/year inputs.

BUG=451654

Review URL: https://codereview.chromium.org/870203002

Cr-Commit-Position: refs/heads/master@{#313120}

BUG=449849
TEST=Peter is happy

Review URL: https://codereview.chromium.org/879653002

Cr-Commit-Position: refs/heads/master@{#313119}

Chrome App will replace this functionality.

BUG=451851

Review URL: https://codereview.chromium.org/873103002

Cr-Commit-Position: refs/heads/master@{#313118}

There are correctness issues in the ServiceWorkerCache when multiple
operations occur on the same key in parallel. The various steps of the
operations can interleave. This CL serializes all cache operations by
placing all operations in a queue and calling the next operation from
the callback of the previous operation.

While this provides correctness, it is sub-optimal. We really only
need to serialize operations that affect the same entry. A smarter
scheduler can be created in the future to implement that (see
https://crbug.com/451174).

BUG=421226

Review URL: https://codereview.chromium.org/863263003

Cr-Commit-Position: refs/heads/master@{#313117}

Previously if we got an invalid event stream such as

Press id 0
Press id 0

MotionEventAura would happily add the second pointer. Now we replace
the first pointer with the second pointer.

This work around is required due to crbug.com/373125.

BUG=450880

Review URL: https://codereview.chromium.org/873283003

Cr-Commit-Position: refs/heads/master@{#313116}

BUG=369661
TEST=tests stay green

Committed: https://crrev.com/6b988de501639cc9a8f9d40aa25fc44b431de71d
Reverted: https://crrev.com/67d33496116a22ce2244977569314d818525da04

Review URL: https://codereview.chromium.org/850953002

Cr-Commit-Position: refs/heads/master@{#313115}

BUG=448827

Review URL: https://codereview.chromium.org/876803002

Cr-Commit-Position: refs/heads/master@{#313114}

Update the visual feedback for touch on the volume tray.

Increased the touch region for the mute button. Combined the views after the
volume slider into one touch region that opens the detailed view.

Additionally removed subclasses of ui/views/controls/ inside VolumeView, where
update logic was only extension.

Removed need for custom layout by setting up the BoxLayout to tread the slider
as a flex region.

TEST=Manually tested on device
BUG=447213

Review URL: https://codereview.chromium.org/865333002

Cr-Commit-Position: refs/heads/master@{#313113}

BUG=None
R=peter@chromium.org
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/873033002

Cr-Commit-Position: refs/heads/master@{#313112}

BUG=369661
TEST=tests stay green

Committed: https://crrev.com/4442a6507d04b27eea65065c3a849f3c9d570352
Reverted: https://crrev.com/a4758bcdbf0cf027f18e3e87f15de51ce757eee0

Review URL: https://codereview.chromium.org/853693003

Cr-Commit-Position: refs/heads/master@{#313111}

Rationale is that disengaged write protect switch indicates the user
already has control over firmware and VPD contents, trying to force
enrollment in this environment doesn't make sense.

BUG=chromium:450325

Review URL: https://codereview.chromium.org/871013004

Cr-Commit-Position: refs/heads/master@{#313110}

Implement support for adding networks. Specifically:
1) When an ACTION_ADD change is received from sync, apply that
   change to the platform's network configruation.
2) Provide a method that upper layers can call, to add a network
   to Chrome Sync.

BUG=chromium:431435
TEST=components_unittests --gtest_filter="Wifi*"

Review URL: https://codereview.chromium.org/836303004

Cr-Commit-Position: refs/heads/master@{#313109}

These are needed for Debug builds when using allocator_shim.

These were accidently removed in r312720.

BUG=451663
TEST=base_unittests, allocator_unittests (Debug, component=static_library)

Review URL: https://codereview.chromium.org/872153002

Cr-Commit-Position: refs/heads/master@{#313108}

This CL was reverted at
https://codereview.chromium.org/867773002/
due to perf bot redness at that time. Now that the perf bot has
recovered, we can reland it.

This is to make the trace events captured during smoothness test more
useful in debugging smoothness/latency issues.

These added trace events are supposed to be giving most useful information
about the input/scheduling/rendering pipeline and have low occurrence in
each frame so as to minimize the performance overhead.

Following are the list for the added trace events roughly in the order
of the input->rendering pipeline:

LatencyInfo.Flow                                 // so we can follow the input latency flow
RenderWidgetHostViewAndroid::OnVSync             // when frame is started
InputHandlerProxy::HandleInputEvent              // when the input event is handled on impl
RenderWidget::OnHandleInputEvent                 // when the input event is handled on main
Scheduler::BeginFrame                            // cc decides to schedule a frame
Scheduler::BeginRetroFrame                       // cc starts a retro frame
Scheduler::BeginImplFrame                        // impl frame is scheduled
Scheduler::OnBeginImplFrameDeadline              // impl frame actually starts
OnSwapCompositorFrame                            // browser gets notified that renderer frame is ready
CompositorImpl::PostComposit                     // browser schedules a frame
SingleThreadProxy::CompositeImmediately          // browser starts a frame
SingleThreadProxy::DidSwapBuffersCompleteOnImplThread  // browser frame is done

BUG=449258
TBR=sievers@chromium.org,brianderson@chromium.org,skyostil@chromium.org

Review URL: https://codereview.chromium.org/874283004

Cr-Commit-Position: refs/heads/master@{#313107}

BUG=

Review URL: https://codereview.chromium.org/872883002

Cr-Commit-Position: refs/heads/master@{#313106}