GitLab

This updates the relative time shown in non-native MD notifications as
time goes by.

Bug: 910089
Change-Id: Ie403c6b00c2f3b5508a5ed63d19d1b650787f83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547518Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651752}

A regression lead to viz::SkiaOutputDeviceVulkan::UpdateDrawSurface crashing.
This has since been fixed (crbug.com/952231).

This combined with falling back to GL Renderer was leading to the test only
having flaky failures.

We have recently added a testing flag to prevent this false positive:
"--disable-vulkan-fallback-to-gl-for-testing" which this change adds to the
tests. So that we reliably catch failures going forward.

This change also re-enables
AuraWindowVideoCaptureDeviceBrowserTest.ErrorsOutIfWindowHasGoneBeforeDeviceStart
which was failing due to crbug.com/948249 which has since been fixed.

This change also removes the test exceptions for vulkan_content_browsertests
aside from TSAN and Intel HD 630, which are failing for other reasons

TEST=vulkan_content_browsertests

Bug: 940723, 930943
Change-Id: Id187c41718a91b4401db9ff2549d6556d1820c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568088
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651751}

Force callers to specify a SameSite mode instead of relying on defaults
which may be subject to change.

Also removes blink::WebCanonicalCookie::kDefaultSameSiteMode.

Bug: 953306
Change-Id: Iaea2224a28a169804048ad9f765e811374a9836f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567955Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651750}

This CL adds a separator between the two toolbars and the content on
the screen.

Bug: 912963
Change-Id: I1a386c5ffb1cbe9cdbfd25000df7adcd5b00f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571417
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651749}

Update the expectation to match the wait_until_unloaded case. This
should have been updated along with that case in
http://crrev.com/645138 but was overlooked.

Bug: 953714
Change-Id: I168f6690fdb32081930cae0c1ae57021219d471d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572221
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651748}

This is a reland of 58017e6c with a fix
for base_unittests failing on chromium.memory/win-asan
(https://crbug.com/953465)

Original change's description:
> Remove MessageLoopBase
>
> Bug: 891670
> Change-Id: Iff6a2b4685f455509553779c7c04afd3c6f6c4e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538289
> Commit-Queue: Carlos Caballero <carlscab@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#651343}

Bug: 891670
Change-Id: I5271b84caaa204093203284342fe0289843844d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570030
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651747}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia4358f355bd200b43dd7f72c979f4f6a8f6d559a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572080Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651746}

Add SuspendAllSessions mojo API to suspend all
media sessions. This will be used to pause
playback when the audio output is detached.

BUG=905923

Change-Id: I540ef1a78ec6f9e8d7eec0b4cb39f783db58e641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568831Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651745}

Bug: 923426
Change-Id: I26920165476cbc5a6cb7d03329e66d346528f1d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565617Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651744}

With this change, the AA controller is deleted immediately, even when a
script is running, no matter what action is it. This simplifies the
shutdown procedure and makes it overall more robust.

This solves an immediate issue with wait for navigation preventing
shutdown.

There used to be ownership issues that prevented it from working
properly. These issues seems to have been fixed.

Bug: b/128300038
Change-Id: Ieeeccc9bcf3cc996072ef87b97b9fe741842adb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569116
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#651743}

Remove ScopedAccountConsistency so that UnifiedConsent is enabled
through the fieldtrial features. ScopedAccountConsistency can
be removed because kDice is already default in the tests.

Bug: 811351
Change-Id: I9d5a6de0dca8c31edfacf0ced0b242ac1eb02f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571685Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651742}

These profiles will be specially rolled just for Android and Linux, so
we'll probably put them in a different location than our current
profiles. Since it's easier to land a change on master than on a branch,
and we're probably going to give this rolling a shot on M75, ...

Bug: 858856
Change-Id: Idd8cef23f7daddbb40c2a8b18a852c386eef1efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570572Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651741}

On both Chrome on iOS and iOS WebView, the sign-in workflow consists
of the following operations performed in order:

1.  copying the information about the account from the SSO library
    to the IdentityManager via LegacySeedAccountInfo()

2.  setting the primary account information using the account_id
    acquired from the previous step

3.  synchronizing the list of accounts between the SSO library and
    the IdentityManager via LegacyReloadAccountsFromSystem()

However, AuthenticationService intermingled this with other steps
that are unrelated: clearing the kSigninShouldPromptForSigninAgain
preference and calling PrepareForFirstSyncSetup().

It would become possible to refactor the sign-in workflow on iOS so
that the legacy API calls are internalized into the Identity Service
implementation if those calls where not intermingled.

Looking at what they do, it is safe to move them before the call to
LegacySeedAccountInfo() because LegacySeedPrimaryAccount() does not
result in any callbacks to be invoked, and the implementation does
not depend on the system modified by those two calls.

Bug: 926940
Change-Id: Ie129675ae4a65e9b065885a205c6990468d1649a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569865Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651740}

The first thing that ComputeHaveAccountsChanged() does is invoke
ReloadCredentialsFromIdentities() passing !is_in_foreground_ for
value of should_prompt.

Before this change, when the app was leaving the background, it
would end up calling ReloadCredentialsFromIdentities() twice,
first with should_prompt set to true, and then set to false.

After this change, the method will only be called once. This is
safe as the second call to the method would be a no-op from the
point of view of outside code:

-   if the primary account refresh token was lost, then the user
    would has been signed out during the first call (with a
    notification) and on the second call it would have returned
    early

-   if the primary account refresh token is still present, then
    the second call will just reload the same list of account
    (this assumes that SSO library does not change the list of
    account asynchronously)

There is one difference introduced by this change. The value of
the preference prefs::kSigninShouldPromptForSigninAgain is set
to the value passed to should_prompt in the last call. So before
this change the value would have been set to false, while after
the change it ends up being set to true.

Setting the preference to false looks like it is a bug however.
Reading the code, it appears the code sets this to true when a
primary account was configured but the refresh token is lost
in order to prompt the user for the credentials. It is indeed
set to true if the refresh token is lost while the app is in
the foreground, so it is weird to have it set to false if the
same event happens if it occurred while the app was in the
background.

Another reason for qualifying this behaviour as a bug is that
the call to ReloadCredentialsFromIdentities() explicitly pass
true, and only the second indirect call inside the method
ComputeHaveAccountsChanged() was passing false.

Bug: none
Change-Id: Ic3fdcac71bbcce4a3198a58f39f8cbddb5be611b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569124Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651739}

When we create the MachineLevelUserCloudPolicyManager, we need to provide
a flag to indicate whether cloud policy has higher priority than the platform
one.

Since the |local_state| is not ready yet, We will read it from platform policy
provider directly.

Bug: 749530
Test: Manually on Win/Mac/Linux.
Change-Id: I84222156199460f651ffb7638dead41bf264da01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568037Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651738}

Created CompositorFrameReporter class to report execution times of
certain phases within a Compositor frame's pipeline to show trace
events.

Reporters are managed by CompositorFrameReportingController class which
keeps track of reporters at different phases. This class belongs to
CompositorTimingHistory, which makes calls to indicate that certain
phases have begun/ended.

Currently, only phases for the multi-threaded compositor are tracked.
The general order of the phases are:
  - BeginImplFrameToSendBeginMainFrame
  - SendBeginMainFrameToCommit
  - Commit
  - CommitEndToActivate
  - Activate
  - ActivateEndToSubimtCompositorFrame
  - SubmitCompositorFrame

Sample trace:
https://drive.google.com/file/d/1il9m0smq7iQRfUKl0n52_6fZdSSRZarV/view?usp=sharing

Doc:
https://docs.google.com/document/d/1UDVTqBKckFVSyxhdebCFIiupUwFmHkT7h0G_HjxZGsA/edit?usp=sharing

Change-Id: I6473ad3431af7754c6d7cfc9f1c8368dc897477b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1448513
Commit-Queue: Kaan Alsan <alsan@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651737}

Bug: 740501
Change-Id: I0a5caf723806cfdb4923150885c29508d367afff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570032
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651736}

When embed token is reset, we should not enforce that sequence numbers
monotonically increase. Also, any call to EvictSurface should only
affect surfaces with the same embed token as the evicted id.

Bug: 931801
Change-Id: I3cc1ecc80197b02fe0a3c5cffed4988cfd8e5d0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570247Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651735}

Introduce a new class (FrameRateDecider) to decide the refresh rate for
the display in cases where multiple refresh rates are supported by the
current display. The FrameRateDecider chooses the optimum rate based
on the content producers which are animating and onscreen.

R=ericrk@chromium.org, kylechar@chromium.org

Change-Id: I595f207c07057a0a72914100e672af741cde99e4
Bug: 938106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555593
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651734}

WKWebView passes nil WKNavigation object to WKNavigationDelegate
callbacks when last committed item represents restricted web page.
nil WKNavigation confuses existing chrome code, and the app crashes
because navigation never gets committed and committed item is expected
in webView:didFinishNavigation:.

This CL adds early return and commits pending item for
web::kWebKitErrorUrlBlockedByContentFilter errors to prevent
placeholder navigations, which will cause a crash.

This CL makes crbug.com/950488 reproducible for legacy navigation
manager.

Bug: 944044, 950488
TEST=load, reload and perform a back forward navigation to restricted URLs

Change-Id: I158c55137f70909b503b1698e82ec77b60d312b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570530Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651733}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ca659d06..58da6c5b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I70bd96b3239595ceade98b205f6f7a266a0294ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571486Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651732}

Webview suppresses SwapAck because calling SwapAck synchronously will
mean it happens before DidSwap. However webview now requires
presentation feedbacks to go through the normal code path in viz, so
remove that check.

Change-Id: I63ec790da644325c5990b80648c93770aa826aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570911
Commit-Queue: Bo <boliu@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651731}

This reverts commit e7eac012.

Reason for revert: Looks like one of the tests is failing on ios

Original change's description:
> Fix MOCK_TIME bug with racy cross thread immediate task posting
> 
> In https://crrev.com/c/1564008 we have a test that only cares about main
> thread delayed tasks.  However it invokes an API which as a side effect
> triggers cross thread PostTask to the main thread.  These tasks are
> uninteresting except occasionally they happen in the window between
> MockTimeDomain::DelayTillNextTask and
> MockTimeDomain::MaybeFastForwardToNextTask.  Due to a bug in
> MaybeFastForwardToNextTask it was treating this racy cross thread post
> the same as running out of tasks and exiting early.
> 
> This is clearly undesirable and this patch fixes that behaviour.
> 
> Change-Id: I98a96c98c8ae56fd22bc2b9ea452d46565354127
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565983
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#651677}

TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org

Change-Id: Id8850f47c66400d59e8aa43e04f3bf5d25205e08
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571687Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651730}

These metrics were added earlier when the lookalike interstitial was
created, but they weren't added to histograms.xml so they don't show
up on the UMA dashboard.

Bug: 933520
Change-Id: Ib2839caf03cc5ac4f8022f073c74a9daf8da8fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570472Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651729}

Change-Id: Idce427c63a86a02e71e9e26e63a868ce204478c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571645
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#651728}

This reverts commit 7ba68304.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 651700 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2JhNjgzMDQ3MDBmYTJhMDRjZjMyYTU4M2I1ZWRmZGUxYWI0MWI0MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/90491

Sample Failed Step: browser_tests

Sample Flaky Test: BackgroundSyncBrowserTest.VerifyShutdownBehavior

Original change's description:
> [Background Sync] Keep the browser alive
> 
> When the (one-shot) sync event can be fired at the time of registering.
> The keepalive is cancelled after the first attempt of firing the event
> has completed, regardless of whether it was successful.
> 
> Bug: 949486
> 
> Change-Id: I6a1f6bfe2bdd820bc8fc05828e8f226922323368
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550833
> Commit-Queue: Mugdha Lakhani <nator@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#651700}

Change-Id: If0760fe0df8cbf7ed552b8d7b818dab403de8d4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 949486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572220
Cr-Commit-Position: refs/heads/master@{#651727}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91e5b46b8d77..d7ea5259bb00


Created with:
  gclient setdep -r src-internal@d7ea5259bb00

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org

Change-Id: I47cb99106785a73c0e063929df27fd3c9f56b4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571533Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#651726}

Bug: 953283
Change-Id: I978fd4fc5c0830b7c03d885889d6435b313a983a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571012Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#651725}

Experiment Ids are passed to the AssistantOnboardingCoordinator, where
they are used to pick the onboarding variant.

Bug: 806868
Bug: b/123679241
Change-Id: I0c897c0973e49bf49d134a7d21764246779c7a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570019
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651724}

Recent investigations surfaced an issue outside tests, with a
problematic scenario leading to duplicates if two clients enable sync
simultaneously (or very close in time).

The underlying issue is that prepopulated search engines use random
GUIDs as sync identifiers, and this can lead to both clients committing
creations, if the downloaded remote data doesn't contain such search
engines (which can happen if sync is enabled simultaneously).

While this underlying issue gets addressed, we work it around in tests
by waiting until the two clients converge (with or without duplicates).

Bug: 953650,953711
Change-Id: I36f435099889fbcb3c3d9f2eba2c215ccef786dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572118
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651723}

Calling ClearResults sends updated search results to Ash
and ultimately causes a DCHECK (see linked bug).

Introduce a version of this method that does not send an update.

Bug: 948441
Test: type "Set" in search box, hit Enter - no DCHECK
Change-Id: I1f8fd9598841c34b17396e74be1dddb6ece1dbf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570569
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651722}

Non bubble dialogs can be dragged by clicking in some arbitrarily-sized
top part of the dialog.

Dragging is now agnostic of whether the title is visible.
For example, EnterpriseStartupDialogView does not show a window title,
but would want to remain draggable.

Bug: 951693
Change-Id: Icefb1d1ed49ee97bd6984c7fad417170c3458396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566684
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651721}

This cl has the following changes:
1- ManifestIconSelector::FindBestMatchingIcon considers square icons only,
ManifestIconSelector::FindBestMatchingLandscapeIcon is added to provide
GURLS for landscape icons as well.

2- Change ManifestIconDownloader to download landscape icons as well.

Bug: 879741
Change-Id: If620b0da64735b6ce902e9ee73eafb04de79a481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544139
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651720}

Under some circumstances, this can be called while the widget is
destructing. See linked bug for details.

It would be ideal to, in addition to this, prune whatever code path
is making this happen from running while the view hierarchy is destructing,
but the crash stack has too much inlining to easily figure out exactly what
that path is.

Bug: 951518
Change-Id: Icc6386aee63456c58f7cb356c5e7fd6b5a30ad29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569523Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651719}

This reverts commit 4aff7056.

Reason for revert: Abandoning the effort to stuff message ordering into Mojo core. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit#

Original change's description:
> Reland "[mojo] Shared message ordering for C++ bindings"
> 
> This is a reland of a095e3b2
> 
> PS2 is the fix, PS1 the original CL. This was just some uninitialized
> padding bytes in a control message.
> 
> Original change's description:
> > [mojo] Shared message ordering for C++ bindings
> >
> > Implements support for the [ShareMessageOrder] attribute on mojom method
> > parameters and struct fields. If the field or parameter is a
> > pending_receiver or pending_remote type (or a container of one of those
> > types), its handle will be attached to the encompassing serialized
> > message with the new MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE flag
> > set, meaning that interface pipe will begin to share message ordering
> > with the sending pipe after message transmission.
> >
> > This support should be sufficient to fully replace usage of associated
> > interfaces while eliminating all bindings-layer encoding and routing
> > support for multiplexed pipes.
> >
> > See bug for design doc link.
> >
> > Bug: 941809
> > Change-Id: I5629497705e4e747f9d63ef8198091d7917a41a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548611
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#648747}
> 
> Bug: 941809
> Change-Id: Ief79131f13e4a8b08232aafb100c466b8750fc29
> TBR: oksamyt@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559256
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#649027}

TBR=rockot@google.com,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 941809
Change-Id: Ib50135c63fc2eb93205ede22a2af89e283010e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570538Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#651718}

The test was checking the number of UKM entries, but it turns out that
unrelated evetns are sometimes logged making the test flaky. The test
now only checks metrics related to the test.

Bug: 948811
Change-Id: Ib64b50f02c9d10c8c889a74e15b307e8064f2200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570174
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651717}

BUG=none

Change-Id: Ib25823d69cc0e5926ecb1780ac5debe6af752e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570689Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651716}

With SplitSettings, browser settings opens in a tab, but OS settings
open in a window.

Delete an old test that was never running. The test was left over from
a time when we had experimental support for settings-in-a-window on
non-Chrome OS platforms. That support was removed in 2017.

Bug: 950007
Test: added to browser_tests
Change-Id: I8c2738263cbb43530fdcd6119aab2a2e2d088446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570577Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651715}

Remove the Enterprise Policy for enabling the Legacy Symantec
PKI. Certificates issued directly by the legacy PKI will no longer
be trusted by default in any version of Chrome.

Support for the SSLConfig option is still maintained for embedders,
such as Android WebView, which may wish to adhere to locally defined
or system-wide policies around trust.

Bug: 953321
Change-Id: I15cb23734be19e3ec53af0e9adcc49102fe06550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569515Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651714}

So that interactive_ui_tests running on ChromeOS device could find
libassistant.so for branded build. This eliminates the need to use
LD_LIBRARY_PATH to run the test.

Bug: 939010
Change-Id: If6f2f14fff78d68132444db6f21e070a25558f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570532Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651713}