GitLab

[PM] Remove expectation that DidStartLoading/DidStopLoading are invoked in alternance in PageLoadMetricsWebContentsObserver.

R=chrisha@chromium.org

Bug: 1145482, 1145572
Change-Id: Icedfcd1675de8751cf17ee44d396090270131ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519478
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824036}

Calling GMSCore's isGooglePlayServicesAvailable(context) uses our SDK to
check what corresponding version of the GMSCore app we need on the
device. This assumption (that we need the GMSCore app to be ahead of the
SDK) hasn't been true for years for most Google apps, and that
requirement is breaking us when we update to bleeding-edge GMSCore SDKs.

This is currently blocking new users from signing into Canary.

Testing: Was able to reproduce error message with local build:
https://photos.app.goo.gl/e9PJ9cmhRaeH7THt6
With this change, error message did not appear, and signin button was
not greyed out. This is consistent with another local build made before
the breaking roll occurred.

TBR: nyquist, mattreynolds, bsazonov for urgent refactor
Bug: 1144669, 1145211
Change-Id: Iea18fc7340222bbf6027e210318cca6c68105a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518219
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824035}

Due to a mistake in refactoring, the EULA was never marked as read, and
the location pop-up was never shown. Fix these by moving relevant code
to scene controller.

It seems like running this code multiple times (if multiwindow is used
in FRE) is safe and will not cause issues.

Bug: 1145063
Change-Id: If61e1fdb75b8cf6e1743c543d4570279f1f7a2d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517953
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824034}

Bug: 772945
Change-Id: I6623910c2a85b4b662e9bef1951f3c9f811eb0ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515100
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824033}

Change-Id: Ic67cc2f5f47ac21a392cc2c0c66530819ee96c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517724Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#824032}

This CL includes several improvements to autotest.py:
-Slightly expand the GTest regex.
  -Previously, it missed some tests due to them not explicitly including
    gtest via #include "...gtest.h". Variations included <...gtest.h>,
    gmock.h, or via *test_utils.h. Expand the regex to include these
    cases.
  -In my (limited) testing I didn't see any large regressions in terms
    of number of files added via the expanded regex, but its possible
    there is something I missed.
-Add utf-8 encoding when opening a file to read.
  -This avoids errors when opening files with non-English characters.
-Debugging lines to output all files that matched the regex.
-Added sys.executable to beginning of call to make-gtest-filter.py.
  -This enables it to work on Windows, which requires 'python3' before
    calling a python script.

Change-Id: Ic9e67658b7298867d997ba4cc396320bf5d61c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517944Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#824031}

The flush in discard buffer mode happens only at end of trace and the
packet is discarded if the buffer is already full. So flush after writing the
metadata packet.

Change-Id: I4cc75a03909629eace1e8bdfcb4eeb2239ad1309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518520
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824030}

Bug: b/168541952
Test: Run existing tests
Change-Id: I3aa883b677516b646658c583165eff017e728117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518722
Auto-Submit: Yue Li <updowndota@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824029}

I looked at the implementation of libyuv::MJPGSize() and discovered
that part of "loading" the data required validating it, which involves
reading up to 1 kB of bytes looking for an End of Image marker.

Loading and unloading it like this seems like an awful waste if all we
want to do is get the width and height...

Luckily, the CVSampleBuffer contains a format description that has the
dimensions, which I assume means getting them without reading 1 kB of
raw data.

This CL gets the dimensions that way instead of libyuv::MJPGSize().

(Note that libyuv::MJPGSize() is still used for sanity-checking inside
of the unit tests.)

Bug: chromium:1132299
Change-Id: I2c32bc319d3ae61cd6ea863ce59ab38f9fdd9d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517948
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824028}

Bug: 1014639
Change-Id: I689f97f57f07b1337df616cdf4621234bbd10841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518246
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824027}

The current list at chrome-android-perf-status@ does not seem to be
working well. The brief emails it sends are hiding the message behind an
imprecise link, making it more difficult for members of the list to
react.

Also it hides other owners, which makes them less discoverable. Switch
to the list of explicit owners.

Ideally this should be a rotation with automated assignment, but that
would be a lot to change in our processes => latermaybe.

Change-Id: I5cec8d4cf810d2fedca9b838b1f79297a7c1305b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514417Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824026}

This CL extends the MTC of the SEND_TAB_TO_SELF data type to receive a
ModelTypeControllerDelegate for transport-only mode. A non-null
delegate is passed to the controller if and only if the existing
kSendTabToSelfWhenSignedIn feature toggle is enabled.

Bug: 956722
Change-Id: Ie14535d0e873cc8a3c8bcfedc611f8d8eb6abaa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517584
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824025}

Change-Id: Ib34e24737947cc812c69e64d8ff4eb7a2d8775e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518832Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824024}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f014ab92..7ae0bc9f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I16a620023101ebe0e2237fc23a1ddbd84f5c81dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519714Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824023}

This CL test the description generated for the different types of Nodes.

Bug: chromium:1048143,chromium:1127115
Change-Id: Iedd575129cdb7a34570e0cbb96d52a91d13897ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515680
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824022}

Now that widget messages are handled in Blink, there's no need to expose
this method through the public API.

Change-Id: Ica1b737f0095d853fd021b8ce96e694a25772438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518791Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824021}

No functional change, just a minor cleanup.

R=oshima@chromium.org

Bug: 1099418
Change-Id: Iceb8ee9d87b62d7428972e9327be7d1930837e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519482Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#824020}

Currently an attacker can obtain the System-proxy policy set credentials
by tricking the Chromebook to connect to a proxy with a less secure auth
scheme.

To protect against a downgrade attack, this CL adds
policy_credentials_auth_schemes to the SystemProxySettings policy which
will allow admins to specify for which proxy auth schemes the
credentials can be applied to.

If no value is set by policy, then all three username+password auth
schemes are allowed. This is to have backwards compatibility with the
current policy until AdminConsole is updated.

Bug: 1132247
Test: browser test
Change-Id: I67a21c88c411a4373159aaa5f8cadb948e5b9cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484446
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#824019}

This CL switches Tab Search to use the WebUIBubbleManager and updates
WebUIBubbleManager to handle UMA metrics / extensions APIs.

This CL also removes the now redundant TabSearchBubbleView and
WebBubbleDialogView code.

Bug: 1099917
Change-Id: I808de88af774f91539c9610f066317f155252037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514077Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824018}

This reverts commit 0b7197a2.

Reason for revert: Speculative revert for https://crbug.com/1145587

Original change's description:
> [gpu] Add trace events and thread priority assertion in GpuChannelHost.
>
> Traces collected through Slow Reports show that acquiring the
> GpuChannelHost lock from threads running at different priorities can
> cause priority inversions. In particular, it can cause jank on the
> renderer main thread through this chain of dependency:
>
> > Main thread: cc::ProxyMain::BeginMainFrame
>   > Compositor Thread: TileManager::FlushAndIssueSignals
>     > CompositorTileWorkerBackground (slow):
>         OneCopyRasterBuffer::Playback
>
> This CL adds trace events to make contention on the GpuChannelHost lock
> more obvious in traces, and an assertion to ensure that the
> GpuChannelHost lock is never acquired at background thread priority.
>
> Bug: 1072756
> Change-Id: I2a25efe2e3f6e9bf5d980ca351a990f9c7d256b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157659
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Victor Miura <vmiura@chromium.org>
> Auto-Submit: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823744}

TBR=fdoray@chromium.org,vmiura@chromium.org

Change-Id: I18717e6387e20e892b2a58e1aad34cd8b5e4d3e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1072756, 1145587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519397Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824017}

When the favicon is updated but the top contents container is not set as
the top view, finding the favicon view would fail.

test:
1. click top left dropdown menu
2. select alternate top view
3. navigate

Bug: 1145310
Change-Id: I7aadc6a8b43b18e318d2ffea89aea0688a27e636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519090
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824016}

This will aid in constructing a catalog of known font digests for the
identifiability study.

Change-Id: Ic0d4b603513aed6c5f1fec7d3606a371119e2707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399446Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824015}

This class is for observers that observe only one source.
This is more readable and slightly more efficient than using
base::ScopedObserver, where an observer has zero or one subscriptions.

Change-Id: Iefd987ce006aa2106249cf2708f63d90326814ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518028Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824014}

Updates the expires_after attribute for 194 histograms that show
frequent access in the past 90 days.  These are the 95% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-02-01.

TBR=chromium-metrics-reviews@google.com

Change-Id: I41163acda25dc95371561ed787c1e61b21e2cef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518692Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#824013}

Change-Id: Idb6cb5718a907d08fb08597ce4666ec9bc4e04b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517481
Auto-Submit: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824012}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5399fa01a3e1..62e571e6bb4c

2020-11-04 alexrudenko@chromium.org Add align-self icons to the Styles panel
2020-11-04 jacktfranklin@chromium.org Fix bad falsey check for numeric values in emulation mode
2020-11-04 aerotwist@chromium.org TypeScriptify TimelineOverviewPane.js
2020-11-04 szuend@chromium.org TypeScrip-ify profiler/CPUProfileView.js
2020-11-04 jacktfranklin@chromium.org Add dark mode patch option to `createShadowRootWithCoreStyles`
2020-11-04 szuend@chromium.org TypeScriptify profiler/IsolateSelector.js
2020-11-04 aerotwist@chromium.org TypeScriptify FilmStripView.js
2020-11-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-11-04 szuend@chromium.org TypeScript-ify profiler/ProfileHeader.js
2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelineTreeView.js with TypeScript
2020-11-04 jobay@google.com Remove redundant aria labels and update tests
2020-11-04 janscheffler@chromium.org [Network] Fix incorrectly unescaped ampersand on windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1122511,chromium:1139945
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I41aa6d24ef0bc0ffb452f17399a123cf6dac76b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824011}

The value is not sent to blink yet. As a result, the same origin
computed from blink and the browser process might differ by their
|nonce_|.

Bug: 888079
Change-Id: I1c884a2e72e4d79fb9663d152cb011cc219f320f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502477Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824010}

This adds a histogram to log, for SameParty cookies, whether the
attribute was applied correctly (i.e. whether the cookie both had Secure
and did not have SameSite=Strict).

Bug: 1142606
Change-Id: I512f0dd83896d917022ece0da2e85ac6f0d7392c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510195Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824009}

Fixed: 1127303
Change-Id: I933f39e41be145aa85af41a632acf387c2be690f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414174
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824008}

This CL refactors tests in ContentAnalysisDelegate to use Connector
policies directly instead of the indirect helpers that map to legacy
policies.

Bug: 1109242
Change-Id: I3521f023b0e6497e6d570e8bfa83551a00d9d920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510192
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824007}

This reverts commit 9e3dabc4.

Reason for reland: This CL was not actually the cause of the test failures (https://crrev.com/c/2519333 fixed them).

Original change's description:
> Revert "[AF] Add account indication footer to AutofillSaveCardInfoBar"
>
> This reverts commit ba7d8814.
>
> Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164
>
>
> Original change's description:
> > [AF] Add account indication footer to AutofillSaveCardInfoBar
> >
> > The footer is shown only to signed-in users have more than one account, and who do not sync.
> >
> > Screenshot with feature enabled in light mode:
> > https://screenshot.googleplex.com/ApVmkMVQakM6ai9
> >
> > Screenshot with feature enabled in dark mode:
> > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM
> >
> > Bug: 1135847
> > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184
> > Commit-Queue: Anne Lim <annelim@google.com>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Reviewed-by: Matthew Jones <mdjones@chromium.org>
> > Reviewed-by: Jared Saul <jsaul@google.com>
> > Cr-Commit-Position: refs/heads/master@{#823710}
>
> TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com
>
> Change-Id: I5f235bc5843acf4ea504a78762907a019576e656
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1135847
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823942}

TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com

# Not skipping CQ checks because this is a reland.

Bug: 1135847
Change-Id: I7d1a7ad2bc6b5c30d2b859c9f68bfee34992ff95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517530Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824006}

This will allow us to start experimenting in Beta.

R=asvitkine@chromium.org

Change-Id: I7a93235c712b1f24015058c02417899c5cc5914d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517224
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824005}

The newly-introduced metrics explore different predicates to determine
whether a bookmark is a duplicate. These variants are more strict and
involve not only URL equality, but also title equality and (in a
separate metric) parent equality.

Change-Id: I8ac7ce46b235e31ec855d55fcc5bf0cad8ef9fff
Bug: 1068378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514155Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824004}

Bug: 1104925
Change-Id: Ic128c5577ce8a9c079bab701630a1680cbb3380c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517723
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824003}

This reverts commit 8e2b3210.

Reason for revert: Breaks angle_unittests on emulator

Original change's description:
> Reland #2: Android: Use locally-build devil deps only when build_with_chromium=true
>
> This reverts commit 85773e52.
>
> Reason for reland:
>  * Fixed data deps
>  * _BuildWithChromium() handles missing key
>
> Original change's description:
> > Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true""
> >
> > This reverts commit f8b7ec28.
> >
> > Reason for revert: Causing all builds to fail on android-pixel2-perf failing
> >
> > Original change's description:
> > > Reland "Android: Use locally-build devil deps only when build_with_chromium=true"
> > >
> > > This reverts commit b47e9c83.
> > >
> > > Reason for reland: Updated more .pydeps files.
> > >
> > > Original change's description:
> > > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true"
> > > >
> > > > This reverts commit 49fdeca1.
> > > >
> > > > Reason for revert: Breaking presubmit due to stale .pydeps file:
> > > > android_webview/tools/run_cts.pydeps
> > > >
> > > > Original change's description:
> > > > > Android: Use locally-build devil deps only when build_with_chromium=true
> > > > >
> > > > > Bug: 1120190
> > > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842
> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#819489}
> > > >
> > > > TBR=agrieve@chromium.org,bpastene@chromium.org
> > > >
> > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 1120190
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857
> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#819668}
> > >
> > > TBR=agrieve # reland
> > >
> > > Bug: 1120190
> > > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558
> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#819810}
> >
> > TBR=agrieve@chromium.org,bpastene@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1120190, 1141891
> > Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Commit-Queue: John Chen <johnchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#820355}
>
> Bug: 1120190
> Bug: 1141891
> Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823651}

TBR=agrieve@chromium.org,bpastene@chromium.org

Change-Id: Ia586b0d8f68795e493074ba6b00ac36c529eb1ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1120190
Bug: 1145570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519425Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824002}

This CL takes the Mojo changes from:
  https://chromium-review.googlesource.com/c/chromium/src/+/2484038
and adds an Android implementation for them.

Once these mojo changes are wired up on the Blink side, I'll add some
tests to DigitalGoodsTests.

Bug: 1139795
Change-Id: Ib8c92cbc619b8977f37d3a9b59a3045d5c1bbb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510271
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824001}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b049cadeb140..0bd50c9043c7

2020-11-04 wl@gnu.org Typo.
2020-11-04 wl@gnu.org docs/CHANGES: Updated.
2020-11-03 heftig Fix documentation build.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: drott@google.com,thestig@google.com,bungeman@google.com
Change-Id: Ibc858fb318df6e41726fef1abe2091a2de3faef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519411Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824000}

Change-Id: I65a0590b3d745b0a209ae8c7a7fc634e50ac4f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518728Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823999}

The experiment to disable PDF partial loading was successful, so we're
making it the default now.

The PdfPartialLoading and PdfIncrementalLoading features will be kept
for now for tests that rely on these features (often to test mostly
unrelated behaviors).

Fixed: 1115149
Change-Id: Iea45106f919d1fa608fcf6cfc28e432c88d4d75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505972
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Auto-Submit: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823998}

Also disable it for WebLayer since it doesn't work in that context.

Bug: 1051508
Change-Id: I5368d2c803547cccb54e0e981a77b688ec528a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516702
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823997}