- 13 Nov, 2018 40 commits
-
-
Shawn Gallea authored
Moved text_input_manager_v1 interface into another file, to be followed by refactoring of more protocols. Refactor wayland_text_input_delegate.* from server.cc with no new code. Modify server_util to add more utilities Bug: 896710 Test: Compiled on ChromeOS. Change-Id: I2739c538a16640fdaebed1cd7493d300dd42a5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1306406Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#607738}
-
Scott Violet authored
This is a copy of c/b/ui/ash/multi_user_window_manager_chromeos* to ash. I'm doing this as a precursor to a refactoring so you can better see what changes. I've only changed things necessary to avoid presubmit checks. This file is purposely not compiled now as it needs to be cleaned up first. BUG=756085 TEST=nothing new is compiled, so no tests. Change-Id: I946d9e3b582142761e6519bf754733649d1a7612 Reviewed-on: https://chromium-review.googlesource.com/c/1330078 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607737}
-
Dianna Hu authored
This CL updates Http2Random to use unsigned integers consistently, in hopes of being platform-agnostic (see, e.g., https://crrev.com/c/1310613). This CL lands server changes 221087569 by bnc and 221279592 by diannahu. Change-Id: Ifb1ea404887ab46569572a27b0c61c7e1bf1a26f Reviewed-on: https://chromium-review.googlesource.com/c/1334009Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607736}
-
Jun Choi authored
HoverListView is a model-agnostic view that holds multiple clickable item views. In WebAuthn, this view is used to display a list of BLE authenticators. This CL makes the view scrollable to handle an arbitrary number of BLE authenticators in the UI. Bug: 877344 Change-Id: I86f68bc3939ff661c982ae0e6bec1eed2d9a3a3a Reviewed-on: https://chromium-review.googlesource.com/c/1322832 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607735}
-
bsheedy authored
Automates the manual test for ensuring that the refresh button in the VR browser's overflow menu functions as expected. Bug: 887510 Change-Id: I9e97f5b5c313229e8845ef7fc0f1e2730434bf29 Reviewed-on: https://chromium-review.googlesource.com/c/1333111Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607734}
-
Charlie Reis authored
Change-Id: I968c0faf6ff19d6225015967d82440b1f80c4f0c Reviewed-on: https://chromium-review.googlesource.com/c/1333865Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#607733}
-
Henrique Grandinetti authored
Bug: 899980 Change-Id: I196999915290fe07322d934423430a0782c7ba55 Reviewed-on: https://chromium-review.googlesource.com/c/1330224Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#607732}
-
Ryan Meier authored
(Previously disabled due to apparent flakiness, but I've been unable to reproduce that behavior). Change-Id: I16433fa2ca8496cf2200f7a6948866b6b7e3efdf Reviewed-on: https://chromium-review.googlesource.com/c/1332208Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ryan Meier <rameier@chromium.org> Cr-Commit-Position: refs/heads/master@{#607731}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f47abb48757f..9d958b54af30 git log f47abb48757f..9d958b54af30 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Update several more oval ops to use WriteVertexData 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cd47a379f960..2778029563f2 (2 commits) 2018-11-13 mtklein@google.com remove opaque/alpha distinction in SSSE3 code 2018-11-13 herb@google.com Move strike cache backpointer to glyph cache 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1147fc2a5dac..6ed398b46847 (1 commits) 2018-11-13 mtklein@google.com drop sub_y == 0 optimization Created with: gclient setdep -r src/third_party/skia@9d958b54af30 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I2099d5fd7b5b651e9ef133c3784f282aeb8da16e Reviewed-on: https://chromium-review.googlesource.com/c/1333864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607730}
-
Kyle Milka authored
When the iframe finishes resizing send a postMessage to the doodle iframe letting it know the expansion has finished. b/118340003 Change-Id: Ic974ca58f51882d932e8de10c5706990f8f462cd Reviewed-on: https://chromium-review.googlesource.com/c/1323620Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#607729}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 95852cba. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I19cfd09cecfc2391f580e03ef1211f72e38d5e28 Reviewed-on: https://chromium-review.googlesource.com/c/1334189 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607728}
-
Tomas Popela authored
DHECK should be DCHECK. Change-Id: I3368631dee61b472d8bd58d38a4d3df3dd3900b1 Reviewed-on: https://chromium-review.googlesource.com/c/1332931Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#607727}
-
Sahel Sharify authored
With browser side fling instead of queuing a GFS in gesture event queue the fling controller processes the event immediately. It means that it is possible to process the GFS before arrival of the GSB's ack. This behavior does not cause any issues since after processing the GFS event the fling controller starts to generate GSU events at every begin frame. Since the generated GSU events are queued in gesture event queue they will wait for the ack of the GSB before getting processed. The only issue with the logic above is when we are bubbling GFS: It is possible that the fling controller processes the GFS before the ack of the GSB is arrived. In this case we won't bubble the GFS since we only bubble the rest of the scroll events in a sequence only when the GSB of the sequence is bubbled. This cl changes the scroll bubbling logic to avoid GFS bubbling. With this change the GFS won't get bubbled and the fling controller of the oopif will generate GSU events which will get bubbled. When the bubbling target did not consume a generated GSU event it will tell the oopif's fling controller (via RWH_input_event_router) to stop flinging. The first three tests are not new. They just show that the flinging on the oopif still causes the parent to scroll when we are bubbling scroll. The last test shows that the child's fling controller stops flinging when the parent's renderer does not consumed the generated GSUs that are bubbled. I also changed the following tests to be browser tests since instead of the fling controller cancelling the fling when generated GSUs are not consumed the RWHV_* calls stop fling. This change is necessary since the RWHV_* knows when the scroll is getting bubbled but the fling controller does not: -Early[Touchpad|Touchscreen]FlingCancelationOnInertialGSUAckNotConsumed BrowserSideFlingBrowserTest.TouchscreenInertialGSUsBubblesFromOOPIF, BrowserSideFlingBrowserTest.InertialGSEGetsBubbledFromOOPIF, BrowserSideFlingBrowserTest.InertialGSUBubblingStopsWhenParentCannotScroll Bug: 900357 Test: BrowserSideFlingBrowserTest.TouchpadInertialGSUsBubblesFromOOPIF, Change-Id: I784aa03b561d0482a95341544133761e40a1917f Reviewed-on: https://chromium-review.googlesource.com/c/1308598Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL extends the amount of useful information a popup tracker has, and reports it to UKM on close. This data will additionally be useful if we add spammy popup detection + enforcement at run time. Bug: 825875 Change-Id: I1366b795c500cbf58730887cf4e71c3f32b945a8 Reviewed-on: https://chromium-review.googlesource.com/c/1313508Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607725}
-
Tommy Martino authored
Multiline entries are used mostly for warnings and other edge cases where descriptive text is needed. By their nature the height is variable, so we need to set padding and use a content-wrapping height. This was done in the old implementation but errantly not carried over to the refactor. Bug: 903554 Change-Id: I6e9873c757fb9087af3066bb55017badccd15149 Reviewed-on: https://chromium-review.googlesource.com/c/1327579Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607724}
-
Andrey Lushnikov authored
The GpuProcessTransportFactory::OnLostMainThreadSharedContext gets called in a valid codepathes inside compositor - this message should not be reported to regular users. This causes a lot of confusion to Chrome Puppeteer clients who attribute their issues to the first error they see in terminal: https://github.com/GoogleChrome/puppeteer/issues/1925 Change-Id: Ib6c6862e6fb6a71fae388675d6dc709cf99503c8 Reviewed-on: https://chromium-review.googlesource.com/c/1333832 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607723}
-
Owen Min authored
These policies are encouraged to be set via cloud policy. Hide them from policy template and documentation. Change-Id: Ifb7c258daa4da6aeeccefbb61d11a0b68498507e Reviewed-on: https://chromium-review.googlesource.com/c/1332255Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607722}
-
Vasilii Sukhanov authored
This is exactly the same crash and fix as in https://chromium-review.googlesource.com/c/chromium/src/+/951002/ The fix is for 3 different crashes. - AutoSigninFirstRunDialogView::ControllerGone can trigger some accessibility events. The framework needs the title of the dialog. As a result the controller is dereferenced. - AutoSigninFirstRunDialogView::Accept and AutoSigninFirstRunDialogView::Cancel. On Mac those events may be triggered when the dialog already disappeared. Therefore, a NULL-check is required before pinging the controller. Bug: 904154 Change-Id: I58904340599227a5b06eb00a3d46f180bc2864a6 Reviewed-on: https://chromium-review.googlesource.com/c/1333659Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607721}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I4fb7cf0011d067c24f26914009681563baf51d11 Reviewed-on: https://chromium-review.googlesource.com/c/1331949 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#607720}
-
Mike Wittman authored
This reverts commit ce0ec6fc. Reason for revert: While the perf regression may have been caused by the original CL, it was transient. Original change's description: > Partial revert of "Use preferred language in extension i18n" > > This is a logical revert of "Use preferred language in extension i18n" > (commit 693d01a6). Because of some > intervening changes causing more complicated merges, it's simpler to > just undo the side effects of the original change, leaving the changed > boilerplate intact. > > Reason for revert: Testing perf regression in crbug.com/898191 > > If this exonerates the original CL, we will revert this change. > Otherwise, we will clean up the boilerplate added for the original CL. > > Original change's description: > > Use preferred language in extension i18n > > > > When localizing an extension, prioritize the user's preferred language > > over the application locale. > > > > Normally, these are the same. In some cases, they differ. For example, > > the user may choose to display Chrome in "en-CA" (the intl.app_locale > > pref), but because we don't have translations for that, the actual > > UI locale is "en-GB". > > > > This CL makes extensions try to use the user's preferred locale for i18n > > ("en_CA"), falling back to the UI locale ("en_GB") if no locale > > directory is found for the preferred locale. > > > > This change also updates the "current_locale" manifest key to reflect > > the user's preferred locale, or the UI locale if intl.app_locale is > > unset. > > > > Note: Like the application locale, the preferred locale is only set at > > startup (and in certain situations in CrOS). If the user changes their > > intl.app_locale pref, they have to restart Chrome before extensions are > > re-localized, just like before. > > > > Bug: 874225 > > Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d > > Reviewed-on: https://chromium-review.googlesource.com/c/1244666 > > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600619} > > Bug: 898191 > Change-Id: Iaddceb16d61ffc5572a25ed31276443ea5b5baa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1308765 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604819} TBR=lazyboy@chromium.org,michaelpg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 898191 Change-Id: Iead107f46039f01b5d5b97b36d1b8fb242f0aee3 Reviewed-on: https://chromium-review.googlesource.com/c/1334194Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607719}
-
Sergio Villar Senin authored
Partially migrates authentication_service_unitttest.mm to IdentityManager. In particular it does no longer observ OAuth2TokenService::Observer but IdentityManager::Observer. Apart from that a IdentityTestEnvironment was created to wrap all the testing factories used by the test. The IdentityManager returned by that object is then used to completely replace the calls to the SigninManager object. Bug: 890821 Change-Id: I0a04a4e8e605546a96606ecb9a3a2338e9060257 Reviewed-on: https://chromium-review.googlesource.com/c/1323552 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607718}
-
Danyao Wang authored
This allows the slim nav bots to be added to the main waterfall. Bug: 807428 Change-Id: Ia5caca43734158f88c2292222a2cbcd70049bb75 Reviewed-on: https://chromium-review.googlesource.com/c/1334191 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607717}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78869faa9193..c14a383e61b4 git log 78869faa9193..c14a383e61b4 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 pasko@chromium.org androidStartupMetric: skip FCP events when startup is missing Created with: gclient setdep -r src/third_party/catapult@c14a383e61b4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900878 TBR=sullivan@chromium.org Change-Id: I521c24016a609b53682ae7ccc8b8e26e54f40f24 Reviewed-on: https://chromium-review.googlesource.com/c/1333863Reviewed-by:
-
Victor Vasiliev authored
R=bnc@chromium.org Change-Id: I37dddebc128654dc417ec7fbbcebe5679b3d9294 Reviewed-on: https://chromium-review.googlesource.com/c/1333139Reviewed-by:
-
gogerald authored
Bug: 806868 Change-Id: If15e7d8c188179b29347645fde3f4fe7b0cbf7d5 Reviewed-on: https://chromium-review.googlesource.com/c/1331140 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607714}
-
Peter Kasting authored
These passed 50 times in a row on Windows. This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation observer in hopes of fixing observed flakiness in EnterToSearch. Bug: 69433, 133341, 133344, 133347, 133355, 133360, 146953, 408634, 431575, 751031, 751543, 823532, 841195 Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c Reviewed-on: https://chromium-review.googlesource.com/c/1332257 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#607713}
-
Steven Valdez authored
Change-Id: I88932442b714820944b4608e106eaf47536bf00d Reviewed-on: https://chromium-review.googlesource.com/c/1329344 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#607712}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: I85c5d0efcdf3c954d7756d2ca2952c06c56dd509 Reviewed-on: https://chromium-review.googlesource.com/c/1333899 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44ca9a392ac6..c7e3af1ad928 git log 44ca9a392ac6..c7e3af1ad928 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 terelius@webrtc.org Remove rtc_event_log2stats. 2018-11-13 jonasolsson@webrtc.org Introduce DLOG to video and voiceengine. 2018-11-13 tomas.popela@gmail.com Reland "Add support for screen sharing with PipeWire on Wayland" 2018-11-13 alessiob@webrtc.org AGC2: adding level estimation option (RMS or peak-based). Created with: gclient setdep -r src/third_party/webrtc@c7e3af1ad928 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id5a0ea4e3980c70d91601c64b8f68a43b7469927 Reviewed-on: https://chromium-review.googlesource.com/c/1333860Reviewed-by:
-
manuk authored
[Omnibox] Avoid removing the `www.` prefix during deduping when doing so would leave no host component. When sorting and deduping matches, match GURLs are stripped (`AutocompleteMatch::GURLToStrippedGURL`). Certain omnibox inputs, such as `http://www.` without inline autocomplete, produce matches with host compoments `www.`. Stripping `www.` in these cases would result in an empty url host component and, therefore, invalid `GURL`. Invoking `GURL::spec` on such invalid URLs would then cause a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. Bug: 898554 Change-Id: I73461c65ba53891d6f3b52bc767c754b02c1ce3e Reviewed-on: https://chromium-review.googlesource.com/c/1331631 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607709}
-
Steve Anton authored
Bug: 874296 Change-Id: I1786acb3b64fa0450e76fe27300c178081d1e191 Reviewed-on: https://chromium-review.googlesource.com/c/1285528 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607708}
-
Anne Lim authored
Renamed strike_database.h/cc to legacy_strike_database.h/cc and strike_database_unittest.cc to legacy_strike_database_unittest.cc. This is so that the files for the new version of StrikeDatabase can take the old name. Bug: 884817 Change-Id: Id4d1496b792d93f7e38afdab1ddad0419ec27f10 Reviewed-on: https://chromium-review.googlesource.com/c/1330724Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#607707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52c961afab61..b822560337a6 Created with: gclient setdep -r src-internal@b822560337a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7f2520d9b91994c276613c5223ffd94cc4cb9e6 Reviewed-on: https://chromium-review.googlesource.com/c/1333859Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607706}
-
Justin Cohen authored
Remove the NTP and show the web view more quickly. WKWebView appears to run more slowly in certain circumstances when it is obscured by another view. Change-Id: I769d9e5602a0b19a0032d5bca2fc6c6d85f3d365 Reviewed-on: https://chromium-review.googlesource.com/c/1333873 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Ted Choc authored
This moves the bulk of the key handling into the view classes themselves and not the coordinator. BUG=898522 Change-Id: Ie2b517eca6d7ae9e27bc12a020880bc668897b56 Reviewed-on: https://chromium-review.googlesource.com/c/1331689Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607704}
-
danakj authored
R=chrishtr@chromium.org, piman@chromium.org, sky@chromium.org Change-Id: I851b632e4b09f1fd9f87229c69c7f6aff30b0ead Bug: 738465 Reviewed-on: https://chromium-review.googlesource.com/c/1330332Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607703}
-
Antoine Labour authored
GpuProcessHost::ReportProcessCrash incorrectly early-outs in case of process launch failure, and fails to trigger fallback, causing a retry loop. Instead, correctly track if DidFailInitialize happened (which caused a fallback) and only early-out in that case. Bug: 876921 Change-Id: I561de5d73ce8afddf920fa3ff141524bd5797733 Reviewed-on: https://chromium-review.googlesource.com/c/1333129Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607702}
-
Mario Sanchez Prada authored
Remove the custom C++ class IdentityManagerObserver and rely on the new API from //services/identity/public/objc instead. Bug: 903262 Change-Id: I32c3d46bbd6c1cd45c092c859ef303d9cd6b240f Reviewed-on: https://chromium-review.googlesource.com/c/1326151 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607701}
-
Hao Zhang authored
Bug: 899057 Change-Id: I9a79e9a280ec0a937b44afd319f0dc3e516aef0f Reviewed-on: https://chromium-review.googlesource.com/c/1321471 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Has MenuController consider command to be an accelerator key, along with control and alt, for the purpose of not searching for mnemonics; 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing which tells the menu to close for an accelerator Bug: 885138 Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a Reviewed-on: https://chromium-review.googlesource.com/c/1334147Reviewed-by:
-
