GitLab

HasUnsyncedItems() now honors USS workers.

Bug: 836139
Change-Id: Id46bcae5a8ed66474e13da3cafba5ef32560cfbe
Reviewed-on: https://chromium-review.googlesource.com/1025713
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553117}

On ChromeOS, IdentityManager::GetPrimaryAccountInfo DCHECKs that its
view of the primary account info matches the one in SigninManagerBase.
However, if the primary account's refresh token gets revoked, then the
account gets removed from the AccountTrackerService, and
SigninManagerBase will only remember the account's ID, but not the
full AccountInfo.
This CL updates the DCHECKs so that they only verify the account ID in
this case.

Bug: 825190, 806775
Change-Id: I6cbde518e064b590109ef8ca165a1106c7ebda83
Reviewed-on: https://chromium-review.googlesource.com/1025094
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553116}

TBR=clamy@chromium.org
NOTRY=true

Bug: 836242
Change-Id: I7699ca7b26abafd04ac31c3dd5750122509db6cd
Reviewed-on: https://chromium-review.googlesource.com/1025963Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553115}

Widget::GetMinimumSize should return the size including the window
frame. Remove ShellSurfaceWidget override of this function in order
to have the frame view calculate this correctly.

Bug: 827736
Test: exo_unittest --gtest_filter=ShellSurface.SetMinimumSize
Change-Id: I25b59f1e2273364a5579e273b952c15590c744d0
Reviewed-on: https://chromium-review.googlesource.com/1024821Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553114}

This CL updates the voice search button guide when being triggered from
the omnibox voice search button.

Bug: 825396
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia0aeb04340966bbdf96715af56dbc334152598d0
Reviewed-on: https://chromium-review.googlesource.com/1025570
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553113}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rockot@chromium.org

Bug: 825327
Change-Id: I17d3542e3e7b2e1f6f53c52a7f985a64bf2d076c
Reviewed-on: https://chromium-review.googlesource.com/1024713Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553112}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Bug: 825327
Change-Id: Ifa839d59418b7a637c228a337b49bbbc811ed494
Reviewed-on: https://chromium-review.googlesource.com/1024251Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553111}

The previous CL that tried to disable this forgot to put MAYBE_ prefix,
this CL does it.

TBR=clamy@chromium.org
NOTRY=true

Bug: 836200
Change-Id: Iaa946acf3631f61cbc30e6f4a14f6aa0fce9ca76
Reviewed-on: https://chromium-review.googlesource.com/1025966Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553110}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=haraken@chromium.org

Bug: 825327
Change-Id: I0d98633558525902e6ab91c21ec03e505817ce4f
Reviewed-on: https://chromium-review.googlesource.com/1024755Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553109}

These expected files are the same as the one under platform/mac/, so
this CL removes them.

Bug: None
Change-Id: Iafae856cfd0ccac6fc7261d754f0935bba0ea6a7
Reviewed-on: https://chromium-review.googlesource.com/1025129Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553108}

TBR=clamy@chromium.org
NOTRY=true

Bug: 665296
Change-Id: I538e83666a06e8e385c79f339f9089f4ee293242
Reviewed-on: https://chromium-review.googlesource.com/1025964Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553107}

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4496464db436553d1a969a80a148062e6a1bdfaf
Reviewed-on: https://chromium-review.googlesource.com/1023975Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553106}

Also fix a parameter mismatch in the Close function.

Bug: 834101, 826817, 734095
Change-Id: I94bef0defae6c7179605db23bfc8ff0020433f75
Reviewed-on: https://chromium-review.googlesource.com/1023231
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553105}

TBR=thestig@chromium.org
NOTRY=true

Bug: 836241
Change-Id: Idfe38c1419121cbf99295d54aa3bf059a84a0359
Reviewed-on: https://chromium-review.googlesource.com/1025957Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553104}

Fixes walmart.com

To test, go to https://rsolomakhin.github.io/autofill/ and autofill the
form with default value attributes.

Also cleans up __gCrWeb.autofill.fillForm and
__gCrWeb.autofill.clearAutofilledFields for better readability.

Change-Id: I800e82cc67dd3e1c3300186d0df3b3a36dda88cf
Reviewed-on: https://chromium-review.googlesource.com/1025135Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553103}

Switches mojom maps to use base::flat_map for C++ bindings instead of
std::unordered_map.

Bug: 830040
Change-Id: Ifcc4ed6a4a76745940aaa5fb75afc61eae243763
Reviewed-on: https://chromium-review.googlesource.com/1000393
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553102}

Bug: 755840
Change-Id: Ib992197eb21d4705e8911c9ded73dfa7197b329d
Reviewed-on: https://chromium-review.googlesource.com/1024499
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553101}

Chrome extensions can be distributed outside of the Chrome Web Store by
following the instructions at
https://developer.chrome.com/apps/external_extensions.

This automatically installs the extension in a disabled state then
displays an "error bubble" dialog to the user offering them to enable or
remove the extension.

The default button of the dialog is currently the button to enable the
extension. In some cases, bad extensions are installed this way. The
default focus could be misleading users into thinking that Chrome is
endorsing the extension and recommending its extension.

This CL adds two ways to modify the default button of the dialog:
1. Through field trials, the default can be changed for _all_ extensions.
2. Through the CWS response, the default can be changed on a per-extension
   basis.

This CL does not change the default itself and should have no visible user
impact.

The field trial change can be tested with:
--force-fieldtrials="TestTrial/ExternalExtensionDefaultButtonControl"
--force-fieldtrial-params="TestTrial.ExternalExtensionDefaultButtonControl:external_install_default_button/button_cancel"
--enable-features="ExternalExtensionDefaultButtonControl<TestTrial"

Bug: 801680
Change-Id: I756b551413afa6d7b8f717aaba4bf2994d46f8ab
Reviewed-on: https://chromium-review.googlesource.com/1006058Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553100}

This change introduces SpanLess to //device/fido's parsing utils. This
is a function object similarly to std::less<>, converting its arguments
to base::spans before comparing them. Example use cases include ordered
collections of std::vectors, that wish to support lookup using a
base::span.

Bug: 829413
Change-Id: Ic74bdf67012e5cc698f3c24b7956ab739b6ff9cd
Reviewed-on: https://chromium-review.googlesource.com/1025650Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553099}

https://webrtc.googlesource.com/src.git/+log/b04e5cae08b8..29e865a5d8a5

$ git log b04e5cae0..29e865a5d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:833801,chromium:None,chromium:834875,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iab31fc923dd915e26178e425bfda37c9a6dd4f67
Reviewed-on: https://chromium-review.googlesource.com/1025320
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553098}

Bug: chromium:672469
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I857ff57164c1d58637247ec1615b2f8817d6edbd
Reviewed-on: https://chromium-review.googlesource.com/1009944
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553097}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 825327
Change-Id: Ib44e36143c5fb3bcb2aa2d84c994a6d3dff1a74c
Reviewed-on: https://chromium-review.googlesource.com/1024432Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553096}

This CL removes the DCHECK in the popupMenuCoordinator in the callback
at the end of the presentation of the popup menu.
The DCHECK can be triggered by dismissing the popup menu before the end
of the animation.

Bug: 834957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic507735290e56ab80b3ae7b9e9f74abf0ae35722
Reviewed-on: https://chromium-review.googlesource.com/1025096Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553095}

Supervised users are deprecated, and the corresponding SyncableService
implementations are already gone.
This CL adds a DEPRECATED_ prefix to the enum entries, and removes some usages
that aren't needed anymore. However, some uses are still required, e.g. the
pref mappings. I hope to fully remove the enum entries in a followup.

Skipping presubmit because of pre-existing failure (SU model type enum
entries not matching the model type name strings).
NOPRESUBMIT=true

Bug: 824756
Change-Id: Ic6ffd500e656719424f74fb92889270d1385301e
Reviewed-on: https://chromium-review.googlesource.com/1019404
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553094}

We shouldn't require clients to explicitly set that they can be
minimized. The default behavior for toplevel XDG surfaces is that
they can be minimized.

Note: The previous behavior was motivated by the lack of shelf icon
integration, and that making it less obvious how to restore the
window after minimizing it. This is not an issue anymore, with
shelf integration having been added.

Bug: 821498
Test: Caption for xterm in crostini has minimize button by default
Change-Id: I8a730d8e64dc104f990d70b0e147f182cc06e54d
Reviewed-on: https://chromium-review.googlesource.com/1024818
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553093}

Two functions do not call the assoicated Cocoa suffix properly.
It causes an infinity loop in the end.

Here is the original CL:
https://chromium.googlesource.com/chromium/src/+/007bca68b8905abeac9519c0809d039fc47f73a8

Please note that the CL above has been checked into M66. It was not caught by the QA
team as the code was disabled by the feature switcher.

Bug: 835758
Change-Id: I60f38199049fcf07f1767680f4287349152f1360
Reviewed-on: https://chromium-review.googlesource.com/1025047Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553092}

https://skia.googlesource.com/skia.git/+log/78fb04e69eae..af88ec371248

$ git log 78fb04e69..af88ec371 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 mtklein Revert "Add arcs as a specialized geometry to GrShape."
2018-04-24 csmartdalton Revert "ccpr: Don't preempt the convex path renderer"
2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms e492929..6a4194e (1 commits)
2018-04-24 mtklein Revert "call skcms_OptimizeForSpeed()"
2018-04-23 mtklein Revert "Reland "Exercise the threaded backend in test bots""
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms e8bc226..e492929 (1 commits)
2018-04-23 bsalomon Add arcs as a specialized geometry to GrShape.
2018-04-23 mtklein call skcms_OptimizeForSpeed()
2018-04-23 angle-skia-autoroll Roll third_party/externals/angle2/ 40786bdfc..b3474d9d7 (6 commits)
2018-04-23 liyuqian Reland "Exercise the threaded backend in test bots"
2018-04-23 liyuqian Fix variable name collision
2018-04-23 halcanary SkBitSet: make movable.
2018-04-23 brianosman Add skcms include directory for Android framework builds
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms fe14a6a..e8bc226 (1 commits)
2018-04-23 robertphillips Suppress BlurMaskBiggerThanDest on NexusPlayer for Vulkan
2018-04-23 jvanverth Revert "Remove ambient clamp hack for analytic shadows."
2018-04-18 csmartdalton ccpr: Don't call calcCubicInverseTransposePowerBasisMatrix
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms f1a2ba9..fe14a6a (1 commits)
2018-04-23 brianosman Enable skcms by default
2018-04-23 halcanary SkPDF: Don't forget to upcast before shift.
2018-04-23 liyuqian Clip the SkAntiRect because of possible tilings
2018-04-23 herb Generalize to SkDescriptorMap
2018-04-23 brianosman Use relative path to skcms GN file
2018-04-23 brianosman Fix deprecated constructor usage
2018-04-23 bungeman Add Transform section to viewer tools window.
2018-04-23 reed use SkRect::outset, as it clamps on overflow
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms 17d4b82..f1a2ba9 (1 commits)
2018-04-23 reed Rewrite CHECK_INTERSECT to perform the !(opposite) predicate, so that we return false if either argument is NaN.
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms 71966da..17d4b82 (1 commits)
2018-04-23 egdaniel Fixes in ReadPixels2 and yuv_texture gm to fix Vulkan validation issues.
2018-04-23 robertphillips Reland "Prevent masked solid-color draws from being turned into clears"
2018-04-23 robertphillips Disable BlurMaskBiggerThanDest unit test on ANGLE
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms c4941e8..71966da (1 commits)
2018-04-20 benjaminwagner Add SwiftShader Test jobs.
2018-04-23 bungeman Backspace opens slide picker (not paint) in viewer.
2018-04-23 brianosman Reject XYZ profiles missing some (or all) TRC tags
2018-04-20 scroggo (Mostly) respect FilterQuality in draw[stretchy]
2018-04-23 borenet [infra] Fast-forward recipes, re-enable roller
2018-04-23 robertphillips Revert "Prevent masked solid-color draws from being turned into clears"
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms e658346..c4941e8 (1 commits)
2018-04-23 angle-skia-autoroll Roll third_party/externals/angle2/ 505ea1bb5..40786bdfc (3 commits)
2018-04-23 rmistry Remove Android compile bot from the CQ
2018-04-23 borenet Switch RecreateSKPs and Bookmaker bots to use service accounts
2018-04-23 borenet Remove UpdateMetaConfig bot
2018-04-20 robertphillips Disable threaded SW mask generation on DDL bots
2018-04-23 robertphillips Prevent masked solid-color draws from being turned into clears

Created with:
  roll-dep src/third_party/skia
BUG=chromium:835666,chromium:b/77917978


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I2d3ce75f62d13529ad35a13fa78a62e6da15c08e
Reviewed-on: https://chromium-review.googlesource.com/1025319Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553091}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 825327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibb41d632874e6c54c87755eee78a306f8be1fb0f
Reviewed-on: https://chromium-review.googlesource.com/1024766Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553090}

Also removed outdated FIXME.

Bug: 813068
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I93fbe971f2d3a419b2fdcd15512073d841ea1104
Reviewed-on: https://chromium-review.googlesource.com/1025712
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553089}

Previously, in Mash, Ash used an EmptyDraggableNonClientFrameView and
Chrome drew an AppWindowFrameView on top of that. Events went to the
former, which didn't know about caption buttons, and AppWindowFrameView
draws Windows-style caption buttons, so both appearance and behavior
were broken. (In classic Ash, Chrome uses a CustomFrameViewAsh.)

Now, in Mash, Chrome doesn't have a NonClientFrameView, but tells Ash
about the frame's colors via mus init properties. The Ash-process
CustomFrameViewAsh will be painted correctly and be able to handle
events.

Bug: 766712
Change-Id: Ic272e5755d0ac9af325b512bb0c3ccbe87fcb2c8
Reviewed-on: https://chromium-review.googlesource.com/1023036Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553088}

Support additional placeholders in ONC identity fields such as Identity
or Username:
- CERT_SUBJECT_COMMON_NAME: the ASCII CommonName of the selected client
  certificate (replaced when a CertPattern is used).
- DEVICE_SERIAL_NUMBER: the serial number of the device. Only replaced
  in DeviceOpenNetworkConfiguration.
- DEVICE_ASSET_ID: the Asset ID of the device. Only replaced in
  DeviceOpenNetworkConfiguration.

This CL also changes ONC identity field variable replacement to use
|VariableExpander| instead of custom code.

      chromeos_unittests --gtet_filter=ClientCertResolverTest*

Bug: 833426
Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* && \
Change-Id: I436792ea0115230554f9726d56288cae09e80d40
Reviewed-on: https://chromium-review.googlesource.com/1016920
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553087}

As stated in message_loop_current.h, |MessageLoopCurrent::IsSet()|
should be preferred to checking the return value of
|MessageLoopCurrent::Get()|.

Bug: 825327
Change-Id: I90bf74dd9929eeb946e8e2e3ee1ac2e9f093a938
Reviewed-on: https://chromium-review.googlesource.com/1025770Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553086}

TBR=tandrii@chromium.org

Bug: 731978
Change-Id: Idbd56255a33cd7fa2d14d27c4ba0847893c94257
Reviewed-on: https://chromium-review.googlesource.com/1025326Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553085}

This is flaky on all platform

TBR=clamy@chromium.org
NOTRY=true

Bug: 836220
Change-Id: I13265c5d90e7297a004ccb75607419d60b4dd10e
Reviewed-on: https://chromium-review.googlesource.com/1025128Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553084}

This change has some pros and some cons:

Pros:
- Human readable ExecType in patch/hex dumps as the ASCII is meaningful.
- Can be done at next to no cost at compile time.
- Assigning new values regardless of order of appearance in the enum is
  more flexible. No more concern over invalidating old patches as values
  will be more or less permanent once this change goes in.

Cons:
- Checking if an ExecutableType is valid requires O(n) time where n
  is the number of supported Exec types using a cast.
  Alternatively, we could maintain a sorted list of these types in
  memory to check against in O(log(n)) or could use a set
  but this is more memory. Overall not a huge deal since we only support
  ~9 types but it is worth understanding the tradeoffs.
- Enums don't enforce value reuse so it is possible although highly
  unlikely we introduce a repeated value. However, given the use of the
  switch case casting requiring unique values this is very unlikely.

Bug: 834932
Change-Id: I7bc14ea7b4434e60bb0dafa47178fb2c2c12dc7f
Reviewed-on: https://chromium-review.googlesource.com/1020446
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553083}

I applied modernize-use-override in blink/renderer/core
http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

Bug: 428099
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3ce2ca968d5f8beee68620d3e9f4421e99008807
Reviewed-on: https://chromium-review.googlesource.com/1025494
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553082}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 825327
Change-Id: I0da1a35816b422a01b88ae1dac4b2f4c400e8aee
Reviewed-on: https://chromium-review.googlesource.com/1024285Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553081}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kpschoedel@chromium.org

Bug: 825327
Change-Id: Ie381e306bf1ea665a24180ac51c881a220875f3b
Reviewed-on: https://chromium-review.googlesource.com/1024471Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553080}

NewPasswordFormManager (details go/new-cpm-design-refactoring) needs
to find best matches. This CL implements new best matches finding
algorithm, that will be used for now by both PasswordFormManager
and NewPasswordFormManager.

Scoring algorithm is greatly simplified. All that we need to compare
matches is PSL/non-PSL match, preferred/non-preferred.

Since now algorithm of finding best matches is in separate function,
we can test it. So tests were written.

Bug: 831123
Change-Id: I543aa185e489777007c0c19bcc5924f9964696b6
Reviewed-on: https://chromium-review.googlesource.com/1023936
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553079}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 825327
Change-Id: I1b445eb50f48bfd9e52cc13458f936b251fdd47f
Reviewed-on: https://chromium-review.googlesource.com/1024373Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553078}