- 09 Nov, 2018 40 commits
-
-
Sammie Quon authored
Now that tablet mode manager tracks all user windows and not just current accounts, the window should be non account windows should be maximized on entering tablet mode, not on user switch. Test: unit_tests MultiUserWindowManagerChromeOS.TabletModeInteraction Bug: 903427 Change-Id: Ib21a7e1d7f1a37f8a571ad16226f11e03f0db960 Reviewed-on: https://chromium-review.googlesource.com/c/1329502Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#606998}
-
Kevin Marshall authored
Currently, a Frame doesn't process WebContentsObserver methods until a FIDL NavigationEventObserver is registered. WebContentsObserver is useful for more than just navigation events, though! In cases where a Frame is created but never passed a N.E.O., observer events like ReadyToCommitNavigation() were not being received, which interfered with on-load script injection. This CL fixes the issue by attaching the observer at Frame creation time. Bug: 903880 Change-Id: Ie3ab194fbaa60a5e18a4150be3ce4c6f7345845f Reviewed-on: https://chromium-review.googlesource.com/c/1328147 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606997}
-
Kyle Milka authored
Allocate more ids for local ntp resources in preparation for adding more resources. Bug: 864763 Change-Id: I9b68fdda795959306d248eec973b86e0506323c7 Reviewed-on: https://chromium-review.googlesource.com/c/1327558Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606996}
-
Roger McFarlane authored
Change-Id: Ia78991eda5e1e25ca410ab94b3a1176ae75f7d7a Reviewed-on: https://chromium-review.googlesource.com/c/1330333Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606995}
-
Becca Hughes authored
Support playback state in MediaSessionImpl. This is analogous to the previous IsActuallyPaused boolean. Also exposes MockMediaSession as we have duplicate test helpers in content and services that can be shared. BUG=893296 Change-Id: I8d7120a64b2eb9792eb7ba11e1ef13849eb81b93 Reviewed-on: https://chromium-review.googlesource.com/c/1281905 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#606994}
-
Parastoo Geranmayeh authored
validity related members in AutofillProfile should be mutable, and changing them should not change an instance of the profile. (The instances could remain const.) Change-Id: I2b088013ab4be3f4d7116c6949285690c965d68f Reviewed-on: https://chromium-review.googlesource.com/c/1324233 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606993}
-
Fabio Tirelo authored
This CL is the first step in the refactoring and: - Adds a new class (TabData) to represent the data in both C++ and Java, which replaces the AccessoryItem/KeyboardAccessoryData.Item classes. - Replaces AccessoryItem with TabData in the back end and sends it to the Java frontend. - Converts from TabData to KeyboardAccessoryData.Item in the Java frontend, so we don't need to propagate these changes everywhere. A follow-up CL will completely replace KeyboardAccessoryData.Item with TabData and remove the conversion listed in the last step above. Please check the linked bug for the desired final state as well as the steps of this refactoring to be sent in follow-up CLs. Bug: 902425 Change-Id: I6c28a31c682176c2409d3e3df2f6604768aed16d Reviewed-on: https://chromium-review.googlesource.com/c/1320732 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606992}
-
Mikel Astiz authored
Each flag maps to one feature toggle representing one (usually) or two (rarely) sync datatypes. If enabled, the sync datatype(s) are wrapped within the USS architecture, based on the so-called pseudo-USS approach (SyncableServiceBasedBridge). The functionality has been sanity-checked for crashes on dev&canary already, although some resulting UMA is suspicious. The flags should allow easier debugging and testing. Bug: 870624 Change-Id: Id5762c01f7232de8dda4e524083fae59f66217a2 Reviewed-on: https://chromium-review.googlesource.com/c/1329142 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606991}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5d2dfa46c05c..50bf0429394d git log 5d2dfa46c05c..50bf0429394d --date=short --no-merges --format='%ad %ae %s' 2018-11-09 syoussefi@chromium.org Vulkan: add depth-only or stencil-only tests Created with: gclient setdep -r src/third_party/angle@50bf0429394d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Id57aa1fff67ad92703d95353f149e8be85379621 Reviewed-on: https://chromium-review.googlesource.com/c/1329991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606990}
-
kylechar authored
The overridden functions for GpuMemoryBufferFactory can be called on multiple threads with OOP-D. Add a lock to protect |buffer_map_| which is used in both CreateGpuMemoryBuffer() and DestroyGpuMemoryBuffer(). Bug: 902163 Change-Id: Ib80169103677f5bdaccc2d4803efa029f4910b03 Reviewed-on: https://chromium-review.googlesource.com/c/1329547 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606989}
-
Francois Doray authored
Previously, we read a variation param from the "BrowserScheduler" study to determine whether all tasks should have USER_BLOCKING priority. With this CL, we instead use a base::Feature. Benefits: - Study that controls the feature doesn't have to be "BrowserScheduler". - Enabling/disabling a feature is less verbose than setting a variation params with the new GCL config format. Bug: 902441 Change-Id: Ib38dcfdf097c1ca92784a22c3501b644b077f744 Reviewed-on: https://chromium-review.googlesource.com/c/1321032 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606988}
-
Maks Orlovich authored
This time with a DumpWithoutCrashing Bug: 901405 Change-Id: Ie2a075afe384e3dc13fde076a558d5d90591ab92 Reviewed-on: https://chromium-review.googlesource.com/c/1330076Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#606987}
-
Scott Violet authored
I'm converting some tests, and would like to avoid having to update a bunch of places to use lower case strings. BUG=756085 TEST=none Change-Id: I4beba5088736a6f1c9dbf040741073ce19016097 Reviewed-on: https://chromium-review.googlesource.com/c/1329930Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606986}
-
Roger Tawa authored
This is needed to make sure that credential provider pdbs make it to the chromium symbol server. Bug: 901825 Change-Id: I23e116d0c7405c827fc3ed5385013a9e776644d2 Reviewed-on: https://chromium-review.googlesource.com/c/1315533Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606985}
-
David Tseng authored
Bug: 898386 Change-Id: Id924396f5fa4cd88c5a8efa2b7ac593553237a64 Reviewed-on: https://chromium-review.googlesource.com/c/1327807 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606984}
-
Justin Cohen authored
CIPD packages: infra_internal/ios/xcode/mac 10b61 infra_internal/ios/xcode/ios 10b61 Bug: 903674 Change-Id: Ifd61e84840a4ff9d36a215ad0c8d11efc51cbfd0 Reviewed-on: https://chromium-review.googlesource.com/c/1329022Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606983}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5a398e8. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I664c9c1148f41ec79d7464441dce7b4029b3a220 Reviewed-on: https://chromium-review.googlesource.com/c/1329899 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606982}
-
danakj authored
This is a reland of 68d8dbc0 The flaky test this caused to fail is flaky before this CL. Investigation in https://bugs.chromium.org/p/chromium/issues/detail?id=903695. I will disable it if I can't resolve it. TBR= Original change's description: > Don't make a LayerTreeFrameSink for a non-visible RenderWidget. > > Importantly, non-visible RenderWidgets include swapped out RenderWidgets > which are zombies, without a frame, and which should not be used. > > This can happen if the RenderWidget swap out races with the posted task > from the compositor to make a LayerTreeFrameSink. When swapping out, the > compositor would be marked as not-visible, which would stop it from > making such requests, but one could already be in flight. > > In the other case, honoring the request for a non-visible compositor is > more benign, but we can delay it until the compositor is actually > visible again. This means if a context is lost, backgrounded tabs would > not all attempt to reconnect to the Gpu process at once. > > This is a better followup for the hacky > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which > was meant only for merge to a release branch. It reverts that change as > part of this one. > > R=piman@chromium.org > > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7 > Bug: 896836, 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/1292714 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606655} Bug: 896836, 419087, 894899 Change-Id: Ic82c9c61d0e3154e20352470636e09b13248d775 Reviewed-on: https://chromium-review.googlesource.com/c/1329546Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606981}
-
Stephane Zermatten authored
With this change, when TouchEventFilter restricts usage of the page to some specified element, it also highlights these elements by graying out the sections of the page that cannot be used. The color used for graying out is the same as the one used for the overlay. https://screenshot.googleplex.com/TX0MNV26coP.png If the user taps 3 times within a 15s window, the message "Continue Manually" appears in the snackbar, allowing 5s to decide to continue or let Autofill Assistant shuts itself down. https://screenshot.googleplex.com/zxYdR8i9JuO.png This patch also lengthen the duration of the snackbar shown when closing Autofill Assistant to 5s. And shortens the message shown after hitting the back button, for example, to "I cannot help anymore, please continue manually." Bug: 806868 Change-Id: I6a31b31e6f8810b30b64e6a4060ca2fab117f5d1 Reviewed-on: https://chromium-review.googlesource.com/c/1328988 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606980}
-
Raphael Kubo da Costa authored
This code was added in commit 061d113d ("[sensors](CrOS/Linux) Implement Sensor device manager for sensors") but was never used anywhere. Change-Id: I3a0a213c09461d416aa0fffe7bbed6346692e95f Reviewed-on: https://chromium-review.googlesource.com/c/1329922Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#606979}
-
Raphael Kubo da Costa authored
There is no reason to require SensorReader instances to be created in a thread/task that allows blocking: SensorReader already uses a ThreadChecker and all methods verify they are being called from the right thread (i.e. one that can block). The call to base::AssertBlockingAllowedDeprecated() has been there since the code was added in commit 061d113d ("[sensors](CrOS/Linux) Implement Sensor device manager for sensors"), but the existing unit tests behaved differently from the production code paths and not many people seem to have used a Linux or ChromeOS build with DCHECKs enabled on a machine with sensors. PlatformSensorAndProviderLinuxTest has been adjusted and now almost all code runs within a base::ScopedDisallowBlocking scope to better mimic production conditions. Care has been taken to avoid changing too much code: porting classes and tests to base::PostTask() and reducing the amount of task runners passed around will be done separately. Bug: 896382 Change-Id: I374acba4ec982cf5ae49eb44e410607e57ac85c0 Reviewed-on: https://chromium-review.googlesource.com/c/1329921Reviewed-by:
-
Tommy Martino authored
Change-Id: I5c4e2a34c2c39e06029d27bc1a0f27dab26c4382 Reviewed-on: https://chromium-review.googlesource.com/c/1329896Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606977}
-
Balazs Engedy authored
Add a TRACE_EVENT to track how long it takes to initialize content_settings::PrefProvider, and record the number of exceptions parsed. Bug: 890129 Change-Id: Ic70783bc9c69f4ce0fdb84e5406701b59bbcbd10 Reviewed-on: https://chromium-review.googlesource.com/c/1326150Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606976}
-
danakj authored
During the navigation in the test, a renderer is loading a page and if it completes in time, sends a AddLinkRelPrerender IPC to the browser to start a link prerenderer. If this occurs before the navigation started by the test completes, then the test will fail with the wrong number of prerenderers. This seems to imply the test is exiting too quickly, and not observing the actual number of prerenderers that we create. TBR=droger@chromium.org NOTRY=true Change-Id: If74bf60f45b60f52041167532eca9915c6d604b3 Bug: 903695 Reviewed-on: https://chromium-review.googlesource.com/c/1330287Reviewed-by:
-
Roger McFarlane authored
Bug: 896719 Change-Id: I52ae96084f32210ef187a023fa6090f57928a654 Reviewed-on: https://chromium-review.googlesource.com/c/1330343Reviewed-by:
-
Martin Kreichgauer authored
This changes the return type of FidoAuthenticator::Options() from AuthenticatorSupportedOptions to base::Optional<AuthenticatorSupportedOptions>. The FidoAuthenticator subclass for the Windows WebAuthn API can potentially talk to a number of different authenticators with different capabilities and hence cannot return a sensible value for this method. It previously returned a "maximum possible" Options value; but that lead to a bug where GetAssertionHandler assumed it could set the user verification requirement of a request from "preferred" to "required" because the Windows authenticator reported itself as having a PIN set up (while the actual physical device might not even support PINs). By returning an Optional, we make the Windows case more explicit. The aforementioned bug is fixed by moving the "effective uv requirement" computation for GetAssertion into FidoDeviceAuthenticator. For MakeCredential, we have a similar bug: Because CtapMakeCredentialRequest only stores the UV requirement as a bool rather than the full enum, we currently default to uv=false for authenticators that *do* support UV (even in the non-Windows case), which is wrong. I'm going to address this in an immediate follow up CL. Bug: 898718 Change-Id: I3e40296578929c75585e820aa5764bd623e1fe79 Reviewed-on: https://chromium-review.googlesource.com/c/1321852 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#606973}
-
dpapad authored
This code should have been removed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1029952/ Bug: 902959,828890 Change-Id: Ib7e00a646c864bea6b741924d6c592197ff2863d Reviewed-on: https://chromium-review.googlesource.com/c/1327227Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606972}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6edb632ff8cd..e28390cc438f git log 6edb632ff8cd..e28390cc438f --date=short --no-merges --format='%ad %ae %s' 2018-11-09 pbos@chromium.org Add the opt-in/out commands to metrics notice Created with: gclient setdep -r src/third_party/depot_tools@e28390cc438f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I2350f1de79641e10fbd18a95062641e2136e9495 Reviewed-on: https://chromium-review.googlesource.com/c/1329986Reviewed-by:
-
Dmitry Titov authored
Bug: 861647 Change-Id: I405a0221ff7a26b6e892ab738efca6102d2f54c9 Reviewed-on: https://chromium-review.googlesource.com/c/1329885 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#606970}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31d1c800f1a0..db21dac6ad7d Created with: gclient setdep -r src-internal@db21dac6ad7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:448088 TBR=mmoss@chromium.org Change-Id: I5b99814a47f06e430d86317cd0d80b4fcaf5d069 Reviewed-on: https://chromium-review.googlesource.com/c/1329987Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606969}
-
David Tseng authored
Bug: 875437 Change-Id: I708517acb953d5ec0cb243c30c44c349f40fbe9b Reviewed-on: https://chromium-review.googlesource.com/c/1324869 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606968}
-
weiliangc authored
This reverts commit b8e27a0d. Reason for revert: Fail at compile for GPU FYI bots. Linking error see crbug.com/903934 for more deails. Original change's description: > [skia][libFuzzer] Allow building targets from OSS-Fuzz on Windows > > Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not. > Enable low hanging fruit that can easily be built in a Chromium build. > > Bug: 903632 > Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df > Reviewed-on: https://chromium-review.googlesource.com/c/1328225 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606938} TBR=kjlubick@chromium.org,mtklein@chromium.org,metzman@chromium.org Change-Id: I9398c135a4dfaa96c8e24e6566d2af87f3212ab6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903632 Reviewed-on: https://chromium-review.googlesource.com/c/1330325Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606967}
-
David Black authored
AssistantWebView is the host for embedding the web contents used by Assistant Settings and Reminders. Previously, AssistantWebView did not handle either single- or multi-process mash, so the web contents would not be embedded. Now, we use Content Service which works in both single- and multi- process mash in the same pattern established for AppList in: https://chromium-review.googlesource.com/c/chromium/src/+/1269622 This required adding a few new abilities to NavigableContents that Assistant has the need for: - Adding min/max size for auto resizing. - Adding ability to navigate backwards in history stack. - Adding handling for target="_blank" links. Still TODO: Do the same for the Assistant cards that are embedded in Assistant's UiElementContainerView. Once this is complete, we will be able to remove WebContentsManager and associated classes/logic :) Bug: b:78078693 Change-Id: I4dd19a0a4c9506fc6b7f065d54fc1a75132d278f Reviewed-on: https://chromium-review.googlesource.com/c/1313745 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#606966}
-
John Abd-El-Malek authored
Bug: 891074 Change-Id: I8904c8d0285b8b2f245456509d88206f4789fc8d Reviewed-on: https://chromium-review.googlesource.com/c/1330064Reviewed-by:
-
Vaclav Brozek authored
Chrome currently won't autofill credentials into forms which have a "new-password" field. This includes change-password forms, which also have the "current-password" field. Filling that is actually useful for users. Therefore this CL changes the condition aginst autofilling to only pick forms which do not have the "current-password" field. This is limited to the kNewPasswordFormParsing feature, to make it easier to understand the impact of that change to the overall difference between the old parser and the new parser. Bug: 895781 Change-Id: I39cee16c725d108213e045f0cef94f52a6e80837 Reviewed-on: https://chromium-review.googlesource.com/c/1309742 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606964}
-
Philip Rogers authored
This patch switches PaintTouchActionRects to status=test while the root-cause of https://crbug.com/903480 is investigated. This will turn the feature off for end-users and performance tests, though it is still on for layout tests and content shell. Bug: 903480 Change-Id: Iff6695cd6140c7caf29819a856a7b894fd4d6733 Reviewed-on: https://chromium-review.googlesource.com/c/1330070 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606963}
-
Xi Cheng authored
Bug: 888716, 851163 Change-Id: I4ac176bf42d716f163717022352793dee763399a Reviewed-on: https://chromium-review.googlesource.com/c/1327704 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606962}
-
David Quiroz Marin authored
Change-Id: I0ad5183c8d8af1432dc59504ffb589d7ba799afe Reviewed-on: https://chromium-review.googlesource.com/c/1327903Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606961}
-
Ken Rockot authored
Adds a globally_unique_id field to each service's Identity, generated and assigned by the Service Manager when starting any new service instance. This ensures that every running service instance has an Identity that is globally unique across space and time. TBR=jam@chromium.org Bug: 840127,895591 Change-Id: If32863b7d8562e3a2cd9625d8eed2db8e83c67cb Reviewed-on: https://chromium-review.googlesource.com/c/1318806 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef4709b7850d..b07ed8fb0766 git log ef4709b7850d..b07ed8fb0766 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 halcanary@google.com SkQP: revert change that broke something 2018-11-09 mtklein@google.com clean up SkBlitRow_opts 2018-11-09 halcanary@google.com SkQP run_skqp.sh catches crashes and failures now. 2018-11-09 jvanverth@google.com Merge common code for SkImage_Gpu and SkImage_GpuYUVA. 2018-11-09 mtklein@google.com move LCD blits to SkBlitter_ARGB32.cpp 2018-11-09 michaelludwig@google.com Improve degenerate 2pt conical gradient cases 2018-11-09 reed@google.com Reland "remove guards for hinting in google3" 2018-11-09 reed@google.com Revert "remove guards for hinting in google3" Created with: gclient setdep -r src/third_party/skia@b07ed8fb0766 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I038cc1494a8bfa05745baea82304f7bb47aae1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1330022Reviewed-by:
-
