- 23 Feb, 2018 40 commits
-
-
https://chromium.googlesource.com/angle/angle.git/+log/e41df6556f93..a4ef843fe0de $ git log e41df6556..a4ef843fe --date=short --no-merges --format='%ad %ae %s' 2018-02-22 jiajia.qin ES31: Fix incorrect error code in DispatchComputeIndirect 2018-02-22 jiajia.qin Fix that readonly buffer variable can be assigned Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I4cab542f00d4606a6b251e7377f8367f2941af13 Reviewed-on: https://chromium-review.googlesource.com/935121 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538885}
-
Ria Jiang authored
This CL adds RenderWidgetHostViewBase::GetOffsetFromRootSurface() and implements it on different platforms. This is necessary to use the correct coordinate-space for Viz hit-test. Bug: 810128 Test: https://chromium-review.googlesource.com/c/chromium/src/+/919260 Change-Id: I01903dc92bc00bcfa19a3870e26e4f73ea7bff37 Reviewed-on: https://chromium-review.googlesource.com/930701Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#538884}
-
sczs authored
- Creates RecentTabsTableViewController, and adds the plumbing required from BVC to Coordinator to VC. Bug: 805135 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I40a2c02f2bd7e93e93bdf75cd365c7853c27ea6f Reviewed-on: https://chromium-review.googlesource.com/933261 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538883}
-
Tim Brown authored
Bug: 815232 Change-Id: I7fad2ccc0c63b16839fb4f43b095bbfb41e844fd Reviewed-on: https://chromium-review.googlesource.com/935156Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#538882}
-
John Chen authored
Add a missing dependency that was causing chromedriver_py_tests to fail on Mac when is_component_build=true. Bug: 814818 Change-Id: I923d6e96910255380669d5f02f3bc828feaa3396 Reviewed-on: https://chromium-review.googlesource.com/935287 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538881}
-
Matt Mueller authored
This allows path building to continue and try to build a valid path (either to a different root, or to the same cert if it happens to be self-signed.) Update comments & todos that trusted leaf certs are intentionally not supported. Bug: 814994 Change-Id: Id8e6a5f3d00c94c96271e4c6e21860206bb71c2a Reviewed-on: https://chromium-review.googlesource.com/933108Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#538880}
-
https://skia.googlesource.com/skia.git/+log/09f818d2c9c0..1022f743758b $ git log 09f818d2c..1022f7437 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 fmalita [skottie] Nested animation support Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I7a6f03eef6ec89e55e27e94a9d432289f01e26bd Reviewed-on: https://chromium-review.googlesource.com/935201 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538879}
-
James Cook authored
"!ash" is the same as "+ash" but will cause checkdeps.py to emit a presubmit warning if you add additional deps on that path. Since we're trying to eliminate deps on //ash, that's desirable. TBR=atwilson@chromium.org Bug: 678705 Change-Id: I911479be6d308f2ba21370761ab9d5575827e7df Reviewed-on: https://chromium-review.googlesource.com/935282 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#538878}
-
Peter Collingbourne authored
This bot has the same configuration as ToTAndroidCFI except that it uses clang releases instead of clang ToT. While here, drop an unnecessary test suite exception from the configuration for ToTAndroidCFI. Bug: 810907 Change-Id: I9040dd8ba64b9117fd6c1425ca60b88a6161bc2b Reviewed-on: https://chromium-review.googlesource.com/924607 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538877}
-
Peter Kasting authored
BUG=none TEST=none TBR=yusukes Change-Id: I49bc09082dc5d9cb3200a50cca74280b94a9455f Reviewed-on: https://chromium-review.googlesource.com/935291Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#538876}
-
Julia Tuttle authored
Bug: 810142 Change-Id: If62d38c058de404f3fd02508b9d63828d37d8d7c Reviewed-on: https://chromium-review.googlesource.com/919422 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#538875}
-
Xiaoqian Dai authored
Cros splitscreen: Defer resetting identity transform of the overview window until window is snapped. Before this change, in overview mode, when dragging a window item to snap to one side of the screen, the window will reset its identity transform first and then change to its desired snapped window bounds. It may work fine for Chrome browser/app windows since the bounds change is very quick, however, for Arc app windows, it takes much longer time to change to its desired bounds, thus the animation will look like the Arc app window enlarges itself to maximized window bounds (restore its original transform animation) and then shrinks to its snapped window bounds (bounds change animation). To fix this problem, we defer resetting to identity transform of the drag-to-snap window until its bounds has changed to its desired bounds. With this change, the animation will look like the Arc app window directly enlarges to its desired snapped window bounds. Bug: 725683 Change-Id: Id734b77593fbda8dce647c7c43d64671317c208e Reviewed-on: https://chromium-review.googlesource.com/910076Reviewed-by:
Mitsuru Oshima (OOO 2/23) <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#538874}
-
Eugene But authored
This reverts commit 9f7168d5. Reason for revert: iOS 11.3 Beta 3 does not have this bug Original change's description: > Always add WKWebView to the view hierarchy on iOS 11.3. > > On iOS 11.3 WKWebView loads much slower if it is not a part of the view > hierarchy. This is more-likely a system issue, however it is important > to have a workaround until Apple fixes the bug. > > BUG=739390 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I8a066a97699a56980689b1d37dde560e69d91ff1 > Reviewed-on: https://chromium-review.googlesource.com/910712 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536517} TBR=justincohen@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739390 Change-Id: I1d5332e35361e19020e34d4c12bbb2e87e8d036a Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/935222Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#538873}
-
Fady Samuel authored
Input throttling is not currently well supported on non-Chrome OS platforms and that's causing some crashes in the wild. Input throttling still makes sense on any synchronization event on any platform because things aren't getting updated while we are synchronizing but for the time being to avoid crashes in the wild, this CL disables input throttling outside of Chrome OS. Bug: 672962, 791447 Change-Id: I0ac419a683f8a0f735e746fa629a037370fbd169 Reviewed-on: https://chromium-review.googlesource.com/932542Reviewed-by:
-
Morten Stenshorne authored
We forgot to subtract space taken up by scrollbars. Now that we do, we also need NGBlockNode::GetScrollbarSizes() to add the horizontal scrollbar on the correct side. Need to check with the layout object, not directly with computed style. This matters e.g. if the object in question is the LayoutView, which always places it on the right hand side, even if document direction is RTL. Also fix static block offset in flipped blocks writing mode. We got it wrong, because we flipped an offset relative to the border edge around the padding box. That's a regression from https://chromium-review.googlesource.com/926004 Since I managed to break stuff without any tests regressing, I added a few to wpt/css/css-flexbox/ (it doesn't really matter which layout model to test with, as long as the containing block is in legacy layout, so I just picked flexbox). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf Reviewed-on: https://chromium-review.googlesource.com/931502Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#538871}
-
jonross authored
With RenderFrameSubmissionObserver browser_tests and content_browsertests can wait for the submission of compositor frames, or changes in RenderFrameMetadata. In a way that works for both classic and Viz DisplayCompositor. FrameWatcher did not work with Viz. This change ports all usage of FrameWatcher to RenderFrameSubmissionObserver. It also updates the new API to specifiy the two forms of waiting. FrameWatcher is also being deleted. TEST=content_browsertests, browser_tests Bug: 785013 Change-Id: I4e34ab49e8a7739a105686483ff9cd6aee3e3fa7 Reviewed-on: https://chromium-review.googlesource.com/924479Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#538870}
-
Robert Flack authored
WindowSelectorController::ToggleOverview used to do 3 removal loops over the active window list, one of which did a search through another window list for each window. This reduces the runtime complexity (a single removal loop) and makes the code easier to read (having fewer conditions). Bug: None Change-Id: I06ddf20b5ef3be57da4660de849bffeb4935683b Reviewed-on: https://chromium-review.googlesource.com/934974Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538869}
-
Mina Almasry authored
Will be used in to be implemented CMA backend. BUG=internal b/73746352 TEST=Build Change-Id: I08d520edf54cbd8658c6112eeb930e7e68fd3d6a Reviewed-on: https://chromium-review.googlesource.com/933584Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#538868}
-
Eugene But authored
This removes code from BVC and allows reusing Store Kit code in DownloadManagerCoordinator. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5d33de9666a0bdc35fb3d451158b33a8636bf4d Reviewed-on: https://chromium-review.googlesource.com/934315 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#538867}
-
wutao authored
This cl releases some resource ids after moving Keyboard Shortcut Viewer (KSV) from ui/chromeos to ash/components. Current ui_chromeos_strings' max id is 26353, starts next grd id from 26450. Bug: 768932 Test: None Change-Id: I93ca16b9797af61ee46f8ee27999859e86a0583f Reviewed-on: https://chromium-review.googlesource.com/934966Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538866}
-
Ian Clelland authored
This reverts commit 62f63887. Reason for revert: Breaks Linux x64 build See https://ci.chromium.org/buildbot/chromium/Linux%20x64/59320 Original change's description: > Rename buildflag_headers for consistency > > This renames targets in chrome, chromecast and chromeos. > > Targets go from foo_features to foo_buildflags > And similarly the header now has buildflags in the name. > > BUG=814485 > TEST=covered by build > TBR=dcheng@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews > Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091 > Reviewed-on: https://chromium-review.googlesource.com/932544 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538856} TBR=sky@chromium.org,dcheng@chromium.org,thakis@chromium.org Change-Id: Ie087d5e711feb3d2ac127b78f0c019ae18bcdaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814485 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews Reviewed-on: https://chromium-review.googlesource.com/935361Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#538865}
-
Sonny Sasaka authored
This adds BlueZ.ChipLost. This differs from BlueZ.AdapterLost in that ChipLost records adapter lost specifically due to hardware disconnection. Corresponding CL where metrics is used: http://crosreview.com/924505 BUG=chromium:813390 Change-Id: I1a1956f6f40508b57af12c49ee4c1265c7309457 Reviewed-on: https://chromium-review.googlesource.com/930482Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#538864}
-
Xiaoling Bao authored
Bug: 615187 Change-Id: I843a790e5a0000d9ca8a981b734c5891f54577c8 Reviewed-on: https://chromium-review.googlesource.com/934977Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538863}
-
Julia Tuttle authored
Use Service directly, since it's all in //net anyway. Bug: 811472 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If76628a56aa9e9e1b463f40f5ade4e3c50b506ed Reviewed-on: https://chromium-review.googlesource.com/919421Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#538862}
-
Theresa authored
This support is no longer needed, and removing it side-steps an Android framework issue. Specifically, re-enabling popupwindow clipping prevents Android from drawing it overtop of the bottom navigation bar. BUG=815226 Change-Id: I5860a7f58efb3920cb636557502879dd9e3136ab Reviewed-on: https://chromium-review.googlesource.com/934978 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538861}
-
Adam Langley authored
This change causes |AuthenticatorImpl| to only serialize |CollectedClientData| once for each request. Since the code then carries it around as a string, the |CollectedClientData| object itself is never used except to immediately call |SerializeToJson| on it. Thus |CollectedClientData| is folded into a function on |AuthenticatorImpl| to save two indirections. Along the way, implement the changes to the Token Binding member[1] and re-add the random hint to not template match[2] now that it doesn't break things. [1] https://github.com/w3c/webauthn/commit/a47fe1c4d53b123caa7abc76e9659b95dc1c1a16 [2] https://chromium.googlesource.com/chromium/src/+/eb234c8e7356f2239700c604ad7b3eda42aaac33 Bug: 814103 Change-Id: Ifa96f3eee11bcbf740c7adff43e092ce5361210a Reviewed-on: https://chromium-review.googlesource.com/929807Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#538860}
-
Henrik Grunell authored
* Move the code pulling and pushing data to its own function. * Add a loop that runs until the audio client reports empty buffer. * Remove unnecessary GetVolume() call; it's overwritten by GetAgcVolume() call later. Bug: 637558 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie06d862592143d76508a7d4d709efd42c83a1d9c Reviewed-on: https://chromium-review.googlesource.com/931554 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538859}
-
Amirhossein Simjour authored
Remove VrTabModalJsDialog flag when in VR. BUG=779126 Change-Id: I2c7ce7d764cc7879496878d8a20facf1baba5a9b Reviewed-on: https://chromium-review.googlesource.com/932756Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#538858}
-
Sergey Volk authored
This will allow configuring minigbm via GN variables, instead of make file args. Bug: 733450 Change-Id: I455d6b39c587b061a3527b63c7b1a1f556a529ac Reviewed-on: https://chromium-review.googlesource.com/933595Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#538857}
-
Scott Violet authored
This renames targets in chrome, chromecast and chromeos. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=dcheng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091 Reviewed-on: https://chromium-review.googlesource.com/932544Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Min Qin authored
Currently BaseFile will ask ContentBrowserClient for default download dir if preference returns an empty dir. This CL moves that logic into DownloadManagerImpl, so BaseFile won't need to reference ContentBrowserClient. BUG=803135 Change-Id: I480d9f32bd685068134bd25b23e07ea21d7239f6 Reviewed-on: https://chromium-review.googlesource.com/930234 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#538855}
-
Randy Rossi authored
Allow toggle of color inversion on the root window layer to support high contrast mode toggle. Bug: b/73383555 Change-Id: I97bc389385249283ca362ddfb22599b87a822ab2 Tested: Manual Reviewed-on: https://chromium-review.googlesource.com/932621 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#538854}
-
Francois Doray authored
Today, PaymentAppContext::Shutdown() is called from ~StoragePartitionImpl() after the UI thread is done running tasks and before the IO thread is done running tasks. ShutdownOnIO() is successfully posted to the IO thread. After it runs, it tries to send the DidShutdown() reply to the UI thread, which fails. Because of how PostTaskAndReply is implemented, the PaymentAppContext is leaked (cf. https://cs.chromium.org/chromium/src/base/threading/post_task_and_reply_impl.cc?l=89&rcl=0fe5265959e1da13c1521fd7f5f6275a3b83c614). We now want to change PostTaskAndReply() to avoid leaking the reply callback and its arguments when the reply thread can't run tasks. To make that possible, we need to change the DCHECK in ~PaymentAppContextImpl() so that it only fails if ShutdownOnIO() didn't run, not if DidShutdown() didn't run. Bug: 807013 Change-Id: Ie893c70d423fed7c617cec31f01dfe1763501913 Reviewed-on: https://chromium-review.googlesource.com/929592Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#538853}
-
Emircan Uysaler authored
Bug: 812186 Change-Id: I441588439e23144311c1960c20ae49aaf75f96e5 TBR: chfremer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/934976Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538852}
-
Bruce Dawson authored
This reverts commit da69db99. Reason for revert: Suspected of causing the crashes tracked by crbug.com/814641 Original change's description: > Fix Windows sandbox to work with Application Verifier > > Application Verifier is a useful tool for tracking down bugs on Windows. > However Chrome's sandbox has not played well with App Verifier - it ends > up initializing a heap before the process is ready for this. This change > teaches the NtMapViewOfSection to skip InitHeap when handling the App > Verifier DLLs, which don't need patching anyway. > > With this change I can run Chrome with the default App Verifier settings > enabled with the exception of Handles and TLS (those failures probably > don't represent real bugs), without using --no-sandbox. > > Bug: 752344 > Change-Id: Id1fd4be9c0f080513bbdb649ed5cf2637df8474c > Reviewed-on: https://chromium-review.googlesource.com/925821 > Reviewed-by: James Forshaw <forshaw@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538307} TBR=brucedawson@chromium.org,forshaw@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 752344 Change-Id: Icd8feea1779f2891389762db0773ecf0ed9ad762 Reviewed-on: https://chromium-review.googlesource.com/934862Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#538851}
-
Min Qin authored
This CL simply moves the file, no major changes. BUG=803135 Change-Id: I3158f7e4382940afe1114bb4f614eba4337ba660 Reviewed-on: https://chromium-review.googlesource.com/929745Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
David Roger authored
The Sync Confirmation Dialog was using the Unity width instead of the default width. Bug: 814555 Change-Id: I9e4ebcd296fb9afc470841f0344a52ce7f2f40f4 Reviewed-on: https://chromium-review.googlesource.com/934244Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538849}
-
Reilly Grant authored
ShouldShowLocationBarForHTTPApp and ShouldShowLocationBarForHTTPSApp are both flaky, with the former failing while the later crashes. TBR=mguica@chromium.org Bug: 815240, 815246 Change-Id: I8856047c78d503affea58a25ba6f708454642116 Reviewed-on: https://chromium-review.googlesource.com/934926Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#538848}
-
Ryan Sturm authored
This was unintentionally removed, and needs to be added back. In the future, this might move to DataReductionProxyData. Bug: 813948 Change-Id: Iee0b5c16fc99860a9682804d1948651b434ab7ea Reviewed-on: https://chromium-review.googlesource.com/927749 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#538847}
-
Daniel Murphy authored
For the mojo version of session storage, the 'cloning' of namespaces has to to be called on the same mojo pipe as all session storage data operations. This patch allows that to happen by letting the source renderer mint the new namespace ID (and thus allowing it to call 'clone' with that ID). Bug: 716490 Change-Id: I7d1e20c7b1387e9caeab868217cf25c7a0119342 Reviewed-on: https://chromium-review.googlesource.com/910109 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538846}
-
