GitLab

This patch fixes the static position of an out-of-flow objects
to honor the 'text-align' property, when they have inline-type
'display' property, and their siblings are block-level.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7c83f241984d079f9d3729e3bfbdb8bd428946a4
Reviewed-on: https://chromium-review.googlesource.com/1098750
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566962}

Bug: 820046
Test: chromeos_unittests --gtest_filter="*AccountManager*"
Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"
Change-Id: I017bb9e9f9ed789d77235336be8fa465fd4289b8
Reviewed-on: https://chromium-review.googlesource.com/1087455Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566961}

Moves TranslateErrorToMountResult functions to smb_errors and adds unit
tests

Bug: 757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I93c415a5855d05d75cabe312c3f6cce398120d0c
Reviewed-on: https://chromium-review.googlesource.com/1087546
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566960}

Previously two tests were disabled on Viz due to flakiness. Since then it was
determined that these tests were flaking even without Viz and have been
disabled on the according platforms.

This removes them from the Viz testing filter.

TBR=kylechar@chromium.org
TEST=MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated
MainThreadEventQueueBrowserTest.MouseMove

Bug: 760181
Change-Id: Ie686d7925cb0413542a68cf72bda68295500ca56
Reviewed-on: https://chromium-review.googlesource.com/1099716Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566959}

Use a GLFence fallback (when available) if GPUTimer is not supported
for reporting presentation time.

BUG=851504
TBR=dcastagna@ for trivial mechanical change in media/gpu/

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib7cb1361974e8f4e0cfa019ebb2fc2f620ac353a
Reviewed-on: https://chromium-review.googlesource.com/1098528
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566958}

In jumbo all files are merged into a single (or many) larger
translation unit and then a couple of kButtonPadding variables
end up in same anonymous namespace so that they clash.

This patch gives those constants unique names, matching their
individual use.

Bug: 773275
Change-Id: I9d8be1076552b7ffaa095bb4d50d3fa3d5845274
Reviewed-on: https://chromium-review.googlesource.com/1078816Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#566957}

In jumbo all files are merged into a single (or many) larger
translation units and then a couple of kBorderThickness variables
end up in same anonymous namespace so that they clash.

This patch gives those constants unique names, matching their
individual use.

Bug: 773275
Change-Id: I1d81153af042c27927902b648fd7271a13f47c92
Reviewed-on: https://chromium-review.googlesource.com/1079168Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#566956}

https://chromium-review.googlesource.com/1060025 moved the creation of
the PDFium engine from OutOfProcessInstance::OutOfProcessInstance()
to OutOfProcessInstance::Init(), so it is possible that multiple calls
to Init() might produce more than one engine. The crash in 852273 looks
like a page might have somehow outlived an engine, so prevent duplicate
engine creation. We rollback the configurable javascript option, since
a single engine would have to support all environments. Having fixed
the crash, we can re-consider this implementation.

Bug: 852273
Change-Id: I00fa208fbc54dc376385fb1c2009d56944d804cb
Reviewed-on: https://chromium-review.googlesource.com/1099359
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566955}

This is a temporary build flag to hold out a Skia change which will
affect very tiny text with FreeType. This will change the layout tree in
two layout tests on Linux and will cause them to better match the other
platforms. This flag will hold out the Skia change until these can be
rebaselined.

Bug: skia:8042
Change-Id: Iecb305343924dfc9f945352e94b81361a131bb22
Reviewed-on: https://chromium-review.googlesource.com/1099423Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566954}

(Those would generally fail cleanly in release code on CRC checking)

Bug: 851912
Change-Id: I9c4301893c917b6a51f3d9532080ae7098829b12
Reviewed-on: https://chromium-review.googlesource.com/1099275Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566953}

This finishes the refactoring on the Chrome side of things so that it
communicates with cicerone instead of concierge for all communication
that goes to the container. Once this is merged and Chrome OS is uprev'd
to use the version of Chrome with this CL we can remove all of the
corresponding calls from concierge.

Bug: 842845
Test: Verified all related container functionality
Change-Id: Ia44796333b2e12e243a899477d5ca2581374166a
Reviewed-on: https://chromium-review.googlesource.com/1097939
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566952}

Followup to http://crrev.com/c/1098627, correct the iOS category field.

Change-Id: Ia0b0213825b6ee7bb241c9f67dab4e389001e3ea
Reviewed-on: https://chromium-review.googlesource.com/1099433Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566951}

Bug: 852120
Change-Id: I11844f1785fa3f6bd6e19ed28ea8dfe25f3dd11f
Reviewed-on: https://chromium-review.googlesource.com/1099042
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566950}

Since all gesture pinch event handling is done on the compositor
thread, sending gesture pinch events via EventSender has no effect.

Bug: 787924
Change-Id: Iac8cb5b387eede1bdf7d172d71ac746fd2cd70fb
Reviewed-on: https://chromium-review.googlesource.com/1087403Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566949}

And enable base_unittests on the CQ.

Bug: 840967
Change-Id: I485b9d785ef02fe9918e0f2c310e3b63ffab1b4a
Reviewed-on: https://chromium-review.googlesource.com/1098314Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566948}

It seems that TouchActionFilter::scrolling_touch_action_ could have no
value in various cases:
1. Start a fling with a touchpad and then do fling boosting with a touch
screen.
2. We could have TapDown targeting an iframe and GestureScrollBegin
targeting the main frame.

This CL does the temporary fix to ensure that the scrolling_touch_action_
always have value. A proper fix with tests will come later.

This CL also fixes the case when we try to access the allowed_touch_action_
which could have no value.

TBR=creis@chromium.org

Bug: 850979
Change-Id: I8dc52a396970d20a7037fa64dc239a25def4fac1
Reviewed-on: https://chromium-review.googlesource.com/1099193Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566947}

A number of IETF framer tests were disabled to cope with the
incomplete merging of IETF Framing to chromium. Those issues
have been resolved and the tests can now be reenabled.

N/A is tests only.

This was manually merged to Chromium

Merge internal change: 200386798

R=rch@chromium.org

Bug: 109878472
Change-Id: I908510175c02a30d7d76b2931e8e61b863dbfe0c
Reviewed-on: https://chromium-review.googlesource.com/1099137Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566946}

This reverts commit a6b5210c.

Reason for revert: Breaks all tablets

Original change's description:
> Remove not-tablet check in DeviceFormFactor
> 
> This patch removes an early return from
> DeviceFormFactor#detectScreenWidthBucket that will allow tablets to
> return their screen width "bucket". This should prevent tablets from
> trying to load phone resources in certain cases.
> 
> Bug: 850096
> Change-Id: Ie25c66d7dcc5278300f628cdd58e7e7c8f1052da
> Reviewed-on: https://chromium-review.googlesource.com/1095642
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566246}

TBR=tedchoc@chromium.org,agrieve@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850096
Change-Id: Ia214bd8fc00e0c20bc79bb74f1d092348527bb1f
Reviewed-on: https://chromium-review.googlesource.com/1099395Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566945}

This reverts commit 83ce891c.

TBR=jdufault@chromium.org

Bug: 839593
Change-Id: I7dc8393ddc3101d7c47f4e770d4007a0a6c16f96
Reviewed-on: https://chromium-review.googlesource.com/1099268Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566944}

This addresses the following feedback provided during UI review:
 - Footer item height should be 40 = 36 (suggestion height) +
   4 (compensation for corner radius); in the current implementation,
   this is 44 (36 + 2 * 4).
 - All footer items should have the same value; in the current
   implementation, the last one is taller than the others.
 - Left and right padding should also compensate for the corner
   radius; it's 8 today, should be 8 + 4.

Bug: 851009
Change-Id: I0dad1c8bbbe97dce9341900d25af44df9efbde11
Reviewed-on: https://chromium-review.googlesource.com/1091158Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566943}

Reland of crrev.com/566724. Original commit message:

The presentation-time from gpu gives a more correct view of what the
user experiences, rather than the swap-time in the renderer process.
So switch to using the presentation-time to measure the various
paint-time metrics.

The various paint-time metrics in telemetry tests (loading benchmark)
will go up after this change, but it is expected, and it is not a
regression. Results on various platforms with this change:

Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000
Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000
Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000
Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000
Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000

BUG=811961

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7742fa669ab583dbfda8be2259c553385b7fef10
Reviewed-on: https://chromium-review.googlesource.com/1099187Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566942}

This is a requirement of our current AR image transport implementation.

Bug: 852445
Change-Id: I5b64a1dfe98fd6c8b26f0436e35645c49bc4da16
Reviewed-on: https://chromium-review.googlesource.com/1099490Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566941}

Previously, the MainThreadScheduler froze its pages when the renderer
was backgrounded for a certain amount of time and the freezing feature
flag was enabled. This CL moves this logic to the PageScheduler, which
now freezes a page when (1) the page freezing feature flag is set, and
(2) The page is freezable (hidden + no audio) for X time, where X is
either the default 5 minutes or a value set in finch.

This change also:
  - Removes the previous plumbing of the feature flag through the
    content layer and checks the flag directly.
  - Adds a new metric PageScheduler.PageLifecycleStateTransition to
    replace RendererScheduler.BackgroundedRendererTransition. This
    metric is recorded for lifecycle state transitions between active,
    hidden/backgrounded, hidden/foregrounded, and frozen.

Bug: 820634
Change-Id: I548daf643f090e161dc9afd8f788452a95669e03
Reviewed-on: https://chromium-review.googlesource.com/1086488
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566940}

This pulls the code out of the executable and moves it into the
//sandbox/mac:seatbelt target. This way it can be reused by
content_shell.

In addition, this also reduces the number of arguments used by the V2
sandbox. A prior design used a double-exec, requiring additional
switches to know the stage at which the sandboxed process was running.
However the double-exec is no longer done for performance reasons, so
some switches can be eliminated.

No-Presubmit: True
Bug: 850735, 749839
Test: No functional change. Sandboxed processes are still sandboxed.
Change-Id: I4eedf1e7e057d0650c805430fa53763b3909f923
Reviewed-on: https://chromium-review.googlesource.com/1097842Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566939}

In preparation of eventual onion souping DOMStorage this move the
SessionStorageNamespace and StoragePartitionService mojom interfaces
to blink/public/mojom as well, splitting them up in each their own
file in the process.

Tbr: dgozman@chromium.org
Bug: 781870
Change-Id: Icf85fee3eb327d81d2eee1cc68ce89b255cd13b4
Reviewed-on: https://chromium-review.googlesource.com/1087406
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566938}

The fix (crrev.com/c/1097624) is already rolled (crrev.com/c/1098715)

Bug: 851523
Change-Id: I6a4f35eb1448b14c2a28864236bcde9785ee768a
Reviewed-on: https://chromium-review.googlesource.com/1098634Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566937}

Adds StartDiscovery function to SmbHandler and is called when the Add
Smb Share Dialog is opened. StartDiscovery will be wired up to start
share discovery on the network

Bug: 757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied25d42b004d160f5b4486fbcfb4c8e8cceb3c37
Reviewed-on: https://chromium-review.googlesource.com/1073498Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566936}

This makes sure clicking the checked Picture-in-Picture browser context
menu (after entering Picture-in-Picture) exits Picture-in-Picture.

Screenshot: https://i.imgur.com/asJ1qgT.png

Bug: 840516, 806249
Change-Id: Ic283ca8cb431bfcb56613067e0fec43db2bbf53b
Reviewed-on: https://chromium-review.googlesource.com/1086796
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566935}

Bug: 850877
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc3c4520ab26400fbbca3490e038b1d25f4a8727
Reviewed-on: https://chromium-review.googlesource.com/1093262Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566934}

Fixes a bug when focusing an empty omnibox on incognito NTP that lead
to an incorrect layout of the placeholder.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id3215b4ca564789caca03473d029b088e2643ecf
Reviewed-on: https://chromium-review.googlesource.com/1098964
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566933}

This patch extends support for painting touch action rects (behind the
PaintTouchActionRects flag) to inline painting. With this patch, the
inline box's background hit test rect is painted. To reduce duplicate
code, InlineFlowBoxPainter::AdjustedPaintRect was introduced.

Because touch action rects are painted the same way as backgrounds, this
approach correctly handles vertical-rl writing modes.

Bug: 836905, 852013
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I53296e0fc6e939e220a90fee40e07492a9da113a
Reviewed-on: https://chromium-review.googlesource.com/1097562
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566932}

This caused some issues and we don't have time to address them for M69.
For example: crbug.com/849802, crbug.com/851852, crbug.com/848164.

Bug: 822075
Change-Id: I2b318ea6a9ff0b05120b21262088f6fbe2c3df10
Reviewed-on: https://chromium-review.googlesource.com/1098376Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566931}

FontCustomPlatformData::FamilyNameForInspector returns an SkString so
this adds an include for SkString.h. Previously this code compiled
because SkTypes.h has a forward declaration of SkString which was pulled
in though the SkRefCnt.h include. Skia is looking to remove this forward
declaration in SkTypes.h.

Change-Id: I638e13a0db4fba02e9caf73b448aa70ae2011100
Reviewed-on: https://chromium-review.googlesource.com/1099416Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566930}

The Refresh tabstrip does not draw the toolbar top separator, so this
test is unnecessary in that mode.

Bug: 846410
Change-Id: I0adac7e80227267e8a92556a4fef602d81e531db
Reviewed-on: https://chromium-review.googlesource.com/1098139Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566929}

No one is using the WindowServerTest interface, so remove it.

BUG=none
TEST=none

Change-Id: Ifff29e9601088586fb8a43306b231a5d6eb696b5
Reviewed-on: https://chromium-review.googlesource.com/1099367Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566928}

https://pdfium.googlesource.com/pdfium.git/+log/81a3085b250d..5f032995b3d7


git log 81a3085b250d..5f032995b3d7 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 tsepez@chromium.org CPDFSDK_Widget(): bDisplay arg always passed as true (default).


Created with:
  gclient setdep -r src/third_party/pdfium@5f032995b3d7

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib44d0051ab49ba858f40edc2732449946ab99eb2
Reviewed-on: https://chromium-review.googlesource.com/1098940Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566927}

SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames seems to be executing an invalid instruction.

Builders failed on:
- Mac10.12 Tests:
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests

TBR: ekaramad@chromium.org
Bug: 852452
Change-Id: If6592678a299db04184c55d1433a6558fa78816d
Reviewed-on: https://chromium-review.googlesource.com/1099364Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566926}

We were crashing if we ended up failing to publish a page when sharing.
An initial fix repaired it by sharing an item that was invalid in such
a way as to fail silently.

Initially I thought that the share callback needed to always be called
to continue processing and report failures.  However, all it does is to
share the item in the callback.  Therfore, a better fix is to just not
call the callback if there is some failure, as opposed to making sure
that we call it with an item which will fail to share.

Bug: 829099
Change-Id: I9b25cb67480a822cbbe8cef1b39d687fce076af1
Reviewed-on: https://chromium-review.googlesource.com/1098382Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566925}

The Finch experiment is showing that the experiment group has much more
extensions than the control group. Adding these new histograms may help us
understand more about what's happening.

Bug: 722942
Change-Id: Ia3308e61efeeb533c31638ca0f0ecf500c7e0f9c
Reviewed-on: https://chromium-review.googlesource.com/1091695Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566924}

Remove the  util class with a single method. Now Chrome gest the list of
processes without using the content API.

Change-Id: If519f153fd7833de439b41c311a7abe1b926da2a
Reviewed-on: https://chromium-review.googlesource.com/1091730
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566923}