- 03 Oct, 2018 40 commits
-
-
braveyao authored
To support the implementation of getDisplayMedia() API in chromium, it's required to stop screensharing when screen is locked on desktop platforms. This cl is to add an interface to observe the screen lock event into content/browser and let VideoCaptureManager stop desktopCapture sessions on screenlock event. Note: It's done on Win/OSX/CrOS at present. Still tring to find a solid way on Linux. Bug: 887585 Change-Id: Ibe65d51c68e07f632a851f22d2ba6777a527204d Reviewed-on: https://chromium-review.googlesource.com/1241160Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596273}
-
Fabio Tirelo authored
Screenshots can be found in the bug. Bug: 891369 Change-Id: I206d89a1118cad0f65c17ba3cafee81998e3198c Reviewed-on: https://chromium-review.googlesource.com/1258046Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596272}
-
Marek Haranczyk authored
MANUAL_CommonMeasureFinalization and MANUAL_CommonInitialize tests reseted global registry on exit without initializing it again causing random test flakes on tests that operated on manifests that happen to run after those two tests (they passed on retry). Change-Id: I2b4297d33441c72d9cdd099106abad68921c2f6a Reviewed-on: https://chromium-review.googlesource.com/1259046 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596271}
-
Christian Biesinger authored
With names "blink_perf.parser_layout_ng" and "blink_perf.paint_layout_ng" This is useful for running manually and a precondition for running the paint test suite on the bot. R=eae@chromium.org, kojii@chromium.org Change-Id: I6437113221a591e2c244efe0f8780b6e29923be7 Reviewed-on: https://chromium-review.googlesource.com/1259122 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#596270}
-
Min Qin authored
When running network service without launching full browser process, ChromeContentBrowserClient::OnNetworkServiceCreated() will be called without g_browser_process. This CL allows us to create SystemNetworkContextManager on demand and services depending on the network service can call SystemNetworkContextManager::GetInstance() to access it. BUG=866028 Change-Id: I9a557921e1bb164ecd62c766dd698137498c0a47 Reviewed-on: https://chromium-review.googlesource.com/1256207 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596269}
-
Hector Carmona authored
Bug: 874118 Change-Id: Id5e57c2667e1b7c1b8f11a132a51c1ecc377a444 Reviewed-on: https://chromium-review.googlesource.com/1246153Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#596268}
-
Stephen Martinis authored
This reverts commit cc86e6e5. Reason for revert: https://crbug.com/891729, didn't account for strange step names. Original change's description: > rebaseline_cl.py: Set step_name when retrieving results > > Layout test results are now uploaded into a directory indicating which > step name they were run as. This is to allow for without patch runs to > be recorded for analytics. This CL changes rebaseline_cl to pass the > step name when retrieving resuls. > > Bug: 882946 > Change-Id: Iad18ca54cc8804fff76f059ceab49d8c69fadd3e > Reviewed-on: https://chromium-review.googlesource.com/1244598 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595949} TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,robertma@chromium.org Change-Id: Ib5a73d70e234f73312bb32db7189ea9cdd43c185 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882946, 891729 Reviewed-on: https://chromium-review.googlesource.com/1259282Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#596267}
-
Meilin Wang authored
Add SetNightLightEnabled function in mojom::DeviceActions. Call this function in assistant_manager_service_impl.cc to enable/disable Night Light mode when query comes. Test: local compile and manually test. Bug: b:112698292 Change-Id: Id4ae0ed07fc2bc1197c0b702fd14c46284d1ba33 Reviewed-on: https://chromium-review.googlesource.com/1256216 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596266}
-
Rayan Kanso authored
Background Fetch notifications should always show the origin in the notification. In order to not break the behavior of other download notifications, a flag was added to OfflineItem to show the origin. Bug: 774612 Change-Id: I2f08e7e7d71a6520d02443a0961733d173242372 Reviewed-on: https://chromium-review.googlesource.com/1259011Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596265}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55aea84baa53..49fdd7ad1875 git log 55aea84baa53..49fdd7ad1875 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jvanverth@google.com Bundle shared SkImage_Gpu methods. 2018-10-03 caryclark@google.com fix bookmaker nightly 2018-10-03 reed@google.com play with animated gif 2018-10-03 bsalomon@google.com Remove unused macro SK_DONT_DROP_UNNECESSARY_AA_IN_TEXTURE_OP 2018-10-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 607f907d47b0..c3bef3e7b028 (1 commits) Created with: gclient setdep -r src/third_party/skia@49fdd7ad1875 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Id35569ef3781394f4c5f08697ceb040fb8866b25 Reviewed-on: https://chromium-review.googlesource.com/1257717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596264}
-
Ryan Hansberry authored
When SoftwareFeatures were changed to be stored in prefs as strings instead of as ints [1], CryptAuthDeviceManagerImpl failed to also migrate old int prefs to the new string representation when the prefs were desrialized. This caused all devices migrating from M69 to a newer release to believe none of their synced devices had any SoftwareFeatures until another sync occurred. 1) https://chromium-review.googlesource.com/c/chromium/src/+/1145588 Bug: 888031 Change-Id: Icd666106d6ebd4db5620cfab0dac459ef67df23e Reviewed-on: https://chromium-review.googlesource.com/1258515Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596263}
-
Rayan Kanso authored
The origin will be displayed in the status section of the notification. Very long origins will be elided to display the eTLD+1. Screenshots: https://lh3.googleusercontent.com/-eFfCFlWJf3Y/W7NlhkLY07I/AAAAAAAABMw/_RhaEe6jlnM1X-xXfsIoZ7uyJOnfd6JngCL0BGAYYCw/h48/desktoporigin1.png https://lh3.googleusercontent.com/-TiCAYHS9hfg/W7Nlep2HgkI/AAAAAAAABMk/cG6uFKK8sBcc8P-cmy9HtqEZHTp_2S2hgCL0BGAYYCw/h50/desktoporiginevil.png Bug: 774612 Change-Id: Iacd874b5fd03f3e6e37c204e9df9e4cbaba67435 Reviewed-on: https://chromium-review.googlesource.com/1256943Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596262}
-
Yeonwoo Jo authored
This patch simplifies conditions around the code in content/. Bug: 875665 Change-Id: I52e639adce40a86e20304ee64c52d3b399c39841 Reviewed-on: https://chromium-review.googlesource.com/1215147Reviewed-by:
-
Rayan Kanso authored
The origin will be set if provided to the OfflineItem a non-incognito profile. screenshot: https://lh3.googleusercontent.com/-BCLL-YuqB28/W6j_XbF542I/AAAAAAAABLA/Mq7jMbOdDdAPPZh-rfFVbDx7JIfLTKlEACL0BGAYYCw/h261/2018-09-24.png Bug: 774612 Change-Id: I34aa8fa51195443a242e4bd6e068d2d408737fbb Reviewed-on: https://chromium-review.googlesource.com/1240304 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Pete Williamson authored
When a finch experiment sets the override country for an instance of chrome, pass along that override country in the request headers to the server to get the catalog. Add logging Add experiment flag Change-Id: I16f94892c3fa9445af2290fd1c62d5c11be11374 Reviewed-on: https://chromium-review.googlesource.com/1258058Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#596259}
-
tzik authored
This adds the explicit instantiation declarations of LayoutNGMixin, and adds the CORE_EXPORT to the instantiation definitions, so that it's not instantiated in the test binaries, and is instantiated in the libcore with the proper visibility. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If51cda70ab619b178ca53c1fcbad8019fafc3c0b Reviewed-on: https://chromium-review.googlesource.com/1258806Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596258}
-
Bailey Berro authored
- Adds a dropdown to select authentication method that is only visible to chromad users. - This change has no effect on non-chromad users - The KerberosAuthentication_ boolean will be passed to SmbService::Mount in a following CL Bug: chromium:853803 Change-Id: Icc9ec65a4eb0ae20e90088f2767c7fda17578a0a Reviewed-on: https://chromium-review.googlesource.com/1191923 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596257}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b21e4a509d0c..457799c2a3af Created with: gclient setdep -r src-internal@457799c2a3af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6043e013c86dfec50f98d36480a9d718c36c77c7 Reviewed-on: https://chromium-review.googlesource.com/1257716Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596256}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d136b2884e0d..f9d38f2e4e5d git log d136b2884e0d..f9d38f2e4e5d --date=short --no-merges --format='%ad %ae %s' 2018-10-03 hans@chromium.org Fix -Wdefaulted-function-deleted warning in StreamPrioKey 2018-10-03 saza@webrtc.org Replace leftover usage of old AEC interfaces Created with: gclient setdep -r src/third_party/webrtc@f9d38f2e4e5d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:890307 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4c21e96c13d25cbcf65df39270276bac705b9cf2 Reviewed-on: https://chromium-review.googlesource.com/1257718Reviewed-by:
-
timidger authored
We already shipped a chrome version with version 2 exposed, so the Chrome Cleanup Tool will try to use this method when it doesn't exist unless we bump the minimum version. Change-Id: I6c0bf1209da85ea54f4e7d2d365d64ac8a98ba66 Bug: 889568 Reviewed-on: https://chromium-review.googlesource.com/1258296 Commit-Queue: Preston Carpenter <timidger@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#596254}
-
Nico Weber authored
Removes 69 exit time destructors. Since it's test-only this isn't very important, but since it also simplifies the code and needs fewer string conversions at runtime, might as well do it. Bug: 101600 Change-Id: I7474cbcf77fdbb35f350dbfdfee1ed597cadbe50 Reviewed-on: https://chromium-review.googlesource.com/1258301 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596253}
-
Ned Nguyen authored
Bug: 891705 Change-Id: Ied9506803dd2dd09a0bcfbff73274cc96d014715 Reviewed-on: https://chromium-review.googlesource.com/c/1258965Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596252}
-
Sorin Jianu authored
This reverts commit 23d3d537. Reason for revert: It breaks tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests such as failures: PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/1 PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/0 10.12 is affected too: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15611 Original change's description: > mac: Re-enable PageInfoBubbleViewsMacTest. > > Bug: 845389 > Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1258293 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596204} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: Ied439ffdb5cce7d708c250251d74a8d2c9b98631 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845389 Reviewed-on: https://chromium-review.googlesource.com/c/1259143Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596251}
-
John Delaney authored
The current name "AddCompleteResourcesExpectation" is deceiving. This does not check that exactly a certain number of resources completed, but that at some point, that number of resources had been completed. E.g. an expectation for 3 resources will wait correctly, even if 10 resources actually completed. Rename using minimum to match rest of expectation conventions in file. Change-Id: Ie9edaccf106d8f7c131c1caaa257ebeab32a0459 Reviewed-on: https://chromium-review.googlesource.com/c/1258297Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596250}
-
edchin authored
Bug: 751553 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa724ae915ccb81347a7f82c41de47f64697eeee Reviewed-on: https://chromium-review.googlesource.com/c/1257791Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596249}
-
edchin authored
When using the WKWebView snapshot API, the specified frame should be in the coordinate space of the web view rather than the BVC. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idc5f28745085e36891d77a4005e10f4d3bfd66c5 Reviewed-on: https://chromium-review.googlesource.com/c/1257828Reviewed-by:
-
Guido Urdaneta authored
This CL also covers the MediaStream constructor. In addition, tests are moved to WPT. Bug: 770908 Change-Id: I6db9a86e9ee839efc2b04b00ae8fc57f07d852c3 Reviewed-on: https://chromium-review.googlesource.com/c/1256796 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#596247}
-
Koji Ishii authored
LayoutNG used to apply Subtree paint invalidation for new NGPaintFragment, because fragments are always replaced with new ones. With recent changes to reuse NGPaintFragment, we can start exploring to do less paint invalidations. This patch changes Subtree to FullPaintInvalidation on all objects. There might be cases where we can do even less, but this change: * paint/invalidation test results match better to legacy. * Fixes 4 paint/invalidation/css-grid-layout by not invalidating inline formatting context container. The impact on blink_perf/paint is unclear. It looks like large-table-background-change-with-* and some other tests are flaky, and this change does not seem to have much impacts on blink_perf/paint. Still the paint/invalidation tests indicate we invalidate less with this change. Ran the pinpoint 3 times on the same code. On the first try: https://pinpoint-dot-chromeperf.appspot.com/job/12d257d8e40000 one test regressed by 11.5% while not much changes in others. On the second try: https://pinpoint-dot-chromeperf.appspot.com/job/11f8d4c2e40000 the regressed test above improved by 8.9%, another by 9.2% and 2.5%. On the third try: https://pinpoint-dot-chromeperf.appspot.com/job/1723022ce40000 the two tests above improved by 18%, though fixed-and-many-layers-scroll regresed by 5.6%. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5b0db240c3d9f84ffb7f02d0f7bd7d0aa9b82296 Reviewed-on: https://chromium-review.googlesource.com/c/1250821Reviewed-by:
-
Florent Castelli authored
Update the test outputs accordingly too. Change-Id: I644199d912c71df0ce2db7dd3292d00ce5a120ec Reviewed-on: https://chromium-review.googlesource.com/c/1256971Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596245}
-
Florent Castelli authored
Bug: 803494 Change-Id: Ic9efe4adba6909f6af3dbcf90d64debeef216480 Reviewed-on: https://chromium-review.googlesource.com/c/1257786Reviewed-by:
-
Tarun Bansal authored
Skip cookie check for origins when sending client hints. The cookie check was initially added when there was plan to allow 3rd party origins to request client hints. Since client hints are now restricted to only first party origins, and client hints are already disabled for origins that do not have JavaScript permissions, this cookie check is considered redundant. Note that cookie check is not required by the fetch or client hints spec either. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I080fa5257abba15724559a39b4b73ac4f2e12e3e Bug: 891370 Reviewed-on: https://chromium-review.googlesource.com/c/1253215Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Florent Castelli authored
The base function is changing to return an RTCError, so we need to stop overriding the old function. Bug: 891556 Change-Id: Id9d1a90732a07fa3877f5ce50824d920bacf2777 Reviewed-on: https://chromium-review.googlesource.com/c/1257860Reviewed-by:
-
Stephen McGruer authored
Test is flaky-failing on win7, with no obvious recent change to be reverted. Bug: 891510 Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690 TBR=mlippautz@chromium.org Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690 Reviewed-on: https://chromium-review.googlesource.com/c/1258962 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596241}
-
Hans Wennborg authored
../../cc/paint/solid_color_analyzer.cc:155:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] Frame() = default; ^ ../../cc/paint/solid_color_analyzer.cc:161:38: note: default constructor of 'Frame' is implicitly deleted because field 'iter' has no default constructor PaintOpBuffer::CompositeIterator iter; ^ Bug: 890307 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9e4cb20394a603e43e3a62264189da29f01da20a Reviewed-on: https://chromium-review.googlesource.com/c/1256827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596240}
-
Eric Stevenson authored
Includes fix for supporting asserts and invalid locals information. Bug: 843307 Change-Id: Iec4ecb2981e8c895e728127179d3b0eb54f09b14 Reviewed-on: https://chromium-review.googlesource.com/c/1258963Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596239}
-
Nico Weber authored
It's now redundant with is_mac. The biggest use of it was that it set the buildflag MAC_VIEWS_BROWSER, but I removed all references to that in the last few days: https://cs.chromium.org/chromium/src/ui/base/BUILD.gn?q=%5CbMAC_VIEWS_BROWSER+case:yes Bug: 832676 Change-Id: I9bd74e26a35ddb4dfec786e4b0a6ada24366c951 Reviewed-on: https://chromium-review.googlesource.com/c/1258295Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596238}
-
Shahbaz Youssefi authored
Prior to this commit, the passthrough program cache used EGL_ANGLE_program_cache_control to store binary programs in angle's cache. With support for EGL_ANDROID_blob_cache added to angle, this role is reversed, i.e. the blob cache lives in the application (chrome), with the implementation (angle) storing additional data through callbacks. Bug: angleproject:2516 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I62d5c484580d953013d00e31300285be6b9442ce Reviewed-on: https://chromium-review.googlesource.com/c/1251325Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596237}
-
Geoff Lang authored
ui/gl initialization is now in a sub library, move the dependencies. Require a flag to use ANGLE on Android, this allows ANGLE and the native driver to both work with a given build so we can test on the bots. BUG=726002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d3e0c4e844dca9e72c363f07e011c710e1a9f57 Reviewed-on: https://chromium-review.googlesource.com/c/1244078Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596236}
-
Rouslan Solomakhin authored
Before this patch, rotating a device with the Payment Handler CCT could result in cutting off the bottom of the CCT, making a part of web content inaccessible. This patch updates the height of the window when configuration changes. The height is never more than the height of the screen available to the activity. After this patch, rotating a device with the Payment Handler CCT will resize the CCT to always fit on the screen, so all web content is accessible to the user. Bug: 890184 Change-Id: I6ddf93f61e08e6a6281192e6a57b703ac18694ce Reviewed-on: https://chromium-review.googlesource.com/c/1252404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596235}
-
Boris Sazonov authored
This CL reimplements SyncAndServicesPreferences.updateDataTypeState to unify configuration of checkboxes. It resolves the issue when all checkboxes become enabled even though requirements for some data types aren't met. Bug: 889015 Change-Id: If9cffded02ce163edd33eaeeba73ddd244b9ce89 Reviewed-on: https://chromium-review.googlesource.com/c/1258007Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596234}
-
