GitLab

Refactor the RequestPinView class to use a pair of callbacks instead of
the callback+delegate.

This refactoring makes the interface of the RequestPinView more compact,
which will simplify the introduction of alternative UI implementations
(for the Chrome OS Login and Lock screens) in follow-up CLs.

This is a pure refactoring, it's expected to bring no behavior changes.

Bug: 964069
Change-Id: I7d35592f7897b133d98f4dbc0657a19009ebb7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722847
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683334}

Bug: 969139
Change-Id: I406d768d3f1ae9aaebca26596c8b1ab0f0f404e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727435
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#683333}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ida88bbeda035099d0b6a4c41be6b298a1fdb5099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700864Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683332}

In addition to cancelling active touches before activation, we also
need to end active gestures to ensure the gesture stream remains valid.
To do this, we ack touch events that are pending acks directly from the
browser and generate the required gesture events.

Because we flush the touch event queue in PassthroughTouchEventQueue,
we no longer need to worry about any pending acks in TEAQ, and can
revert the changes made in https://crrev.com/c/1656808 and
https://crrev.com/c/1645159.

Bug: 985929
Change-Id: I7526b8ba0d92d05d518656347865d46c20dfa2d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714372Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683331}

Create print_common.mojom for common print structs and enums.

Bug: b:138786123
Test: Build Chrome
Change-Id: Ib32f22abef74e1eb85fb529b21705247495c72d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730625Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Auto-Submit: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683330}

This allows us to put all WPT-specific failures in the new file and turn
waterfall builder green while we whittle away at the failures. The goal
would be to eventually remove this file as all failures get triaged.

The immediate benefit is that this builder starts to give meaningful signals
without being obscured by all of these failures. So we can use it 1) to gauge
flakiness/stability and 2) see results for tests that aren't affected by
failures (eg: some new testdriver APIs like Actions or Payments).

This change was tested by merging into crrev.com/c/1551486 and confirming
the new expectations file was used.

Change-Id: I7f2f83058804cee365e2082cbee9f6c23002d187
Bug: 937369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707065
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683329}

This CL renames *_struct_traits.* to *_mojom_traits.* in
//third_party/blink.

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: Ia7a5af20d1cf0fcc521b7c6a097c1236cddbcc60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728649Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#683328}

Disable
LayerWithDelegateTest.Cloning
LayerWithNullDelegateTest.SwitchLayerPreservesCCLayerState
for Linux and UNDEFINED_SANITIZER due to bot UBSanVptr Linux.

Bug: 989936
Change-Id: Ieb732e3ded4efd15277dee6b210336b58201242d
Tbr: flackr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731756Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683327}

Change-Id: Ia165412bce19d960be3e15bb783ffe7f850f7118
Bug: 990053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729243
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683326}

Adding this filter in search_result_tile_item_list_view will allow for
future-proof placement of dinner for one and other future policy tile
apps.

This change re implements cl/1687296, which was reverted during bisecting
a flickering UI bug.

Bug: 981023

Change-Id: I97b70c297a686ad084f4b93b6a96fd722948bbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729914
Commit-Queue: Cameron Womack <camw@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683325}

ScopedSysTraceEvent has played a critical role in investigating WebView
startup time. However, since it is currently under android_webview, you
cannot use it in other directories. Moving this under base.metrics such
that we can investigate startup components outside android_webview and
we can allow Chrome to use this for Chrome startup trace investigation.

Bug: 817644
Change-Id: Ic585ede2d90fb2cea30638b7d80355c6c00c2161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730313
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683324}

https://webrtc.googlesource.com/src.git/+log/59a041db7e50..0c67c80ac3fd

git log 59a041db7e50..0c67c80ac3fd --date=short --no-merges --format='%ad %ae %s'
2019-08-01 yvesg@webrtc.org Guard video analyzer against race conditions.

Created with:
  gclient setdep -r src/third_party/webrtc@0c67c80ac3fd

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I8df87dad07fd91338412c99e8b9ee88ba8615996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731772Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683323}

Patch https://chromium-review.googlesource.com/c/chromium/src/+/1626596
renamed the metric but forgot to update the mapping to prefixes, which
means the metric doesn't show up in the dashboard.

Bug: 966375
Change-Id: I6214fd2d55cb846c9dac555cf5e79f3e74e5f3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731491
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683322}

This is a utility class for use in building a hierarchy of voters. It
allows one branch of voters to always override another branch of
voters when they have conflicting votes.

BUG=971272

Change-Id: I3051319031fe634343e0ac4a26ad050ffa30105c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700108
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683321}

This CL makes DownloadManagerService to report the UMAs when new
download backend expriment are turned on

BUG=989970

Change-Id: Iff088709dc2ca373139f8e2e3e7858ea3cae6254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730952Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683320}

The CreateURLLoaderFactory method is part of WebLocalFrameClient not
WebWidgetClient.

R=tommycli@chromium.org

Change-Id: I41b7c07f42151c58c01753f3da525073845638bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729205
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683319}

This CL converts the dynamic linking of Vista-era clipboard APIs into
static linking as we no longer support Windows XP.

Bug: 986625
Change-Id: Ic619f0058fde7f221e7aebc44c9db8bf82a39741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730748Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683318}

Changed the way to get SendTabToSelfIconView to make sure that
BubbleDialogDelegateView::SetHighlightedButton() Will been called.

Deleted redundant variable and getter.

Bug: 978520
Change-Id: I70ed6ff878b7e1b2583659bca147cb5452dc307a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728057Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683317}

This reverts commit a652f156.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55382
There are lots of ASAN error since the roll out. Going to revert the CL.

Original change's description:
> Roll asan_symbolize.py 227327:367589
> 
> Change-Id: Ideb0ee78b9be02c6acda3e1eddbae8dc9065fa15
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731616
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683264}

TBR=thakis@chromium.org,thestig@chromium.org

Change-Id: Id280e47303c959725b87169f524e0fb269224b9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730777Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683316}

Also remove the corresponding NetworkContext constructor. These methods
were added temporarily to make transition to using the network service
easier. Now that they're no longer used, we can remove them.

Also merge NetworkContext::ApplyContextParamsToBuilder() and
NetworkContext::MakeURLRequestContext() into a single massive method,
since they no longer need to be separate. It may make sense to subdivide
it into smaller methods, but the previous division doesn't make much
sense, given the removal of the constructor that used
ApplyContextParamsToBuilder() without MakeURLRequestContext().

Bug: 934009
Change-Id: I423b0d8a95c78d1a48ca7ab83562b74c47e3b505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731754Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683315}

Change-Id: I5d6d557e61542f14faefd89f07d83c1a646b446f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731769Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683314}

Per comment at:
https://chromium-review.googlesource.com/c/chromium/src/+/1727730/3/chrome/android/java/src/org/chromium/chrome/browser/SmsReceiverDialog.java

This CL creates a subdirectory sms under:
//chrome/android/java/src/org/chromium/chrome/browser/
//chrome/android/javatests/src/org/chromium/chrome/browser/
and moves sms related files into this subdirectory.

This CL also adds OWNERS files for these subdirectory.

Bug: 990020
Change-Id: I2a9f579492f77d1d23c6620ef7798b47320308d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730525Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683313}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/747518d43f4b..3101bd58464a

git log 747518d43f4b..3101bd58464a --date=short --no-merges --format='%ad %ae %s'
2019-08-01 zoddicus@users.noreply.github.com Turn on warnings on about missing semi-colons (#770)

Created with:
  gclient setdep -r src/third_party/shaderc/src@3101bd58464a

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: Iaa420158b69524ec05a92708999ba23c85d4e192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730797Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683312}

This effectively reverts commit 90496b3b.

This turns out to be unpopular, as well as causing issues on the Mac,
particularly with Magic Mice.

BUG=2384,965753

Change-Id: I69803bcbde01b1978c58ef1454280ac08403a24d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730631Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683311}

This also fixes a big where feature policy reports were not being counted.

Bug: 938531
Change-Id: Ie6faad7f0b2c0f5ef97b5b471011887461255860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642956
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683310}

This CL extends the expiration date on VR-related histograms, and adds
myself and Sam Drazin to the VR-related histograms owned by Bill Orr.

Bug: 988688, 988687, 988682, 988671, 988656, 988646
Change-Id: Ia24a3a692435450222e9a561e1bcd4fb990a656b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730290
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683309}

I've pushed back some that we're still actively using and also pushed
forward a few that we're done with. Also expanded ownership a number of
our flags to include a specific person in adition to the team alias.

Change-Id: I118bb5cc9e51f36929b98b4be2f92cfe8c68ab72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731774Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683308}

This change adds the following system color keywords:
    - LinkText: the color of non-active, non-visited links
    - VisitedText: the color of visited links

These color keywords are used for high contrast style overrides and
will give users the ability to customize their sites with the relevant
link colors when in high contrast.

Bug: 970285
Change-Id: I3305e954623f2f4e5da594d9dc9dfd651b028056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691308Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#683307}

The Clear should have cleared exceeded_iteration_limit and exceeded_deadline,
but it was overlooked. Instead of using a Clear method, the object can be reset
by assigning a default-constructed Result(). This removes the need to
update Clear any time new members are added.

(The lack of clearing those members did not cause any issues with the way they
are currently used in chromium, so this shouldn't cause any behavioral changes.)

Bug: 410574
Change-Id: I3585abed17bfdeaf1362ee098ebddfdf2c2d3080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730957
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683306}

Bug: 989734
Change-Id: I0c9a6c29bf504838595cddf3109870130fa12881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731171Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683305}

This CL displays the lookalike interstitial for domains that are lookalikes of top 500 domains instead of the full top 10K. It uses the same Huffman encoded trie that contains the top 10K list to do this. The CL adds a new "is_top_500" bit to each entry and marks the top 500 domains with one and the rest with zero.

The lookalike navigation throttle reads this bit and displays the interstitial for top domains with is_top_500 bit set. It still records UMA and UKM for other top domains.

An alternative approach is to use the top 500 domains array generated by the make_top_domain_list_for_edit_distance binary. This would require rewriting the list as a map so that lookups are constant time. This isn't particularly tricky, but we would essentially duplicate the functionality of the Huffman trie in a  roundabout way so I opted for the current approach.

Bug: 988885
Change-Id: I98381f4035ace891bfe8162427e7cc2d4080a991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724897
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683304}

The Bluetooth FeaturePod button can be disabled in certain cases (e.g. when the
screen is locked) so the current "Toggle Bluetooth" and "Show Bluetooth
settings" tooltips are not appropriate.

BUG=987933

Change-Id: I2d534f3e99525847a1e4164e510996bd90b0a096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729565Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683303}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 968047
Change-Id: I105e2965f7d21583f68174683a8e76823f7f3065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729077
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683302}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 968047
Change-Id: I1849e7c28ee90650814e7a7f8e53b0075511da63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729081
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683301}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0aee86d1e39c..7e33a7e91b89


Created with:
  gclient setdep -r src-internal@7e33a7e91b89

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I8f744285e3b52ba28be55bb5230f860b9c945096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731752Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683300}

Fix an issue that auto Download resumption is not in reduced mode if native resumption handler is enabled

We need to check the job type to see which feature flag is used.

BUG=990052

Change-Id: I3c2ee43f923eca3249e2ce293bf9818978321713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730852
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683299}

We sometimes change the actual delay after which a periodicsync event is fired
based on other registrations for the origin. Update what we show in Devtools so
it corresponds to the actual delay_until set on the registration.

Bug: 989524
Change-Id: I9ba06f9c5f65d93775b0a9bf9d934f1d9b5b5ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730921Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683298}

http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html
http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
http/tests/fetch/serviceworker-proxied/thorough/redirect-loop-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/nocors-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/auth-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/nocors-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/redirect-loop-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/access-control-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/cors-preflight2-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/nocors-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html [ Pass Failure ]
virtual/streaming-preload/http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html [ Pass Failure ]

Bug: 989863
Change-Id: Ie63e6a41555e5c8fa956f583df787df5159e241f
TBR: skym@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731134Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683297}

Currently PDFiumEngine::LoadPageInfo() loads pages into PDFiumEngine
only in a single-view layout. However, in the future LoadPageInfo() will
be able to load pages in a two-up view layout as well.

This CL extracts the logic for formatting pages in single-view and
appending them to |pages_| to a helper function
PDFiumEngine::LoadPagesInSingleView(). This helps manage the complexity
of LoadPageInfo().

Bug: 51472
Change-Id: I087f171308e4425dd3bae8b8abe5f0f70e0c0eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728059Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Cr-Commit-Position: refs/heads/master@{#683296}

Create a class that listens to PowerManagerClient for changes in the
battery level of Bluetooth HID devices, and update the corresponding
device::BluetoothDevice battery percentage field.

Design doc at go/cros-bt-battery.

Bug: 785758
Change-Id: I3519d6d19c7a24abafc353d4afd3d059034e808b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721087
Commit-Queue: Alberto Herrera <ahrfgb@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683295}