- 09 Nov, 2020 2 commits
-
-
Nicholas Hollingum authored
These utilities will be used as the basis of the structured state refactoring. I'm committing them now so we can partially re-work what we have and benefit from them earlier. Bug: b/172178036 Change-Id: I812c32ba90eb6e5a5c3538ed7aea492b4d49872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519181Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#825229}
-
Nicholas Hollingum authored
This test ensures that control returns to the task *before it is deleted* on completion, which tasks expect in order to be able to clean up. Bug: b/172605172 Change-Id: I159cb2e78f3b368128b1540cd672503b8e9c404b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521878 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
- 08 Nov, 2020 21 commits
-
-
Abigail Klein authored
Make the MediaDialogView observer the SODAInstaller and update the live_caption_title with a download message as SODA installs. Bug: 1055150 Change-Id: I54317158bf6678c98ba823490157e510c2fd3d10 AX-Relnotes: N/A (feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495922 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#825227}
-
Joel Hockey authored
Change-Id: Iea3c4f398da33308841d04ed95371d2f09a8e38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519548 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#825226}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/5aSyRE6sYFfgSxo Bug: 889763 Change-Id: Ib3f2f411824e2055c340d039b311720c1e91b015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517228 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825225}
-
Jinsuk Kim authored
The search box scroll listener needs updating whenever search engine provider changes. It was prevented by a small optimization introduced in https://crrev.com/c/2500389 which updates the listener only when there's a new visible NTP. This CL fixes the bug by removing the line added in the culprit CL. Bug: 1145981 Change-Id: I674d82546e5bf9f2067cf26f3413c57bf8dc35b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521977Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825224}
-
Jason Lin authored
`chrome.test.callbackPass()` call `chrome.test.succeed()` automatically, so `settingsTest()` was actually calling `succeed()` twice. Also, calling `callbackPass()` inside a callback function seems to be a bad idea. For example, the test could succeed prematurely if the callback is not called in time. Change-Id: I6d46337db933e515551a1c172ad072ac92abe9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522715 Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#825223}
-
Abigail Klein authored
ChromeOS and non-ChromeOS installations. Introduce a new SODAInstaller which is responsible for installing SODA (Speech On-Device API). It has a separate implementations in ChromeOS and non-ChromeOS. The SODAInstallerImpl on ChromeOS installs SODA with the DlcserviceClient. The SODAInstallerImpl on non-ChromeOS installs SODA with the ComponentUpdaterService. Each sends installation progress updates to its observers. The SODAInstaller has a single instance, because SODA is only downloaded once for the entire device. The CaptionController initiates the SODA download by calling the InstallSODA method of the SODAInstaller. It initiates language downloads by calling InstallLanguage. The CaptionsHandler is a SODAInstallerObserver. It sends SODA download updates to the captions subpage WebUI in settings. Since the SODAInstallerObserver is a common interface between the ChromeOS and non-ChromeOS implementations, there now only needs to be one CaptionsHandler. More SODAInstallerObservers will be introduced in upcoming CLs. For more information, see this design doc: https://docs.google.com/document/d/1e9ie7WequR4UafYq72-wpXwFj0-lLWMvjXZP5jXXpwU/edit# Bug: 1055150, 1111002 Change-Id: Ia82285a1dc1440229d7912bb07ae522abde9900b AX-Relnotes: N/A (feature not yet launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473744 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825222}
-
Nohemi Fernandez authored
Open the Settings UI to manage on device accounts when user clicks on 'Settings' button from the infobar. Bug: 1145592 Change-Id: I6cf2021b09f920a0de84674b202ffc89bba3d664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521815 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#825221}
-
Nohemi Fernandez authored
The high priority attribute allows an infobar to be presented for a longer period of time to the user. This is necessary for the sign-in notification, so that the user has time to take action if needed. Bug: 1145592 Change-Id: I3160298195643cf684213340c9aebd644505a28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521621 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#825220}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic05d7f8e78a3277fed8898931eefaf01d6bcb15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524657Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825219}
-
Nohemi Fernandez authored
Adds the user's profile image in the signed-in notification infobar. Bug: 1145592 Change-Id: If70abf051c2cbee54381f4646c499c7d55ae3675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521622Reviewed-by:
-
Liquan (Max) Gu authored
Since CL[1] renamed onInstrumentDetailsLoading as onInstrumentDetailsLoadingWithoutUI, the clank build was failed. This CL is to revert the renaming to fix the build. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2522954/10/components/payments/content/android/java/src/org/chromium/components/payments/PaymentApp.java TBR=rouslan@chromium.org NOPRESUBMIT=true No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146065 Change-Id: I74508a531b64785d5c906136c84861948cb4df24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524720Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#825217}
-
David Roger authored
The profile picker may be shown on new browsing sessions. This includes Chrome being reopened from the dock. In order to share code, two functions are moved out of startup_browser_creator: * IsGuestModeRequested * ProfilePicker::ShouldShowAtLaunch This is a simple code move and should not change the behavior. The only behavior change is in app_controller_mac.mm Tests for IsGuestModeRequested were added in this CL. Fixed: 1122536 Change-Id: Ic078c79f300cde7ad5e26141eaebd3b249a66c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485168Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#825216}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1dc12d5e0f9e..bb6ca4c0c230 2020-11-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02f40658d81c40e3415d186e7c39fd37691af944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524651Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed435953dfd6..cfe647c02fb4 2020-11-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I798cfa06599227690688f559d564870c86910400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524361Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I80507802250eaec3da12482a031ecf484ad33274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524722Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825213}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1659de704c2..1dc12d5e0f9e 2020-11-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a85c3557284a5731bc2c855c5df8a5ef9115cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524927Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I308d7638ecc67e6c6660ec3cfd7957f4d893ae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524427Reviewed-by:
-
Xiaocheng Hu authored
This patch implements most of the CSSOM class, CSSCounterStyleRule, for @counter-style rule. This also allows us to test @counter-style rules in web tests. Note that the attribute setters require actual implementation of descriptor parser, and hence, is left for future patches. Bug: 687225 Change-Id: Ia8d06f8565a17de89e7edb38ea13ad47e99472a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522124 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825210}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/83fc3e2cef87..f1659de704c2 2020-11-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5a70a245799656a1f3af98c5e301bcaa87ab8fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524424Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I923392869ef06df7a015c4c8c1966dcb872b3d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524509Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825208}
-
Mike Reed authored
TBR=fmalita Change-Id: I65bad35c6f64574082fb3cb72e0fbb7bf01eb507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524821Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#825207}
-
- 07 Nov, 2020 17 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/18fcb4ad3232..aca3d408105d 2020-11-07 jmadill@chromium.org Fix return value of cube map array imageStore. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I72d1e366be33443ad9d41e04425e684856171176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524744Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia101458e26d7be64dd739ceb2094557ff1e2a543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524740Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icb4734d05e6a34caa20714154a8b08a5e0aee046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524503Reviewed-by:
-
Thiabaud Engelbrecht authored
The task runner used to run the periodic periodic was not set properly, causing DCHECKs to fail. This CL fixes this issue. Periodic Purging continues to be disabled by default, so this CL causes no change in functionality. Bug: 1131857 Change-Id: If3bd626e9f5ac3c52b7d9e181605882c134d115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519032 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#825203}
-
David Maunder authored
Show in tab grid card the old and new price for a shopping offer when there is a reduction in the price. Bug: 1145766 Change-Id: I20d42f2731ff7759f452d2cd2d3cb5331bfc1d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520167 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825202}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56af9cbd3f35..3e17e33724b4 2020-11-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from cc2305dd9537 to 8655b62207a5 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib80d1acb4e268c152d73bffa0e7bb951d72aca37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524680Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2ecb2ddefbc..18fcb4ad3232 2020-11-07 m.maiya@samsung.com Vulkan: Enable a subset of ImageTest colorspace tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: angle_end2end_tests.exe Change-Id: I6979d2c2a7d716c5f3bb3ef724074f5ce7746de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524600Reviewed-by:
-
Liquan (Max) Gu authored
Now that PRService has implemented several interfaces, it's hard to demand the callers that they should no longer use the class after PRService has been closed because the callers are only responsible for the interfaces. What if the interface provides hasClosed() and requires the callers to check before use? It could complicate the caller code and the interfaces (for adding hasClosed to about 10 interfaces that PRService would implement). For this reason, this CL is to make PRService more flexible to use. Instead of asserting that mBrowserPaymentRequest and mClient should not be used after PRService is closed, PRService will just early return. Bug: 1146565 Change-Id: Ifd5e8a73ea66bdc0b3c615695f2fc3009d4f62ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522980 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825199}
-
Liquan (Max) Gu authored
Currently, PRService delegates disconnectFromClientWithDebugMessage() to CPRService which in turns calls PRService#onError and PRService#close() to close the PRClient. This is unnecessary. Also this indicates an layering violation. Since CPRService depends on PRService, it's more natural for CPRService to call PRService's disconnectFromClientWithDebugMessage() than the other way around. Change-Id: I479f1ae9794b8c5b5997410758fdd1a4e7d97ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522962 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * PRService takes over the PaymentApp.AbortCallback impl: - onInstrumentDetailsError() * PRService takes over the PaymentApp.InstrumentDetailsCallback impl: - onInstrumentDetailsLoading(): separated into two methods. - onInstrumentDetailsReady(): separated into two methods. - onInstrumentAbortResult(): moved completely. * Moved CPRService#abort into PRService, because after moving onInstrumentAbortResult(), CPRService#abort() only depends on PRService. Bug: 1146065 Change-Id: I0b8fa2a615624b8dfe1c8e1242075473e05cbb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522954 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Will be useful while debugging Nearby Connections issues Bug: 1106937 Change-Id: I07c65eea9a9da1ef3c5d6a300219ee80ece9d622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523906 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825196}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ifab9b9c21a6dd591ed08f4bb84ed65712bcaa831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521250 Auto-Submit: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825195}
-
Liquan (Max) Gu authored
Changes: * PRService takes over mPaymentResponseHelper and its result listener PaymentResponseRequesterDelegate from CPRService. * Although CPRService no longer retain the helper, it's still responsible for creating an implementation of it, because WebLayer payment would have a different implementation of it. * Chrome only tells PRService whether and how to patch the payment response according to its need of skip-to-GPay. WebLayer would have no such logic. Bug: 1146159 Change-Id: Iede2e3d7a9f2d6b404aaaf59c880d5454b143099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522213 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Breaks the current PaymentResponseHelper into 2 parts: * PaymentResponseHelperInterface: a general interface. * ChromePaymentResponseHelper: the helper that's used by Chrome, which includes the Autofill feature. With the PaymentResponseHelperInterface, we will create another general purpose implementation (without Autofill) that can be used by the WebLayer. Bug: 1146159 Change-Id: I7cbfbd9486f085179d2298fdf29428fd641217e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521369 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2bfcff07225..ed435953dfd6 2020-11-07 martin@scenegroup.co Fix issues with latest GN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Idfb23201d0e5d7c8a9ae59eae80ab4d147d266e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524194Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iaf17870ad7ba647b1672924db192dfb9d8ca0804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524500Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b5e59f3c505..83fc3e2cef87 2020-11-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc0c6434a137d266656400c7e7de0f9de4554581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524186Reviewed-by:
-
